arel 7.1.2 → 7.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2399144c676bc7f590c0204ea754fdf535a9d715
-  data.tar.gz: 67a31fe3f14b215a6e2ca0be88c9f97a6450f424
+  metadata.gz: 60798bcc684ea3ced1a4f162f9949b5bab2e0970
+  data.tar.gz: 5c2c10c8903f1d6ea662e750069957f346389f7a
 SHA512:
-  metadata.gz: ee16e1759920826871c7e9e61f858de0df42922bb43e827d769ff18525ff58b9af0cfda6e75a3df565f76d3cb7b1259efbc078fe5f3fa0269411eaf843459e1b
-  data.tar.gz: 2a3858946bbe6efefdf9a0e759455386958c6d6aa07be1fcad05083c869c387c1bf888a1bfbc88a0e3693bdf674dd3d86a69632069631182952e76cb69954f0c
+  metadata.gz: 536f6c961442b0ac33e4a8da505dd40ce1ede1906ecace4c6768353fb7a8bc7bcb8761ad25dec3ca62a6e666c7d625497c331c10fd7cf71be049033367c60f82
+  data.tar.gz: d71eb8659cadc5bc8dbfe1631632a5c05e4356ac7ace6cb1db2456e35631eeeac6b341c5f853bd49100b84a1cb602aacda8f9450ff2063c34a2b7406c61799f8

data/History.txt

@@ -1,3 +1,12 @@
+=== 7.1.3 / 2016-10-07
+
+* bug fixes
+
+  * Remove union mapping as :binary node when performing DepthFirst enumeration
+  * Fix invalid BindParam output in Dot visitor
+  * Add Arel::Nodes::Casted to dot visitor
+  * Use Arel::Nodes::BindParam in Oracle visitor for queries using both LIMIT and OFFSET
+
 === 7.1.2 / 2016-09-13
 
 * bug fixes

data/lib/arel.rb

@@ -21,7 +21,7 @@ require 'arel/delete_manager'
 require 'arel/nodes'
 
 module Arel
-  VERSION = '7.1.2'
+  VERSION = '7.1.3'
 
   def self.sql raw_sql
     Arel::Nodes::SqlLiteral.new raw_sql

data/lib/arel/visitors/depth_first.rb

@@ -98,7 +98,6 @@ module Arel
       alias :visit_Arel_Nodes_Regexp             :binary
       alias :visit_Arel_Nodes_RightOuterJoin     :binary
       alias :visit_Arel_Nodes_TableAlias         :binary
-      alias :visit_Arel_Nodes_Union              :binary
       alias :visit_Arel_Nodes_Values             :binary
       alias :visit_Arel_Nodes_When               :binary
 

data/lib/arel/visitors/dot.rb

@@ -155,6 +155,11 @@ module Arel
         visit_edge o, "name"
       end
 
+      def visit_Arel_Nodes_Casted o
+        visit_edge o, 'val'
+        visit_edge o, 'attribute'
+      end
+
       def visit_Arel_Attribute o
         visit_edge o, "relation"
         visit_edge o, "name"
@@ -204,7 +209,6 @@ module Arel
       alias :visit_NilClass :visit_String
       alias :visit_TrueClass :visit_String
       alias :visit_FalseClass :visit_String
-      alias :visit_Arel_Nodes_BindParam :visit_String
       alias :visit_Integer :visit_String
       alias :visit_Fixnum :visit_String
       alias :visit_BigDecimal :visit_String
@@ -212,6 +216,8 @@ module Arel
       alias :visit_Symbol :visit_String
       alias :visit_Arel_Nodes_SqlLiteral :visit_String
 
+      def visit_Arel_Nodes_BindParam o; end
+
       def visit_Hash o
         o.each_with_index do |pair, i|
           edge("pair_#{i}")   { visit pair }

data/lib/arel/visitors/oracle.rb

@@ -26,11 +26,22 @@ module Arel
                 FROM ("
 
           collector = super(o, collector)
-          collector << ") raw_sql_
+
+          if offset.expr.is_a? Nodes::BindParam
+            offset_bind = nil
+            collector << ') raw_sql_ WHERE rownum <= ('
+            collector.add_bind(offset.expr) { |i| offset_bind = ":a#{i}" }
+            collector << ' + '
+            collector.add_bind(limit) { |i| ":a#{i}" }
+            collector << ") ) WHERE raw_rnum_ > #{offset_bind}"
+            return collector
+          else
+            collector << ") raw_sql_
                 WHERE rownum <= #{offset.expr.to_i + limit}
               )
               WHERE "
-          return visit(offset, collector)
+            return visit(offset, collector)
+          end
         end
 
         if o.limit

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arel
 version: !ruby/object:Gem::Version
-  version: 7.1.2
+  version: 7.1.3
 platform: ruby
 authors:
 - Aaron Patterson
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-13 00:00:00.000000000 Z
+date: 2016-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest