arclight 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8714e205fc1504d10046b11ca15d052b88fa7807
-  data.tar.gz: aab016edd61930e28c62fd598926e7b8dfd06b55
+SHA256:
+  metadata.gz: ed0ceaf7e03fb194a6ea2981582c688924e78f9024aacbef9ca18cb99971e9a7
+  data.tar.gz: 786a90d77e725fe19f247dea85c0da2b811c87bee38ed29713c338692b90368f
 SHA512:
-  metadata.gz: 2f8ee0bf77483e97caed185a8914511c439ac8f80d041f403079fe6160b491e101afcb033f9769656d3c10629354b031fdfd0a52d3a65cf9eac0cd22dc56d702
-  data.tar.gz: 24a2833db4e0600ca07e7f5135214a7808f982c49c3950228ee4d7713740fe68e0631ef90599e443823b6601bbe7cc3a2b80c257899ec05683ac77a98c688995
+  metadata.gz: 96d493efd656d72772ed0167715b3698df1d32af0bf81a5f9712bab2c7f992ad5836a713d06c7b28d35ed3069bdbd149dd2b92ab623e1dd51ed142b039649cea
+  data.tar.gz: 43a811a99449328b75bafbda1f41d4b6e362323656ecc2d899bd6e5cc05acfdbcaac27e6ba842fe500d253cd6be4697f330f72dc19e4c2ee44e2215e937f8230

data/.gitignore

@@ -2,6 +2,7 @@
 /.ruby-version
 /.yardoc
 /Gemfile.lock
+/yarn.lock
 /_yardoc/
 /coverage/
 /doc/

data/.rubocop.yml

@@ -1,5 +1,8 @@
 require: rubocop-rspec
 
+inherit_from:
+  - .rubocop_todo.yml
+
 AllCops:
   Exclude:
     - '.internal_test_app/**/*'
@@ -10,57 +13,13 @@ AllCops:
   TargetRubyVersion: 2.4
   DisplayCopNames: true
 
-Rails:
-  Enabled: true
-
-Metrics/LineLength:
-  Max: 120
-  Exclude:
-    - 'Gemfile'
-    - 'lib/arclight/custom_document.rb'  # XPaths get long
-    - 'lib/arclight/custom_component.rb' # XPaths get long
-
-Metrics/ModuleLength:
-  Max: 120
-
-Metrics/ClassLength:
-  Max: 120
-
 Metrics/BlockLength:
   Exclude:
-    - !ruby/regexp /\.rake$/
-    - 'arclight.gemspec'
-    - 'spec/**/*'
-    - 'lib/arclight/custom_document.rb'
-
-Metrics/MethodLength:
-  Exclude:
-    - 'lib/arclight/custom_document.rb' # arclight_field_definitions too long
+    - 'spec/features/traject/ead2_indexing_spec.rb'
 
-Performance/RegexpMatch:
-  Enabled: false
 
-Rails/OutputSafety:
-  Exclude:
-    - 'app/controllers/concerns/arclight/field_config_helpers.rb' # html_safe needs to be called to mimic BL JOIN behavior
-
-RSpec/ExampleLength:
-  Enabled: false
-
-RSpec/FilePath:
-  Exclude:
-    - 'spec/lib/arclight/viewers/oembed_spec.rb' # Default file path is o_embed, and that looks weird
-
-RSpec/MultipleExpectations:
-  Enabled: false
-
-RSpec/NestedGroups:
-  Max: 4
-
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/arclight.rb'
+Rails:
+  Enabled: true
 
 Bundler/DuplicatedGem:
   Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,259 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-08-21 15:42:57 -0600 using RuboCop version 0.74.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnabledMethods.
+Capybara/FeatureMethods:
+  Exclude:
+    - 'spec/features/compact_search_results_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Exclude:
+    - 'arclight.gemspec'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/AlignHash:
+  Exclude:
+    - 'lib/arclight/solr_ead_indexer_ext.rb'
+
+# Offense count: 29
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'app/factories/blacklight_field_configuration_factory.rb'
+    - 'app/helpers/arclight_helper.rb'
+    - 'app/models/arclight/parent.rb'
+    - 'app/models/concerns/arclight/catalog.rb'
+    - 'app/models/concerns/arclight/solr_document.rb'
+    - 'lib/arclight/normalized_date.rb'
+    - 'lib/arclight/normalized_id.rb'
+    - 'lib/arclight/normalized_title.rb'
+    - 'lib/arclight/repository.rb'
+    - 'lib/arclight/shared_indexing_behavior.rb'
+    - 'lib/arclight/viewers/oembed.rb'
+    - 'lib/arclight/year_range.rb'
+    - 'lib/tasks/index.rake'
+    - 'tasks/arclight.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowInHeredoc.
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'lib/tasks/index.rake'
+
+# Offense count: 1
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'lib/arclight/traject/ead2_config.rb'
+
+# Offense count: 1
+# Configuration parameters: IgnoreImplicitReferences.
+Lint/ShadowedArgument:
+  Exclude:
+    - 'lib/arclight/solr_ead_indexer_ext.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnneededCopDisableDirective:
+  Exclude:
+    - 'lib/arclight/shared_indexing_behavior.rb'
+
+# Offense count: 1
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'lib/arclight/year_range.rb'
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 16
+
+# Offense count: 70
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 278
+  Exclude:
+    - 'spec/features/traject/ead2_indexing_spec.rb'
+    
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 11
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 113
+
+# Offense count: 1
+# Configuration parameters: Blacklist.
+# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'spec/features/autocomplete_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db
+Naming/UncommunicativeMethodParamName:
+  Exclude:
+    - 'lib/arclight/shared_terminology_behavior.rb'
+
+# Offense count: 97
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/presenters/arclight/show_presenter_spec.rb'
+
+# Offense count: 58
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterExampleGroup:
+  Enabled: false
+
+# Offense count: 8
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterHook:
+  Exclude:
+    - 'spec/features/collection_page_spec.rb'
+    - 'spec/features/home_page_spec.rb'
+    - 'spec/features/many_component_ead_spec.rb'
+    - 'spec/features/search_results_spec.rb'
+    - 'spec/helpers/arclight_helper_spec.rb'
+    - 'spec/views/_collection_count.html.erb_spec.rb'
+    - 'spec/views/repositories/index.html.erb_spec.rb'
+
+# Offense count: 49
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Enabled: false
+
+# Offense count: 3
+RSpec/ExpectInHook:
+  Exclude:
+    - 'spec/helpers/arclight_helper_spec.rb'
+    - 'spec/lib/arclight/indexer_spec.rb'
+    - 'spec/presenters/arclight/index_presenter_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/lib/arclight/viewers/oembed_spec.rb'
+
+# Offense count: 108
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 28
+
+# Offense count: 22
+RSpec/NestedGroups:
+  Max: 4
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: Strict, EnforcedStyle.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
+  Exclude:
+    - 'spec/helpers/arclight_helper_spec.rb'
+    - 'spec/lib/arclight/year_range_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectStub:
+  Exclude:
+    - 'spec/lib/arclight/indexer_spec.rb'
+
+# Offense count: 1
+Security/Open:
+  Exclude:
+    - 'lib/tasks/index.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'lib/tasks/index.rake'
+
+# Offense count: 2
+Style/CommentedKeyword:
+  Exclude:
+    - 'lib/arclight/shared_terminology_behavior.rb'
+    - 'lib/arclight/year_range.rb'
+
+# Offense count: 1
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/arclight.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'arclight.gemspec'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'arclight.gemspec'
+    - 'lib/generators/arclight/install_generator.rb'
+    - 'lib/generators/arclight/update_generator.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'app/models/concerns/arclight/search_behavior.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MinMax:
+  Exclude:
+    - 'lib/arclight/year_range.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
+  Exclude:
+    - 'lib/arclight/shared_indexing_behavior.rb'
+
+# Offense count: 457
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 153

data/.travis.yml

@@ -3,31 +3,26 @@ language: ruby
 notifications:
   email: false
 rvm:
-  - 2.4.1
+  - 2.5.5
+  - 2.6.3
 jdk:
-  - oraclejdk8
-
-# Update to phantomjs 2.1.1 to fix issues with < 2
-# See https://github.com/travis-ci/travis-ci/issues/3225#issuecomment-177592725
-# and https://github.com/travis-ci/travis-ci/issues/3225#issuecomment-200965782
-cache:
-  bundler: true
-  directories:
-    - "travis_phantomjs"
-
-before_install:
-  - "phantomjs --version"
-  - "export PATH=$PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH"
-  - "phantomjs --version"
-  - "if [ $(phantomjs --version) != '2.1.1' ]; then rm -rf $PWD/travis_phantomjs; mkdir -p $PWD/travis_phantomjs; fi"
-  - "if [ $(phantomjs --version) != '2.1.1' ]; then wget https://assets.membergetmember.co/software/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2; fi"
-  - "if [ $(phantomjs --version) != '2.1.1' ]; then tar -xvf $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis_phantomjs; fi"
-  - "hash -r"
-  - "phantomjs --version"
+  - oraclejdk9
 
 before_script:
   - find spec/fixtures/ead -name '*.xml' | xargs xmllint --noout --schema spec/fixtures/xsd/ead.xsd
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+  - yarn install
 addons:
   apt:
     packages:
     - libxml2-utils
+  chrome: stable
+
+env:
+  global:
+    - CC_TEST_REPORTER_ID=65288e8c489d9d571730d098a9e7ec951e286f7d8ca3d728f4bb812dd7eeb46d
+
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/README.md

@@ -1,8 +1,7 @@
-[![Build Status](https://travis-ci.org/sul-dlss/arclight.svg?branch=master)](https://travis-ci.org/sul-dlss/arclight)
+[![Build Status](https://travis-ci.org/projectblacklight/arclight.svg?branch=master)](https://travis-ci.org/projectblacklight/arclight)
+[![Code Climate Test Coverage](https://codeclimate.com/github/sul-dlss/arclight/badges/coverage.svg)](https://codeclimate.com/github/sul-dlss/arclight/coverage)
 
-[![Coverage Status](https://coveralls.io/repos/github/sul-dlss/arclight/badge.svg?branch=master)](https://coveralls.io/github/sul-dlss/arclight?branch=master)
-
-# Arclight
+# ArcLight
 
 A Rails engine supporting discovery of archival materials.
 
@@ -51,6 +50,19 @@ See the [ArcLight demo](https://arclight-demo.projectblacklight.org/) and [ArcLi
 
 See [Arclight Major Features](https://github.com/sul-dlss/arclight/wiki/Arclight-Major-Features) for a list of features.
 
+### Traject indexing of EAD content
+[Traject](https://github.com/traject/traject) is a proposed way forward for migrating indexing. An EAD2 can be indexed by doing the following:
+
+```sh
+bundle exec traject -u http://127.0.0.1:8983/solr/blacklight-core -i xml -c lib/arclight/traject/ead2_config.rb spec/fixtures/ead/sample/large-components-list.xml
+```
+
+Or pass the `TRAJECT=true` env variable to current indexing tasks.
+
+```sh
+TRAJECT=true bundle exec rake arclight:seed
+end
+
 ## Resources
 
 * General
@@ -86,6 +98,7 @@ Ensure Solr and Rails are _not_ running (ports 8983 and 3000 respectively), then
 ```sh
 $ bundle exec rake
 ```
+If you find that the tests are failing when you run them on a Linux computer, you might need to install Google Chrome so the Selenium testing framework can run properly.
 
 ### Run a development server
 

data/app/assets/images/blacklight/compact.svg

@@ -6,20 +6,20 @@
     <defs></defs>
     <g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd" stroke-linecap="square">
         <g id="Compact" stroke="#000000">
-            <path d="M1.43885093,2.44444444 L6.83349609,2.44444444" id="Line"></path>
-            <path d="M1.43885093,4.44444444 L6.83349609,4.44444444" id="Line"></path>
-            <path d="M1.43885093,6.44444444 L6.83349609,6.44444444" id="Line"></path>
-            <path d="M1.43885093,8.44444444 L6.83349609,8.44444444" id="Line"></path>
-            <path d="M1.43885093,10.4444444 L6.83349609,10.4444444" id="Line"></path>
-            <path d="M1.43885093,12.4444444 L6.83349609,12.4444444" id="Line"></path>
-            <path d="M1.43885093,14.4444444 L6.83349609,14.4444444" id="Line"></path>
-            <path d="M9.43885093,2.44444444 L14.8334961,2.44444444" id="Line"></path>
-            <path d="M9.43885093,4.44444444 L14.8334961,4.44444444" id="Line"></path>
-            <path d="M9.43885093,6.44444444 L14.8334961,6.44444444" id="Line"></path>
-            <path d="M9.43885093,8.44444444 L14.8334961,8.44444444" id="Line"></path>
-            <path d="M9.43885093,10.4444444 L14.8334961,10.4444444" id="Line"></path>
-            <path d="M9.43885093,12.4444444 L14.8334961,12.4444444" id="Line"></path>
-            <path d="M9.43885093,14.4444444 L14.8334961,14.4444444" id="Line"></path>
+            <path d="M1.43885093,2.44444444 L6.83349609,2.44444444"></path>
+            <path d="M1.43885093,4.44444444 L6.83349609,4.44444444"></path>
+            <path d="M1.43885093,6.44444444 L6.83349609,6.44444444"></path>
+            <path d="M1.43885093,8.44444444 L6.83349609,8.44444444"></path>
+            <path d="M1.43885093,10.4444444 L6.83349609,10.4444444"></path>
+            <path d="M1.43885093,12.4444444 L6.83349609,12.4444444"></path>
+            <path d="M1.43885093,14.4444444 L6.83349609,14.4444444"></path>
+            <path d="M9.43885093,2.44444444 L14.8334961,2.44444444"></path>
+            <path d="M9.43885093,4.44444444 L14.8334961,4.44444444"></path>
+            <path d="M9.43885093,6.44444444 L14.8334961,6.44444444"></path>
+            <path d="M9.43885093,8.44444444 L14.8334961,8.44444444"></path>
+            <path d="M9.43885093,10.4444444 L14.8334961,10.4444444"></path>
+            <path d="M9.43885093,12.4444444 L14.8334961,12.4444444"></path>
+            <path d="M9.43885093,14.4444444 L14.8334961,14.4444444"></path>
         </g>
     </g>
-</svg>
+</svg>