archive_hook 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e54918283bc4fcb9f8c3890c51191fe8b844e0d82d6fe6f5316c2af38a3ebc3e
-  data.tar.gz: 2126bf291081eb4943422c7ff7ac3fc57ace9faa9904c94904a3ccf780355de6
+  metadata.gz: 4952c4f26bb1327189da3753cbf44bf1fcd76f5477cc8e0160265d508b3f46db
+  data.tar.gz: 8e0930ef126fef1b8ff7e347a5ba17b95b0aad13eaabc4a1818f918c10edba3c
 SHA512:
-  metadata.gz: aba9e9c6ec17d9b92cc90915e48ed451daf3c82aa8cd723a4700b1d1e2da07c504e2374b0c6ca5f8667cae59e69f679c45a851e4fd9c38034c60b0d24d1c4c62
-  data.tar.gz: 677fcee118a322e088f6c8c66dffd8a9b7468812f3025182bfa4ffa6714cf6635088fe5928dfe788316bc624bc93f7273a6577ce7b6b47f3e459fae4403f9a42
+  metadata.gz: 9ea29d7cb8a0269f8a3bd956820d21f69bd33cff1cfc9ca3c8a3c3d7b35fabb0cb2b34362402ee4233f50dd11ea33f72f96f1d57ef3505834da837d793a158a0
+  data.tar.gz: b1dcefaf9e2b9e0b6c7caa491756a7876557f2dc0e6ce8bd95070a7f3120a7fa2717370c0dc6a8eda06c510251aeac0080976fd3be4c27e905c22513d11b52ad

data/lib/archive_hook/version.rb

@@ -1,3 +1,3 @@
 module ArchiveHook
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/archive_hook.rb

@@ -1,7 +1,29 @@
 require "archive_hook/version"
 
 module ArchiveHook
+  # Identifiers are interpolated straight into SQL, so anything that needs
+  # quoting -- a column called "default", "order" or "group", a table name that
+  # collides with a keyword -- has to be quoted or Postgres rejects the
+  # statement with a syntax error.
+  module Quoting
+    private
+
+    def quote_columns(column_names)
+      column_names.map { |name| connection.quote_column_name(name) }.join(",")
+    end
+
+    def quote_table(name)
+      connection.quote_table_name(name)
+    end
+
+    def connection
+      ActiveRecord::Base.connection
+    end
+  end
+
   class ScopeArchiver
+    include Quoting
+
     def initialize(dependencies: {})
       @dependencies = dependencies
     end
@@ -37,23 +59,24 @@ module ArchiveHook
     end
 
     def archive_records_sql(scope)
-      table_name = scope.table_name
-      attributes_list = scope.column_names.join(",")
+      attributes_list = quote_columns(scope.column_names)
       <<-SQL
-        INSERT INTO #{table_name}_archive (#{attributes_list})
+        INSERT INTO #{quote_table("#{scope.table_name}_archive")} (#{attributes_list})
         #{scope.select(attributes_list).to_sql}
       SQL
     end
   end
 
   class ScopeRestorer
+    include Quoting
+
     def initialize(dependencies: {})
       @dependencies = dependencies
     end
 
     def call(scope)
       parent = scope.model
-      table_name = "#{scope.table_name}_archive as #{scope.table_name}"
+      table_name = "#{quote_table("#{scope.table_name}_archive")} as #{quote_table(scope.table_name)}"
       parent_id_groups = scope.from(table_name).in_batches.map { |relation| relation.pluck(:id) }
       parent_id_groups.each do |parent_ids|
         restore_by_ids(parent, parent_ids)
@@ -78,22 +101,22 @@ module ArchiveHook
     end
 
     def restore_by_ids(model, ids)
-      table_name = model.table_name
       ActiveRecord::Base.transaction do
-        ActiveRecord::Base.connection.execute(Arel.sql(restore_records_sql(model, ids)))
-        ActiveRecord::Base.connection.execute(Arel.sql <<-SQL
-          DELETE FROM #{table_name}_archive WHERE id IN (#{ids.join(', ')})
+        connection.execute(Arel.sql(restore_records_sql(model, ids)))
+        connection.execute(Arel.sql <<-SQL
+          DELETE FROM #{quote_table("#{model.table_name}_archive")}
+          WHERE #{connection.quote_column_name(model.primary_key)} IN (#{ids.join(', ')})
         SQL
         )
       end
     end
 
     def restore_records_sql(model, ids)
-      table_name = model.table_name
-      attributes_list = model.column_names.join(",")
+      attributes_list = quote_columns(model.column_names)
       <<-SQL
-        INSERT INTO #{table_name} (#{attributes_list})
-        SELECT #{attributes_list} FROM #{table_name}_archive WHERE id IN (#{ids.join(', ')})
+        INSERT INTO #{quote_table(model.table_name)} (#{attributes_list})
+        SELECT #{attributes_list} FROM #{quote_table("#{model.table_name}_archive")}
+        WHERE #{connection.quote_column_name(model.primary_key)} IN (#{ids.join(', ')})
       SQL
     end
   end
@@ -101,7 +124,8 @@ module ArchiveHook
   class << self
     def archive(root, archive_date, dependencies)
       column = dependencies[root] && dependencies[root][:column] || :created_at
-      base_scope = root.where("#{column} < ?", archive_date)
+      quoted_column = ActiveRecord::Base.connection.quote_column_name(column)
+      base_scope = root.where("#{quoted_column} < ?", archive_date)
       ScopeArchiver.new(dependencies: dependencies).call(base_scope)
     end
 

data/lib/generators/archive_hook/templates/migration.rb

@@ -2,7 +2,13 @@
 
 class Create<%= archive_table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>
   def up
-    execute("CREATE TABLE <%= archive_table_name %> (LIKE <%= table_name %>)")
+    # Quoted at run time so a mixed-case table name survives Postgres folding
+    # unquoted identifiers to lower case, and so a name that collides with a
+    # reserved word still parses.
+    execute(
+      "CREATE TABLE #{connection.quote_table_name('<%= archive_table_name %>')} " \
+      "(LIKE #{connection.quote_table_name('<%= table_name %>')})"
+    )
   end
 
   def down

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: archive_hook
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - alvir
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-31 00:00:00.000000000 Z
+date: 2026-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord