arcadia_cops 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7bd311576a85df26bc0ec95d52dd6ecd5fe2b2b0
-  data.tar.gz: af60523f56d95bdf670c5102f8b88fb8205fee2a
+  metadata.gz: 84600629053ba1052a1d4038e1bd2779207c9bd4
+  data.tar.gz: 8825d24775f597ec9a5db9b1c75d7211407c9260
 SHA512:
-  metadata.gz: 0be0177915bf5626d5e00145f9a698dbfccb1de3ce6254748653c99210319fa502431f51dbd8798921e6793cfb8f025288bd15ed8979c48e4cbe32ba4349ec85
-  data.tar.gz: dd95d5e221b623795d7ce838526252452f186c72b9b188f9df3c291540fcde885ed5980f57af928f9e0b337afdc634ea080b033ad5f1263d4e5fe0a75ccfe177
+  metadata.gz: 54f250e1f25650cd492999b95e68f673450140e4c75190f12e03e2db031ebce4426d59f8b888328a64a83ccae93c420c62fac9b428ad96b6112962375d7f10b7
+  data.tar.gz: 5834e7bd2b73b6fcd2635d5c80590ad2e18010792e4939fe15d451077a4804bee183f72b250d5dda593e48ba3206f575243b1bcaba452916c28142123e22e9aa

data/README.md

@@ -0,0 +1,27 @@
+Arcadia Power Rubocop Configuration
+===================================
+ The arcadia_cops gem contains enabled and customized [rubocop](https://github.com/bbatsov/rubocop) cops to check and enforce our style guide.
+
+## Install
+
+```ruby
+# Add to your gemfile
+gem 'arcadia_cops'
+```
+
+Then setup your `.rubocop.yml` file per [rubocop docs](http://rubocop.readthedocs.io/en/latest/configuration/#inheriting-configuration-from-a-dependency-gem).
+
+
+## Development
+
+Add a new cop to the `enabled.yml`, bump the version, and put in a PR for review.
+
+To see all cops including those that aren't enabled run `bundle exex rubocop --show-cops`.
+
+## Release
+
+Ensure you have bumped the version and run `rake release` to release to rubygems.org.
+
+## Other
+
+`arcadia_cops` also maintains the rubocop version to maintain parity across repos.

data/{lib/arcadia_cops → config}/enabled.yml

@@ -17,9 +17,63 @@ Layout/AlignHash:
                  Align the elements of a hash literal if they span more than
                  one line.
 
+Layout/AlignParameters:
+  Description: Align the parameters of a method call if they span more than one line.
+  StyleGuide: "#no-double-indent"
+  EnforcedStyle: with_fixed_indentation
+  SupportedStyles:
+  - with_first_parameter
+  - with_fixed_indentation
+  IndentationWidth: 2
+
 Layout/BlockEndNewline:
   Description: 'Put end statement of multiline block on its own line.'
 
+Style/DefWithParentheses:
+  Description: 'Use def with parentheses when there are arguments.'
+  StyleGuide: '#method-parens'
+
+Style/MethodDefParentheses:
+  Description: Checks if the method definitions have or don't have parentheses.
+  StyleGuide: "#method-parens"
+  EnforcedStyle: require_parentheses
+  SupportedStyles:
+  - require_parentheses
+  - require_no_parentheses
+  - require_no_parentheses_except_multiline
+
+Layout/FirstMethodArgumentLineBreak:
+  Description: Checks for a line break before the first argument in a multi-line method
+    call.
+
+Layout/MultilineMethodCallBraceLayout:
+  Description: Checks that the closing brace in a method call is either on the same
+    line as the last method argument, or a new line.
+  EnforcedStyle: symmetrical
+  SupportedStyles:
+  - symmetrical
+  - new_line
+  - same_line
+
+Layout/MultilineMethodDefinitionBraceLayout:
+  Description: Checks that the closing brace in a method definition is either on the
+    same line as the last method parameter, or a new line.
+  EnforcedStyle: symmetrical
+  SupportedStyles:
+  - symmetrical
+  - new_line
+  - same_line
+
+Layout/ClosingParenthesisIndentation:
+  Description: Checks the indentation of hanging closing parentheses.
+
+Style/BlockDelimiters:
+  Description: >-
+                Avoid using {...} for multi-line blocks (multiline chaining is
+                always ugly).
+                Prefer {...} over do...end for single-line blocks.
+  StyleGuide: '#single-line-blocks'
+
 Style/CommentAnnotation:
   Description: >-
                  Checks formatting of special comments

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arcadia_cops
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - justin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-31 00:00:00.000000000 Z
+date: 2017-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,34 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.49.0
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Contains enabled rubocops for arcadia power ruby repos.
 email:
 - justin@arcadiapower.com
@@ -31,10 +59,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/arcadia_cops.rb
-- lib/arcadia_cops/config.yml
-- lib/arcadia_cops/enabled.yml
-- lib/arcadia_cops/version.rb
+- README.md
+- config/config.yml
+- config/enabled.yml
 homepage: https://github.com/ArcadiaPower/rubocop/
 licenses:
 - MIT

data/lib/arcadia_cops/version.rb

@@ -1,3 +0,0 @@
-module ArcadiaCops
-  VERSION = '1.0.1'
-end

data/lib/arcadia_cops.rb

@@ -1,2 +0,0 @@
-module ArcadiaCops
-end