arask 1.1.3 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bbc371d18529aa76cdb47358c395712a623f95c6
-  data.tar.gz: c48f5ddda64e71cafac940cb3ce4af81691ae2ba
+  metadata.gz: e2055444d486251702ec8f09cc6944742f4ef45e
+  data.tar.gz: 3215c191aab13ce67fec68d09ec02962314f528b
 SHA512:
-  metadata.gz: 2061665d541fc6bc7758b0a595161b18820f267ea90e3bb56edead27f7bc666fe78d765405c2f86e69d11d744052a918a11a98bdfd76463a745a3f81c34a68d5
-  data.tar.gz: 1338c50d342cd77ff4d26bc273f518c276e1174369fcc5db0a27938573302dfd148dafd6243dcdb7126027f29682dd1c50902aab20122c603cbba5183d58b87f
+  metadata.gz: ba226a137d88675b7375f5bc59cdd780437a5f9bd218c7523ec8ad149823d03511b96a358acb3ca8b2d2a26d9b36a3577bb134925b03ee0f9a8c75721cf53cc0
+  data.tar.gz: af1ab2f4a7933407c0361e4f14fc09a8c00f974db29859a3532fabe374a25f28db8cfca5fc7c252af539f17f28f632c51b77ea3c1cd5bc4709aa88eae6fce408

data/README.md

@@ -49,6 +49,11 @@ arask.create script: 'Attachment.process_new', interval: 5.hours, run_first_time
 
 # On exceptions, send email with details
 arask.on_exception email: 'errors@example.com'
+
+# Run code on exceptions
+arask.on_exception do |exception, arask_job|
+  Honeybadger.notify(exception)
+end
 ```
 
 ### About cron
@@ -61,10 +66,9 @@ The interval starts when the task has started running. If a task with the interv
 
 ## Todos
 * Have a "try again" feature. For instance `arask.create script: 'raise "I failed"', interval: :daily, fail_retry: 5.minutes, retry_at_most: 2`
-* Be able to run a block when an exception occurs. `arask.on_exception do <code> end`
 * Be able to specify line and number that failed for an exception:
 ```ruby
-file,line,_ = caller.first.split(' ')[0].split(':')
+file,line,_ = caller.first.split(':')
 fileline = File.readlines(file)[line.to_i - 1].strip
 ```
 

data/lib/arask.rb

@@ -5,11 +5,14 @@ require "arask/setup"
 require 'fugit' # To parse cron
 
 module Arask
-  class << self; attr_accessor :jobs_touched, :exception_email, :exception_email_from; end
+  class << self; attr_accessor :jobs_touched, :exception_email, :exception_email_from, :exception_block; end
 
   def self.setup
     # Make sure we only run setup if Rails is actually run as a server or testing.
     return unless defined?(Rails::Server) or Rails.env.test?
+    # If we don't wait and rails is setup to use another language, ActiveJob
+    # saves what is now (usually :en) and reloads that when trying to run the
+    # job. Renderering an I18n error of unsupported language.
     ActiveSupport.on_load :after_initialize, yield: true do
       Arask.jobs_touched = []
       yield Setup

data/lib/arask/arask_job.rb

@@ -16,6 +16,9 @@ module Arask
         p self
         puts e.message
 
+        unless Arask.exception_block.nil?
+          Arask.exception_block.call(e, self)
+        end
         unless Arask.exception_email.nil?
           ActionMailer::Base.mail(
             from: Arask.exception_email_from,

data/lib/arask/initialize.rb

@@ -21,4 +21,9 @@ Arask.setup do |arask|
 
   # On exceptions, send email with details
   #arask.on_exception email: 'errors@example.com'
+
+  # Run code on exceptions
+  #arask.on_exception do |exception, arask_job|
+  #  Honeybadger.notify(exception)
+  #end
 end

data/lib/arask/setup.rb

@@ -1,9 +1,12 @@
 module Arask
   class Setup
-    def self.on_exception(email: nil, from: 'robot@server')
-      Arask.exception_email = email
-      Arask.exception_email_from = from
-      puts "Arask could not parse parameter for on_exception!" unless email.class == String
+    def self.on_exception(email: nil, from: 'robot@server', &block)
+      Arask.exception_email = email unless email.nil?
+      Arask.exception_email_from = from unless from.nil?
+      puts "Arask could not parse parameter for on_exception!" unless email.nil? or email.class == String
+      if block_given?
+        Arask.exception_block = block
+      end
     end
 
     def self.create(script: nil, task: nil, job: nil, interval: nil, cron: nil, run_first_time: false)

data/lib/arask/version.rb

@@ -1,3 +1,3 @@
 module Arask
-  VERSION = '1.1.3'
+  VERSION = '1.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arask
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - Esben Damgaard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-02 00:00:00.000000000 Z
+date: 2018-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails