aranha-parsers 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbfb4a3d4feea7f1277d6799adf12fed1b52883dd63954a1f363de7bad9330ae
-  data.tar.gz: d2d9374791a11f06efeb8530034fc71db7232f513cd7ddfa3cef0176b3fde6cd
+  metadata.gz: b5dea73c22dac3845360b773ca5b07d3c122dbc5d108c1e24c9bd778187aedd3
+  data.tar.gz: 836cae17dea5908018ca41e0a73566bebc35c2df67709b0c8ea2ea3509eaaeb9
 SHA512:
-  metadata.gz: 27392a453f55a9e1e3434f551274828928c759eb338fe5563831ea734fbeada2f24ba115bc1174e25e074070370088afd295cbda4f1319de58e76188e5eec6dc
-  data.tar.gz: e31aef37cc29d8c22a237e96f0cf73b05f5edd1e915d44921a3c4b2614ddba764390289d4136874010743b9d7dee9ba6dd634b7f96e3499c72eee86d4c4e0327
+  metadata.gz: 199a2471fd78740fa54ef4f31446e8ff7f4ea74ea03d32328a5b9ee56ab99be31db87c217a544d070ce5d743cab3211847d570363d41acbe820169031a6b2715
+  data.tar.gz: b4a9d90a266fedd2a11d497565d0ac9a10295f8ce87835689d10ab4a71b5c0bae4e2d654afe0089a9dfe190861b0bc77d77f26bcac188b772b05dc491d18b660

data/lib/aranha/parsers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Aranha
   module Parsers
     require 'aranha/parsers/base'

data/lib/aranha/parsers/base.rb

@@ -30,12 +30,14 @@ module Aranha
         path = log_file(suffix)
 
         return unless path
+
         File.open(path, 'wb') { |file| file.write(content) }
       end
 
       def log_file(suffix)
         dir = log_parsers_dir
         return nil unless dir
+
         f = ::File.join(dir, "#{self.class.name.parameterize}#{suffix}.log")
         FileUtils.mkdir_p(File.dirname(f))
         f
@@ -44,6 +46,7 @@ module Aranha
       def log_parsers_dir
         return ENV[LOG_DIR_ENVVAR] if ENV[LOG_DIR_ENVVAR]
         return ::Rails.root.join('log', 'parsers') if rails_root_exist?
+
         nil
       end
 
@@ -51,7 +54,7 @@ module Aranha
         ::Rails.root
         true
       rescue NameError
-        return false
+        false
       end
     end
   end

data/lib/aranha/parsers/html.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Aranha
   module Parsers
     module Html

data/lib/aranha/parsers/html/item.rb

@@ -14,6 +14,7 @@ module Aranha
           @item_node ||= begin
             r = item_xpath ? nokogiri.at_xpath(item_xpath) : nokogiri
             raise "Item node not found (Item xpath: #{item_xpath})" unless r
+
             r
           end
         end

data/lib/aranha/parsers/html/node.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Aranha
   module Parsers
     module Html

data/lib/aranha/parsers/html/node/default.rb

@@ -19,11 +19,13 @@ module Aranha
             root = node.at_xpath(xpath)
             if root.blank?
               return nil unless required
+
               raise "No node found (Xpath: #{xpath})"
             end
             result = string_recursive(root)
-            return result unless result.blank?
+            return result if result.present?
             return nil unless required
+
             raise "String blank (Xpath: #{xpath})"
           end
 
@@ -109,6 +111,7 @@ module Aranha
 
           def string_recursive(node)
             return sanitize_string(node.text) if node.is_a?(::Nokogiri::XML::Text)
+
             s = ''
             node.children.each do |child|
               child_s = string_recursive(child)

data/lib/aranha/parsers/source_address.rb

@@ -20,6 +20,7 @@ module Aranha
 
         def detect_sub(source)
           return source.sub if source.is_a?(self)
+
           SUBS.each do |sub|
             return sub.new(source) if sub.valid_source?(source)
           end
@@ -27,7 +28,7 @@ module Aranha
         end
 
         def deserialize(string)
-          new(string =~ %r{\A[a-z]+://} ? string.strip : ::YAML.load(string))
+          new(string =~ %r{\A[a-z]+://} ? string.strip : ::YAML.load(string)) # rubocop:disable Security/YAMLLoad
         end
 
         def from_file(path)

data/lib/aranha/parsers/source_address/http_get.rb

@@ -36,6 +36,7 @@ module Aranha
           c.follow_location = true
           raise "Curl perform failed (URL: #{url})" unless c.perform
           return c.body_str if c.status.to_i == 200
+
           raise "Get #{url} returned #{c.status.to_i}"
         end
 

data/lib/aranha/parsers/source_target_fixtures.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # frozen_string_literal: true
 
 require 'active_support/core_ext/object'
@@ -50,7 +49,7 @@ module Aranha
       def fixture_file(basename, suffix)
         prefix = "#{basename}.#{suffix}"
         Dir.foreach(fixtures_directory) do |item|
-          next if item == '.' || item == '..'
+          next if %w[. ..].include?(item)
           return File.expand_path(item, fixtures_directory) if item.starts_with?(prefix)
         end
         nil
@@ -59,7 +58,8 @@ module Aranha
       def sources_targets_basenames
         basenames = Set.new
         Dir.foreach(fixtures_directory) do |item|
-          next if item == '.' || item == '..'
+          next if %w[. ..].include?(item)
+
           b = self.class.source_target_basename(item)
           basenames << b if b.present?
         end

data/lib/aranha/parsers/spec/source_target_fixtures_example.rb

@@ -10,12 +10,12 @@ RSpec.shared_examples 'source_target_fixtures' do |spec_file| # rubocop:disable
   end
 
   context 'in fixtures directory' do
-    it 'should have at least one file' do
-      expect(source_target_fixtures.source_target_files.count).to be > 0
+    it 'has at least one file' do
+      expect(source_target_fixtures.source_target_files.count).to be > 0 # rubocop:disable Style/NumericPredicate
     end
 
     if ENV['WRITE_TARGET_FIXTURES']
-      it 'should write target data for all files' do
+      it 'writes target data for all files' do
         source_target_fixtures.source_files.each do |source_file|
           sd = sort_results(source_data(source_file))
           basename = ::Aranha::Parsers::SourceTargetFixtures.source_target_basename(source_file)
@@ -24,7 +24,7 @@ RSpec.shared_examples 'source_target_fixtures' do |spec_file| # rubocop:disable
         end
       end
     else
-      it 'should parse data for all files' do
+      it 'parses data for all files' do
         source_target_fixtures.source_target_files.each do |st|
           assert_source_target_complete(st)
           sd = source_data(st.source)
@@ -39,9 +39,9 @@ RSpec.shared_examples 'source_target_fixtures' do |spec_file| # rubocop:disable
     @source_target_fixtures ||= ::Aranha::Parsers::SourceTargetFixtures.new(fixtures_dir)
   end
 
-  def assert_source_target_complete(st)
-    expect(st.source).to(be_truthy, "Source not found (Target: #{st.target})")
-    expect(st.target).to(be_truthy, "Target not found (Source: #{st.source})")
+  def assert_source_target_complete(source_target)
+    expect(source_target.source).to(be_truthy, "Source not found (Target: #{source_target.target})")
+    expect(source_target.target).to(be_truthy, "Target not found (Source: #{source_target.source})")
   end
 
   def source_data(source_file)
@@ -55,7 +55,7 @@ RSpec.shared_examples 'source_target_fixtures' do |spec_file| # rubocop:disable
     )
   end
 
-  def sort_results(r)
-    r
+  def sort_results(results)
+    results
   end
 end

data/lib/aranha/parsers/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Aranha
   module Parsers
-    VERSION = '0.2.2'.freeze
+    VERSION = '0.3.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aranha-parsers
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Esquilo Azul Company
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-24 00:00:00.000000000 Z
+date: 2020-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport