arachni 1.4 → 1.6.0

data/components/reporters/plugin_formatters/xml/vector_collector.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework
@@ -17,11 +17,11 @@ class PluginFormatters::VectorCollector < Arachni::Plugin::Formatter
                 xml.vector {
                     xml.class_ vector['class']
                     xml.type vector['type']
-                    xml.url vector['url']
-                    xml.action vector['action']
+                    xml.url Arachni::Reporters::XML.replace_nulls( vector['url'] )
+                    xml.action Arachni::Reporters::XML.replace_nulls( vector['action'] )
 
                     if vector['source']
-                        xml.source vector['source']
+                        xml.source Arachni::Reporters::XML.replace_nulls( vector['source'] )
                     end
 
                     if vector['method']
@@ -31,7 +31,10 @@ class PluginFormatters::VectorCollector < Arachni::Plugin::Formatter
                     if vector['inputs']
                         xml.inputs {
                             vector['inputs'].each do |k, v|
-                                xml.input( name: k, value: v )
+                                xml.input(
+                                    name:  Arachni::Reporters::XML.replace_nulls( k ),
+                                    value: Arachni::Reporters::XML.replace_nulls( v )
+                                )
                             end
                         }
                     end

data/components/reporters/plugin_formatters/xml/waf_detector.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework

data/components/reporters/stdout.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework
@@ -33,6 +33,7 @@ class Arachni::Reporters::Stdout < Arachni::Reporter::Base
         print_info '---------------'
 
         print_info "Version:           #{report.version}"
+        print_info "Seed:              #{report.seed}"
         print_info "Audit started on:  #{report.start_datetime}"
         print_info "Audit finished on: #{report.finish_datetime}"
         print_info "Runtime:           #{report.delta_time}"
@@ -216,7 +217,7 @@ class Arachni::Reporters::Stdout < Arachni::Reporter::Base
             name:        'Stdout',
             description: %q{Prints the results to standard output.},
             author:      'Tasos "Zapotek" Laskos <tasos.laskos@arachni-scanner.com>',
-            version:     '0.3.2'
+            version:     '0.3.3'
         }
     end
 

data/components/reporters/txt.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework

data/components/reporters/xml/schema.xsd

@@ -5,6 +5,7 @@
         <xs:complexType>
             <xs:all>
                 <xs:element name="version" type="xs:string"/>
+                <xs:element name="seed" type="xs:string"/>
                 <xs:element name="start_datetime" type="xs:dateTime" />
                 <xs:element name="finish_datetime" type="xs:dateTime"/>
                 <xs:element name="sitemap" type="sitemap"/>
@@ -52,6 +53,7 @@
             <xs:element name="general" type="plugin_metrics_results_general"/>
             <xs:element name="scan" type="plugin_metrics_results_scan"/>
             <xs:element name="http" type="plugin_metrics_results_http"/>
+            <xs:element name="browser_cluster" minOccurs="0" type="plugin_metrics_results_browser_cluster"/>
             <xs:element name="resource" type="plugin_metrics_results_resource"/>
             <xs:element name="element" type="plugin_metrics_results_element"/>
             <xs:element name="dom" type="plugin_metrics_results_dom"/>
@@ -75,20 +77,33 @@
         </xs:all>
     </xs:complexType>
 
+    <xs:complexType name="plugin_metrics_results_browser_cluster">
+        <xs:all>
+            <xs:element name="seconds_per_job" type="xs:float"/>
+            <xs:element name="total_job_time" type="xs:float"/>
+            <xs:element name="job_count" type="xs:integer"/>
+            <xs:element name="job_time_outs" type="xs:integer"/>
+        </xs:all>
+    </xs:complexType>
+
     <xs:complexType name="plugin_metrics_results_http">
         <xs:all>
-            <xs:element name="requests" type="xs:integer"/>
-            <xs:element name="response_time_min" type="xs:float"/>
-            <xs:element name="response_time_max" type="xs:float"/>
-            <xs:element name="response_time_average" type="xs:float"/>
+            <xs:element name="requests" minOccurs="0" type="xs:integer"/>
+
+            <xs:element name="request_time_outs" minOccurs="0" type="xs:integer"/>
+            <xs:element name="request_size_min" minOccurs="0" type="xs:float"/>
+            <xs:element name="request_size_max" minOccurs="0" type="xs:float"/>
+            <xs:element name="request_size_average" minOccurs="0" type="xs:float"/>
+
+            <xs:element name="response_time_min" minOccurs="0" type="xs:float"/>
+            <xs:element name="response_time_max" minOccurs="0" type="xs:float"/>
+            <xs:element name="response_time_average" minOccurs="0" type="xs:float"/>
 
-            <xs:element name="response_size_min" type="xs:float"/>
-            <xs:element name="response_size_max" type="xs:float"/>
-            <xs:element name="response_size_average" type="xs:float"/>
+            <xs:element name="responses_per_second" minOccurs="0" type="xs:float"/>
 
-            <xs:element name="request_size_min" type="xs:float"/>
-            <xs:element name="request_size_max" type="xs:float"/>
-            <xs:element name="request_size_average" type="xs:float"/>
+            <xs:element name="response_size_min" minOccurs="0" type="xs:float"/>
+            <xs:element name="response_size_max" minOccurs="0" type="xs:float"/>
+            <xs:element name="response_size_average" minOccurs="0" type="xs:float"/>
         </xs:all>
     </xs:complexType>
 
@@ -695,7 +710,7 @@
     <xs:complexType name="stackframe">
         <xs:all>
             <xs:element name="function" type="function"/>
-            <xs:element name="line" type="xs:integer"/>
+            <xs:element name="line" type="xs:integer" nillable="true"/>
             <xs:element name="url" type="xs:string"/>
         </xs:all>
     </xs:complexType>
@@ -714,7 +729,7 @@
 
     <xs:complexType name="headers">
         <xs:sequence>
-            <xs:element name="header" type="input"
+            <xs:element name="header" type="header"
                         minOccurs="0" maxOccurs="unbounded"/>
         </xs:sequence>
     </xs:complexType>
@@ -726,7 +741,7 @@
 
     <xs:complexType name="parameters">
         <xs:sequence>
-            <xs:element name="parameter" type="input"
+            <xs:element name="parameter" type="parameter"
                         minOccurs="0" maxOccurs="unbounded"/>
         </xs:sequence>
     </xs:complexType>
@@ -747,6 +762,7 @@
             <xs:enumeration value="Arachni::Element::Link::DOM"/>
             <xs:enumeration value="Arachni::Element::Cookie" />
             <xs:enumeration value="Arachni::Element::Cookie::DOM" />
+            <xs:enumeration value="Arachni::Element::NestedCookie" />
             <xs:enumeration value="Arachni::Element::Header" />
             <xs:enumeration value="Arachni::Element::LinkTemplate" />
             <xs:enumeration value="Arachni::Element::LinkTemplate::DOM"/>

data/components/reporters/xml.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework
@@ -16,6 +16,7 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
     LOCAL_SCHEMA  = File.dirname( __FILE__ ) + '/xml/schema.xsd'
     REMOTE_SCHEMA = 'https://raw.githubusercontent.com/Arachni/arachni/' <<
         "v#{Arachni::VERSION}/components/reporters/xml/schema.xsd"
+    NULL          = '[ARACHNI_NULL]'
 
     def run
         builder = Nokogiri::XML::Builder.new do |xml|
@@ -24,13 +25,14 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
                 'xsi:noNamespaceSchemaLocation' => REMOTE_SCHEMA
             ) {
                 xml.version report.version
+                xml.seed report.seed
                 xml.options Arachni::Options.hash_to_save_data( report.options )
                 xml.start_datetime report.start_datetime.xmlschema
                 xml.finish_datetime report.finish_datetime.xmlschema
 
                 xml.sitemap {
                     report.sitemap.each do |url, code|
-                        xml.entry url: url, code: code
+                        xml.entry url: replace_nulls( url ), code: code
                     end
                 }
 
@@ -65,15 +67,15 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
                             xml.vector {
                                 xml.class_ vector.class
                                 xml.type vector.type
-                                xml.url vector.url
-                                xml.action vector.action
+                                xml.url replace_nulls( vector.url )
+                                xml.action replace_nulls( vector.action )
 
                                 if vector.respond_to? :source
-                                    xml.source vector.source
+                                    xml.source replace_nulls( vector.source )
                                 end
 
                                 if vector.respond_to? :seed
-                                    xml.seed vector.seed
+                                    xml.seed replace_nulls( vector.seed )
                                 end
 
                                 if issue.active?
@@ -81,7 +83,7 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
                                 end
 
                                 if vector.respond_to? :affected_input_name
-                                    xml.affected_input_name vector.affected_input_name
+                                    xml.affected_input_name replace_nulls( vector.affected_input_name )
                                 end
 
                                 if vector.respond_to? :inputs
@@ -168,6 +170,8 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
         end
 
         IO.binwrite( outfile, xml )
+
+        print_info "Null bytes have been replaced with: #{NULL}"
         print_status "Saved in '#{outfile}'."
     end
 
@@ -177,15 +181,23 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
             description:  %q{Exports the audit results as an XML (.xml) file.},
             content_type: 'text/xml',
             author:       'Tasos "Zapotek" Laskos <tasos.laskos@arachni-scanner.com>',
-            version:      '0.3.4',
-            options:      [ Options.outfile( '.xml' ), Options.skip_responses ]
+            version:      '0.3.8',
+            options:      [ Options.outfile( '.xml' ) ]
         }
     end
 
+    def self.replace_nulls( s )
+        s.to_s.gsub( "\0", NULL )
+    end
+
+    def replace_nulls( *args )
+        self.class.replace_nulls( *args )
+    end
+
     def add_inputs( xml, inputs, name = :inputs )
         xml.send( name ) {
             inputs.each do |k, v|
-                xml.input( name: k, value: v )
+                xml.input( name: replace_nulls( k ), value: replace_nulls( v ) )
             end
         }
     end
@@ -193,7 +205,7 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
     def add_headers( xml, headers )
         xml.headers {
             headers.each do |k, v|
-                xml.header( name: k, value: v )
+                xml.header( name: replace_nulls( k ), value: replace_nulls( v ) )
             end
         }
     end
@@ -201,30 +213,30 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
     def add_parameters( xml, parameters )
         xml.parameters {
             parameters.each do |k, v|
-                xml.parameter( name: k, value: v )
+                xml.parameter( name: replace_nulls( k ), value: replace_nulls( v ) )
             end
         }
     end
 
     def add_page( xml, page, name = :page )
         xml.send( name ) {
-            xml.body page.body
+            xml.body replace_nulls( page.body )
 
             request = page.request
             xml.request {
-                xml.url request.url
+                xml.url replace_nulls( request.url )
                 xml.method_ request.method
 
                 add_parameters( xml, request.parameters )
                 add_headers( xml, request.headers )
 
-                xml.body request.effective_body
-                xml.raw request.to_s
+                xml.body replace_nulls( request.effective_body )
+                xml.raw replace_nulls( request )
             }
 
             response = page.response
             xml.response {
-                xml.url response.url
+                xml.url replace_nulls( response.url )
                 xml.code response.code
                 xml.ip_address response.ip_address
                 xml.time response.time.round( 4 )
@@ -233,13 +245,13 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
 
                 add_headers( xml, response.headers )
 
-                xml.body response.body
-                xml.raw_headers response.headers_string
+                xml.body replace_nulls( response.body )
+                xml.raw_headers replace_nulls( response.headers_string )
             }
 
             dom = page.dom
             xml.dom {
-                xml.url dom.url
+                xml.url replace_nulls( dom.url )
 
                 xml.transitions {
                     dom.transitions.each do |transition|
@@ -256,8 +268,8 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
                         xml.data_flow_sink {
                             xml.object sink.object
                             xml.tainted_argument_index sink.tainted_argument_index
-                            xml.tainted_value sink.tainted_value
-                            xml.taint_ sink.taint
+                            xml.tainted_value replace_nulls( sink.tainted_value )
+                            xml.taint_ replace_nulls( sink.taint )
 
                             add_function( xml, sink.function )
                             add_trace( xml, sink.trace )
@@ -281,7 +293,12 @@ class Arachni::Reporters::XML < Arachni::Reporter::Base
             trace.each do |frame|
                 xml.frame {
                     add_function( xml, frame.function )
-                    xml.line frame.line
+                    line = xml.line( frame.line )
+
+                    if frame.line.nil?
+                        line['xsi:nil'] = true
+                    end
+
                     xml.url frame.url
                 }
             end

data/components/reporters/yaml.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework

data/config/write_paths.yml

@@ -13,3 +13,7 @@ framework:
     # Default directory for scan snapshots generated either by the CLI
     # or by RPC Instances.
     snapshots:
+    # Directory for temporary files -- like for excess workload that's been
+    # offloaded to disk etc..
+    # Will default to the OS temporary directory.
+    tmpdir:

data/lib/arachni/banner.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework

data/lib/arachni/browser/element_locator.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework
@@ -79,23 +79,27 @@ class ElementLocator
         if attributes['id']
             attrs['id'] = attributes['id']
 
+        # If we have our own attribute trust it more than the rest,
+        # 'class' attributes and others can change dynamically.
+        elsif attributes[ARACHNI_ID]
+            attrs[ARACHNI_ID] = attributes[ARACHNI_ID]
+
         # Alternatively, exclude data attributes (except from ours ) to prevent
         # issues and use whatever other attributes are available.
         else
             attrs = attributes.reject do |k, v|
-                k = k.to_s
-                k.start_with?( 'data-' ) && k != ARACHNI_ID
+                k.to_s.start_with?( 'data-' )
             end
         end
 
-        "#{tag_name}#{attrs.map { |k, v| "[#{k}=#{v.inspect}]"}.join}"
+        "#{tag_name}#{attrs.map { |k, v| "[#{k}=\"#{v.escape_double_quote}\"]"}.join}"
     end
 
     # @return   [String]
     #   Locator as an HTML opening tag.
     def to_s
         "<#{tag_name}#{' ' if attributes.any?}" <<
-            attributes.map { |k, v| "#{k}=#{v.inspect}" }.join( ' ' ) << '>'
+            attributes.map { |k, v| "#{k}=\"#{v.escape_double_quote}\"" }.join( ' ' ) << '>'
     end
     alias :inspect :to_s
 

data/lib/arachni/browser/javascript/dom_monitor.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework

data/lib/arachni/browser/javascript/proxy/stub.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework

data/lib/arachni/browser/javascript/proxy.rb

@@ -1,5 +1,5 @@
 =begin
-    Copyright 2010-2016 Tasos Laskos <tasos.laskos@arachni-scanner.com>
+    Copyright 2010-2022 Ecsypno <http://www.ecsypno.com>
 
     This file is part of the Arachni Framework project and is subject to
     redistribution and commercial restrictions. Please see the Arachni Framework