arachni 1.4 → 1.6.0

data/spec/arachni/uri_spec.rb

@@ -79,7 +79,7 @@ describe Arachni::URI do
            "http://test.com/stuff?name=val&name2=val2"=>
                "http://test.com/stuff?name=val&name2=val2",
            "http://testfire.net/bank/queryxpath.aspx?__EVENTVALIDATION=%2FwEWAwLNx%2B2YBwKw59eKCgKcjoPABw%3D%3D&__VIEWSTATE=%2FwEPDwUKMTEzMDczNTAxOWRk&_ctl0%3A_ctl0%3AContent%3AMain%3AButton1=Query&_ctl0%3A_ctl0%3AContent%3AMain%3ATextBox1=Enter+title+%28e.g.+IBM%29%27%3Becho+287630581954%2B4196403186331128%3B%23"=>
-               "http://testfire.net/bank/queryxpath.aspx?__EVENTVALIDATION=/wEWAwLNx+2YBwKw59eKCgKcjoPABw==&__VIEWSTATE=/wEPDwUKMTEzMDczNTAxOWRk&_ctl0:_ctl0:Content:Main:Button1=Query&_ctl0:_ctl0:Content:Main:TextBox1=Enter+title+(e.g.+IBM)';echo+287630581954+4196403186331128;%23",
+               "http://testfire.net/bank/queryxpath.aspx?__EVENTVALIDATION=/wEWAwLNx%2B2YBwKw59eKCgKcjoPABw==&__VIEWSTATE=/wEPDwUKMTEzMDczNTAxOWRk&_ctl0:_ctl0:Content:Main:Button1=Query&_ctl0:_ctl0:Content:Main:TextBox1=Enter%20title%20(e.g.%20IBM)';echo%20287630581954%2B4196403186331128;%23",
            "http://192.168.0.232/dvwa/phpinfo.php?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000%23%5E%28%24%21%40%24%29%28%28%29%29%29%2A%2A%2A%2A%2A%2A&_arachni_trainer_c987fdb6d3955bd60191449bc465bb5ca760f60661fa4bcdf28736ae04aa2a1e=c987fdb6d3955bd60191449bc465bb5ca760f60661fa4bcdf28736ae04aa2a1e"=>
                "http://192.168.0.232/dvwa/phpinfo.php?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000%23%5E($!@$)(()))******&_arachni_trainer_c987fdb6d3955bd60191449bc465bb5ca760f60661fa4bcdf28736ae04aa2a1e=c987fdb6d3955bd60191449bc465bb5ca760f60661fa4bcdf28736ae04aa2a1e",
            "http://foo.com/user/login?user%5Bname%5D=bar&user%5Bpass%5D=asdasd%26asdihbasd"=>
@@ -209,6 +209,16 @@ describe Arachni::URI do
             expect(described_class.parse( 'javascript:stuff()' )).to be_nil
             expect(described_class.parse( 'jAvaScRipT:stuff()' )).to be_nil
         end
+
+        it 'ignores data: URLs' do
+            expect(described_class.parse( 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUA
+AAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO
+9TXL0Y4OHwAAAABJRU5ErkJggg==' )).to be_nil
+
+            expect(described_class.parse( 'dAtA:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUA
+AAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO
+9TXL0Y4OHwAAAABJRU5ErkJggg==' )).to be_nil
+        end
     end
 
     describe '.fast_parse' do
@@ -239,13 +249,6 @@ describe Arachni::URI do
             expect(parsed_uri[:query]).to eq(query)
         end
 
-        it 'returns a frozen hash (with frozen values)' do
-            h = described_class.fast_parse( 'http://test.com/stuff/' )
-
-            expect { h[:stuff] = 0 }.to raise_error
-            expect { h[:path] << '/' }.to raise_error
-        end
-
         it 'ignores javascript: URLs' do
             expect(described_class.fast_parse( 'javascript:stuff()' )).to be_nil
         end

data/spec/arachni/utilities_spec.rb

@@ -30,14 +30,14 @@ describe Arachni::Utilities do
 
     {
         forms_from_response:     [Arachni::Element::Form, :from_response],
-        forms_from_document:     [Arachni::Element::Form, :from_document],
+        forms_from_parser:     [Arachni::Element::Form, :from_parser],
         form_encode:             [Arachni::Element::Form, :encode],
         form_decode:             [Arachni::Element::Form, :decode],
         request_parse_body:      [Arachni::HTTP::Request, :parse_body],
         links_from_response:     [Arachni::Element::Link, :from_response],
-        links_from_document:     [Arachni::Element::Link, :from_document],
+        links_from_parser:     [Arachni::Element::Link, :from_parser],
         cookies_from_response:   [Arachni::Element::Cookie, :from_response],
-        cookies_from_document:   [Arachni::Element::Cookie, :from_document],
+        cookies_from_parser:   [Arachni::Element::Cookie, :from_parser],
         cookies_from_file:       [Arachni::Element::Cookie, :from_file],
         cookie_encode:           [Arachni::Element::Cookie, :encode],
         cookie_decode:           [Arachni::Element::Cookie, :decode],

data/spec/components/checks/active/code_injection_spec.rb

@@ -8,8 +8,8 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element_per_platform
@@ -21,7 +21,8 @@ describe name_from_filename do
                 Element::Header       => 4,
                 Element::LinkTemplate => 8,
                 Element::JSON         => 4,
-                Element::XML          => 8
+                Element::XML          => 8,
+                Element::NestedCookie => 8
             },
             perl:    {
                 Element::Form         => 8,
@@ -30,7 +31,8 @@ describe name_from_filename do
                 Element::Header       => 4,
                 Element::LinkTemplate => 8,
                 Element::JSON         => 4,
-                Element::XML          => 8
+                Element::XML          => 8,
+                Element::NestedCookie => 8
             },
             python:  {
                 Element::Form         => 4,
@@ -39,7 +41,8 @@ describe name_from_filename do
                 Element::Header       => 2,
                 Element::LinkTemplate => 4,
                 Element::JSON         => 2,
-                Element::XML          => 4
+                Element::XML          => 4,
+                Element::NestedCookie => 4
             },
             asp:    {
                 Element::Form         => 8,
@@ -48,7 +51,8 @@ describe name_from_filename do
                 Element::Header       => 4,
                 Element::LinkTemplate => 8,
                 Element::JSON         => 4,
-                Element::XML          => 8
+                Element::XML          => 8,
+                Element::NestedCookie => 8
             },
             ruby:    {
                 Element::Form         => 4,
@@ -57,7 +61,8 @@ describe name_from_filename do
                 Element::Header       => 4,
                 Element::LinkTemplate => 4,
                 Element::JSON         => 4,
-                Element::XML          => 8
+                Element::XML          => 8,
+                Element::NestedCookie => 4
             }
         }
     end

data/spec/components/checks/active/code_injection_timing_spec.rb

@@ -8,8 +8,8 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element
@@ -20,7 +20,8 @@ describe name_from_filename do
             Element::Header       => 3,
             Element::LinkTemplate => 4,
             Element::JSON         => 4,
-            Element::XML          => 8
+            Element::XML          => 8,
+            Element::NestedCookie => 4
         }
     end
 

data/spec/components/checks/active/csrf_spec.rb

@@ -14,28 +14,8 @@ describe name_from_filename do
         )
     end
 
-    it 'logs forms that lack CSRF protection' do
-        audit :forms
-        expect(issues.size).to eq(1)
-        expect(issues.first.vector.name).to eq('insecure_important_form')
-    end
-
-    it 'skips forms that have an anti-CSRF token in a name attribute' do
-        options.url = url + 'token_in_name'
-        audit :forms
-        expect(issues.size).to eq(1)
-        expect(issues.first.vector.name).to eq('insecure_important_form')
-    end
-
-    it 'skips forms that have an anti-CSRF token in their action URL' do
-        options.url = url + 'token_in_action'
-        audit :forms
-        expect(issues.size).to eq(1)
-        expect(issues.first.vector.name).to eq('insecure_important_form')
-    end
-
     it 'skips forms that have a nonce' do
-        options.url = url + 'with_nonce'
+        options.url = url
         audit :forms
         expect(issues.size).to eq(1)
         expect(issues.first.vector.name).to eq('insecure_important_form')

data/spec/components/checks/active/file_inclusion_spec.rb

@@ -8,8 +8,8 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element_per_platform
@@ -21,16 +21,18 @@ describe name_from_filename do
                 Element::Header       => 8,
                 Element::LinkTemplate => 16,
                 Element::JSON         => 16,
-                Element::XML          => 16
+                Element::XML          => 16,
+                Element::NestedCookie => 32
             },
             windows: {
                 Element::Form         => 192,
-                Element::Link         => 192,
+                Element::Link         => 190,
                 Element::Cookie       => 96,
                 Element::Header       => 48,
                 Element::LinkTemplate => 96,
                 Element::JSON         => 96,
-                Element::XML          => 96
+                Element::XML          => 96,
+                Element::NestedCookie => 192
             },
             java:    {
                 Element::Form         => 16,
@@ -39,25 +41,28 @@ describe name_from_filename do
                 Element::Header       => 4,
                 Element::LinkTemplate => 8,
                 Element::JSON         => 8,
-                Element::XML          => 8
+                Element::XML          => 8,
+                Element::NestedCookie => 16
             },
             php:  {
                 Element::Form         => 240,
-                Element::Link         => 240,
+                Element::Link         => 238,
                 Element::Cookie       => 112,
                 Element::Header       => 56,
                 Element::LinkTemplate => 120,
                 Element::JSON         => 112,
-                Element::XML          => 112
+                Element::XML          => 112,
+                Element::NestedCookie => 224
             },
             perl:  {
                 Element::Form         => 240,
-                Element::Link         => 240,
+                Element::Link         => 238,
                 Element::Cookie       => 120,
                 Element::Header       => 60,
                 Element::LinkTemplate => 120,
                 Element::JSON         => 120,
-                Element::XML          => 120
+                Element::XML          => 120,
+                Element::NestedCookie => 240
             }
         }
     end

data/spec/components/checks/active/ldap_injection_spec.rb

@@ -4,8 +4,8 @@ describe name_from_filename do
     include_examples 'check'
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element
@@ -14,11 +14,12 @@ describe name_from_filename do
         {
             Element::Form         => i,
             Element::Link         => i,
-            Element::Cookie       => i,
+            Element::Cookie       => i * 2,
             Element::Header       => i,
             Element::LinkTemplate => i * 2,
             Element::JSON         => i,
-            Element::XML          => i * 2
+            Element::XML          => i * 2,
+            Element::NestedCookie => i * 2
         }
     end
     easy_test

data/spec/components/checks/active/no_sql_injection_differential_spec.rb

@@ -8,7 +8,7 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie ]
     end
 
     def issue_count

data/spec/components/checks/active/no_sql_injection_spec.rb

@@ -8,8 +8,8 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element_per_platform
@@ -17,11 +17,12 @@ describe name_from_filename do
             mongodb: {
                 Element::Form         => 2,
                 Element::Link         => 2,
-                Element::Cookie       => 2,
+                Element::Cookie       => 4,
                 Element::Header       => 1,
                 Element::LinkTemplate => 2,
                 Element::JSON         => 2,
-                Element::XML          => 2
+                Element::XML          => 2,
+                Element::NestedCookie => 3
             }
         }
     end

data/spec/components/checks/active/os_cmd_injection_spec.rb

@@ -8,8 +8,8 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element_per_platform
@@ -22,7 +22,8 @@ describe name_from_filename do
                 Element::Header       => 8,
                 Element::LinkTemplate => 20,
                 Element::JSON         => 11,
-                Element::XML          => 22
+                Element::XML          => 22,
+                Element::NestedCookie => 16
             }
         end
 
@@ -33,7 +34,8 @@ describe name_from_filename do
             Element::Header       => 16,
             Element::LinkTemplate => 44,
             Element::JSON         => 22,
-            Element::XML          => 44
+            Element::XML          => 44,
+            Element::NestedCookie => 32
         }
 
         h

data/spec/components/checks/active/os_cmd_injection_timing_spec.rb

@@ -8,8 +8,8 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element
@@ -20,7 +20,8 @@ describe name_from_filename do
             Element::Header       => 14,
             Element::LinkTemplate => 14,
             Element::JSON         => 14,
-            Element::XML          => 28
+            Element::XML          => 28,
+            Element::NestedCookie => 8
         }
     end
 

data/spec/components/checks/active/path_traversal_spec.rb

@@ -8,29 +8,31 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element_per_platform
         {
             unix:    {
-                Element::Form         => 224,
-                Element::Link         => 224,
-                Element::Cookie       => 112,
-                Element::Header       => 56,
+                Element::Form         => 288,
+                Element::Link         => 286,
+                Element::Cookie       => 144,
+                Element::Header       => 72,
                 Element::LinkTemplate => 16,
-                Element::JSON         => 168,
-                Element::XML          => 112
+                Element::JSON         => 216,
+                Element::XML          => 144,
+                Element::NestedCookie => 288
             },
             windows: {
-                Element::Form         => 672,
-                Element::Link         => 672,
-                Element::Cookie       => 336,
-                Element::Header       => 168,
+                Element::Form         => 864,
+                Element::Link         => 856,
+                Element::Cookie       => 432,
+                Element::Header       => 216,
                 Element::LinkTemplate => 48,
-                Element::JSON         => 504,
-                Element::XML          => 336
+                Element::JSON         => 648,
+                Element::XML          => 432,
+                Element::NestedCookie => 864
             },
             java:    {
                 Element::Form         => 16,
@@ -39,7 +41,8 @@ describe name_from_filename do
                 Element::Header       => 4,
                 Element::LinkTemplate => 0,
                 Element::JSON         => 12,
-                Element::XML          => 8
+                Element::XML          => 8,
+                Element::NestedCookie => 16
             }
         }
     end

data/spec/components/checks/active/response_splitting_spec.rb

@@ -4,19 +4,20 @@ describe name_from_filename do
     include_examples 'check'
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element
         {
             Element::Form         => 4,
             Element::Link         => 4,
-            Element::Cookie       => 4,
+            Element::Cookie       => 6,
             Element::Header       => 2,
             Element::LinkTemplate => 8,
             Element::JSON         => 4,
-            Element::XML          => 4
+            Element::XML          => 4,
+            Element::NestedCookie => 8
         }
     end
 

data/spec/components/checks/active/rfi_spec.rb

@@ -4,18 +4,19 @@ describe name_from_filename do
     include_examples 'check'
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::JSON, Element::XML ]
     end
 
     def issue_count_per_element
         {
-            Element::Form   => 24,
-            Element::Link   => 24,
-            Element::Cookie => 12,
-            Element::Header => 6,
-            Element::JSON   => 12,
-            Element::XML    => 12
+            Element::Form         => 24,
+            Element::Link         => 24,
+            Element::Cookie       => 18,
+            Element::Header       => 6,
+            Element::JSON         => 12,
+            Element::XML          => 12,
+            Element::NestedCookie => 24
         }
     end
 

data/spec/components/checks/active/source_code_disclosure_spec.rb

@@ -8,19 +8,42 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie, Element::Header,
-          Element::LinkTemplate, Element::JSON, Element::XML ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie,
+          Element::Header, Element::LinkTemplate, Element::JSON, Element::XML ]
     end
 
-    def issue_count_per_element
+    def issue_count_per_element_per_platform
         {
-            Element::Form         => 12,
-            Element::Link         => 12,
-            Element::Cookie       => 4,
-            Element::Header       => 4,
-            Element::LinkTemplate => 10,
-            Element::JSON         => 6,
-            Element::XML          => 8
+            php:    {
+                Element::Form         => 12,
+                Element::Link         => 12,
+                Element::Cookie       => 3,
+                Element::Header       => 4,
+                Element::LinkTemplate => 10,
+                Element::JSON         => 6,
+                Element::XML          => 8,
+                Element::NestedCookie => 8
+            },
+            asp: {
+                Element::Form         => 12,
+                Element::Link         => 12,
+                Element::Cookie       => 3,
+                Element::Header       => 4,
+                Element::LinkTemplate => 10,
+                Element::JSON         => 6,
+                Element::XML          => 8,
+                Element::NestedCookie => 8
+            },
+            java:    {
+                Element::Form         => 12,
+                Element::Link         => 12,
+                Element::Cookie       => 4,
+                Element::Header       => 4,
+                Element::LinkTemplate => 10,
+                Element::JSON         => 6,
+                Element::XML          => 8,
+                Element::NestedCookie => 8
+            }
         }
     end
 

data/spec/components/checks/active/sql_injection_differential_spec.rb

@@ -8,7 +8,7 @@ describe name_from_filename do
     end
 
     def self.elements
-        [ Element::Form, Element::Link, Element::Cookie ]
+        [ Element::Form, Element::Link, Element::Cookie, Element::NestedCookie ]
     end
 
     def issue_count