arachni 1.4 → 1.6.0

data/spec/arachni/check/auditor_spec.rb

@@ -144,7 +144,7 @@ describe Arachni::Check::Auditor do
     describe '.check?' do
         context 'when elements have been provided' do
             it 'restricts the check' do
-                page = Arachni::Page.from_data( url: url, body: 'stuff' )
+                page = Arachni::Page.from_data( url: url, body: 'stuff',headers: [] )
                 allow(page).to receive(:has_script?) { true }
                 auditor.class.info[:elements] =
                     element_classes + [Arachni::Element::Body, Arachni::Element::GenericDOM]
@@ -205,6 +205,7 @@ describe Arachni::Check::Auditor do
                 let(:page) do
                     p = Arachni::Page.from_data(
                         url: url,
+                        headers: [],
                         "#{element.type}s".gsub( '_dom', '').to_sym => [Factory[element.type]]
                     )
                     allow(p.dom).to receive(:depth) { 1 }
@@ -364,7 +365,7 @@ describe Arachni::Check::Auditor do
 
     describe '#log_remote_file_if_exists' do
         it "delegates to #{Arachni::Element::Server}#log_remote_file_if_exists" do
-            sent     = [:stuff, false]
+            sent     = [:stuff, false, { blah: '1' }]
             received = nil
             b        = proc {}
 
@@ -391,6 +392,11 @@ describe Arachni::Check::Auditor do
         let(:issue) { Arachni::Data.issues.last }
         let(:vector) { Arachni::Element::Server.new( page.url ) }
 
+        it 'assigns the extra Issue options' do
+            expect(subject.log_remote_file( page, false )).to be_trusted
+            expect(subject.log_remote_file( page, false, trusted: false )).to_not be_trusted
+        end
+
         context 'given a' do
             describe Arachni::Page do
                 it 'logs it' do
@@ -422,62 +428,41 @@ describe Arachni::Check::Auditor do
         end
 
         it 'sets the auditor' do
-            auditor.each_candidate_element [ Arachni::Link ] do |element|
+            auditor.each_candidate_element do |element|
                 expect(element.auditor).to eq(auditor)
             end
         end
 
-        context 'when types have been provided' do
-            it 'provides those types of elements' do
-                elements = []
-                auditor.each_candidate_element [ Arachni::Link, Arachni::Header ] do |element|
-                    elements << element
-                end
+        it 'provides the types of elements specified by the check' do
+            auditor.class.info[:elements] = [Arachni::Link, Arachni::Form]
 
-                expect(elements).to eq((auditor.page.links | auditor.page.headers).
-                    select { |e| e.inputs.any? })
+            elements = []
+            auditor.each_candidate_element do |element|
+                elements << element
             end
 
-            context 'and are not supported' do
-                it 'raises ArgumentError' do
-                    expect {
-                        auditor.each_candidate_element [Arachni::Link::DOM]
-                    }.to raise_error ArgumentError
-                end
-            end
+            expect(auditor.class.elements).to eq([Arachni::Link, Arachni::Form])
+            expect(elements).to eq((auditor.page.links | auditor.page.forms).
+                select { |e| e.inputs.any? })
         end
-        context 'when types have not been provided' do
-            it 'provides the types of elements specified by the check' do
-                auditor.class.info[:elements] = [Arachni::Link, Arachni::Form]
+
+        context 'and no types are specified by the check' do
+            it 'provides all types of elements but :inputs and :ui_forms'do
+                auditor.class.info[:elements].clear
+
+                expected_elements = Arachni::Page::ELEMENTS
+                expected_elements.delete :ui_inputs
+                expected_elements.delete :ui_forms
 
                 elements = []
                 auditor.each_candidate_element do |element|
                     elements << element
                 end
 
-                expect(auditor.class.elements).to eq([Arachni::Link, Arachni::Form])
-                expect(elements).to eq((auditor.page.links | auditor.page.forms).
+                expect(elements.map { |e| "#{e.type}s".to_sym }.uniq).to eq(Arachni::Page::ELEMENTS)
+                expect(elements).to eq((auditor.page.elements).
                     select { |e| e.inputs.any? })
             end
-
-            context 'and no types are specified by the check' do
-                it 'provides all types of elements but :inputs and :ui_forms'do
-                    auditor.class.info[:elements].clear
-
-                    expected_elements = Arachni::Page::ELEMENTS
-                    expected_elements.delete :ui_inputs
-                    expected_elements.delete :ui_forms
-
-                    elements = []
-                    auditor.each_candidate_element do |element|
-                        elements << element
-                    end
-
-                    expect(elements.map { |e| "#{e.type}s".to_sym }.uniq).to eq(Arachni::Page::ELEMENTS)
-                    expect(elements).to eq((auditor.page.elements).
-                        select { |e| e.inputs.any? })
-                end
-            end
         end
     end
 
@@ -498,54 +483,33 @@ describe Arachni::Check::Auditor do
             end
         end
 
-        context 'when types have been provided' do
-            it 'provides those types of elements' do
-                elements = []
-                auditor.each_candidate_dom_element [ Arachni::Link::DOM ] do |element|
-                    elements << element
-                end
+        it 'provides the types of elements specified by the check' do
+            auditor.class.info[:elements] = [Arachni::Form::DOM]
+            expect(auditor.class.elements).to eq([Arachni::Form::DOM])
 
-                expect(elements).to be_any
-                expect(elements).to eq(auditor.page.links.select { |l| l.dom }.map(&:dom))
+            elements = []
+            auditor.each_candidate_dom_element do |element|
+                elements << element
             end
 
-            context 'and are not supported' do
-                it 'raises ArgumentError' do
-                    expect {
-                        auditor.each_candidate_dom_element [Arachni::Link]
-                    }.to raise_error ArgumentError
-                end
-            end
+            expect(elements).to eq(auditor.page.forms.map(&:dom))
         end
-        context 'when types have not been provided' do
-            it 'provides the types of elements specified by the check' do
-                auditor.class.info[:elements] = [Arachni::Form::DOM]
-                expect(auditor.class.elements).to eq([Arachni::Form::DOM])
+
+        context 'and no types are specified by the check' do
+            it 'provides all types of elements'do
+                auditor.class.info[:elements].clear
 
                 elements = []
                 auditor.each_candidate_dom_element do |element|
                     elements << element
                 end
 
-                expect(elements).to eq(auditor.page.forms.map(&:dom))
-            end
-
-            context 'and no types are specified by the check' do
-                it 'provides all types of elements'do
-                    auditor.class.info[:elements].clear
-
-                    elements = []
-                    auditor.each_candidate_dom_element do |element|
-                        elements << element
-                    end
-
-                    expect(elements).to eq(
-                        (auditor.page.links.select { |l| l.dom } |
-                            auditor.page.forms | auditor.page.cookies |
-                            auditor.page.link_templates | auditor.page.ui_inputs |
-                            auditor.page.ui_forms).map(&:dom)
-                    )
-                end
+                expect(elements).to eq(
+                    (auditor.page.links.select { |l| l.dom } |
+                        auditor.page.forms | auditor.page.cookies |
+                        auditor.page.link_templates | auditor.page.ui_inputs |
+                        auditor.page.ui_forms).map(&:dom)
+                )
             end
         end
     end
@@ -627,20 +591,19 @@ describe Arachni::Check::Auditor do
         end
     end
 
-    describe '#log_issue' do
+    describe '.log_issue' do
         it 'logs an issue' do
-            auditor.log_issue( issue_data )
+            auditor.class.log_issue( issue_data )
 
             logged_issue = Arachni::Data.issues.first
 
             expect(logged_issue.to_h.tap do |h|
                 h[:page][:dom][:transitions].each { |t| t.delete :time }
-            end).to eq issue.to_h.merge( referring_page: {
-                body: auditor.page.body,
-                dom:  auditor.page.dom.to_h.tap do |h|
-                    h.delete :skip_states
-                end
-            }).tap { |h| h[:page][:dom][:transitions].each { |t| t.delete :time } }
+                h[:referring_page][:dom][:transitions].each { |t| t.delete :time }
+            end).to eq (issue.to_h.tap do |h|
+                h[:page][:dom][:transitions].each { |t| t.delete :time }
+                h[:referring_page][:dom][:transitions].each { |t| t.delete :time }
+            end)
         end
 
         it 'assigns a #referring_page' do
@@ -656,15 +619,31 @@ describe Arachni::Check::Auditor do
 
         context 'when #issue_limit_reached?' do
             it 'does not log the issue' do
-                allow(subject).to receive(:issue_limit_reached?) { true }
+                allow(auditor.class).to receive(:issue_limit_reached?) { true }
 
-                expect(auditor.log_issue( issue_data )).to be_falsey
+                expect(auditor.class.log_issue( issue_data )).to be_falsey
                 expect(Arachni::Data.issues).to be_empty
             end
         end
     end
 
-    describe '#log' do
+    describe '#log_issue' do
+        it 'forwards options to .log_issue' do
+            expect(auditor.class).to receive(:log_issue).with(
+                issue_data.merge( referring_page: auditor.page )
+            )
+            auditor.log_issue( issue_data )
+        end
+
+        it 'assigns a #referring_page' do
+            auditor.log_issue( issue_data )
+
+            logged_issue = Arachni::Data.issues.first
+            expect(logged_issue.referring_page).to eq(auditor.page)
+        end
+    end
+
+    describe '.log' do
         let(:issue_data) do
             d = super()
 
@@ -675,28 +654,28 @@ describe Arachni::Check::Auditor do
         end
 
         it 'preserves the given remarks' do
-            auditor.log( issue_data )
+            auditor.class.log( issue_data )
 
             logged_issue = Arachni::Data.issues.first
             expect(logged_issue.remarks.first).to be_any
         end
 
         it 'returns the issue' do
-            expect(auditor.log( issue_data )).to be_kind_of Arachni::Issue
+            expect(auditor.class.log( issue_data )).to be_kind_of Arachni::Issue
         end
 
         context 'when given a page' do
             after { @framework.http.run }
 
             it 'includes response data' do
-                auditor.log( issue_data )
+                auditor.class.log( issue_data )
                 expect(Arachni::Data.issues.first.response).to eq(
                     issue_data[:page].response
                 )
             end
 
             it 'includes request data' do
-                auditor.log( issue_data )
+                auditor.class.log( issue_data )
                 expect(Arachni::Data.issues.first.request).to eq(
                     issue_data[:page].request
                 )
@@ -704,14 +683,53 @@ describe Arachni::Check::Auditor do
         end
 
         context 'when not given a page' do
-            it 'uses the current page' do
-                issue_data.delete(:page)
-                auditor.log( issue_data )
+            it 'uses the referring page' do
+                issue_data[:referring_page].response.url = @opts.url
+                auditor.class.log( issue_data )
 
                 issue = Arachni::Data.issues.first
-                expect(issue.page.body).to eq(auditor.page.body)
-                expect(issue.response).to eq(auditor.page.response)
-                expect(issue.request).to eq(auditor.page.request)
+
+                expect(issue.page.body).to eq(issue_data[:referring_page].body)
+                expect(issue.response).to eq(issue_data[:referring_page].response)
+                expect(issue.request).to eq(issue_data[:referring_page].request)
+            end
+        end
+
+        context 'when :referring page has been set' do
+            it 'uses it to set the Issue#referring_page' do
+                i = auditor.class.log( issue_data )
+                expect(i.referring_page).to eq issue_data[:referring_page]
+            end
+        end
+
+        context 'when no :referring page has been set' do
+            it 'uses Element#page' do
+                issue_data[:vector].page = issue_data.delete( :referring_page )
+
+                i = auditor.class.log( issue_data )
+                expect(i.referring_page).to eq issue_data[:vector].page
+            end
+        end
+
+        context 'when no referring page data are available' do
+            it 'raises ArgumentError' do
+                expect do
+                    issue_data[:vector].page    = nil
+                    issue_data[:referring_page] = nil
+
+                    auditor.class.log( issue_data )
+                end.to raise_error ArgumentError
+            end
+        end
+
+        context 'when no referring page data are available' do
+            it 'raises ArgumentError' do
+                expect do
+                    issue_data[:vector].page    = nil
+                    issue_data[:referring_page] = nil
+
+                    auditor.class.log( issue_data )
+                end.to raise_error ArgumentError
             end
         end
 
@@ -752,6 +770,24 @@ describe Arachni::Check::Auditor do
         end
     end
 
+    describe '#log' do
+        let(:issue_data) do
+            d = super()
+
+            d[:page].response.url = @opts.url
+            d.merge( page: d[:page] )
+
+            d
+        end
+
+        it 'forwards options to .log_issue' do
+            expect(auditor.class).to receive(:log).with(
+                issue_data.merge( referring_page: auditor.page )
+            )
+            auditor.log( issue_data )
+        end
+    end
+
     describe '#audit' do
         before do
             @seed = 'my_seed'
@@ -796,99 +832,20 @@ describe Arachni::Check::Auditor do
                 end
 
                 auditor.audit( @seed ){}
-                expect($audit_called).to eq(auditor.page.elements.map(&:class))
+                expect($audit_called).to eq(auditor.class.elements)
             end
         end
 
         context 'when called without a block' do
             it 'delegates to #audit_signature' do
-                expect(auditor).to receive(:audit_signature).with( @seed, described_class::OPTIONS )
-                auditor.audit( @seed )
+                opts = { stuff: :here }
+
+                expect(auditor).to receive(:audit_signature).with( @seed, opts )
+                auditor.audit( @seed, opts )
             end
         end
 
         context 'when called with options' do
-            describe ':elements' do
-
-                before { auditor.load_page_from( @url + '/elem_combo' ) }
-
-                describe 'Arachni::Element::Link' do
-                    it 'audits links' do
-                        auditor.audit( @seed,
-                            format: [ Arachni::Check::Auditor::Format::STRAIGHT ],
-                            elements: [ Arachni::Element::Link ]
-                         )
-                        @framework.http.run
-                        expect(Arachni::Data.issues.size).to eq(1)
-                        issue = Arachni::Data.issues.first
-                        expect(issue.vector.class).to eq(Arachni::Element::Link)
-                        expect(issue.vector.affected_input_name).to eq('link_input')
-                    end
-                end
-                describe 'Arachni::Element::Form' do
-                    it 'audits forms' do
-                        auditor.audit( @seed,
-                            format: [ Arachni::Check::Auditor::Format::STRAIGHT ],
-                            elements: [ Arachni::Element::Form ]
-                         )
-                        @framework.http.run
-                        expect(Arachni::Data.issues.size).to eq(1)
-                        issue = Arachni::Data.issues.first
-                        expect(issue.vector.class).to eq(Arachni::Element::Form)
-                        expect(issue.vector.affected_input_name).to eq('form_input')
-                    end
-                end
-                describe 'Arachni::Element::Cookie' do
-                    it 'audits cookies' do
-                        auditor.audit( @seed,
-                            format: [ Arachni::Check::Auditor::Format::STRAIGHT ],
-                            elements: [ Arachni::Element::Cookie ]
-                         )
-                        @framework.http.run
-                        expect(Arachni::Data.issues.size).to eq(1)
-                        issue = Arachni::Data.issues.first
-                        expect(issue.vector.class).to eq(Arachni::Element::Cookie)
-                        expect(issue.vector.affected_input_name).to eq('cookie_input')
-                    end
-                    it 'maintains the session while auditing cookies' do
-                        auditor.load_page_from( @url + '/session' )
-                        auditor.audit( @seed,
-                                        format: [ Arachni::Check::Auditor::Format::STRAIGHT ],
-                                        elements: [ Arachni::Element::Cookie ]
-                        )
-                        @framework.http.run
-                        expect(Arachni::Data.issues.size).to eq(1)
-                        issue = Arachni::Data.issues.first
-                        expect(issue.vector.class).to eq(Arachni::Element::Cookie)
-                        expect(issue.vector.affected_input_name).to eq('vulnerable')
-                    end
-
-                end
-                describe 'Arachni::Element::Header' do
-                    it 'audits headers' do
-                        auditor.audit( @seed,
-                            format: [ Arachni::Check::Auditor::Format::STRAIGHT ],
-                            elements: [ Arachni::Element::Header ]
-                         )
-                        @framework.http.run
-                        expect(Arachni::Data.issues.size).to eq(1)
-                        issue = Arachni::Data.issues.first
-                        expect(issue.vector.class).to eq(Arachni::Element::Header)
-                        expect(issue.vector.affected_input_name).to eq('Referer')
-                    end
-                end
-
-                context 'when using default options' do
-                    it 'audits all element types' do
-                        auditor.audit( @seed,
-                            format: [ Arachni::Check::Auditor::Format::STRAIGHT ]
-                         )
-                        @framework.http.run
-                        expect(Arachni::Data.issues.size).to eq(4)
-                    end
-                end
-            end
-
             describe ':train' do
                 context 'default' do
                     it 'parses the responses of forms submitted with their default values and feed any new elements back to the framework to be audited' do
@@ -901,17 +858,19 @@ describe Arachni::Check::Auditor do
                         # feed the new pages/elements back to the queue
                         @framework.trainer.on_new_page { |p| pages << p }
 
+                        vector = nil
                         # audit until no more new elements appear
                         while (page = pages.pop)
                             auditor = Auditor.new( page, @framework )
-                            auditor.audit( @seed )
+                            auditor.audit( @seed ) do |response, mutation|
+                                next if !response.body.include? @seed
+                                vector = mutation.affected_input_name
+                            end
                             # run audit requests
                             @framework.http.run
                         end
 
-                        expect(Arachni::Data.issues.all.find do |i|
-                            i.vector.affected_input_name == 'you_made_it'
-                        end).to be_truthy
+                        expect(vector).to eq 'you_made_it'
                     end
                 end
 
@@ -926,18 +885,21 @@ describe Arachni::Check::Auditor do
                         # feed the new pages/elements back to the queue
                         @framework.trainer.on_new_page { |p| pages << p }
 
+                        vector = nil
                         # audit until no more new elements appear
-                        while page = pages.pop
+                        while (page = pages.pop)
                             auditor = Arachni::Check::Base.new( page, @framework )
-                            auditor.audit( @seed, submit: { train: true })
+                            auditor.audit( @seed, submit: { train: true } ) do |response, mutation|
+                                next if !response.body.include?( @seed ) ||
+                                    mutation.affected_input_name != 'you_made_it'
+
+                                vector = mutation.affected_input_name
+                            end
                             # run audit requests
                             @framework.http.run
                         end
 
-                        issue = issues.first
-                        expect(issue).to be_truthy
-                        expect(issue.vector.class).to eq(Arachni::Element::Form)
-                        expect(issue.vector.affected_input_name).to eq('you_made_it')
+                        expect(vector).to eq 'you_made_it'
                     end
                 end
 
@@ -978,7 +940,7 @@ describe Arachni::Check::Auditor do
             end
 
             auditor.audit_signature( 'seed' )
-            expect($audit_signature_called).to eq(auditor.page.elements.map(&:class))
+            expect($audit_signature_called).to eq(auditor.class.elements)
         end
     end
 
@@ -997,7 +959,7 @@ describe Arachni::Check::Auditor do
             end
 
             auditor.audit_differential( { false: '0', pairs: { '1' => '2' } } )
-            expect($audit_differential_called).to eq(auditor.page.elements.map(&:class))
+            expect($audit_differential_called).to eq(auditor.class.elements)
         end
     end
 
@@ -1016,7 +978,7 @@ describe Arachni::Check::Auditor do
             end
 
             auditor.audit_timeout( 'seed', timeout: 1 )
-            expect($audit_timeout_called).to eq(auditor.page.elements.map(&:class))
+            expect($audit_timeout_called).to eq(auditor.class.elements)
         end
     end
 
@@ -1182,6 +1144,8 @@ describe Arachni::Check::Auditor do
 
             context 'true' do
                 it 'marks the job as done' do
+                    pending
+
                     calls = 0
                     auditor.trace_taint( url ) do
                         calls += 1

data/spec/arachni/data/framework/rpc_spec.rb

@@ -41,7 +41,7 @@ describe Arachni::Data::Framework::RPC do
 
             pages = []
             Dir["#{dump_directory}/distributed_page_queue/*"].each do |page_file|
-                pages << Marshal.load( IO.binread( page_file ) )
+                pages << subject.distributed_page_queue.unserialize( IO.binread( page_file ) )
             end
             expect(pages).to eq([page, page])
         end

data/spec/arachni/data/framework_spec.rb

@@ -166,7 +166,7 @@ describe Arachni::Data::Framework do
 
             pages = []
             Dir["#{dump_directory}/page_queue/*"].each do |page_file|
-                pages << Marshal.load( IO.binread( page_file ) )
+                pages << subject.page_queue.unserialize( IO.binread( page_file ) )
             end
             expect(pages).to eq([page, page])
         end

data/spec/arachni/element/capabilities/analyzable/signature_spec.rb

@@ -18,7 +18,6 @@ describe Arachni::Element::Capabilities::Analyzable::Signature do
     end
 
     describe '#signature_analysis' do
-
         before do
             @seed = 'my_seed'
             Arachni::Framework.reset
@@ -81,7 +80,7 @@ describe Arachni::Element::Capabilities::Analyzable::Signature do
                     end
                 end
 
-                context 'String' do
+                context 'Regexp' do
                     it 'tries to match the provided pattern' do
                         @positive.signature_analysis(
                             @seed,
@@ -93,6 +92,17 @@ describe Arachni::Element::Capabilities::Analyzable::Signature do
                         expect(issues.first.vector.seed).to eq(@seed)
                         expect(issues.first).to be_trusted
                     end
+
+                    context 'multi-line' do
+                        it 'raises error' do
+                            expect do
+                                @positive.signature_analysis(
+                                    @seed,
+                                    signatures: /ff/m
+                                )
+                            end.to raise_error ArgumentError
+                        end
+                    end
                 end
 
                 context 'Array' do
@@ -106,6 +116,17 @@ describe Arachni::Element::Capabilities::Analyzable::Signature do
                         expect(issues.size).to eq(1)
                         expect(issues.first.vector.seed).to eq(@seed)
                     end
+
+                    context 'with multi-line Regexp' do
+                        it 'raises error' do
+                            expect do
+                                @positive.signature_analysis(
+                                    @seed,
+                                    signatures: [/ff/m]
+                                )
+                            end.to raise_error ArgumentError
+                        end
+                    end
                 end
 
                 context 'Hash' do
@@ -128,6 +149,28 @@ describe Arachni::Element::Capabilities::Analyzable::Signature do
                         expect(issues[0].signature).to eq(regexps[:windows].source)
                     end
 
+                    context 'with multi-line Regexp' do
+                        it 'raises error' do
+                            expect do
+                                @positive.signature_analysis(
+                                    @seed,
+                                    signatures: {
+                                        windows: /ff/m
+                                    }
+                                )
+                            end.to raise_error ArgumentError
+
+                            expect do
+                                @positive.signature_analysis(
+                                    @seed,
+                                    signatures: {
+                                        windows: [/ff/m]
+                                    }
+                                )
+                            end.to raise_error ArgumentError
+                        end
+                    end
+
                     context 'when the payloads are per platform' do
                         it 'only tries to matches the regexps for that platform' do
                             issues = []
@@ -168,7 +211,7 @@ describe Arachni::Element::Capabilities::Analyzable::Signature do
                             end
                         end
 
-                        context 'when there is not a payload for the regexp platform' do
+                        context 'when there is not a payload for the platform' do
                             it 'matches against all payload responses and assigns the pattern platform to the issue' do
                                 payloads = {
                                     windows: "#{@seed} windows",