ar_transaction_changes 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abd88f1f38f3175de32b5fa97590b0a3bf08e83ae68aefe73797a633161956ac
-  data.tar.gz: 7c9568f33755097c43348c72a94defafdd5b2b1fe6b4618654f394ffba6153d7
+  metadata.gz: b2acb53b1999dcee1b3665da06ef90afec0801aee463790207632d3618120a28
+  data.tar.gz: edd02898b47f64d95ee7f0eb0d30859db66b75cf75b1a2a5112b42ecd808a89c
 SHA512:
-  metadata.gz: b4dda2921a2be6e0b7b2dea7bf597c774f322374b3c38a69e545cbf827adc290157e7e5795e8d4015c3e9c0a6c344aa0a688bf8e16e401d3249e9f8f34a75e6c
-  data.tar.gz: ee32cc827a67f5a76fc8ea7e6659e646b1814aa31d75dc2183f4de92744e0a398574e90e4eb5ca078c63506b3750a7142b0ecf9bd99d2c7404aa8ec13a2fea4d
+  metadata.gz: aa7b27f1e322d10dee7d93155594b8c174c2024dbecce12d4d1b6dd5b310664aa0a1df76b09ce4dc1c9c0332b752a2af4795386b95d4867bc0bb583ac1a280a9
+  data.tar.gz: 10a385416ff519564fff02e55df735718b50d3bf26a88788c396e6ba591b87ad0644d8290ea65ba6924ac7725a70fc46d36cb18e959923135d3307274395de93

data/.travis.yml

@@ -1,27 +1,17 @@
 language: ruby
 sudo: false
 
-rvm:
-  - 2.2.5
-  - 2.3.1
-
-gemfile:
-  - Gemfile.rails42
-  - Gemfile.rails50
-  - Gemfile.rails51
-  - Gemfile.rails52
-
-matrix:
+jobs:
   include:
-    - rvm: 2.1.9
-      gemfile: Gemfile.rails42
-    - rvm: 2.5.0
-      gemfile: Gemfile.rails60
-    - rvm: 2.5.0
+    - name: "Minimum supported versions"
+      rvm: 2.4
+      gemfile: Gemfile.rails52
+    - name: "Latest released versions"
+      rvm: 2.7
+      gemfile: Gemfile
+    - name: "Rails master branch"
+      rvm: 2.7
       gemfile: Gemfile.rails_head
 
 services:
   - mysql
-
-before_script:
-  - mysql -e 'create database ar_transaction_changes_test'

data/Gemfile.rails52

@@ -1,5 +1,5 @@
 source "https://rubygems.org"
 
-gem 'activerecord', '~> 5.2.2'
+gem 'activerecord', '~> 5.2.0'
 
 gemspec

data/ar_transaction_changes.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency "activerecord", ">= 4.2.4"
+  gem.add_dependency "activerecord", ">= 5.2.0"
 
   gem.add_development_dependency("rake")
   gem.add_development_dependency("mysql2")

data/lib/ar_transaction_changes.rb

@@ -18,17 +18,12 @@ module ArTransactionChanges
     @transaction_changed_attributes ||= HashWithIndifferentAccess.new
   end
 
-  method_name = if ActiveRecord.gem_version >= Gem::Version.new("5.2.0.beta1")
-    "_write_attribute"
-  else
-    "write_attribute"
-  end
-
-  define_method(method_name) do |attr_name, value|
+  def _write_attribute(attr_name, value)
     attr_name = attr_name.to_s
     old_value = read_attribute(attr_name)
     ret = super(attr_name, value)
-    unless transaction_changed_attributes.key?(attr_name) || value == old_value
+    new_value = read_attribute(attr_name)
+    unless transaction_changed_attributes.key?(attr_name) || new_value == old_value
       transaction_changed_attributes[attr_name] = old_value
     end
     ret

data/lib/ar_transaction_changes/version.rb

@@ -1,3 +1,3 @@
 module ArTransactionChanges
-  VERSION = "1.1.4"
+  VERSION = "1.1.5"
 end

data/test/test_helper.rb

@@ -1,19 +1,24 @@
-ENV["RAILS_ENV"] = "test"
 require 'pathname'
 require 'yaml'
 require 'ar_transaction_changes'
 require 'minitest/autorun'
 
+ENV["RAILS_ENV"] = "test"
+
 test_dir = Pathname.new(File.dirname(__FILE__))
 config_filename = test_dir.join("database.yml").exist? ? "database.yml" : "database.yml.default"
 database_yml = YAML.load(test_dir.join(config_filename).read)
-ActiveRecord::Base.establish_connection database_yml['test']
+database_config = database_yml.fetch("test")
+
+ActiveRecord::Base.establish_connection(database_config.except("database"))
+ActiveRecord::Base.connection.recreate_database(database_config.fetch("database"))
+ActiveRecord::Base.establish_connection(database_config)
 
 ActiveRecord::Base.connection.tap do |db|
-  db.drop_table(:users) if db.table_exists?(:users)
   db.create_table(:users) do |t|
     t.string :name
     t.string :occupation
+    t.integer :age
     t.timestamps null: false
   end
 end

data/test/transaction_changes_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class TransactionChangesTest < MiniTest::Unit::TestCase
   def setup
-    @user = User.new(:name => "Dylan", :occupation => "Developer")
+    @user = User.new(:name => "Dylan", :occupation => "Developer", age: 20)
     @user.save!
     @user.stored_transaction_changes = nil
   end
@@ -94,4 +94,13 @@ class TransactionChangesTest < MiniTest::Unit::TestCase
     end
     refute @user.stored_transaction_changes["name"]
   end
+
+  def test_transaction_changes_type_cast
+    # "20" will be converted to 20 by read_attribute https://apidock.com/rails/ActiveRecord/AttributeMethods/read_attribute
+    @user.transaction do
+      @user.age = "20"
+      @user.save!
+    end
+    assert_empty @user.stored_transaction_changes
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ar_transaction_changes
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Dylan Thacker-Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-05 00:00:00.000000000 Z
+date: 2020-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.4
+        version: 5.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.4
+        version: 5.2.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -63,11 +63,7 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - Gemfile
-- Gemfile.rails42
-- Gemfile.rails50
-- Gemfile.rails51
 - Gemfile.rails52
-- Gemfile.rails60
 - Gemfile.rails_head
 - LICENSE.txt
 - README.md
@@ -97,7 +93,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Store transaction changes for active record objects

data/Gemfile.rails42

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem 'activerecord', '~> 4.2.0'
-
-gemspec

data/Gemfile.rails50

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem 'activerecord', '~> 5.0.0'
-
-gemspec

data/Gemfile.rails51

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem 'activerecord', '~> 5.1.0.rc1'
-
-gemspec

data/Gemfile.rails60

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem 'activerecord', '~> 6.0.0.beta2'
-
-gemspec