ar_transaction_changes 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8512832019c33caf8bd9bb39796f2db6b6e8ce74
-  data.tar.gz: 05f8382a08442778dc3a9eb3fc4d9f573c83969d
+  metadata.gz: 89f3ff2a1237cc1fab8f9b2bb7b338eacb83ea97
+  data.tar.gz: f05afe6d47540c9bfc5e7c8a80fa1277dfc03d32
 SHA512:
-  metadata.gz: 258b699e07a4dcc3bbce95dce4991f5916569f94764eb3c66fb2627fb12e3f98520eb0663a57986cf868f37eef0703f013a9f6d4c73e9337682d67b8e29b6de3
-  data.tar.gz: e8b2912cc3fd090905493e6d0230da91fe08251cfea9cb1edebe93ab1eaa78619d667947d81689443f6a0d56158da4db545d2583ec632b83e76b65bfeec935f3
+  metadata.gz: b5c64f5f5684ac7b3f06653cc6f59e855fefd51ec285fe3e8fd6f357f76201ff3d94440c272a195fcb98f5086006c672eebc743d1eff35d76abee1c6a426e4d9
+  data.tar.gz: d4969d2850dbee065ba0711613968cbe8f4f096d4557da97b3ae82cb688b17804b6fb702dafd64a5ef72f5d625b2f0714de9943d5a6517cb4fd699b1400fc4cf

data/.travis.yml

@@ -9,6 +9,7 @@ gemfile:
   - Gemfile.rails42
   - Gemfile.rails50
   - Gemfile.rails51
+  - Gemfile.rails52
 
 matrix:
   include:

data/Gemfile.rails52

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+
+gem "rails", "~> 5.2.0.beta1"
+
+gemspec

data/README.md

@@ -44,6 +44,19 @@ class User < ActiveRecord::Base
 end
 ```
 
+## Important Notes
+
+`ar_transaction_changes` may have conflict with another gems who modify
+`active_record#write_attribute` method, e.g. `globalize` gem
+
+the workaround is by requiring this gem first, for example:
+
+```ruby
+gem 'ar_transaction_changes', require: false
+gem 'globalize', require: ['ar_transaction_changes', 'globalize']
+
+```
+
 ## Contributing
 
 1. Fork it

data/lib/ar_transaction_changes.rb

@@ -1,4 +1,5 @@
 require "ar_transaction_changes/version"
+require "active_record"
 
 module ArTransactionChanges
   def _run_commit_callbacks
@@ -17,10 +18,16 @@ module ArTransactionChanges
     @transaction_changed_attributes ||= HashWithIndifferentAccess.new
   end
 
-  def write_attribute(attr_name, value) # override
+  method_name = if ActiveRecord.gem_version >= Gem::Version.new("5.2.0.beta1")
+    "_write_attribute"
+  else
+    "write_attribute"
+  end
+
+  define_method(method_name) do |attr_name, value|
     attr_name = attr_name.to_s
-    old_value = attributes[attr_name]
-    ret = super
+    old_value = read_attribute(attr_name)
+    ret = super(attr_name, value)
     unless transaction_changed_attributes.key?(attr_name) || value == old_value
       transaction_changed_attributes[attr_name] = old_value
     end

data/lib/ar_transaction_changes/version.rb

@@ -1,3 +1,3 @@
 module ArTransactionChanges
-  VERSION = "1.1.2"
+  VERSION = "1.1.3"
 end

data/test/test_helper.rb

@@ -1,7 +1,6 @@
 ENV["RAILS_ENV"] = "test"
 require 'pathname'
 require 'yaml'
-require 'active_record'
 require 'ar_transaction_changes'
 require 'minitest/autorun'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ar_transaction_changes
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Dylan Thacker-Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-12 00:00:00.000000000 Z
+date: 2018-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -72,6 +72,7 @@ files:
 - Gemfile.rails42
 - Gemfile.rails50
 - Gemfile.rails51
+- Gemfile.rails52
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -101,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Store transaction changes for active record objects