ar_after_transaction 0.2.5 → 0.2.6

data/.travis.yml

@@ -0,0 +1,4 @@
+rvm:
+  - ree
+  - 1.9.2
+  - 1.9.3

data/Gemfile

@@ -3,6 +3,7 @@ source :rubygems
 gemspec
 
 gem 'appraisal'
+gem 'bump'
 gem 'rake'
 gem 'rspec', '~>2'
 gem 'sqlite3'

data/Gemfile.lock

@@ -1,42 +1,43 @@
 PATH
   remote: .
   specs:
-    ar_after_transaction (0.2.5)
+    ar_after_transaction (0.2.6)
       activerecord
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activemodel (3.2.8)
-      activesupport (= 3.2.8)
+    activemodel (3.2.9)
+      activesupport (= 3.2.9)
       builder (~> 3.0.0)
-    activerecord (3.2.8)
-      activemodel (= 3.2.8)
-      activesupport (= 3.2.8)
+    activerecord (3.2.9)
+      activemodel (= 3.2.9)
+      activesupport (= 3.2.9)
       arel (~> 3.0.2)
       tzinfo (~> 0.3.29)
-    activesupport (3.2.8)
+    activesupport (3.2.9)
       i18n (~> 0.6)
       multi_json (~> 1.0)
-    appraisal (0.4.1)
+    appraisal (0.5.1)
       bundler
       rake
     arel (3.0.2)
     builder (3.0.4)
+    bump (0.3.5)
     diff-lcs (1.1.3)
     i18n (0.6.1)
-    multi_json (1.3.6)
-    rake (0.9.2.2)
-    rspec (2.8.0)
-      rspec-core (~> 2.8.0)
-      rspec-expectations (~> 2.8.0)
-      rspec-mocks (~> 2.8.0)
-    rspec-core (2.8.0)
-    rspec-expectations (2.8.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.8.0)
+    multi_json (1.3.7)
+    rake (10.0.2)
+    rspec (2.12.0)
+      rspec-core (~> 2.12.0)
+      rspec-expectations (~> 2.12.0)
+      rspec-mocks (~> 2.12.0)
+    rspec-core (2.12.0)
+    rspec-expectations (2.12.0)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.12.0)
     sqlite3 (1.3.6)
-    tzinfo (0.3.33)
+    tzinfo (0.3.35)
 
 PLATFORMS
   ruby
@@ -44,6 +45,7 @@ PLATFORMS
 DEPENDENCIES
   appraisal
   ar_after_transaction!
+  bump
   rake
   rspec (~> 2)
   sqlite3

data/Rakefile

@@ -1,6 +1,7 @@
 require "bundler/setup"
 require "bundler/gem_tasks"
 require "appraisal"
+require "bump/tasks"
 
 
 task :spec do
@@ -10,20 +11,3 @@ end
 task :default do
   sh "bundle exec rake appraisal:install && bundle exec rake appraisal spec"
 end
-
-# extracted from https://github.com/grosser/project_template
-rule /^version:bump:.*/ do |t|
-  sh "git status | grep 'nothing to commit'" # ensure we are not dirty
-  index = ['major', 'minor','patch'].index(t.name.split(':').last)
-  file = 'lib/ar_after_transaction/version.rb'
-
-  version_file = File.read(file)
-  old_version, *version_parts = version_file.match(/(\d+)\.(\d+)\.(\d+)/).to_a
-  version_parts[index] = version_parts[index].to_i + 1
-  version_parts[2] = 0 if index < 2 # remove patch for minor
-  version_parts[1] = 0 if index < 1 # remove minor for major
-  new_version = version_parts * '.'
-  File.open(file,'w'){|f| f.write(version_file.sub(old_version, new_version)) }
-
-  sh "bundle && git add #{file} Gemfile.lock && git commit -m 'bump version to #{new_version}'"
-end

data/Readme.md

@@ -58,11 +58,16 @@ If you use transactional fixtures you should change it in test mode.
 
 Alternative
 ===========
+Rails 3+
+ - basic support is built in, use it if you can!
+ - `after_commit :foo`
+ - `after_commit :bar, :on => :create / :update`
+
 [after_commit](https://github.com/pat/after_commit)<br/>
- + threadsafe<br/>
- + more fine-grained callbacks (before_commit, `after_commit`, before_rollback, after_rollback)<br/>
- - doesn't let you define `after_transaction` callbacks *anywhere* like `ar_after_transaction` does (*outside* of the `after_commit`, etc. callbacks which only happen at certain points in the model's life cycle)<br/>
- - more complex<br/>
+ - pro: threadsafe<br/>
+ - pro: more fine-grained callbacks (before_commit, `after_commit`, before_rollback, after_rollback)<br/>
+ - con: doesn't let you define `after_transaction` callbacks *anywhere* like `ar_after_transaction` does (*outside* of the `after_commit`, etc. callbacks which only happen at certain points in the model's life cycle)<br/>
+ - con: more complex<br/>
 
 Authors
 =======
@@ -71,7 +76,10 @@ Authors
 ### [Contributors](http://github.com/grosser/ar_after_transaction/contributors)
  - [Bogdan Gusiev](http://gusiev.com)
  - [Benedikt Deicke](http://blog.synatic.net)
+ - [Tyler Rick](https://github.com/TylerRick)
 
 [Michael Grosser](http://grosser.it)<br/>
 michael@grosser.it<br/>
-Hereby placed under public domain, do what you want, just do not hold me accountable...
+License: MIT<br/>
+[![Build Status](https://travis-ci.org/grosser/ar_after_transaction.png)](https://travis-ci.org/grosser/ar_after_transaction)
+

data/gemfiles/rails2.gemfile

@@ -3,6 +3,7 @@
 source :rubygems
 
 gem "appraisal"
+gem "bump"
 gem "rake"
 gem "rspec", "~>2"
 gem "sqlite3"

data/gemfiles/rails2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/ar_after_transaction
   specs:
-    ar_after_transaction (0.2.4)
+    ar_after_transaction (0.2.5)
       activerecord
 
 GEM
@@ -13,6 +13,7 @@ GEM
     appraisal (0.4.1)
       bundler
       rake
+    bump (0.3.5)
     diff-lcs (1.1.3)
     rake (0.9.2.2)
     rspec (2.11.0)
@@ -32,6 +33,7 @@ DEPENDENCIES
   activerecord (~> 2.3.14)
   appraisal
   ar_after_transaction!
+  bump
   rake
   rspec (~> 2)
   sqlite3

data/gemfiles/rails3.gemfile

@@ -3,6 +3,7 @@
 source :rubygems
 
 gem "appraisal"
+gem "bump"
 gem "rake"
 gem "rspec", "~>2"
 gem "sqlite3"

data/gemfiles/rails3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/ar_after_transaction
   specs:
-    ar_after_transaction (0.2.4)
+    ar_after_transaction (0.2.5)
       activerecord
 
 GEM
@@ -23,6 +23,7 @@ GEM
       rake
     arel (3.0.2)
     builder (3.0.4)
+    bump (0.3.5)
     diff-lcs (1.1.3)
     i18n (0.6.1)
     multi_json (1.3.6)
@@ -45,6 +46,7 @@ DEPENDENCIES
   activerecord (~> 3.2.7)
   appraisal
   ar_after_transaction!
+  bump
   rake
   rspec (~> 2)
   sqlite3

data/lib/ar_after_transaction.rb

@@ -2,10 +2,6 @@ require 'active_record'
 require 'ar_after_transaction/version'
 
 module ARAfterTransaction
-  def self.included(base)
-    base.extend(ClassMethods)
-  end
-
   module ClassMethods
     @@after_transaction_callbacks = []
 
@@ -51,9 +47,12 @@ module ARAfterTransaction
     end
   end
 
-  def after_transaction(&block)
-    self.class.after_transaction(&block)
+  module InstanceMethods
+    def after_transaction(&block)
+      self.class.after_transaction(&block)
+    end
   end
 end
 
-ActiveRecord::Base.send(:include, ARAfterTransaction)
+ActiveRecord::Base.send(:extend, ARAfterTransaction::ClassMethods)
+ActiveRecord::Base.send(:include, ARAfterTransaction::InstanceMethods)

data/lib/ar_after_transaction/version.rb

@@ -1,3 +1,3 @@
 module ARAfterTransaction
-  VERSION = Version = '0.2.5'
+  VERSION = Version = '0.2.6'
 end

data/spec/ar_after_transaction_spec.rb

@@ -119,3 +119,10 @@ describe ARAfterTransaction do
     end
   end
 end
+
+describe "A normal ActiveRecord subclass" do
+  it "does not get polluted" do
+    User.const_defined?(:VERSION).should be_false
+    User.const_defined?(:Version).should be_false
+  end
+end

metadata

@@ -1,45 +1,39 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: ar_after_transaction
-version: !ruby/object:Gem::Version 
-  hash: 29
+version: !ruby/object:Gem::Version
+  version: 0.2.6
   prerelease: 
-  segments: 
-  - 0
-  - 2
-  - 5
-  version: 0.2.5
 platform: ruby
-authors: 
+authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-10-20 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-11-30 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activerecord
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  requirement: *id001
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email: michael@grosser.it
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
+- .travis.yml
 - Appraisals
 - Gemfile
 - Gemfile.lock
@@ -56,37 +50,34 @@ files:
 - spec/setup_database.rb
 - spec/spec_helper.rb
 homepage: http://github.com/grosser/ar_after_transaction
-licenses: 
+licenses:
 - MIT
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: 3939892965249242623
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
+      hash: 3939892965249242623
 requirements: []
-
 rubyforge_project: 
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Execute irreversible actions only when transactions are not rolled back
 test_files: []
-