ar-sybase-jdbc-adapter 0.1.1 → 0.2.0

data/README.rdoc

@@ -1,15 +1,20 @@
 = ar-sybase-jdbc-adapter
 
-ar-sybase-jdbc-adapter enhances the Arel 2 activerecord-jdbc-adapter to support "limit" and "offset" for Sybase ASE DB.
+ar-sybase-jdbc-adapter enhances activerecord-jdbc-adapter (Rails 3) to support "limit" and "offset" for Sybase ASE DB.
 
 **This project is a proof of concept that Sybase ASE can work nicely with Rails**
+Once the project reaches "close to production" functionality I will try to merge it with activerecord-jdbc-adapter
 
-Once the project reaches "close to production" functionality I will try to merge it with _activerecord-jdbc-adapter_
 
+== Usage
+1. Install
 
+    gem install ar-sybase-jdbc-adapter
+
+2. Configuration
 To use this gem, set the "dialect" configuration parameter to "sybase_jtds".
+Example:
 
-e.g.
     development:
       adapter: jdbc
       username: user_name
@@ -19,6 +24,7 @@ e.g.
       driver: net.sourceforge.jtds.jdbc.Driver
       url: jdbc:jtds:sybase://host:port/db_name
 
+
 == Offset in Sybase ASE
 
 Sybase is an awful DB in term of support for "offset". I found 2 ways to do it for generic queries:
@@ -77,8 +83,6 @@ fall back to `cursor` and get `@@rowcount` to get the number of rows.
 
 
 
-
-
 == Known issues
 
 I am aware of a very strange issue where the driver does not work when the very first query uses "limit()".
@@ -112,6 +116,6 @@ e.g.
 
 == Copyright
 
-Copyright (c) 2010 arkadiy kraportov. See LICENSE.txt for
+Copyright (c) 2011 arkadiy kraportov. See LICENSE.txt for
 further details.
 

data/lib/arel/visitors/sybase_jtds.rb

@@ -5,7 +5,7 @@ module Arel
       def select_count? o
         sel = o.cores.length == 1 && o.cores.first
         projections = sel.projections.length == 1 && sel.projections
-        Arel::Nodes::Count === projections.first
+        Arel::Nodes::Count === (projections.respond_to?(:first) && projections.first)
       end
 
 
@@ -13,22 +13,21 @@ module Arel
         if o.offset || (o.limit && select_count?(o))
           o.offset.expr += 1 if o.offset
           sql = super  # if offset OR (limit & count) use the Java limit/offset/count parser
-        else
-          limit  = o.limit
+        elsif o.limit
+          limit  = o.limit.expr
           o.limit = nil
           sql = super
-
-          if limit
-            limit_and_no_offset sql, limit
-          end
+          limit_and_no_offset sql, limit
+        else
+          sql = super
         end
 
         sql
       end
 
       def limit_and_no_offset sql, limit
-        if sql =~ /DISTINCT /
-          sql.gsub!(/DISTINCT /, "DISTINCT TOP #{limit} ")
+        if sql =~ /DISTINCT /i
+          sql.gsub!(/DISTINCT /i, "DISTINCT TOP #{limit} ")
         else
           sql.gsub!(/SELECT /, "SELECT TOP #{limit} ")
         end

data/lib/arjdbc/sybase_jtds.rb

@@ -14,5 +14,10 @@ module ::ArJdbc
     def self.column_selector
       [/sybase/i, lambda {|cfg,col| col.extend(::ArJdbc::MsSQL::Column)}]
     end
+
+    def supports_migrations?
+      false
+    end
+
   end
 end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
     - 0
-    - 1
-    - 1
-  version: 0.1.1
+    - 2
+    - 0
+  version: 0.2.0
 platform: ruby
 authors: 
   - arkadiy kraportov
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-13 00:00:00 +09:00
+date: 2011-01-17 00:00:00 +09:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -73,13 +73,13 @@ dependencies:
     name: arel
     version_requirements: &id005 !ruby/object:Gem::Requirement 
       requirements: 
-        - - ">"
+        - - "="
           - !ruby/object:Gem::Version 
             segments: 
               - 2
               - 0
-              - 0
-            version: 2.0.0
+              - 7
+            version: 2.0.7
     requirement: *id005
     prerelease: false
     type: :development
@@ -87,13 +87,13 @@ dependencies:
     name: activerecord-jdbc-adapter
     version_requirements: &id006 !ruby/object:Gem::Requirement 
       requirements: 
-        - - ">="
+        - - "="
           - !ruby/object:Gem::Version 
             segments: 
               - 1
               - 1
-              - 0
-            version: 1.1.0
+              - 1
+            version: 1.1.1
     requirement: *id006
     prerelease: false
     type: :development
@@ -120,8 +120,8 @@ dependencies:
             segments: 
               - 1
               - 1
-              - 0
-            version: 1.1.0
+              - 1
+            version: 1.1.1
     requirement: *id008
     prerelease: false
     type: :runtime
@@ -134,8 +134,8 @@ dependencies:
             segments: 
               - 2
               - 0
-              - 6
-            version: 2.0.6
+              - 7
+            version: 2.0.7
     requirement: *id009
     prerelease: false
     type: :runtime
@@ -211,7 +211,7 @@ rubyforge_project:
 rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
-summary: Adds support for limit and offset for Sybase JDBC driver
+summary: Adds support for limit and offset for Rails 3 and Sybase JDBC driver
 test_files: 
   - test/helper.rb
   - test/support/fake_record.rb