aptible-cli 0.19.3 → 0.19.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f20b71eb3388732ade1e6e53cb1f076761d40a06d460faf08fa3e468f239acc1
-  data.tar.gz: 3e603d02a1dbe3e8168209f9a0f061d29851a48189d28dc549bff3a7d203a5e1
+  metadata.gz: f3f0904b2033596eb17ff98125288e5a2adec95ae6e379b95a5b8131b81bfe54
+  data.tar.gz: 9c002c17e22dd77ff79360671d0057455a70ff4ee2311d1466651a5c39b3c1a2
 SHA512:
-  metadata.gz: e195096e2854788c488477ca6d42fd1beb15ce2b6044f0be32a774e6b3915c387694e4608c7546a94915dcb32b3f0844f4864544e4a64806dca23379c0383598
-  data.tar.gz: b2fb1ef99eb836cac0e80419d362277b05877826e8cf4b8f8cb78f937168d4ab658b81f9fea6c7ea0559cd5fe6f926aec896869b7fa8737e4503536d39dfb161
+  metadata.gz: 0c1b0857f175135e6d7feb64a9a6a7b9633b73823f1f32100473f2f90c5b529a6dcf041b55bf4af47a92af08c425b24f4ce1abfacce3deea74b1e031e0bf5fa0
+  data.tar.gz: ccb65684ab24eb9055adee5e17a04d0a9dbf2cdc496ba1b71a9a6a229e83ee092ad43c2ee660f73b5da95b47b875bdf2d0212d6ede3d932455ff67188d4b47c1

data/README.md

@@ -31,6 +31,7 @@ Commands:
   aptible apps                                                                                                                                                                                                                                          # List all applications
   aptible apps:create HANDLE                                                                                                                                                                                                                            # Create a new application
   aptible apps:deprovision                                                                                                                                                                                                                              # Deprovision an app
+  aptible apps:rename OLD_HANDLE NEW_HANDLE [--environment ENVIRONMENT_HANDLE]                                                                                                                                                                          # Rename an app handle. In order for the new app handle to appear in log drain and metric drain destinations, you must restart the app.
   aptible apps:scale SERVICE [--container-count COUNT] [--container-size SIZE_MB]                                                                                                                                                                       # Scale a service
   aptible backup:list DB_HANDLE                                                                                                                                                                                                                         # List backups for a database
   aptible backup:orphaned                                                                                                                                                                                                                               # List backups associated with deprovisioned databases
@@ -50,6 +51,7 @@ Commands:
   aptible db:list                                                                                                                                                                                                                                       # List all databases
   aptible db:modify HANDLE [--iops IOPS] [--volume-type [gp2, gp3]]                                                                                                                                                                                     # Modify a database disk
   aptible db:reload HANDLE                                                                                                                                                                                                                              # Reload a database
+  aptible db:rename OLD_HANDLE NEW_HANDLE [--environment ENVIRONMENT_HANDLE]                                                                                                                                                                            # Rename a database handle. In order for the new database handle to appear in log drain and metric drain destinations, you must reload the database.
   aptible db:replicate HANDLE REPLICA_HANDLE [--container-size SIZE_MB] [--disk-size SIZE_GB] [--logical --version VERSION] [--key-arn KEY_ARN]                                                                                                         # Create a replica/follower of a database
   aptible db:restart HANDLE [--container-size SIZE_MB] [--disk-size SIZE_GB] [--iops IOPS] [--volume-type [gp2, gp3]]                                                                                                                                   # Restart a database
   aptible db:tunnel HANDLE                                                                                                                                                                                                                              # Create a local tunnel to a database
@@ -69,6 +71,7 @@ Commands:
   aptible endpoints:tls:modify [--app APP] ENDPOINT_HOSTNAME                                                                                                                                                                                            # Modify an App TLS Endpoint
   aptible environment:ca_cert                                                                                                                                                                                                                           # Retrieve the CA certificate associated with the environment
   aptible environment:list                                                                                                                                                                                                                              # List all environments
+  aptible environment:rename OLD_HANDLE NEW_HANDLE                                                                                                                                                                                                      # Rename an environment handle. In order for the new environment handle to appear in log drain/metric destinations, you must restart the apps/databases in this environment.
   aptible help [COMMAND]                                                                                                                                                                                                                                # Describe available commands or one specific command
   aptible log_drain:create:datadog HANDLE --url DATADOG_URL --environment ENVIRONMENT [--drain-apps true/false] [--drain_databases true/false] [--drain_ephemeral_sessions true/false] [--drain_proxies true/false]                                     # Create a Datadog Log Drain
   aptible log_drain:create:elasticsearch HANDLE --db DATABASE_HANDLE --environment ENVIRONMENT [--drain-apps true/false] [--drain_databases true/false] [--drain_ephemeral_sessions true/false] [--drain_proxies true/false]                            # Create an Elasticsearch Log Drain
@@ -87,6 +90,8 @@ Commands:
   aptible metric_drain:deprovision HANDLE --environment ENVIRONMENT                                                                                                                                                                                     # Deprovisions a Metric Drain
   aptible metric_drain:list                                                                                                                                                                                                                             # List all Metric Drains
   aptible operation:cancel OPERATION_ID                                                                                                                                                                                                                 # Cancel a running operation
+  aptible operation:follow OPERATION_ID                                                                                                                                                                                                                 # Follow logs of a running operation
+  aptible operation:logs OPERATION_ID                                                                                                                                                                                                                   # View logs for given operation
   aptible rebuild                                                                                                                                                                                                                                       # Rebuild an app, and restart its services
   aptible restart                                                                                                                                                                                                                                       # Restart all services associated with an app
   aptible services                                                                                                                                                                                                                                      # List Services for an App

data/lib/aptible/cli/helpers/database.rb

@@ -154,6 +154,19 @@ module Aptible
           raise Thor::Error, err
         end
 
+        def validate_image_type(type)
+          available_types = []
+
+          Aptible::Api::DatabaseImage.all(token: fetch_token).each do |i|
+            return true if i.type == type
+            available_types << i.type
+          end
+
+          err = "No Database Image of type \"#{type}\""
+          err = "#{err}, valid types: #{available_types.uniq.join(', ')}"
+          raise Thor::Error, err
+        end
+
         def render_database(database, account)
           Formatter.render(Renderer.current) do |root|
             root.keyed_object('connection_url') do |node|

data/lib/aptible/cli/helpers/operation.rb

@@ -1,4 +1,5 @@
 require 'aptible/api'
+require 'net/http'
 
 module Aptible
   module CLI
@@ -48,6 +49,15 @@ module Aptible
           operation.update!(cancelled: true)
         end
 
+        def operation_logs(operation)
+          res = get_operation_logs_redirect(operation)
+          s3_file_request = get_operation_logs_s3_file(res.body)
+
+          m = "Printing out results of operation logs for #{operation.id}"
+          CLI.logger.info m
+          puts s3_file_request.body
+        end
+
         def prettify_operation(o)
           bits = [o.status, o.type, "##{o.id}"]
           if o.resource.respond_to?(:handle)
@@ -55,6 +65,37 @@ module Aptible
           end
           bits.join ' '
         end
+
+        private
+
+        def get_operation_logs_redirect(operation)
+          uri = URI(operation.logs_url)
+          headers = { 'Authorization' => "Bearer #{fetch_token}" }
+          http = Net::HTTP.new(uri.host, uri.port)
+          http.use_ssl = true
+          res = http.request(Net::HTTP::Get.new(uri.request_uri, headers))
+          # note: res body with a 200 is target redirect location for download
+          if !res || res.code != '200' || res.body.nil?
+            raise Thor::Error, 'Unable to retrieve the operation\'s logs. '\
+            'If the issue persists please contact support for assistance.'
+          end
+          res
+        end
+
+        def get_operation_logs_s3_file(location)
+          s3_uri = URI(location)
+          http = Net::HTTP.new(s3_uri.host, s3_uri.port)
+          http.use_ssl = true
+
+          # follow the link with redirect and retrieve it from s3 directly
+          res = http.request(Net::HTTP::Get.new(s3_uri.request_uri))
+          if !res || res.code != '200'
+            raise Thor::Error, 'Unable to retrieve operation logs, '\
+              "S3 returned response code #{res.code}. "\
+              'If the issue persists please contact support for assistance.'
+          end
+          res
+        end
       end
     end
   end

data/lib/aptible/cli/subcommands/apps.rb

@@ -94,6 +94,29 @@ module Aptible
                 raise if e.response.status != 404
               end
             end
+
+            desc 'apps:rename OLD_HANDLE NEW_HANDLE [--environment'\
+                 ' ENVIRONMENT_HANDLE]', 'Rename an app handle. In order'\
+                 ' for the new app handle to appear in log drain and metric'\
+                 ' drain destinations, you must restart the app.'
+            option :environment
+            define_method 'apps:rename' do |old_handle, new_handle|
+              env = ensure_environment(options)
+              app = ensure_app(options.merge(app: old_handle))
+              app.update!(handle: new_handle)
+              m1 = "In order for the new app name (#{new_handle}) to appear"\
+                   ' in log drain and metric drain destinations, you must'\
+                   ' restart the app.'
+              m2 = 'You can restart your app with this command: "aptible '\
+                   "restart --app #{new_handle} --environment #{env.handle}\""
+              m3 = 'Warning - Git remote addresses must be updated to match'\
+                   ' the new handle, if using Dockerfile deploy. '\
+                   "(git@beta.aptible.com:#{app.account.handle}"\
+                   "/#{new_handle}.git)"
+              CLI.logger.warn m1
+              CLI.logger.info m2
+              CLI.logger.warn m3
+            end
           end
         end
       end

data/lib/aptible/cli/subcommands/db.rb

@@ -84,6 +84,7 @@ module Aptible
               version = options[:version]
 
               if version && type
+                validate_image_type(type)
                 image = find_database_image(type, version)
                 db_opts[:type] = image.type
                 db_opts[:database_image] = image
@@ -91,6 +92,7 @@ module Aptible
                 raise Thor::Error, '--type is required when passing --version'
               else
                 db_opts[:type] = type || 'postgresql'
+                validate_image_type(db_opts[:type])
               end
 
               database = account.create_database!(db_opts)
@@ -346,6 +348,24 @@ module Aptible
                 end
               end
             end
+
+            desc 'db:rename OLD_HANDLE NEW_HANDLE [--environment'\
+                 ' ENVIRONMENT_HANDLE]', 'Rename a database handle. In order'\
+                 ' for the new database handle to appear in log drain and'\
+                 ' metric drain destinations, you must reload the database.'
+            option :environment
+            define_method 'db:rename' do |old_handle, new_handle|
+              env = ensure_environment(options)
+              db = ensure_database(options.merge(db: old_handle))
+              db.update!(handle: new_handle)
+              m1 = "In order for the new database name (#{new_handle}) to"\
+                   ' appear in log drain and metric drain destinations,'\
+                   ' you must reload the database.'
+              m2 = 'You can reload your database with this command: "aptible'\
+                   " db:reload #{new_handle} --environment #{env.handle}\""
+              CLI.logger.warn m1
+              CLI.logger.info m2
+            end
           end
         end
       end

data/lib/aptible/cli/subcommands/environment.rb

@@ -41,6 +41,25 @@ module Aptible
                 end
               end
             end
+
+            desc 'environment:rename OLD_HANDLE NEW_HANDLE',
+                 'Rename an environment handle. In order for the new'\
+                 ' environment handle to appear in log drain/metric'\
+                 ' destinations, you must restart the apps/databases in'\
+                 ' this environment.'
+            define_method 'environment:rename' do |old_handle, new_handle|
+              env = ensure_environment(options.merge(environment: old_handle))
+              env.update!(handle: new_handle)
+              m1 = "In order for the new environment handle (#{new_handle})"\
+                   ' to appear in log drain and metric drain destinations,'\
+                   ' you must restart the apps and databases in this'\
+                   ' environment. Also be aware of the following resources'\
+                   ' that may need names adjusted:'
+              m2 = "* Git remote URLs (ex: git@beta.aptible.com:#{new_handle}"\
+                   '/APP_HANDLE.git)'
+              m3 = '* Your own external scripts (e.g. for CI/CD)'
+              [m1, m2, m3].each { |val| CLI.logger.info val }
+            end
           end
         end
       end

data/lib/aptible/cli/subcommands/metric_drain.rb

@@ -8,6 +8,7 @@ module Aptible
           'EU1' => 'https://app.datadoghq.eu',
           'US1-FED' => 'https://app.ddog-gov.com'
         }.freeze
+        PATH = '/api/v1/series'.freeze
 
         def self.included(thor)
           thor.class_eval do
@@ -106,7 +107,7 @@ module Aptible
                                      "Valid options are #{sites}"
                 end
 
-                config[:series_url] = site
+                config[:series_url] = site + PATH
               end
               opts = {
                 handle: handle,

data/lib/aptible/cli/subcommands/operation.rb

@@ -16,6 +16,39 @@ module Aptible
               CLI.logger.info m
               o.update!(cancelled: true)
             end
+
+            desc 'operation:follow OPERATION_ID',
+                 'Follow logs of a running operation'
+            define_method 'operation:follow' do |operation_id|
+              o = Aptible::Api::Operation.find(operation_id, token: fetch_token)
+              raise "Operation ##{operation_id} not found" if o.nil?
+
+              if %w(failed succeeded).include? o.status
+                raise Thor::Error, "This operation has already #{o.status}. " \
+                                   'Run the following command to retrieve ' \
+                                   "the operation's logs:\n" \
+                                   "aptible operation:logs #{o.id}"
+              end
+
+              CLI.logger.info "Streaming logs for #{prettify_operation(o)}..."
+
+              attach_to_operation_logs(o)
+            end
+
+            desc 'operation:logs OPERATION_ID', 'View logs for given operation'
+            define_method 'operation:logs' do |operation_id|
+              o = Aptible::Api::Operation.find(operation_id, token: fetch_token)
+              raise "Operation ##{operation_id} not found" if o.nil?
+
+              unless %w(succeeded failed).include? o.status
+                e = 'Error - You can view the logs when operation is complete.'
+                raise Thor::Error, e
+              end
+
+              m = "Requesting operation logs for #{prettify_operation(o)}..."
+              CLI.logger.info m
+              operation_logs(o)
+            end
           end
         end
       end

data/lib/aptible/cli/version.rb

@@ -1,5 +1,5 @@
 module Aptible
   module CLI
-    VERSION = '0.19.3'.freeze
+    VERSION = '0.19.4'.freeze
   end
 end

data/spec/aptible/cli/helpers/database_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Aptible::CLI::Helpers::Database do
+  subject { Class.new.send(:include, described_class).new }
+
+  describe '#validate_image_type' do
+    let(:pg) do
+      Fabricate(:database_image, type: 'postgresql', version: '10')
+    end
+
+    let(:redis) do
+      Fabricate(:database_image, type: 'redis', version: '9.4')
+    end
+
+    let(:token) { 'some-token' }
+
+    before do
+      allow(subject).to receive(:fetch_token).and_return(token)
+      allow(Aptible::Api::DatabaseImage).to receive(:all)
+        .and_return([pg, redis])
+    end
+
+    it 'Raises an error if provided an invalid type' do
+      bad_type = 'cassandra'
+      err = "No Database Image of type \"#{bad_type}\", " \
+            "valid types: #{pg.type}, #{redis.type}"
+      expect do
+        subject.validate_image_type(bad_type)
+      end.to raise_error(Thor::Error, err)
+    end
+
+    it 'Retruns true when provided a valid type' do
+      expect(subject.validate_image_type(pg.type)).to be(true)
+    end
+  end
+end

data/spec/aptible/cli/subcommands/apps_spec.rb

@@ -197,6 +197,47 @@ describe Aptible::CLI::Agent do
     end
   end
 
+  describe '#apps:rename' do
+    before do
+      allow(Aptible::Api::App).to receive(:all) { [app] }
+      allow(Aptible::Api::Account).to receive(:all) { [account] }
+    end
+
+    before(:each) do
+      allow(subject).to receive(:options)
+        .and_return(environment: account.handle)
+    end
+
+    context 'with environment and app' do
+      it 'should rename properly' do
+        expect(app).to receive(:update!)
+          .with(handle: 'hello2').and_return(app)
+        subject.send('apps:rename', 'hello', 'hello2')
+        expect(captured_logs).to include(
+          'In order for the new app name (hello2) to appear in log drain and '\
+          'metric drain destinations, you must restart the app.'
+        )
+        expect(captured_logs).to include(
+          "(git@beta.aptible.com:#{account.handle}/hello2.git)"
+        )
+      end
+      it 'should fail if app does not exist' do
+        expect { subject.send('apps:rename', 'hello2', 'hello3') }
+          .to raise_error(/Could not find app hello/)
+      end
+      it 'should raise error if update fails' do
+        response = Faraday::Response.new(status: 422)
+        error = HyperResource::ClientError.new('ActiveRecord::RecordInvalid:'\
+        ' Validation failed: Handle has already been taken, Handle has already'\
+        ' been taken', response: response)
+        expect(app).to receive(:update!)
+          .with(handle: 'hello2').and_raise(error)
+        expect { subject.send('apps:rename', 'hello', 'hello2') }
+          .to raise_error(HyperResource::ClientError)
+      end
+    end
+  end
+
   describe '#apps:scale' do
     before do
       allow(Aptible::Api::App).to receive(:all) { [app] }

data/spec/aptible/cli/subcommands/db_spec.rb

@@ -22,6 +22,9 @@ describe Aptible::CLI::Agent do
     before do
       allow(Aptible::Api::Account).to receive(:all).and_return([account])
     end
+    before do
+      subject.stub(:validate_image_type) { true }
+    end
 
     def expect_provision_database(create_opts, provision_opts = {})
       db = Fabricate(:database)
@@ -876,4 +879,39 @@ describe Aptible::CLI::Agent do
       expect(captured_output_text).to eq(expected)
     end
   end
+
+  describe '#db:rename' do
+    before do
+      allow(subject).to receive(:options)
+        .and_return(environment: account.handle)
+      allow(Aptible::Api::Account).to receive(:all) { [account] }
+    end
+    context 'with environment and db' do
+      it 'should rename properly' do
+        expect(database).to receive(:update!)
+          .with(handle: 'foo2').and_return(database)
+        subject.send('db:rename', database.handle, 'foo2')
+        expect(captured_logs).to include(
+          'In order for the new database name (foo2) to appear in log drain '\
+          'and metric drain destinations, you must reload the database.'
+        )
+      end
+      it 'should fail if db does not exist' do
+        expect { subject.send('db:rename', 'foo2', 'foo3') }
+          .to raise_error(/Could not find database foo2/)
+      end
+      it 'should raise error if update fails' do
+        response = Faraday::Response.new(status: 500)
+        error = HyperResource::ClientError.new(
+          'An error occurred: Validation failed: Handle has '\
+          'already been taken, Handle has already been taken',
+          response: response
+        )
+        expect(database).to receive(:update!)
+          .with(handle: 'foo2').and_raise(error)
+        expect { subject.send('db:rename', database.handle, 'foo2') }
+          .to raise_error(HyperResource::ClientError)
+      end
+    end
+  end
 end

data/spec/aptible/cli/subcommands/environment_spec.rb

@@ -10,47 +10,82 @@ describe Aptible::CLI::Agent do
 
   let(:token) { double 'token' }
 
-  before do
+  before(:each) do
     allow(subject).to receive(:fetch_token) { token }
     allow(Aptible::Api::Account).to receive(:all).with(token: token)
       .and_return([a1, a2])
   end
 
-  it 'lists avaliable environments' do
-    subject.send('environment:list')
+  describe('#environment:list') do
+    it 'lists avaliable environments' do
+      subject.send('environment:list')
 
-    expect(captured_output_text.split("\n")).to include('foo')
-    expect(captured_output_text.split("\n")).to include('bar')
+      expect(captured_output_text.split("\n")).to include('foo')
+      expect(captured_output_text.split("\n")).to include('bar')
+    end
   end
 
-  it 'fetches certs for all avaliable environments' do
-    subject.send('environment:ca_cert')
-
-    expect(captured_output_text.split("\n")).to include('account 1 cert')
-    expect(captured_output_text.split("\n")).to include('--account 2 cert--')
-
-    expected_accounts = [
-      {
-        'handle' => 'foo',
-        'ca_body' => 'account 1 cert',
-        'created_at' => fmt_time(a1.created_at)
-      },
-      {
-        'handle' => 'bar',
-        'ca_body' => '--account 2 cert--',
-        'created_at' => fmt_time(a2.created_at)
-      }
-    ]
-    expect(captured_output_json.map! { |account| account.except('id') })
-      .to eq(expected_accounts)
-  end
+  describe('#environment:ca_cert') do
+    it 'fetches certs for all avaliable environments' do
+      subject.send('environment:ca_cert')
+
+      expect(captured_output_text.split("\n")).to include('account 1 cert')
+      expect(captured_output_text.split("\n")).to include('--account 2 cert--')
+
+      expected_accounts = [
+        {
+          'handle' => 'foo',
+          'ca_body' => 'account 1 cert',
+          'created_at' => fmt_time(a1.created_at)
+        },
+        {
+          'handle' => 'bar',
+          'ca_body' => '--account 2 cert--',
+          'created_at' => fmt_time(a2.created_at)
+        }
+      ]
+      expect(captured_output_json.map! { |account| account.except('id') })
+        .to eq(expected_accounts)
+    end
 
-  it 'fetches certs for specified environment' do
-    subject.options = { environment: 'foo' }
-    subject.send('environment:ca_cert')
+    it 'fetches certs for specified environment' do
+      subject.options = { environment: 'foo' }
+      subject.send('environment:ca_cert')
+
+      expect(captured_output_text.split("\n")).to include('account 1 cert')
+      expect(captured_output_text.split("\n"))
+        .to_not include('--account 2 cert--')
+    end
+  end
 
-    expect(captured_output_text.split("\n")).to include('account 1 cert')
-    expect(captured_output_text.split("\n"))
-      .to_not include('--account 2 cert--')
+  describe('#environment:rename') do
+    it 'should rename properly' do
+      expect(a1).to receive(:update!)
+        .with(handle: 'foo-renamed').and_return(a1)
+      subject.send('environment:rename', 'foo', 'foo-renamed')
+      expect(captured_logs).to include(
+        'In order for the new environment handle (foo-renamed)'
+      )
+      expect(captured_logs).to include(
+        '* Your own external scripts (e.g. for CI/CD)'
+      )
+      expect(captured_logs).to include(
+        '* Git remote URLs (ex: git@beta.aptible.com:foo-renamed'
+      )
+    end
+    it 'should fail if env does not exist' do
+      expect { subject.send('environment:rename', 'foo1', 'foo2') }
+        .to raise_error(/Could not find environment foo1/)
+    end
+    it 'should raise error if update fails' do
+      response = Faraday::Response.new(status: 422)
+      error = HyperResource::ClientError.new('ActiveRecord::RecordInvalid:'\
+        ' Validation failed: Handle has already been taken, Handle has already'\
+        ' been taken', response: response)
+      expect(a1).to receive(:update!)
+        .with(handle: 'bar').and_raise(error)
+      expect { subject.send('environment:rename', 'foo', 'bar') }
+        .to raise_error(HyperResource::ClientError)
+    end
   end
 end

data/spec/aptible/cli/subcommands/metric_drain_spec.rb

@@ -145,7 +145,7 @@ describe Aptible::CLI::Agent do
           drain_type: :datadog,
           drain_configuration: {
             api_key: 'foobar',
-            series_url: 'https://app.datadoghq.eu'
+            series_url: 'https://app.datadoghq.eu/api/v1/series'
           }
         }
         expect_provision_metric_drain(opts)

data/spec/aptible/cli/subcommands/operation_spec.rb

@@ -3,6 +3,8 @@ require 'spec_helper'
 describe Aptible::CLI::Agent do
   let(:token) { 'some-token' }
   let(:operation) { Fabricate(:operation) }
+  let(:net_http_double) { double('Net::HTTP') }
+  let(:net_http_get_double) { double('Net::HTTP::Get') }
 
   before do
     allow(subject).to receive(:fetch_token).and_return(token)
@@ -26,4 +28,174 @@ describe Aptible::CLI::Agent do
       subject.send('operation:cancel', 1)
     end
   end
+
+  describe '#operation:follow' do
+    it 'fails if the operation cannot be found' do
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(nil)
+
+      expect { subject.send('operation:follow', 1) }
+        .to raise_error('Operation #1 not found')
+    end
+
+    it 'connects to a running operation' do
+      op = Fabricate(:operation, status: 'running', type: 'restart')
+      expect(Aptible::Api::Operation).to receive(:find)
+        .with(op.id.to_s, token: token).and_return(op)
+
+      expect(subject).to receive(:attach_to_operation_logs).with(op)
+      subject.send('operation:follow', op.id.to_s)
+    end
+
+    it 'connects to a queued operation' do
+      op = Fabricate(:operation, status: 'queued', type: 'restart')
+      expect(Aptible::Api::Operation).to receive(:find)
+        .with(op.id.to_s, token: token).and_return(op)
+
+      expect(subject).to receive(:attach_to_operation_logs).with(op)
+      subject.send('operation:follow', op.id.to_s)
+    end
+
+    it 'does not connect to a failed operation' do
+      id = 34
+      status = 'failed'
+      op = Fabricate(:operation, id: id, status: status)
+      expect(Aptible::Api::Operation).to receive(:find)
+        .with(op.id.to_s, token: token).and_return(op)
+
+      expect { subject.send('operation:follow', op.id.to_s) }
+        .to raise_error(Thor::Error, /aptible operation:logs #{id}/)
+    end
+
+    it 'does not connect to a succeeded operation' do
+      id = 43
+      status = 'succeeded'
+      op = Fabricate(:operation, id: id, status: status)
+      expect(Aptible::Api::Operation).to receive(:find)
+        .with(op.id.to_s, token: token).and_return(op)
+
+      expect { subject.send('operation:follow', op.id.to_s) }
+        .to raise_error(Thor::Error, /aptible operation:logs #{id}/)
+    end
+  end
+
+  describe '#operation:logs' do
+    it 'sends operation logs request when subcommand sent' do
+      operation_id = SecureRandom.uuid
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(Fabricate(
+                      :operation, status: 'succeeded', id: operation_id
+        ))
+
+      # stub out operations call
+      response = instance_double(Net::HTTPResponse, body: 'https://s3.aptible.com/not-real/s3')
+
+      # stub out s3 call
+      s3_response = instance_double(Net::HTTPResponse, body: 'Mock logs')
+
+      allow(Net::HTTP).to receive(:new).twice do |_, _, _|
+        net_http_double
+      end
+      expect(response).to receive(:code).and_return('200')
+      expect(s3_response).to receive(:code).and_return('200')
+      expect(net_http_double).to receive(:use_ssl=).twice
+      expect(net_http_double).to receive(:request).twice do |request|
+        if request.path == "/operations/#{operation_id}/logs"
+          response
+        elsif request.path == '/not-real/s3'
+          s3_response
+        end
+      end
+
+      subject.send('operation:logs', 1)
+    end
+
+    it 'errors when operation is not found' do
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(nil)
+
+      expect { subject.send('operation:logs', 1) }
+        .to raise_error('Operation #1 not found')
+    end
+    it 'errors when operation is not status expected' do
+      operation_id = SecureRandom.uuid
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(Fabricate(:operation, status: 'queued', id: operation_id))
+
+      expect { subject.send('operation:logs', 1) }
+        .to raise_error('Error - You can view the logs when operation '\
+                        'is complete.')
+    end
+    it 'errors when operation logs are not found' do
+      operation_id = SecureRandom.uuid
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(
+          Fabricate(:operation, status: 'succeeded', id: operation_id)
+        )
+
+      # stub out operations call
+      response = Net::HTTPSuccess.new(1.0, '404', 'Not Found')
+      expect_any_instance_of(Net::HTTP)
+        .to receive(:request)
+        .with(an_instance_of(Net::HTTP::Get))
+        .and_return(response)
+
+      expect { subject.send('operation:logs', 1) }
+        .to raise_error('Unable to retrieve the operation\'s logs. '\
+          'If the issue persists please contact support for assistance.')
+    end
+    it 'errors when body is empty' do
+      operation_id = SecureRandom.uuid
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(Fabricate(
+                      :operation, status: 'succeeded', id: operation_id
+        ))
+
+      # stub out operations call
+      response = instance_double(Net::HTTPResponse, body: nil)
+
+      allow(Net::HTTP).to receive(:new) do |_, _, _|
+        net_http_double
+      end
+      expect(response).to receive(:code).and_return('200')
+      expect(net_http_double).to receive(:use_ssl=)
+      expect(net_http_double).to receive(:request).and_return(response)
+
+      expect { subject.send('operation:logs', 1) }
+        .to raise_error('Unable to retrieve the operation\'s logs. '\
+          'If the issue persists please contact support for assistance.')
+    end
+    it 'errors when s3 itself returns an error code' do
+      operation_id = SecureRandom.uuid
+      expect(Aptible::Api::Operation).to receive(:find).with(1, token: token)
+        .and_return(Fabricate(
+                      :operation, status: 'succeeded', id: operation_id
+        ))
+
+      # stub out operations call
+      response = instance_double(Net::HTTPResponse, body: 'https://s3.aptible.com/not-real/s3')
+
+      # stub out s3 call (to fail)
+      expect(response).to receive(:code).and_return('200')
+      s3_response = Net::HTTPSuccess.new(1.0, '404', 'Not Found')
+
+      allow(Net::HTTP).to receive(:new).twice do |_, _, _|
+        net_http_double
+      end
+      expect(net_http_double).to receive(:use_ssl=).twice
+      expect(net_http_double).to receive(:request).twice do |request|
+        if request.path == "/operations/#{operation_id}/logs"
+          response
+        elsif request.path == '/not-real/s3'
+          s3_response
+        end
+      end
+
+      expect { subject.send('operation:logs', 1) }
+        .to raise_error('Unable to retrieve operation logs, '\
+                        'S3 returned response code 404. '\
+                        'If the issue persists please contact support for '\
+                        'assistance.')
+    end
+  end
 end

data/spec/fabricators/operation_fabricator.rb

@@ -1,7 +1,12 @@
 class StubOperation < OpenStruct; end
 
+def mock_logs_url(id)
+  "https://api.aptible.com/operations/#{id}/logs"
+end
+
 Fabricator(:operation, from: :stub_operation) do
   status 'queued'
-  resource { Fabricate(:app) }
   errors { Aptible::Resource::Errors.new }
+  resource { Fabricate(:app) }
+  after_save { |operation| operation.logs_url = mock_logs_url(operation.id) }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aptible-cli
 version: !ruby/object:Gem::Version
-  version: 0.19.3
+  version: 0.19.4
 platform: ruby
 authors:
 - Frank Macreery
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-01 00:00:00.000000000 Z
+date: 2022-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aptible-resource
@@ -326,6 +326,7 @@ files:
 - script/sync-readme-usage
 - spec/aptible/cli/agent_spec.rb
 - spec/aptible/cli/formatter_spec.rb
+- spec/aptible/cli/helpers/database_spec.rb
 - spec/aptible/cli/helpers/git_remote_handle_strategy_spec.rb
 - spec/aptible/cli/helpers/handle_from_git_remote_spec.rb
 - spec/aptible/cli/helpers/operation_spec.rb
@@ -382,7 +383,7 @@ homepage: https://github.com/aptible/aptible-cli
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -398,12 +399,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3.1
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Command-line interface for Aptible services
 test_files:
 - spec/aptible/cli/agent_spec.rb
 - spec/aptible/cli/formatter_spec.rb
+- spec/aptible/cli/helpers/database_spec.rb
 - spec/aptible/cli/helpers/git_remote_handle_strategy_spec.rb
 - spec/aptible/cli/helpers/handle_from_git_remote_spec.rb
 - spec/aptible/cli/helpers/operation_spec.rb