apress-yandex_market 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b62a9a0c7db6767fe9559e3e07cfefd0b1bed4f
-  data.tar.gz: 712a1629589d5f6db999c62fb6f3b547e49cd705
+  metadata.gz: 1f6def217c9f110df4c22f0b606f7fa25d53a42c
+  data.tar.gz: 3a89225ca053beafc5d34ba50353c5a4240c512d
 SHA512:
-  metadata.gz: 4a0840fceb8743f97872f44240717414b55cf0dc3632dd24c6bc22511375cb98bf267e97cff3bbf2b38157c7feceb515d5cdb8aaad1f966d181b1a7a6d9fa19d
-  data.tar.gz: 4b605819f184624087a2ff58bf156560ebf84af744df6977250d0589daf5d4c7ab049f9b4c8b9d36445ced72749b9897b7700b290d0c88dfb96ba0c31302473d
+  metadata.gz: 83f6544a41c4369f75b153484fb674b4e12a2f1d96c1aaa9195ac9fbcb2e42f76b0a65261b982f7d0f2dfcdaa9b11d14b064e1a3a1655a0ddb6f3e11333452c3
+  data.tar.gz: 3c5dfad011d5b954ce12b71e2230bd62431a82eb14f31ab8f240f53f8176858e58d3d110a850074cb592a7490d427943e82df16ada9908f7dde68580048adf06

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v0.1.1
+
+* 2019-01-24 [d3d7504](../../commit/d3d7504) - __(Mikhail Nelaev)__ Release 0.1.1 
+* 2019-01-14 [ad33bf3](../../commit/ad33bf3) - __(Mikhail Nelaev)__ fix: яндекс может отдавать модели без категории 
+https://jira.railsc.ru/browse/GOODS-1610
+
 # v0.1.0
 
 * 2018-12-24 [b5adb2b](../../commit/b5adb2b) - __(Mikhail Nelaev)__ fix: получаем все корневые категории 

data/lib/apress/yandex_market/readers/model_by_category.rb

@@ -109,7 +109,8 @@ module Apress
             models = get_models(category_id, page, sort_direction)
 
             models.each do |model|
-              next if category_id != model.fetch(:category).fetch(:id)
+              next unless model[:category].is_a? Hash
+              next if category_id != model[:category][:id]
               return if processed_models.include? model
 
               processed_models << model

data/lib/apress/yandex_market/version.rb

@@ -1,5 +1,5 @@
 module Apress
   module YandexMarket
-    VERSION = '0.1.0'.freeze
+    VERSION = '0.1.1'.freeze
   end
 end

data/spec/apress/yandex_market/readers/model_by_category_spec.rb

@@ -9,21 +9,40 @@ describe Apress::YandexMarket::Readers::ModelByCategory do
   end
 
   describe '#each_row' do
-    let(:rows) { [] }
-
     before do
       allow(reader.category_reader.client).to receive(:get).and_call_original
       allow(reader.category_reader.client).to receive(:get).with('categories/90509/children', anything).
         and_return(categories: [{id: 8_476_099, childCount: 0}])
+    end
+
+    context 'valid models' do
+      let(:rows) { [] }
+
+      before do
+        VCR.use_cassette 'read_models_from_category' do
+          reader.each_row { |row| rows << row }
+        end
+      end
 
-      VCR.use_cassette 'read_models_from_category' do
-        reader.each_row { |row| rows << row }
+      it 'reads models of specified categories and their subcategories' do
+        expect(rows).to have(840).items
+        expect(rows.uniq).to have(840).items
       end
     end
 
-    it 'reads models of specified categories and their subcategories' do
-      expect(rows).to have(840).items
-      expect(rows.uniq).to have(840).items
+    context 'when some models do not have category' do
+      let(:rows) { [] }
+
+      before do
+        VCR.use_cassette 'read_models_without_category' do
+          reader.each_row { |row| rows << row }
+        end
+      end
+
+      it 'reads models of specified categories and their subcategories' do
+        expect(rows).to have(838).items
+        expect(rows.uniq).to have(838).items
+      end
     end
   end
 end