appydave-tools 0.76.2 → 0.76.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e0809dc40e0f4940381134c70a57833d755df47f01f8e327a04b278e4d87c5a
-  data.tar.gz: a1aa1d00b87481b371edda22ed5f7f0fa63a895358002cbc330b4d4e8cbf1ae8
+  metadata.gz: d2b65bd11cb0b4e0a0c9b1718a9ebb262ad6c998167bfdc8f533ddca754ee850
+  data.tar.gz: e45a7a56eb7f77249911ea874037c002829cfcca1f8f5cfd8553b60d12e88898
 SHA512:
-  metadata.gz: 8ef02094f475fc3df1b6b346158dce9596cbc4898c4a5da60e573ae48ddb8ff10663d2b19be0da582adea9b47597a14926e7e55358d33e742762d8cf7b53bf6f
-  data.tar.gz: 1c96b7e36178f5f0ec3426934a88686fb23e19d890858c1825264bb3a33e67d6054ed520cd4157ff60906f468a91cd25d2c319696b6a1ae936baaca8a013f627
+  metadata.gz: feb57bd1aca715ae2b6b3a587e762e024457b4d14f1172069d1afd19e953c6c432567d9c76c819543f740acb757c53bb36fa7bc839e4e7c8706f13435e94bfb0
+  data.tar.gz: eba77632d7dad881243726e122d8da5546040910b2851c36a9b751d7310da9ca3d1a4279571baa31b908bb1ff398436253bed4f7e52907adeeb6e4cfe1b1f69a

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [0.76.2](https://github.com/appydave/appydave-tools/compare/v0.76.1...v0.76.2) (2026-03-19)
+
+
+### Bug Fixes
+
+* add dedicated specs for Jump Commands layer ([8eec40c](https://github.com/appydave/appydave-tools/commit/8eec40cb60b08b1ca7901f288cff8c9a70783fe2))
+* add determine_range edge cases and fix stale comment ([6e97390](https://github.com/appydave/appydave-tools/commit/6e97390e135ac452a364bfac45fcbc4679b5a26d))
+* add functional CLI tests for -i -e -f -o flags to gpt_context cli_spec ([feed9c7](https://github.com/appydave/appydave-tools/commit/feed9c70abfbec83c6bdb0fcba45fce0ec528657))
+* fix no-args cli spec assertion to avoid false positive on Linux clipboard error ([a50b68e](https://github.com/appydave/appydave-tools/commit/a50b68ea57e2d989b35da2c5f1172181cf825438))
+* fix no-args clipboard assertion to avoid false failure from clipboard gem warning on Linux CI ([197b9de](https://github.com/appydave/appydave-tools/commit/197b9dea84fc12c14b03c39333593f430542228a))
+* strengthen gpt_context no-args spec to verify collection does not proceed ([972d617](https://github.com/appydave/appydave-tools/commit/972d617b2241326a6b4beca53d520ebcb1051530))
+
 ## [0.76.1](https://github.com/appydave/appydave-tools/compare/v0.76.0...v0.76.1) (2026-03-19)
 
 

data/docs/planning/final-test-gaps/AGENTS.md

@@ -0,0 +1,333 @@
+# AGENTS.md — final-test-gaps
+
+> Inherited from test-coverage-gaps AGENTS.md. Self-contained.
+> Last updated: 2026-03-19
+
+---
+
+## Project Overview
+
+**What:** Ruby gem providing CLI productivity tools for AppyDave's YouTube content creation workflow.
+**Stack:** Ruby 3.4.2, Bundler 2.6.2, RSpec, RuboCop, semantic-release CI/CD.
+**This campaign:** Test-only gap closure. No lib/ production code changes.
+**Commits:** Always use `kfix` — never `git commit`.
+
+---
+
+## Build & Run Commands
+
+```bash
+eval "$(rbenv init -)"
+
+RUBYOPT="-W0" bundle exec rspec                                                    # All tests
+bundle exec rspec spec/appydave/tools/gpt_context/file_collector_spec.rb
+bundle exec rspec spec/appydave/tools/gpt_context/cli_spec.rb
+bundle exec rspec spec/appydave/tools/jump/commands/add_spec.rb
+bundle exec rspec spec/appydave/tools/jump/commands/update_spec.rb
+bundle exec rubocop --format clang
+```
+
+**Baseline:** 817 examples, 0 failures, 85.61% line coverage
+
+---
+
+## Directory Structure
+
+```
+lib/appydave/tools/gpt_context/
+  file_collector.rb         READ ONLY — formats: content, tree, json, aider
+  options.rb                READ ONLY — Struct with: include_patterns, exclude_patterns,
+                                         format, line_limit, debug, output_target,
+                                         working_directory, prompt (all keyword_init)
+
+spec/appydave/tools/gpt_context/
+  file_collector_spec.rb    ADD json format, aider format, error path tests
+  cli_spec.rb               ADD body content assertions to -i and -e describe blocks
+
+spec/appydave/tools/jump/commands/
+  add_spec.rb               ADD location data integrity assertions (path, jump, tags, description)
+  update_spec.rb            ADD field isolation assertions (non-updated fields unchanged)
+```
+
+---
+
+## Work Unit Details
+
+---
+
+### fix-b023 — file_collector_spec: json, aider, error paths
+
+**Read first:** `lib/appydave/tools/gpt_context/file_collector.rb` and
+`spec/appydave/tools/gpt_context/file_collector_spec.rb`
+
+**What `build_json` produces:**
+```ruby
+{
+  'tree' => {},      # nested hash matching tree structure
+  'content' => [     # array of hashes, one per file
+    { 'file' => 'path/to/file.txt', 'content' => '...' }
+  ]
+}
+```
+Returns `JSON.pretty_generate(json_output)` — a valid JSON string.
+
+**What `build_aider` produces:**
+- With `prompt` set: `aider --message "my prompt" path/to/file1.rb path/to/file2.rb`
+- Without `prompt` (nil): returns `''`
+
+**Add these describe blocks to file_collector_spec.rb:**
+
+```ruby
+describe '#build with json format' do
+  let(:format) { 'json' }
+  let(:include_patterns) { ['**/*.txt'] }
+  let(:exclude_patterns) { [] }
+
+  it 'returns valid JSON' do
+    result = subject.build
+    expect { JSON.parse(result) }.not_to raise_error
+  end
+
+  it 'includes a tree key in the JSON output' do
+    result = JSON.parse(subject.build)
+    expect(result).to have_key('tree')
+  end
+
+  it 'includes a content key in the JSON output' do
+    result = JSON.parse(subject.build)
+    expect(result).to have_key('content')
+  end
+
+  it 'includes file paths and content in the content array' do
+    result = JSON.parse(subject.build)
+    files = result['content'].map { |f| f['file'] }
+    expect(files).to include('included/file1.txt')
+
+    entry = result['content'].find { |f| f['file'] == 'included/file1.txt' }
+    expect(entry['content']).to include('File 1 content')
+  end
+
+  it 'excludes files matching exclude patterns from content' do
+    result = JSON.parse(subject.build)
+    files = result['content'].map { |f| f['file'] }
+    expect(files).not_to include('excluded/excluded_file.txt')
+  end
+end
+
+describe '#build with aider format' do
+  let(:format) { 'aider' }
+  let(:include_patterns) { ['**/*.txt'] }
+  let(:exclude_patterns) { [] }
+
+  context 'when prompt is set' do
+    let(:options) do
+      Appydave::Tools::GptContext::Options.new(
+        include_patterns: include_patterns,
+        exclude_patterns: exclude_patterns,
+        format: format,
+        line_limit: nil,
+        working_directory: temp_dir,
+        prompt: 'fix the bug'
+      )
+    end
+
+    it 'returns an aider command string' do
+      expect(subject.build).to start_with('aider --message')
+    end
+
+    it 'includes the prompt in the command' do
+      expect(subject.build).to include('fix the bug')
+    end
+
+    it 'includes collected file paths in the command' do
+      result = subject.build
+      expect(result).to include('included/file1.txt')
+    end
+  end
+
+  context 'when prompt is not set' do
+    it 'returns an empty string' do
+      expect(subject.build).to eq('')
+    end
+  end
+end
+
+describe '#build with nonexistent working directory' do
+  let(:options) do
+    Appydave::Tools::GptContext::Options.new(
+      include_patterns: ['**/*.txt'],
+      exclude_patterns: [],
+      format: 'content',
+      line_limit: nil,
+      working_directory: '/tmp/does-not-exist-12345'
+    )
+  end
+
+  it 'returns empty string without raising an error' do
+    expect { subject.build }.not_to raise_error
+    expect(subject.build).to eq('')
+  end
+end
+```
+
+**Note:** The existing `before` block creates files under `temp_dir`. The aider context with `prompt` needs its own `let(:options)` that overrides the parent — this is fine in RSpec because the inner let shadows the outer.
+
+**Commit:** `kfix "add json, aider, and error path tests to file_collector_spec"`
+
+---
+
+### fix-b028 — cli_spec: add file body content assertions to -i and -e tests
+
+**Read first:** `spec/appydave/tools/gpt_context/cli_spec.rb`
+
+**The gap:** `-i` tests write known content to temp files but only assert on `# file: test.rb` headers. File body content (`# test content`, `# ruby file`) is never asserted. File truncation or body corruption would pass silently.
+
+**Find the `-i include pattern` describe block (lines 43-68). Add body assertions to each existing `it` block:**
+
+In the first `-i` example (`'collects files matching the include pattern'`):
+```ruby
+# After the existing assertion, add:
+expect(File.read(outfile)).to include('# test content')
+```
+
+In the second `-i` example (`'does not include files that do not match the pattern'`):
+```ruby
+# The file 'test.rb' has content '# ruby file'
+# After the existing assertions, add:
+expect(content).to include('# ruby file')
+expect(content).not_to include('# markdown file')
+```
+
+**Find the `-e exclude pattern` describe block (lines 70-95). Add body assertions:**
+
+In the first `-e` example (`'excludes files matching the exclude pattern'`):
+```ruby
+# 'keep.rb' has content '# keep'
+# After existing assertions, add:
+expect(content).to include('# keep')
+```
+
+In the second `-e` example (`'keeps all files when exclude pattern matches nothing'`):
+```ruby
+# 'keep.rb' has content '# keep'
+# After existing assertion, add:
+expect(File.read(outfile)).to include('# keep')
+```
+
+**Do NOT modify the `-f`, `-o`, or `no arguments` describe blocks** — those are not in scope.
+
+**Commit:** `kfix "add file body content assertions to cli_spec -i and -e tests"`
+
+---
+
+### fix-b029 — add_spec: validate all returned location data fields
+
+**Read first:** `spec/appydave/tools/jump/commands/add_spec.rb`
+
+**The gap:** The `'returns the created location data'` example (lines 35-41) only asserts `result[:location][:key]`. The path, jump, tags, description are never verified — data corruption or field mapping bugs would pass silently.
+
+**Add a new `it` block** in the `'with valid attributes and existing path'` context, immediately after the existing `'returns the created location data'` block:
+
+```ruby
+it 'returns location data matching all input attrs' do
+  cmd = described_class.new(config, valid_attrs, path_validator: path_validator)
+  result = cmd.run
+
+  location = result[:location]
+  expect(location[:key]).to eq('new-project')
+  expect(location[:path]).to eq('~/dev/new-project')
+  expect(location[:jump]).to eq('jnew')
+  expect(location[:tags]).to eq(%w[ruby])
+  expect(location[:description]).to eq('A new project')
+end
+```
+
+**Do NOT modify the existing `'returns the created location data'` example** — add alongside it.
+
+**Commit:** `kfix "add data integrity assertions to add_spec returned location data"`
+
+---
+
+### fix-b030 — update_spec: verify non-updated fields remain unchanged
+
+**Read first:** `spec/appydave/tools/jump/commands/update_spec.rb`
+**Also read:** `spec/support/jump_test_locations.rb` to get the exact field values for `JumpTestLocations.ad_tools` and `JumpTestLocations.flivideo`
+
+**Gap 1:** `'leaves unmodified locations intact'` (lines 48-53) only checks `config.key_exists?('flivideo')`. The flivideo record's fields (path, jump, tags, description) could be corrupted and the test would still pass.
+
+**Gap 2:** When updating `ad-tools` description, the key/path/jump/tags of the `ad-tools` record itself are never verified to be unchanged.
+
+**Add two new `it` blocks** in the `'when location exists and update is valid'` context:
+
+```ruby
+it 'does not modify non-updated fields on the updated record' do
+  original = config.find('ad-tools')
+  original_path = original.path
+  original_jump = original.jump
+  original_tags = original.tags
+
+  cmd = described_class.new(config, 'ad-tools', { description: 'Changed' }, path_validator: path_validator)
+  cmd.run
+
+  updated = config.find('ad-tools')
+  expect(updated.path).to eq(original_path)
+  expect(updated.jump).to eq(original_jump)
+  expect(updated.tags).to eq(original_tags)
+end
+
+it 'does not modify the sibling record fields' do
+  original_flivideo = config.find('flivideo')
+  original_path = original_flivideo.path
+  original_jump = original_flivideo.jump
+
+  cmd = described_class.new(config, 'ad-tools', { description: 'Changed' }, path_validator: path_validator)
+  cmd.run
+
+  flivideo = config.find('flivideo')
+  expect(flivideo.path).to eq(original_path)
+  expect(flivideo.jump).to eq(original_jump)
+end
+```
+
+**Do NOT modify existing examples** — add alongside them.
+
+**Note:** Read jump_test_locations.rb to understand what fields `JumpTestLocations.flivideo` has before assuming field names.
+
+**Commit:** `kfix "add field isolation assertions to update_spec non-updated fields"`
+
+---
+
+## Success Criteria
+
+- [ ] `RUBYOPT="-W0" bundle exec rspec` — 817+ examples, 0 failures
+- [ ] `bundle exec rubocop --format clang` — 0 offenses
+- [ ] Line coverage stays ≥ 85.61%
+- [ ] All new `it` blocks use descriptive behaviour names
+- [ ] No `require 'spec_helper'` added (auto-required)
+- [ ] All new spec files start with `# frozen_string_literal: true` (if any new files created)
+
+---
+
+## Anti-Patterns to Avoid
+
+- ❌ Do NOT use `$?` — use `$CHILD_STATUS` (rubocop Style/SpecialGlobalVars)
+- ❌ Do NOT modify existing passing examples — add new ones alongside
+- ❌ Do NOT require spec_helper explicitly
+- ❌ Do NOT change production lib/ code
+- ❌ Do NOT use multiple separate `before` blocks on the same context — rubocop RSpec/ScatteredSetup; merge into one
+- ❌ Do NOT assume field names on JumpTestLocations — read the file first
+
+---
+
+## Learnings (inherited from test-coverage-gaps)
+
+- **`$CHILD_STATUS` not `$?`** — rubocop Special/GlobalVars cop
+- **`exit` with no code exits 0** — specs asserting no-args exit should expect 0
+- **`options.format` defaults to `'tree,content'`** — never nil
+- **Grep full codebase before writing scope** — actual files may differ from brief
+- **ENV stubbing:** `allow(ENV).to receive(:[]).and_call_original` then targeted override — no climate_control gem
+- **Merge `before` blocks** — multiple separate `before` blocks on same context trigger RSpec/ScatteredSetup
+- **`options.prompt` defaults to nil** — aider format returns `''` when prompt is nil
+- **Parallel wave had zero merge conflicts across 5 agents** — all different files
+- **B023 `build_json`:** returns `JSON.pretty_generate` — must `JSON.parse(result)` before asserting on keys
+- **B028 body assertions:** file content is written in Dir.mktmpdir blocks; check the `File.write` call to know what body text to assert

data/docs/planning/final-test-gaps/IMPLEMENTATION_PLAN.md

@@ -0,0 +1,29 @@
+# IMPLEMENTATION_PLAN.md — final-test-gaps
+
+**Goal**: Close remaining test quality gaps surfaced by the test-quality-audit: file_collector json/aider/error paths, cli_spec body assertions, add_spec data integrity, update_spec field isolation
+**Started**: 2026-03-19
+**Target**: All 4 work units complete; 817+ examples passing; rubocop clean; no regressions; regression catch rate meaningfully above 55%
+
+## Summary
+- Total: 4 | Complete: 0 | In Progress: 4 | Pending: 0 | Failed: 0
+
+## Pending
+
+## In Progress
+- [~] fix-b023 — file_collector_spec: add json format, aider format, and error path tests
+- [~] fix-b028 — cli_spec: add file body content assertions to -i and -e tests
+- [~] fix-b029 — add_spec: validate ALL returned location data fields match input attrs (path, jump, tags, description)
+- [~] fix-b030 — update_spec: verify non-updated fields are unchanged on both updated record and sibling records
+
+## Complete
+
+## Failed / Needs Retry
+
+## Notes & Decisions
+- All 4 work units are independent — parallel wave
+- Test-only campaign: no lib/ production code changes
+- B019 and B015 already fixed in prior commits — closed without campaign
+- B028 scope: -i tests check `# file: test.rb` header but not body; -e tests same gap. Add body content assertions only (do NOT rewrite existing assertions)
+- B029 scope: "returns the created location data" test at line 35-41 of add_spec.rb — extend it to assert path/jump/tags/description. Add as a new 'it' block rather than modifying existing example.
+- B030 scope: two gaps — (1) updated record: non-updated fields stay the same; (2) sibling record: not just key_exists? but fields are identical
+- B023 scope: Options struct has :prompt field (keyword_init). Aider tests need `prompt: 'my prompt'` in options.

data/docs/planning/test-coverage-gaps/assessment.md

@@ -0,0 +1,75 @@
+# Assessment: test-coverage-gaps
+
+**Campaign**: test-coverage-gaps
+**Date**: 2026-03-19 → 2026-03-19
+**Results**: 5 complete, 0 failed
+**Version shipped**: v0.76.2
+**Quality audit**: code-quality-audit + test-quality-audit run post-campaign
+
+---
+
+## Results Summary
+
+| Work Unit | Examples Added | Notes |
+|-----------|---------------|-------|
+| fix-b024-ssl-tests | +6 | configure_ssl_options protected in s3_operations + share_operations |
+| fix-b022-cli-tests | +10 | -i/-e/-f/-o functional tests with real file I/O |
+| fix-b026-b025 | +6 + comment | b00/b9/a40 edge cases; stale comment fixed |
+| fix-b027-noargs | +1 | No-file-collection assertion added |
+| fix-b018-jump | +36 | Remove/Add/Update fully covered + fixed clipboard assertion |
+
+**759 → 817 examples (+58). 85.0% → 85.61% coverage.**
+
+---
+
+## What Worked Well
+
+- **36 Jump Commands specs landed cleanly.** The accumulated AGENTS.md (JumpTestLocations, `with jump filesystem` context, TestPathValidator) meant agents could write correct specs without scaffolding guidance.
+- **B018 agent fixed the B027 clipboard CI failure.** Unblocked itself and the other agents.
+- **ENV stubbing pattern worked without climate_control.** `allow(ENV).to receive(:[]).and_call_original` + targeted override — captured in AGENTS.md.
+- **Parallel wave had zero merge conflicts.** 5 agents, all different files, clean.
+
+---
+
+## What Didn't Work
+
+**Test quality is C overall (test audit finding).**
+
+Specific gaps the audit surfaced:
+- **cli_spec.rb (-i/-o tests):** Assert `# file:` header present but never check file body content. File truncation or body corruption would not be caught.
+- **add_spec.rb:** After a successful add, only checks `key_exists?` — never validates returned location data matches input attrs (key, path, jump, tags).
+- **update_spec.rb:** Tests verify the updated field changed but never verify other fields were NOT changed.
+- **s3_operations_spec.rb:** Some output format checks use soft regex.
+
+Regression catch rate: ~55%. Would catch code path breaks and guard logic. Would miss data integrity and content corruption.
+
+---
+
+## Key Learnings — Application
+
+- **B015 is already fixed.** BACKLOG.md lists B015 as pending but file_collector.rb already uses block form `FileUtils.cd(@working_directory) { build_formats }` from commit 13d5f87. Close it.
+- **`allow(ENV).to receive(:[]).and_call_original`** is the correct ENV stub pattern when climate_control is absent. Must call `and_call_original` first, then override specific key.
+- **Merge `before` blocks** to avoid `RSpec/ScatteredSetup` — multiple separate `before` blocks on same context trigger the cop.
+- **Jump Commands layer is now tested.** base.rb/generate.rb/validate.rb already had specs; Remove/Add/Update are now covered.
+
+---
+
+## New Backlog Items from Quality Audit
+
+- **B028** — Tests: cli_spec.rb add file body content assertions to -i/-o tests | Priority: medium
+- **B029** — Tests: add_spec.rb validate returned location data matches input attrs exactly | Priority: medium
+- **B030** — Tests: update_spec.rb verify non-updated fields remain unchanged | Priority: low
+
+---
+
+## Suggestions for Next Campaign
+
+**B015 should be closed immediately** — the fix is already in the code. Update BACKLOG.md, don't plan a campaign for it.
+
+Next meaningful work:
+1. **B023** — file_collector_spec: JSON, aider, error paths (last test-coverage gap)
+2. **B028** — cli_spec file body assertions (from this audit)
+3. **B029** — add_spec data integrity assertions
+4. These are small — could bundle into one campaign with B030
+
+Or pivot to **architectural** items (B011 — extract VatCLI, B020 — split S3Operations) which are larger but unblock performance work (B007/B008).

data/lib/appydave/tools/version.rb

@@ -2,6 +2,6 @@
 
 module Appydave
   module Tools
-    VERSION = '0.76.2'
+    VERSION = '0.76.3'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appydave-tools",
-  "version": "0.76.2",
+  "version": "0.76.3",
   "description": "AppyDave YouTube Automation Tools",
   "scripts": {
     "release": "semantic-release"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appydave-tools
 version: !ruby/object:Gem::Version
-  version: 0.76.2
+  version: 0.76.3
 platform: ruby
 authors:
 - David Cruwys
@@ -300,12 +300,15 @@ files:
 - docs/planning/bugfix-and-security/AGENTS.md
 - docs/planning/bugfix-and-security/IMPLEMENTATION_PLAN.md
 - docs/planning/bugfix-and-security/assessment.md
+- docs/planning/final-test-gaps/AGENTS.md
+- docs/planning/final-test-gaps/IMPLEMENTATION_PLAN.md
 - docs/planning/fr2-gpt-context-help/AGENTS.md
 - docs/planning/fr2-gpt-context-help/IMPLEMENTATION_PLAN.md
 - docs/planning/fr2-gpt-context-help/assessment.md
 - docs/planning/next-round-brief.md
 - docs/planning/test-coverage-gaps/AGENTS.md
 - docs/planning/test-coverage-gaps/IMPLEMENTATION_PLAN.md
+- docs/planning/test-coverage-gaps/assessment.md
 - docs/specs/fr-002-gpt-context-help-system.md
 - docs/specs/fr-003-jump-location-tool.md
 - docs/specs/zsh-history-tool.md