appsignal 4.3.3 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0ba9c95d270a611f4b26314db6d6a62a5ffb59e76bd8b797e4f272557ec70d8
-  data.tar.gz: 2318a7c02f13fe76b5d2c9c054eb900f9e3342c4b5e5d8108285b709a3610a74
+  metadata.gz: 5597f989bd9be686cd47741ae75bb370268037d2d3806df3a3b525cc52f7afd1
+  data.tar.gz: b00945131c58201641865769f29b2cc356ed01798a5a32db5a9f6f1665223c55
 SHA512:
-  metadata.gz: 55b25b22f9a2d60c4973c547bd63aa8de67d6fcb83ac5aa47a63b8c0bf19e368bf09c4f09c1362c7552a133de41321e93957f1ed965973fcd818c0ecce0889fa
-  data.tar.gz: cd0c243ee29a67648b3bb397ae2699b16982395501d43b16821e91a063eec6d6f5f3551e190ad7f7ade12c5b264581aede02e83186f69ceeccf89fc29e509e6f
+  metadata.gz: 875215fa3f29741c484c8facd6ab4ffc24d486decc2f2f2c7f741ec379422406192655d7fe4f2911d0cfef001329fe562b9c8cc533f6981e729c3d0cf304a2d2
+  data.tar.gz: ec8ca247cfad7a0e32ef75c8bfa4613ade8f74011c8f84c6b3b69b8d1b35c903401c978de27f0b9b7e5dbdb453cdbfcbd5d309d757a8ae29488bc07519abf45b

data/CHANGELOG.md

@@ -1,5 +1,37 @@
 # AppSignal for Ruby gem Changelog
 
+## 4.4.0
+
+_Published on 2025-02-06._
+
+### Changed
+
+- Do not report error causes if the wrapper error has already been reported. This deduplicates errors and prevents the error wrapper and error cause to be reported separately, as long as the error wrapper is reported first.
+
+  ```ruby
+  error_wrapper = nil
+  error_cause = nil
+  begin
+    begin
+      raise StandardError, "error cause"
+    rescue => e
+      error_cause = e
+      raise Exception, "error wrapper"
+    end
+  rescue Exception => e
+    error_wrapper = e
+  end
+
+  Appsignal.report_error(error_wrapper) # Reports error
+  Appsignal.report_error(error_cause) # Doesn't report error
+  ```
+
+  (minor [af02b8b3](https://github.com/appsignal/appsignal-ruby/commit/af02b8b356f03b23efe83511970de62281837054))
+
+### Fixed
+
+- Fix an issue where the HTTP.rb gem integration would raise an error when a string containing non-ASCII characters is passed to the gem as the URL. (patch [fce0acdf](https://github.com/appsignal/appsignal-ruby/commit/fce0acdfe0a7f807c846c3f90fd79f994c44db0b))
+
 ## 4.3.3
 
 _Published on 2025-01-17._

data/lib/appsignal/integrations/http.rb

@@ -5,7 +5,8 @@ module Appsignal
     # @api private
     module HttpIntegration
       def request(verb, uri, opts = {})
-        parsed_request_uri = uri.is_a?(URI) ? uri : URI.parse(uri.to_s)
+        uri_module = defined?(HTTP::URI) ? HTTP::URI : URI
+        parsed_request_uri = uri.is_a?(URI) ? uri : uri_module.parse(uri.to_s)
         request_uri = "#{parsed_request_uri.scheme}://#{parsed_request_uri.host}"
 
         Appsignal.instrument("request.http_rb", "#{verb.upcase} #{request_uri}") do

data/lib/appsignal/transaction.rb

@@ -213,7 +213,7 @@ module Appsignal
           # In the duplicate transaction for each error, set an error
           # with a block that calls all the blocks set for that error
           # in the original transaction.
-          transaction.set_error(error) do
+          transaction.internal_set_error(error) do
             blocks.each { |block| block.call(transaction) }
           end
 
@@ -560,17 +560,18 @@ module Appsignal
       return unless error
       return unless Appsignal.active?
 
-      _set_error(error) if @error_blocks.empty?
-
-      if !@error_blocks.include?(error) && @error_blocks.length >= ERRORS_LIMIT
-        Appsignal.internal_logger.warn "Appsignal::Transaction#add_error: Transaction has more " \
-          "than #{ERRORS_LIMIT} distinct errors. Only the first " \
-          "#{ERRORS_LIMIT} distinct errors will be reported."
+      if error.instance_variable_get(:@__appsignal_error_reported) && !@error_blocks.include?(error)
         return
       end
 
-      @error_blocks[error] << block
-      @error_blocks[error].compact!
+      internal_set_error(error, &block)
+
+      # Mark errors and their causes as tracked so we don't report duplicates,
+      # but also not error causes if the wrapper error is already reported.
+      while error
+        error.instance_variable_set(:@__appsignal_error_reported, true) unless error.frozen?
+        error = error.cause
+      end
     end
     alias :set_error :add_error
     alias_method :add_exception, :add_error
@@ -632,6 +633,19 @@ module Appsignal
     attr_writer :is_duplicate, :tags, :custom_data, :breadcrumbs, :params,
       :session_data, :headers
 
+    def internal_set_error(error, &block)
+      _set_error(error) if @error_blocks.empty?
+
+      if !@error_blocks.include?(error) && @error_blocks.length >= ERRORS_LIMIT
+        Appsignal.internal_logger.warn "Appsignal::Transaction#add_error: Transaction has more " \
+          "than #{ERRORS_LIMIT} distinct errors. Only the first " \
+          "#{ERRORS_LIMIT} distinct errors will be reported."
+        return
+      end
+      @error_blocks[error] << block
+      @error_blocks[error].compact!
+    end
+
     private
 
     attr_reader :breadcrumbs

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "4.3.3"
+  VERSION = "4.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 4.3.3
+  version: 4.4.0
 platform: ruby
 authors:
 - Robert Beekman
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-17 00:00:00.000000000 Z
+date: 2025-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logger
@@ -315,7 +315,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.5.23
 signing_key:
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com