appsignal 4.0.2 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 898cc61dd09079372dd341fcc77815283720d773a249c951383ac4be7ce031d8
-  data.tar.gz: 2d3d8fa4dfe45a3a42c89955bd243cd2c7871b3f2ac2978e7bef8333b6518b5e
+  metadata.gz: 41324be9bb4bd42bfcee997c778b0ae1eb0a1a773e044503eab2466779f3bcb7
+  data.tar.gz: 1ab95f249d94eedba7e86e36d3f74d217bd57deed236e6b352b190dc34007eb5
 SHA512:
-  metadata.gz: 492ff15286cd7d5ce8064e57ca959dc9b308fc452237463a35b0d64d978bc1b6bff834b078af6a6a19fa0881e88ccb21d24c9f25d7f7a4c721435423d3b81d75
-  data.tar.gz: 52e9a83f45fe345d895453e38833047c305f0b474918d8510148959a87a8e1ae797773213082152a03a19f8fd9cd7adfc37b5b0b6c33572f97fd9fdf3d67b5e1
+  metadata.gz: f8e8e89b583dc585b83fcfc70378f5090e0854d7c19b2f375a68739fc1325bcd184d8ab678fdb68af55e32d81d60ecbb764d3768f0d2c02ea6d1a974b808018c
+  data.tar.gz: d25b331756ceafe336d5b430577fb98da0696f5f92613a47d89f30007b910a4057cf981ddb1d841d295cfdb31f48d69bb8fecb1e7071d933dba47b1160d701bf

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # AppSignal for Ruby gem Changelog
 
+## 4.0.3
+
+_Published on 2024-08-26._
+
+### Changed
+
+- Do not report Sidekiq `Sidekiq::JobRetry::Handled` and `Sidekiq::JobRetry::Skip` errors. These errors would be reported by our Rails error subscriber. These are an internal Sidekiq errors we do not need to report. (patch [e385ee2c](https://github.com/appsignal/appsignal-ruby/commit/e385ee2c4da13063e6f1a7a207286dda74113fc4))
+
+### Removed
+
+- Remove the `app_path` writer in the `Appsignal.configure` helper. This was deprecated in version 3.x. It is removed now in the next major version.
+
+  Use the `root_path` keyword argument in the `Appsignal.configure` helper (`Appsignal.configure(:root_path => "...")`) to change the AppSignal root path if necessary.
+
+  (patch [6335da6d](https://github.com/appsignal/appsignal-ruby/commit/6335da6d99a5ba7687fb5885eee27b9633d80474))
+
 ## 4.0.2
 
 _Published on 2024-08-23._

data/lib/appsignal/config.rb

@@ -225,7 +225,7 @@ module Appsignal
     #   How to integrate AppSignal manually
     def initialize(
       root_path,
-      initial_env,
+      env,
       logger = Appsignal.internal_logger
     )
       @root_path = root_path
@@ -234,8 +234,7 @@ module Appsignal
       @logger = logger
       @valid = false
 
-      @initial_env = initial_env
-      @env = initial_env.to_s
+      @env = env.to_s
       @config_hash = {}
       @system_config = {}
       @loaders_config = {}
@@ -270,7 +269,7 @@ module Appsignal
       end
 
       # Track origin of env
-      @initial_config[:env] = @initial_env.to_s
+      @initial_config[:env] = @env
 
       # Load the config file if it exists
       @file_config = load_from_disk || {}
@@ -560,14 +559,6 @@ module Appsignal
         @config.root_path
       end
 
-      def app_path=(_path)
-        Appsignal::Utils::StdoutAndLoggerMessage.warning \
-          "The `Appsignal.configure`'s `app_path=` writer is deprecated " \
-            "and can no longer be used to set the root path. " \
-            "Use the `Appsignal.configure`'s method `root_path` keyword argument " \
-            "to set the root path."
-      end
-
       def env
         @config.env
       end

data/lib/appsignal/integrations/railtie.rb

@@ -102,14 +102,9 @@ module Appsignal
 
         private
 
-        IGNORED_ERRORS = [
-          # We don't need to alert Sidekiq job skip errors.
-          # This is an internal Sidekiq error.
-          "Sidekiq::JobRetry::Skip"
-        ].freeze
-
         def ignored_error?(error)
-          IGNORED_ERRORS.include?(error.class.name)
+          # We don't need to alert about Sidekiq job internal errors.
+          defined?(Sidekiq::JobRetry::Handled) && error.is_a?(Sidekiq::JobRetry::Handled)
         end
 
         def context_for(context)

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "4.0.2"
+  VERSION = "4.0.3"
 end

data/spec/lib/appsignal/config_spec.rb

@@ -1363,30 +1363,5 @@ describe Appsignal::Config do
 
       expect(dsl.cpu_count).to eq(1.0)
     end
-
-    describe "#app_path=" do
-      it "prints a deprecation warning" do
-        err_stream = std_stream
-        capture_std_streams(std_stream, err_stream) do
-          dsl.app_path = "foo"
-        end
-
-        expect(err_stream.read).to include(
-          "appsignal WARNING: The `Appsignal.configure`'s `app_path=` writer is deprecated"
-        )
-      end
-
-      it "logs a deprecation warning" do
-        logs =
-          capture_logs do
-            silence { dsl.app_path = "foo" }
-          end
-
-        expect(logs).to contains_log(
-          :warn,
-          "The `Appsignal.configure`'s `app_path=` writer is deprecated"
-        )
-      end
-    end
   end
 end

data/spec/lib/appsignal/environment_spec.rb

@@ -115,12 +115,33 @@ describe Appsignal::Environment do
   end
 
   describe ".report_supported_gems" do
-    it "reports about all AppSignal supported gems in the bundle" do
+    it "reports about all AppSignal supported gems in the bundle using Bundler all_specs" do
       logs = capture_logs { described_class.report_supported_gems }
 
       expect(logs).to be_empty
 
-      bundle_gem_specs = ::Bundler.rubygems.all_specs
+      if Bundler.rubygems.respond_to?(:all_specs)
+        skip "Using new Bundler version without `all_specs` method"
+      end
+      bundle_gem_specs = silence { ::Bundler.rubygems.all_specs }
+      rack_spec = bundle_gem_specs.find { |s| s.name == "rack" }
+      rake_spec = bundle_gem_specs.find { |s| s.name == "rake" }
+      expect_environment_metadata("ruby_rack_version", rack_spec.version.to_s)
+      expect_environment_metadata("ruby_rake_version", rake_spec.version.to_s)
+      expect(rack_spec.version.to_s).to_not be_empty
+      expect(rake_spec.version.to_s).to_not be_empty
+    end
+
+    it "reports about all AppSignal supported gems in the bundle using bundler installed_specs" do
+      unless Bundler.rubygems.respond_to?(:installed_specs)
+        skip "Using old Bundler version without `installed_specs` method"
+      end
+
+      logs = capture_logs { described_class.report_supported_gems }
+
+      expect(logs).to be_empty
+
+      bundle_gem_specs = ::Bundler.rubygems.installed_specs
       rack_spec = bundle_gem_specs.find { |s| s.name == "rack" }
       rake_spec = bundle_gem_specs.find { |s| s.name == "rake" }
       expect_environment_metadata("ruby_rack_version", rack_spec.version.to_s)

data/spec/lib/appsignal/integrations/railtie_spec.rb

@@ -229,15 +229,36 @@ if DependencyHelper.rails_present?
           expect(last_transaction).to have_error("ExampleStandardError", "error message")
         end
 
-        it "ignores Sidekiq::JobRetry::Skip errors" do
-          require "sidekiq"
-          require "sidekiq/job_retry"
+        context "Sidekiq internal errors" do
+          before do
+            require "sidekiq"
+            require "sidekiq/job_retry"
+          end
 
-          with_rails_error_reporter do
-            Rails.error.handle { raise Sidekiq::JobRetry::Skip, "error message" }
+          it "ignores Sidekiq::JobRetry::Handled errors" do
+            with_rails_error_reporter do
+              Rails.error.handle { raise Sidekiq::JobRetry::Handled, "error message" }
+            end
+
+            expect(last_transaction).to_not have_error
           end
 
-          expect(last_transaction).to_not have_error
+          it "ignores Sidekiq::JobRetry::Skip errors" do
+            with_rails_error_reporter do
+              Rails.error.handle { raise Sidekiq::JobRetry::Skip, "error message" }
+            end
+
+            expect(last_transaction).to_not have_error
+          end
+
+          it "doesn't crash when no Sidekiq error classes are found" do
+            hide_const("Sidekiq::JobRetry")
+            with_rails_error_reporter do
+              Rails.error.handle { raise ExampleStandardError, "error message" }
+            end
+
+            expect(last_transaction).to have_error("ExampleStandardError", "error message")
+          end
         end
 
         context "when no transaction is active" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 4.0.2
+  version: 4.0.3
 platform: ruby
 authors:
 - Robert Beekman
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-23 00:00:00.000000000 Z
+date: 2024-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack