appsignal 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a51d521ee51d28f13d297b5dd7e00291a701dda4e3e0a639779b5c52c9e0551
-  data.tar.gz: ec09dc858c399b9004cebb9afcdb1e041ba4f0efd068f173c6177e2bb5d10b1c
+  metadata.gz: 388a88a0721342be7efbc7e0398bc42b96d1958805ca58785da79835305114b5
+  data.tar.gz: a966ab77ff86d6620d1f66f09bec4858e35c796fc2998f5fa14ce72a595136b6
 SHA512:
-  metadata.gz: c8d87696bdeb0bf26784c001b67c9fb1201120ad325671b959cf807317dc3c2e948a62c8ce3e5618abc44ae2b5f30b66ee2414e72ee7eb1c55728a001717665e
-  data.tar.gz: 6da6a43068a8edf31158269f956be507f2125ec61dd8374192f228582c730862a5a659d5b2f530e7c995264e571d2e27daf049367089608dcdbbb63b5db16ef9
+  metadata.gz: 0c0518fb68bde59898885efe4c0ab89c596aa9002565bb608ad836262392fe4c9700cfe39c117818a26ddf2e0982bcef050b84e09e91a7f3100d3bb659e6d9d4
+  data.tar.gz: cc80c914a1ca31432f72a136976ef409429baa79d0dc1480d213fa10bcfa627f8c0aabad267aedfdc1506285f0a4fc396424c4f741564fb3e4937898bdef3ccc

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # AppSignal for Ruby gem Changelog
 
+## 4.0.1
+
+_Published on 2024-08-23._
+
+### Fixed
+
+- Do not report `Sidekiq::JobRetry::Skip` errors. These errors would be reported by our Rails error subscriber. This is an internal Sidekiq error we do not need to report. (patch [9ea2d3e8](https://github.com/appsignal/appsignal-ruby/commit/9ea2d3e83657d115baf166257a50c7e3394318aa))
+- Do not report `SystemExit` errors from our `at_exit` error reporter. (patch [e9c0cad3](https://github.com/appsignal/appsignal-ruby/commit/e9c0cad3d672e68a63ca9c33cfa30a3434c77d04))
+
 ## 4.0.0
 
 _Published on 2024-08-23._

data/lib/appsignal/hooks/at_exit.rb

@@ -24,6 +24,7 @@ module Appsignal
       class AtExitCallback
         def self.call
           error = $! # rubocop:disable Style/SpecialGlobalVars
+          return if ignored_error?(error)
           return if Appsignal::Transaction.last_errors.include?(error)
 
           Appsignal.report_error(error) do |transaction|
@@ -31,6 +32,15 @@ module Appsignal
           end
           Appsignal.stop("at_exit")
         end
+
+        IGNORED_ERRORS = [
+          # Normal exits from the application we do not need to report
+          SystemExit
+        ].freeze
+
+        def self.ignored_error?(error)
+          IGNORED_ERRORS.include?(error.class)
+        end
       end
     end
   end

data/lib/appsignal/integrations/railtie.rb

@@ -80,6 +80,8 @@ module Appsignal
     class RailsErrorReporterSubscriber
       class << self
         def report(error, handled:, severity:, context: {}, source: nil) # rubocop:disable Lint/UnusedMethodArgument
+          return if ignored_error?(error)
+
           is_rails_runner = source == "application.runner.railties"
           namespace, action_name, tags, custom_data = context_for(context.dup)
 
@@ -100,6 +102,16 @@ module Appsignal
 
         private
 
+        IGNORED_ERRORS = [
+          # We don't need to alert Sidekiq job skip errors.
+          # This is an internal Sidekiq error.
+          "Sidekiq::JobRetry::Skip"
+        ].freeze
+
+        def ignored_error?(error)
+          IGNORED_ERRORS.include?(error.class.name)
+        end
+
         def context_for(context)
           tags = {}
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "4.0.0"
+  VERSION = "4.0.1"
 end

data/spec/lib/appsignal/hooks/at_exit_spec.rb

@@ -59,7 +59,7 @@ describe Appsignal::Hooks::AtExit::AtExitCallback do
     end
   end
 
-  it "doesn't report the error if is also the last error reported" do
+  it "doesn't report the error if it is also the last error reported" do
     with_error(ExampleException, "error message") do |error|
       Appsignal.report_error(error)
       expect(created_transactions.count).to eq(1)
@@ -69,4 +69,15 @@ describe Appsignal::Hooks::AtExit::AtExitCallback do
       end.to_not change { created_transactions.count }.from(1)
     end
   end
+
+  it "doesn't report the error if it is a SystemExit exception" do
+    with_error(SystemExit, "error message") do |error|
+      Appsignal.report_error(error)
+      expect(created_transactions.count).to eq(1)
+
+      expect do
+        call_callback
+      end.to_not change { created_transactions.count }.from(1)
+    end
+  end
 end

data/spec/lib/appsignal/integrations/railtie_spec.rb

@@ -229,6 +229,17 @@ if DependencyHelper.rails_present?
           expect(last_transaction).to have_error("ExampleStandardError", "error message")
         end
 
+        it "ignores Sidekiq::JobRetry::Skip errors" do
+          require "sidekiq"
+          require "sidekiq/job_retry"
+
+          with_rails_error_reporter do
+            Rails.error.handle { raise Sidekiq::JobRetry::Skip, "error message" }
+          end
+
+          expect(last_transaction).to_not have_error
+        end
+
         context "when no transaction is active" do
           it "reports the error on a new transaction" do
             with_rails_error_reporter do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Robert Beekman