appsignal 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: adfc426b4de03866b5598de0917060befa98d748ef29ca3ddf91ce2c2038550a
-  data.tar.gz: 9eb6f73987c6430543a3456d3931e861d9959a24ea2416c51a6a64004926dbd5
+  metadata.gz: f73ddc957c9f0fd0fd13008f5ef1caea0a9248b70fc6b21a929e607b815dedb1
+  data.tar.gz: 7df48cb0e05e402266198605774661d3ab62dd3952e8770ec7ab4295ab9bed5a
 SHA512:
-  metadata.gz: e9242f6fb0b269ddfcf90bccea590573c2f4bca81790723c3fa198caa4a2eca9311daea2da37eb091440578f4d98771f25d96123286ffa48a54d9d640c7652a0
-  data.tar.gz: 19c4e6886eae5303d0a34736ca22b1fed49e5b20e959b321eb4205d59f27b8c38150c484d58817c67652603495ab76aec51ac710e1de82026c257e4fabc98325
+  metadata.gz: 69dafc14fccd8c5c1ed793563ea0e2c19ce4f58404a1b1dd9d185f83ae1c5996105102e13619612d210c86742ac437c217a66f623f1bb138389df4c8483d9f9d
+  data.tar.gz: 2e3c70b487c91c73d61e5d876cf053d4c6477505ec1d47f3766b7dd4afd9196b78f817def8440c3668609f16d09e468ef1fb7f8712a923bf6034def75dd5c0a2

data/CHANGELOG.md

@@ -1,4 +1,10 @@
-# Changelog
+# AppSignal for Ruby gem Changelog
+
+## 3.0.5
+
+- [4bddac36](https://github.com/appsignal/appsignal-ruby/commit/4bddac3618ccea03c165eec53cee90e222b68cd6) patch - Skip empty HTTP proxy config. When any of the HTTP proxy config returns an
+  empty string, skip this config. This fixes installation issues where an empty
+  String is used as a HTTP proxy, causing a RuntimeError upon installation.
 
 ## 3.0.4
 
@@ -6,22 +12,22 @@
   these messages in debug mode. This should reduce the noise for users running
   AppSignal with the STDOUT logger, such as is the default on Heroku.
 
-# 3.0.3
+## 3.0.3
 - Fix deprecation message for set_error namespace argument. PR #712
 - Fix example code for Transaction#set_namespace method. PR #713
 - Fix extension fallbacks on extension installation failure, that caused
 - NoMethodErrors. PR #720
 - Bump agent to v-75e76ad. PR #721
 
-# 3.0.2
+## 3.0.2
 - Fix error on Rails boot when `enable_frontend_error_catching` is `true`.
   PR #711
 
-# 3.0.1
+## 3.0.1
 - Fix error occurring on APPSIGNAL_DNS_SERVER environment variable option
   parsing. PR #709
 
-# 3.0.0
+## 3.0.0
 
 Please read our [upgrade from version 2 to 3 guide][upgrade3] before upgrading.
 
@@ -37,46 +43,46 @@ Please read our [upgrade from version 2 to 3 guide][upgrade3] before upgrading.
 - Add Sidekiq error handler. Report more Sidekiq errors that happen around job
   execution. PR #699
 
-# 2.11.9
+## 2.11.9
 - Fix and simplify Ruby method delegation for object method instrumentation in
   the different Ruby versions. PR #706
 
-# 2.11.8
+## 2.11.8
 - Mark minutely probe thread as fork-safe by @pixeltrix. PR #704
 
-# 2.11.7
+## 2.11.7
 - Fix ActionCable integration in test environment using `stub_connection`.
   PR #705
 
-# 2.11.6
+## 2.11.6
 - Prepend Sidekiq middleware to wrap all Sidekiq middleware. Catches more
   errors and provide more complete performance measurements. PR #698
 
-# 2.11.5
+## 2.11.5
 - Add more detailed logging to finish_event calls when the event is unknown, so
   we know what event is being tried to finish. Commit
   c888a04d1b9ac947652b29c111c650fb5a5cf71c
 
-# 2.11.4
+## 2.11.4
 - Support Ruby 3.0 for Object method instrumentation with keyword arguments
   (https://docs.appsignal.com/ruby/instrumentation/method-instrumentation.html)
   PR #693
 
-# 2.11.3
+## 2.11.3
 - Support Shoryuken batch workers. PR #687
 
-# 2.11.2
+## 2.11.2
 - Support Ruby 3.0. PR #681
 - Support breadcrumbs. PR #666
 - Log Ruby errors on extension download. PR #679
 - Fix Ruby 1.9 build. PR #680
 
-# 2.11.1
+## 2.11.1
 - Support AS notifications instrumenters that use `start` and `finish`.
 - Updated agent with better logging and an IO stats fix.
 - ActionMailer magic dashboard
 
-# 2.11.0
+## 2.11.0
 - Track queue time regardless of namespace. Support custom namespaces. PR #602
 - Improve deprecation message from frontend error middleware. PR #620
 - Report Ruby environment metadata. PR #621, #627, #619, #618
@@ -103,20 +109,20 @@ Please read our [upgrade from version 2 to 3 guide][upgrade3] before upgrading.
 - Update AuthCheck class to use DeprecationMessage helper. PR #649
 - Print extension load error when AppSignal is loaded. PR #651
 
-# 2.10.12
+## 2.10.12
 - Fix `working_directory_path` config option loaded from environment variables.
   PR #653
 
-# 2.10.11
+## 2.10.11
 - Fix extension install report status output in `appsignal diagnose`. PR #636
 - Support setting a specific configuration file to load with the
   `Appsignal::Config` initializer. PR #638
 
-# 2.10.10
+## 2.10.10
 - Bump agent to v-4548c88. PR #634
   - Fix issue with host metrics values being reported as "Infinity".
 
-# 2.10.9
+## 2.10.9
 - Use http proxy if configured when downloading agent. PR #606
 - Clear event details cache every 48 hours.
   Commit eb5e899db69fcd7cfa221567bfd6ac04f2654c9c

data/ext/base.rb

@@ -184,7 +184,18 @@ def store_download_version_on_report
 end
 
 def http_proxy
-  Gem.configuration[:http_proxy] || ENV["http_proxy"] || ENV["HTTP_PROXY"]
+  proxy = try_http_proxy_value(Gem.configuration[:http_proxy])
+  return proxy if proxy
+
+  proxy = try_http_proxy_value(ENV["http_proxy"])
+  return proxy if proxy
+
+  proxy = try_http_proxy_value(ENV["HTTP_PROXY"])
+  return proxy if proxy
+end
+
+def try_http_proxy_value(value)
+  value if value.respond_to?(:empty?) && !value.strip.empty?
 end
 
 # Fail the installation on purpose in a specific test environment.

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "3.0.4".freeze
+  VERSION = "3.0.5".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Robert Beekman
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-10 00:00:00.000000000 Z
+date: 2021-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack