appsignal 2.9.6-java → 2.9.7-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92a3e8d10cd1fdf02f0ba5fc2083cc3524a3f3b3882e1e1686df719ca1280473
-  data.tar.gz: 8a92cc47146720f2ba0bd8be84190577b9717c8f6d0ee39cfe28727efb59de9d
+  metadata.gz: 1191a88284d057b5c51ac3c2b7eb60d3a89718b916669c0036b7d837773f752b
+  data.tar.gz: d957119f4ebb9f0a2d2ba015880a3a7d6be93ef33a26a9a7b3e7430ce6718027
 SHA512:
-  metadata.gz: f20caec585b2f0eb8c705cfd3d6c9ac26e44840a42d960f642d6b268f374f1ebd16f672c2d5d54343e65b4ec43b0e525416662fda735168d6297f50484460e2a
-  data.tar.gz: fc1859e2c96b8a36fc4aef021f5702e1082d54866817a1f234b0f080f843f7cfa7df5abd923fa1fbe60507522b0a600f165a7d7e0bc9297921f596378590a818
+  metadata.gz: 9b3e5a0947a8ffd0130a975843913fa232e20c2874d4f0153cba370db27995b7d41cae025ff2ec271bd378cadeab86dbf57e49543f446c8fac07a53a3c618930
+  data.tar.gz: c8bf4f9b49cca25cdc6c7f02d36e74cd6a10c6b9ad4614a4f6c25409ba03c4069fe1bff7eb1f3c3580a069fffb936ac8dfe39da29efd0caab50bf4f3b106a48a

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 2.9.7
+- Fix minutely probes not being loaded from Rails initializers. PR #528
+
 ## 2.9.6
 - Print link to diagnose docs on unsuccessful demo command. PR #512
 - Add support for minutely probe `.dependencies_present?` check. PR #523

data/lib/appsignal/cli/diagnose/utils.rb

@@ -6,12 +6,14 @@ module Appsignal
           passwd_struct = Etc.getpwuid(uid)
           return unless passwd_struct
           passwd_struct.name
+        rescue ArgumentError # rubocop:disable Lint/HandleExceptions
         end
 
         def self.group_for_gid(gid)
           passwd_struct = Etc.getgrgid(gid)
           return unless passwd_struct
           passwd_struct.name
+        rescue ArgumentError # rubocop:disable Lint/HandleExceptions
         end
 
         def self.read_file_content(path, bytes_to_read)

data/lib/appsignal/minutely.rb

@@ -135,9 +135,9 @@ module Appsignal
       # @api private
       def start
         stop
-        initialize_probes
         @@thread = Thread.new do
           sleep initial_wait_time
+          initialize_probes
           loop do
             logger = Appsignal.logger
             logger.debug("Gathering minutely metrics with #{probe_instances.count} probes")

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "2.9.6".freeze
+  VERSION = "2.9.7".freeze
 end

data/spec/lib/appsignal/cli/diagnose/utils_spec.rb

@@ -1,6 +1,46 @@
 require "appsignal/cli/diagnose/utils"
 
 describe Appsignal::CLI::Diagnose::Utils do
+  describe ".username_for_uid" do
+    subject { described_class.username_for_uid(uid) }
+
+    context "when user with id exists" do
+      let(:uid) { 0 }
+
+      it "returns username" do
+        is_expected.to be_kind_of(String)
+      end
+    end
+
+    context "when user with id does not exist" do
+      let(:uid) { -1 }
+
+      it "returns nil" do
+        is_expected.to be_nil
+      end
+    end
+  end
+
+  describe ".group_for_gid" do
+    subject { described_class.group_for_gid(uid) }
+
+    context "when group with id exists" do
+      let(:uid) { 0 }
+
+      it "returns group name" do
+        is_expected.to be_kind_of(String)
+      end
+    end
+
+    context "when group with id does not exist" do
+      let(:uid) { -3 }
+
+      it "returns nil" do
+        is_expected.to be_nil
+      end
+    end
+  end
+
   describe ".read_file_content" do
     let(:path) { File.join(spec_system_tmp_dir, "test_file.txt") }
     let(:bytes_to_read) { 100 }

data/spec/lib/appsignal/minutely_spec.rb

@@ -167,33 +167,6 @@ describe Appsignal::Minutely do
         thread && thread.join # Wait for old thread to exit
       end.to_not(change { alive_thread_counter.call })
     end
-
-    # Wait for a condition to be met
-    #
-    # @example
-    #   # Perform threaded operation
-    #   wait_for("enough probe calls") { probe.calls >= 2 }
-    #   # Assert on result
-    #
-    # @param name [String] The name of the condition to check. Used in the
-    #   error when it fails.
-    # @yield Assertion to check.
-    # @yieldreturn [Boolean] True/False value that indicates if the condition
-    #   is met.
-    # @raise [StandardError] Raises error if the condition is not met after 5
-    #   seconds, 5_000 tries.
-    def wait_for(name)
-      max_wait = 5_000
-      i = 0
-      while i <= max_wait
-        break if yield
-        i += 1
-        sleep 0.001
-      end
-
-      return unless i == max_wait
-      raise "Waited 5 seconds for #{name} condition, but was not met."
-    end
   end
 
   describe ".stop" do
@@ -214,6 +187,9 @@ describe Appsignal::Minutely do
       Appsignal::Minutely.probes.register :my_probe, -> {}
       Appsignal::Minutely.start
       thread = Appsignal::Minutely.class_variable_get(:@@thread)
+      wait_for("probes initialized") do
+        !Appsignal::Minutely.send(:probe_instances).empty?
+      end
       expect(Appsignal::Minutely.send(:probe_instances)).to_not be_empty
       Appsignal::Minutely.stop
       thread.join
@@ -336,4 +312,31 @@ describe Appsignal::Minutely do
       end
     end
   end
+
+  # Wait for a condition to be met
+  #
+  # @example
+  #   # Perform threaded operation
+  #   wait_for("enough probe calls") { probe.calls >= 2 }
+  #   # Assert on result
+  #
+  # @param name [String] The name of the condition to check. Used in the
+  #   error when it fails.
+  # @yield Assertion to check.
+  # @yieldreturn [Boolean] True/False value that indicates if the condition
+  #   is met.
+  # @raise [StandardError] Raises error if the condition is not met after 5
+  #   seconds, 5_000 tries.
+  def wait_for(name)
+    max_wait = 5_000
+    i = 0
+    while i <= max_wait
+      break if yield
+      i += 1
+      sleep 0.001
+    end
+
+    return unless i == max_wait
+    raise "Waited 5 seconds for #{name} condition, but was not met."
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.9.6
+  version: 2.9.7
 platform: java
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-30 00:00:00.000000000 Z
+date: 2019-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack