appsignal 2.8.0 → 2.8.1.alpha.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44c65af079aaf661799b20d076f1c5f11eb6bdb47ccdc6aa58dc85781c46d8c7
-  data.tar.gz: 3448422ae801b26eb40ba300016331a85e233fa33e5332971c1529b95fe934d6
+  metadata.gz: 6e0fd938587f34bee839867fa82429bdf95bbd6b5f49720a01eb6fdeac029045
+  data.tar.gz: a854ec47f1be275ac6ac48116458bb6c1547e27af142e513dbca1a21387b03f2
 SHA512:
-  metadata.gz: 610f635119df8b05bdaa3b01cd646594235dd51addde01d96d9433caac12b3c347518e70d941a3a14b594623698952501e09758c9207984aa1209af0bdd8032f
-  data.tar.gz: 4995bd83545cc983821c90e9f1dae888bf6199a703e98a8026b4e8771ec7cf326f8344c2cd9328482c2ca78e785a0ed11f085f63832430cb6c92247056cc6655
+  metadata.gz: 267a3d4ae5fc3805e9427494d1a4c3472f7a85fd12ca9645e486e1aca98623637e2d7b6dab5192d662c1f74903091d6508df168c1c0d92ef49f83cddae3e0f17
+  data.tar.gz: 2e25ece6dd6b5551ce8bc86ba25a6b955f819ddada78ee599cfbd4357cc7a437ca2be73f99a662ddb923f636003ff85e0d717914a29f5c39ee56d0abffad6788

data/.travis.yml

@@ -15,6 +15,7 @@ rvm:
   - "2.3.8"
   - "2.4.5"
   - "2.5.3"
+  - "2.6.0"
   - "jruby-19mode"
 
 gemfile:
@@ -56,6 +57,10 @@ matrix:
       gemfile: "gemfiles/rails-4.0.gemfile"
     - rvm: "2.5.3"
       gemfile: "gemfiles/rails-4.1.gemfile"
+    - rvm: "2.6.0"
+      gemfile: "gemfiles/rails-4.0.gemfile"
+    - rvm: "2.6.0"
+      gemfile: "gemfiles/rails-4.1.gemfile"
 
   allow_failures:
     - rvm: "2.4.5"
@@ -70,9 +75,12 @@ env:
     - "JRUBY_OPTS=''" # Workaround https://github.com/travis-ci/travis-ci/issues/6471
 
 before_install:
-  - "gem update --system"
+  - "gem update --system 2.7.8"
   - "gem update bundler"
 before_script:
   - "bundle exec rake extension:install"
+after_failure:
+  - "find . -name ext/install.log -exec cat {} \\;"
+  - "find . -name ext/mkmf.log -exec cat {} \\;"
 
 script: "bundle exec rake test"

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 2.8.1
+- Fix installation on Ruby 2.6 for libc and musl library builds. PR #453
+
 # 2.8.0
 - Group extension and agent tests in diagnose output. PR #437
 - Add diagnose --[no-]send-report option. PR #438

data/Rakefile

@@ -239,6 +239,7 @@ namespace :extension do
           appsignal-agent \
           appsignal.h \
           appsignal_extension.o \
+          appsignal_extension.so \
           appsignal_extension.bundle \
           install.log \
           libappsignal.* \

data/ext/extconf.rb

@@ -1,7 +1,7 @@
 require File.expand_path("../../lib/appsignal/version.rb", __FILE__)
 require File.expand_path("../base.rb", __FILE__)
 
-def install
+def install # rubocop:disable Metrics/CyclomaticComplexity
   logger.info "Installing appsignal agent #{Appsignal::VERSION} for Ruby #{RUBY_VERSION} on #{RUBY_PLATFORM}"
   write_agent_architecture
   return unless check_architecture
@@ -16,18 +16,22 @@ def install
     unarchive(archive)
   end
 
+  is_linux_system = [
+    Appsignal::System::LINUX_TARGET,
+    Appsignal::System::MUSL_TARGET
+  ].include?(PLATFORM)
+
   logger.info "Creating makefile"
   require "mkmf"
+
+  link_libraries if is_linux_system
+
   if !have_library("appsignal", "appsignal_start", "appsignal.h")
     installation_failed "Aborting installation, libappsignal.a or appsignal.h not found"
   elsif !find_executable("appsignal-agent", EXT_PATH)
     installation_failed "Aborting installation, appsignal-agent not found"
   else
-    with_static_link = [
-      Appsignal::System::LINUX_TARGET,
-      Appsignal::System::MUSL_TARGET
-    ].include?(PLATFORM)
-    if with_static_link
+    if is_linux_system
       # Statically link libgcc and libgcc_s libraries.
       # Dependencies of the libappsignal extension library.
       # If the gem is installed on a host with build tools installed, but is
@@ -45,4 +49,34 @@ rescue => ex
   end
 end
 
+# Ruby 2.6 requires us to statically link more libraries we use in our
+# extension library than previous versions. Needed for normal Linux libc
+# and musl builds.
+def link_libraries
+  if RbConfig::CONFIG["THREAD_MODEL"] == "pthread"
+    logger.info "Linking extension against 'pthread' library"
+    # Link gem extension against pthread library
+    have_library "pthread"
+    have_required_function "pthread_create"
+  end
+
+  # Links gem extension against the `dl` library. This is needed when Ruby is
+  # not linked against `dl` itself, so link it on the gem extension.
+  logger.info "Linking extension against 'dl' library"
+  have_library "dl"
+  # Check if functions are available now from the linked library
+  %w[dlopen dlclose dlsym].each do |func|
+    have_required_function func
+  end
+end
+
+def have_required_function(func) # rubocop:disable Naming/PredicateName
+  return if have_func(func)
+
+  installation_failed "Aborting installation, missing function '#{func}'"
+  # Exit with true/0/success because the AppSignal installation should never
+  # break a build
+  exit
+end
+
 install

data/gemfiles/capistrano3.gemfile

@@ -1,6 +1,7 @@
 source 'https://rubygems.org'
 
 gem 'capistrano', '~> 3.0'
+gem 'i18n', '~> 1.2.0'
 gem 'net-ssh', '2.9.2'
 gem 'rack', '~> 1.6'
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "2.8.0".freeze
+  VERSION = "2.8.1.alpha.1".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.8.0
+  version: 2.8.1.alpha.1
 platform: ruby
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-20 00:00:00.000000000 Z
+date: 2018-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -364,12 +364,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com