appsignal 0.9.5 → 0.9.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 548376adc60aed0084092d6088e3949df194190c
-  data.tar.gz: fba4858b4cb9603946311dcc244c47f6bbf26b0a
+  metadata.gz: 60fe669e8daa8b4015255cecaaa4f785b8fce679
+  data.tar.gz: f04514a5ba7022f74f1c7657a06ae584f968fa03
 SHA512:
-  metadata.gz: 3f6f27716d46a3b8f3a17046bca5b4415406aefc6af0d6810f934abf646b2148c59b968a00225ad2aa224f6673d33492eb94e3e358ee1670d43be9a54241e9e2
-  data.tar.gz: c491d2e9401ea8c68436f3f770d22a36cd45cd32c4b8ccba5b9f43921622f0b64cc5d08bbb2a6589ef28c0bb3642d1b61c1e6693e1e441866ac1c324ad0e8152
+  metadata.gz: 7b0c0d4c2557517439b529f95e9e71dec934ddd44a4f4b080516faad591efb5d4392816d2d839ac0a1309b236e21e51ad1552d6a1f56033440d8f912124d10dd
+  data.tar.gz: 72cb94912a40af82c53e166600d238f197b1c8373060e93e1100d0a6aabf55dc122f9495dd0c7f2dfc27be49d102162dd9e90955698008ef047e0b32a1377d9d

data/CHANGELOG.md

@@ -1,4 +1,4 @@
-# 0.9.5
+# 0.9.6
 * Convert to primitives before sending through pipe
 
 # 0.9.4
@@ -59,7 +59,7 @@ Yanked
 * Alias tag_request to tag_job, for background jobs
 * Skip sanitization of env if env is nil
 * Small bugfix in forking logic
-* Don't send params if send_params is off in config 
+* Don't send params if send_params is off in config
 * Remove --repository option in CLI
 * Name option in appsignal notify_of_deploy CLI
 * Don't call to_hash on ENV

data/lib/appsignal/transaction.rb

@@ -85,7 +85,7 @@
     end
 
     def exception?
-      !!exception
+      !! exception
     end
 
     def slow_request?
@@ -98,20 +98,32 @@
     end
 
     def truncate!
+      return if truncated?
       process_action_event.payload.clear
       events.clear
       tags.clear
       sanitized_environment.clear
       sanitized_session_data.clear
       @env = nil
+      @truncated = true
+    end
+
+    def truncated?
+      !! @truncated
     end
 
     def convert_values_to_primitives!
+      return if have_values_been_converted_to_primitives?
       Appsignal::Transaction::ParamsSanitizer.sanitize!(@process_action_event.payload) if @process_action_event
       @events.map do |o|
         Appsignal::Transaction::ParamsSanitizer.sanitize(o.payload)
       end
       add_sanitized_context!
+      @have_values_been_converted_to_primitives = true
+    end
+
+    def have_values_been_converted_to_primitives?
+      !! @have_values_been_converted_to_primitives
     end
 
     def type
@@ -129,6 +141,7 @@
       Appsignal.transactions.delete(@request_id)
       if process_action_event || exception?
         if Appsignal::Pipe.current
+          convert_values_to_primitives!
           Appsignal.logger.debug("Writing transaction to pipe: #{@request_id}")
           Appsignal::Pipe.current.write(self)
         else

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.9.5'
+  VERSION = '0.9.6'
 end

data/spec/lib/appsignal/transaction_spec.rb

@@ -234,6 +234,15 @@ describe Appsignal::Transaction do
         subject.process_action_event.payload.should be_empty
         subject.events.should be_empty
         subject.tags.should be_empty
+        subject.truncated?.should be_true
+      end
+
+      it "should not truncate twice" do
+        subject.process_action_event.payload.should_receive(:clear).once
+        subject.events.should_receive(:clear).once
+
+        subject.truncate!
+        subject.truncate!
       end
     end
 
@@ -282,6 +291,14 @@ describe Appsignal::Transaction do
           subject
           event_payload.should == before
         end
+
+        it "should not covert to primitives twice" do
+          transaction.convert_values_to_primitives!
+          transaction.have_values_been_converted_to_primitives?.should be_true
+
+          Appsignal::Transaction::ParamsSanitizer.should_not_receive(:sanitize!)
+          transaction.convert_values_to_primitives!
+        end
       end
     end
 
@@ -355,12 +372,20 @@ describe Appsignal::Transaction do
 
       context 'when using pipes' do
         let(:pipe) { double }
-        before { Appsignal::Pipe.stub(:current => pipe) }
+        before do
+          Appsignal::Pipe.stub(:current => pipe)
+          pipe.stub(:write => true)
+          transaction.stub(:convert_values_to_primitives! => true)
+        end
 
         it "should send itself trough the pipe" do
           pipe.should_receive(:write).with(transaction)
         end
 
+        it "should convert itself to primitives" do
+          transaction.should_receive(:convert_values_to_primitives!)
+        end
+
         after { transaction.complete! }
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.9.5
+  version: 0.9.6
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-06 00:00:00.000000000 Z
+date: 2014-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport