appsignal 0.8.3 → 0.8.4.beta.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2UwODdmZmQyMDg4NDRlYzRkOWUyNWFkYzIxZTE4NTNmZWEyNzRiMQ==
+    MWUyMmRhZDY0NjU1MTNkNWUwZTg3NmZiOTA4YTE0NGY5NWRhMmU5Yw==
   data.tar.gz: !binary |-
-    MWUwM2ZhOTY0NGVjYmVkZWJjOThmYWYxMGJiZDc0N2QwMmU5NzBhMQ==
+    YjljNDc0MDVhYzNjNjYzZjk1ZjRhOTM5MGI0N2Y5YzEyYTBjNGIyZQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MjAzZWI1YTI5ZjYzYjFkZDQ2NmY3OTM5MzZhZWVlMzdmYzNhMWE0MmQxNzk4
-    OWY3NjVlZTUyNjliNjBlYzA0MDc3NTFiMDk3MmFkNDRmYzQ0NDE4YzZjM2Ri
-    MTFhYmI0NzdmMDZiNzZhNDE1ODM5YTBmYTM3NzMwY2Y4NmJkYjg=
+    MTBkM2E1OWJkYmNhZjRmYTdmNTViMjAxNzFjZWI1ZmRkZGE5ZjNiNGFmYjdm
+    ZjA3NGViMzRjZDU5YThmZmU1NjZjOWZhZTUxNzA0ZDBlYjRjOWI2MDc1NGM2
+    NDEwMzM4ZDNhNDhiNmMwMzIxMDFiMDFiNzhmNDA3OWJjMmVlOTA=
   data.tar.gz: !binary |-
-    MGY1OTM5YjA3YjlmOWNkYTQxYTE0ODE5ZTYzODAzMzUxYzViYWZhMGY3OWI0
-    NTRjZjk5MjNkNDIwZTI0NDMyNjZkNzNkNGNiODI2ZGEwMDFjYTM3NzBkYzgz
-    ZmFjZTNiNmZhMjAzYWUwMDE1YWExZmY2ZjY3Yzc5ZTY0Yjc5MTI=
+    N2U1MDE3NGI2MWNkNzc3YzUyOGEwY2Y0NjAyZjE3ODQyODk1MDExMTExOTQ5
+    NjAwOGI5OTE2YzYxZGJlN2Q5NGEwOTRkOGIyNDA0NzUwZGY1NDkzNThiMGMz
+    Mjg0YzA5MmMxYjk1YzZmYjM0Zjc0N2MzNTYxZWRmNzMzMGE4N2E=

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.8.4
+* Skip session sanitize if not a http request
+
 # 0.8.3
 * Restart thread when we've been forked
 * Only notify of deploy when active in capistrano

data/lib/appsignal/transaction.rb

@@ -146,7 +146,7 @@ module Appsignal
 
     def add_sanitized_context!
       sanitize_environment!
-      sanitize_session_data!
+      sanitize_session_data! if kind == 'http_request'
       sanitize_tags!
       @env = nil
     end
@@ -169,8 +169,9 @@ module Appsignal
     end
 
     def sanitize_session_data!
-      @sanitized_session_data =
-        Appsignal::Transaction::ParamsSanitizer.sanitize(request.session.to_hash)
+      @sanitized_session_data = Appsignal::Transaction::ParamsSanitizer.sanitize(
+        request.session.to_hash
+      )
       @fullpath = request.fullpath
     end
   end

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.8.3'
+  VERSION = '0.8.4.beta.0'
 end

data/spec/lib/appsignal/transaction_spec.rb

@@ -401,11 +401,26 @@ describe Appsignal::Transaction do
     describe '#add_sanitized_context!' do
       subject { transaction.send(:add_sanitized_context!) }
 
-      it "delegates to sanitize_environment! and sanitize_session_data!" do
-        transaction.should_receive(:sanitize_environment!)
-        transaction.should_receive(:sanitize_session_data!)
-        transaction.should_receive(:sanitize_tags!)
-        subject
+      context "for a http request" do
+        before { transaction.stub(:kind => 'http_request') }
+
+        it "should call sanitize_environment!, sanitize_session_data! and sanitize_tags!" do
+          transaction.should_receive(:sanitize_environment!)
+          transaction.should_receive(:sanitize_session_data!)
+          transaction.should_receive(:sanitize_tags!)
+          subject
+        end
+      end
+
+      context "for a non-web request" do
+        before { transaction.stub(:kind => 'background_job') }
+
+        it "should not call sanitize_session_data!" do
+          transaction.should_receive(:sanitize_environment!)
+          transaction.should_not_receive(:sanitize_session_data!)
+          transaction.should_receive(:sanitize_tags!)
+          subject
+        end
       end
 
       specify { expect { subject }.to change(transaction, :env).to(nil) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.4.beta.0
 platform: ruby
 authors:
 - Robert Beekman
@@ -237,9 +237,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.3