appsignal 0.8.14 → 0.8.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5788be6b8d6c1a8fc8212a6bb1a9ded51848ddbf
-  data.tar.gz: dc08f114adc8b0f80d8fb8f50cd24ee4955f487a
+  metadata.gz: 14c00518e40685c71256e3fb07a80568198e3660
+  data.tar.gz: dc8a116a4c5541feb03e2df238554253e9284ab5
 SHA512:
-  metadata.gz: 302639852d5022985509eb93c47359ed50692fea43e45d43edb823ab8890c7d2903ea6926702833ece9ce7b98642b1359fe37d016f3f1e959a7c8e49f01d51ba
-  data.tar.gz: 61859592272958a21d17e6c3969715d453295d210e5c689dab61daeec52a939ad4b7a35948e512514d0dada1e67ba3747739dd4d0d2f5feb2108e4817679fa0e
+  metadata.gz: a2aa00e17ba12ffd245e83174e6c35e3bced66796fd42e2335cdb38b0099733f09847e769551140b940565e23eabccae7d20fd8361578f0c3e1f9b01ce1494f9
+  data.tar.gz: ce94868b73e6867ebd738f285b2b596ea9b3fdf95cb844c9fd2a5d68c11c57370a34715bc7e6bfb78dfd7fd9b509489d07439afc1d46cbcc3842fe4cf4abe9ca

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.8.15
+* Exception logging in agent thread
+
 # 0.8.14
 * Few tweaks in logging
 * Clarify Appsignal::Transaction.complete! code

data/lib/appsignal/agent.rb

@@ -24,11 +24,16 @@ module Appsignal
     def start_thread
       Appsignal.logger.debug('Starting agent thread')
       @thread = Thread.new do
-        sleep(rand(sleep_time))
-        loop do
-          send_queue if aggregator.has_transactions?
-          Appsignal.logger.debug("Sleeping #{sleep_time}")
-          sleep(sleep_time)
+        begin
+          sleep(rand(sleep_time))
+          loop do
+            send_queue if aggregator.has_transactions?
+            Appsignal.logger.debug("Sleeping #{sleep_time}")
+            sleep(sleep_time)
+          end
+        rescue Exception=>ex
+          Appsignal.logger.error "#{ex.class} in agent thread: '#{ex.message}'"
+          Appsignal.logger.error ex.backtrace.join('\n')
         end
       end
     end

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.8.14'
+  VERSION = '0.8.15'
 end

data/spec/lib/appsignal/agent_spec.rb

@@ -58,6 +58,28 @@ describe Appsignal::Agent do
         sleep 1
       end
     end
+
+    context "when an exception occurs in the thread" do
+      before do
+        aggregator = double
+        aggregator.stub(:has_transactions?).and_raise(
+          RuntimeError.new('error')
+        )
+        subject.stub(
+          :aggregator => aggregator,
+          :sleep_time => 0.1
+        )
+      end
+
+      it "should log the error" do
+        Appsignal.logger.should_receive(:error).
+          with("RuntimeError in agent thread: 'error'").
+          once
+
+        subject.start_thread
+        sleep 1
+      end
+    end
   end
 
   describe "#restart_thread" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.8.14
+  version: 0.8.15
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-02 00:00:00.000000000 Z
+date: 2014-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport