appsignal 0.8.11 → 0.8.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ec48b20664d56b076ded5a3e0114f294a7c0623
-  data.tar.gz: 6ec31090947b82fd5542665407e55bc8008ff464
+  metadata.gz: eba4ca3bafc6cb95c61c0135695eda9ada7a3128
+  data.tar.gz: 5e89621bb70dfb4cdadde2f996e5d4d83ecab9a6
 SHA512:
-  metadata.gz: 90e7b37d11a139d19c946e457b053e0f5f475c1b404f6b0f467b25899ceb826cc67680d4ad62ea52b1324ec1e66303a94021ca960187c77dacb917e493bae710
-  data.tar.gz: 13d1731f5513fc10d4cfc278969fbf57626b84b02a89a6c3b1e17dfa3b9cc5a0f7a3c8a35ee446fffd3b755c83311d2740c84fd0c611f78e1eda043615e6e8ac
+  metadata.gz: 113615a0525a2904cf5f6873032cc767bda1c842c1524383184dd722e27e3b01b41cda320b4497dd68d4119ff83303f43d55b169f8a3e58ff77f3d7be6d3b26a
+  data.tar.gz: ea517cd6039e98f8cc62f26e5d6e43ef4bf97a1c444f71309652354173874facc9a98075d97ba989235ee6e45624fe7048c5c341b0b286c70e131ebb3c5cd8ee

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.8.12
+* Workaround for frozen string in Notification events
+* Require ActiveSupport::Notifications to be sure it's available
+
 # 0.8.11
 * Skip enqueue, send_exception and add_exception if not active
 

data/lib/appsignal.rb

@@ -3,6 +3,7 @@ require 'rack'
 require 'thread_safe'
 require 'securerandom'
 require 'active_support/json'
+require 'active_support/notifications'
 
 module Appsignal
   class << self

data/lib/appsignal/aggregator/middleware/action_view_sanitizer.rb

@@ -8,7 +8,7 @@ module Appsignal
           if event.name.end_with?(TARGET_EVENT_CATEGORY)
             identifier = event.payload[:identifier]
             if identifier
-              identifier.gsub!(root_path, '')
+              event.payload[:identifier] = identifier.gsub(root_path, '')
             end
           end
           yield

data/lib/appsignal/aggregator/middleware/active_record_sanitizer.rb

@@ -16,7 +16,7 @@ module Appsignal
         def call(event)
           if event.name == TARGET_EVENT_NAME
             unless schema_query?(event) || adapter_uses_prepared_statements?
-              query_string = event.payload[:sql]
+              query_string = event.payload[:sql].dup
               if query_string
                 if adapter_uses_double_quoted_table_names?
                   query_string.gsub!(SINGLE_QUOTE, SANITIZED_VALUE)
@@ -28,6 +28,7 @@ module Appsignal
                 end
                 query_string.gsub!(IN_ARRAY, SANITIZED_VALUE)
                 query_string.gsub!(NUMERIC_DATA, SANITIZED_VALUE)
+                event.payload[:sql] = query_string
               end
             end
             event.payload.delete(:connection_id)

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.8.11'
+  VERSION = '0.8.12'
 end

data/spec/lib/appsignal/aggregator/middleware/action_view_sanitizer_spec.rb

@@ -25,7 +25,19 @@ if rails_present?
       before { sanitizer.call(event) { } }
 
       it "should strip Rails root from the path" do
-        payload[:identifier].should == 'app/views/home/index/html.erb'
+        subject[:identifier].should == 'app/views/home/index/html.erb'
+      end
+
+      context "with a frozen identifier" do
+        let(:payload) do
+          {
+            :identifier => '/var/www/app/20130101/app/views/home/index/html.erb'.freeze
+          }
+        end
+
+        it "should strip Rails root from the path" do
+          subject[:identifier].should == 'app/views/home/index/html.erb'
+        end
       end
     end
   end

data/spec/lib/appsignal/aggregator/middleware/active_record_sanitizer_spec.rb

@@ -142,6 +142,12 @@ if rails_present?
 
         it { should == 'SET client_min_messages TO 22' }
       end
+
+      context "with a a frozen sql string" do
+        let(:sql) { "SELECT `table`.* FROM `table` WHERE `id` = 'secret'".freeze }
+
+        it { should == "SELECT `table`.* FROM `table` WHERE `id` = ?" }
+      end
     end
 
     describe "#schema_query?" do

data/spec/lib/appsignal_spec.rb

@@ -396,9 +396,8 @@ describe Appsignal do
       context "without agent" do
         let(:agent) { nil }
 
-        it "should not change paused state on agent" do
-          agent.should_not_receive(:paused=).with(true)
-          agent.should_not_receive(:paused=).with(false)
+        it "should not crash" do
+          # just execute the after block
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.8.11
+  version: 0.8.12
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-08 00:00:00.000000000 Z
+date: 2014-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport