appsignal 0.6.5 → 0.6.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmExMjg1NjdlMjdlZGQ5MWViMGUwYjI3ZDc5OTViYTgyNTcwYWExZQ==
+    NGQ3NjM0YzRiNjRhZmI0NTY1YmE3OThmZmJkMDE2YzljNDRmZjc4YQ==
   data.tar.gz: !binary |-
-    YmYzOTA3NmQ0NDRiMDEzNjVlMmNiZTFhN2U2M2VjODhmODRmNzY3Ng==
+    ZGM3MmU0NGZlMDk4OTAyNGFkNGMxYTMwN2Y3ZTQyMTMzMmZkNWZkZg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NjcwNDg1NmU2MDc1NGEwNTc5ZmM5ZjQwNDI5Njk1M2Y0NWNhOTVlY2FkMDBl
-    NDkwZDYwZGE1NDBhNGU3MjBmNDI2NjBiMjk3NGM0OGFjNWJiM2VkNGNmNjkx
-    OTE5ZGJjZjYxMTI4ZGFkYjNiN2U1ODJjYzFiYzRlYWZmOGRhNDI=
+    MjRmNTY5YThmNzRlZGRjNWM3ZTA1MmFhMzE5NTEzZWRjOWY2ZDk0ZWYyMjlm
+    MWFlNDkxMzIzYmI5ZTI2MzVhNjE4Njk4OWJmYmRjMWUwZWQ2ODZmYjk3Y2Rh
+    NjE5NjdhMWY1ZjAzMWQ5NjJiYzFmYjFiMzYyYWQ0YWMyNmViNGQ=
   data.tar.gz: !binary |-
-    OWI3NTI4NWEwZWI5MzhhODM1OTQ3NGMwZDM1YTU2NTk3ZjQyZDEyNDIyNTcw
-    N2I3OGYyMDM0Y2FmOGU1Y2VmMGZjZGM4MzVmOGVhNGI1NzUyZjhiYjYzYTEz
-    NzIzYzQwYzc3ZGFmYzNhMmNlZDAxNTk4Yzg0NGE5OGU0MTNmMDg=
+    YWM4NGIzOGVmMDlkZjBjYzgwNGZkYjEyMjU3YWZmNDM0YWRmNzU4OTJmNjYy
+    YWJmYWY4MDY0Zjc5ZjI3OTE0MjMwNzNkMGQ0MjhjY2U4MmJlODUxZTMwZmI5
+    MzhhNWVkNmQwZmVlYzFiMjAxMWM4YzJkMzVmNGZmNWE0YjkzNGY=

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.6.6
+* Add Appsignal.add_exception
+
 # 0.6.5
 * Fix bug where fast requests are tracked with wrong action
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012 80beans
+Copyright (c) 2012-2013 AppSignal
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/appsignal.gemspec

@@ -14,6 +14,7 @@ Gem::Specification.new do |gem|
   gem.summary       = 'Logs performance and exception data from your app to'\
                       'appsignal.com'
   gem.homepage      = 'http://github.com/appsignal/appsignal'
+  gem.license       = 'MIT'
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }

data/lib/appsignal.rb

@@ -27,14 +27,17 @@ module Appsignal
     end
 
     def send_exception(exception)
-      unless is_ignored_exception?(exception)
-        Appsignal.agent
-        env = ENV.to_hash
+      return if is_ignored_exception?(exception)
+      transaction = Appsignal::Transaction.create(SecureRandom.uuid, ENV.to_hash)
+      transaction.add_exception(exception)
+      transaction.complete!
+      Appsignal.agent.send_queue
+    end
 
-        transaction = Appsignal::Transaction.create(SecureRandom.uuid, env)
-        transaction.add_exception(exception)
-        transaction.complete!
-        Appsignal.agent.send_queue
+    def add_exception(exception)
+      return if Appsignal::Transaction.current.nil? || exception.nil?
+      unless is_ignored_exception?(exception)
+        Appsignal::Transaction.current.add_exception(exception)
       end
     end
 

data/lib/appsignal/transaction/transaction_formatter.rb

@@ -12,7 +12,6 @@ module Appsignal
     end
 
     def to_hash
-
       merge_process_action_event_with_log_entry! if process_action_event
       if exception?
         add_exception_to_hash!

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.6.5'
+  VERSION = '0.6.6'
 end

data/spec/appsignal_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 describe Appsignal do
   it { should respond_to :subscriber }
+  let(:transaction) { regular_transaction }
 
   describe ".enqueue" do
-    let(:transaction) { regular_transaction }
     subject { Appsignal.enqueue(transaction) }
 
     it "forwards the call to the agent" do
@@ -126,14 +126,21 @@ describe Appsignal do
   end
 
   describe ".send_exception" do
-    it "should raise exception" do
+    it "should send the exception to AppSignal" do
       agent = double
-      Appsignal.should_receive(:agent).exactly(3).times.and_return(agent)
+      Appsignal.stub(:agent).and_return(agent)
       agent.should_receive(:send_queue)
       agent.should_receive(:enqueue).with(kind_of(Appsignal::Transaction))
 
       Appsignal::Transaction.should_receive(:create).and_call_original
+    end
+
+    it "should not send the exception if it's in the ignored list" do
+      Appsignal.stub(:is_ignored_exception? => true)
+      Appsignal::Transaction.should_not_receive(:create)
+    end
 
+    after do
       begin
         raise "I am an exception"
       rescue Exception => e
@@ -143,7 +150,7 @@ describe Appsignal do
   end
 
   describe ".listen_for_exception" do
-    it "should raise exception" do
+    it "should call send_exception and re-raise" do
       Appsignal.should_receive(:send_exception).with(kind_of(Exception))
       lambda {
         Appsignal.listen_for_exception do
@@ -152,4 +159,37 @@ describe Appsignal do
       }.should raise_error(RuntimeError, "I am an exception")
     end
   end
+
+  describe ".add_exception" do
+    before { Appsignal::Transaction.stub(:current => transaction) }
+    let(:exception) { RuntimeError.new('I am an exception') }
+
+    it "should add the exception to the current transaction" do
+      transaction.should_receive(:add_exception).with(exception)
+
+      Appsignal.add_exception(exception)
+    end
+
+    it "should do nothing if there is no current transaction" do
+      Appsignal::Transaction.stub(:current => nil)
+
+      transaction.should_not_receive(:add_exception).with(exception)
+
+      Appsignal.add_exception(exception)
+    end
+
+    it "should not add the exception if it's in the ignored list" do
+      Appsignal.stub(:is_ignored_exception? => true)
+
+      transaction.should_not_receive(:add_exception).with(exception)
+
+      Appsignal.add_exception(exception)
+    end
+
+    it "should do nothing if the exception is nil" do
+      transaction.should_not_receive(:add_exception)
+
+      Appsignal.add_exception(nil)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.6.6
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-27 00:00:00.000000000 Z
+date: 2013-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -192,7 +192,8 @@ files:
 - spec/support/helpers/notification_helpers.rb
 - spec/support/helpers/transaction_helpers.rb
 homepage: http://github.com/appsignal/appsignal
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []