appsignal 0.6.1 → 0.6.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NWRiZDQ1ZWFiNDBlOTYyOGUxYWNiOGE3ZTU1NTJjZGZlNDBhZjFlOA==
+    YmJjMGRiZGFhZmQxMGU0N2MwMzkzNDQ1YmZhMjlkYzZkMDM0YmJjMA==
   data.tar.gz: !binary |-
-    Yjg5MzZkM2ExODNkNmE5MzViZDliN2I3ZGM3NDA1NDUzMTUyOTI3ZA==
+    YTJhNzg1NTBmMDA4ZDlhZDU3YTgzY2YzNzMxOGVmY2RlNjI5YmY0Yw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MTA4ZGMzY2M5ZDc3OWNlZmVkNzBjYjdhOWU0OTZiOTU2OTgxMTNiNmMwNDdj
-    MjFjZjBkOGExZTBiNmNmMTIwMTE3ZmNlOGQ5YTVjOWMzMzdjNjA4NDNhNTg5
-    MTdhZWYwZjA3ZDY2NTczOTI2ODBmNDBmZTg4YTQxMzRlYzRjN2I=
+    ZWNiMDkyZjI0MGNmZDE0Njg4ZDdkMGVhZWUzYWU2OTdkNzg2NmY5MzgwODAy
+    NjMwOTNiMmQyZGI5NGI2NWIwNjllNWMzMTQ3OWRjNDRmMDgxYzRiMDcxMjI0
+    MTY4ZTY3MjNkMWUxOGU1MTFjYjNjN2YxMTg4Zjc0OWUxMmNlMzc=
   data.tar.gz: !binary |-
-    YTI5YTQzNzBhYzk3MTI3NWJkNzJmMDJiYmVkOGJjMmM3NTZhYzVjMDNhMTRh
-    ODQ0ZDQxNDFjNzI2NTljNGM0MWEwZmYzNmJlMzRlYTRiMGFjY2RjZjQzNzNh
-    MzlmNGVjOGQyN2U3YzM4MjRkZmYwMjIzMDY1MWQyZTdmMjE5M2Y=
+    MTk2ZjVjNTIxYjlmMTIwNDVhNDEyMmZkMzE2YWY3ODE2NWM3NDFhY2VhMWVk
+    YzA0OTgyODVhNmU2ZWZiMWI4NDE5YWI5N2RlNDlmYWExMTkzZGNmMTY1MTk1
+    ZmNhOTAyMGJkYTJjOTcxMmU3ZTQ4YmU1MDhjNDA4Yjg4YTcwYzQ=

data/.travis.yml

@@ -1,31 +1,18 @@
 language: ruby
 
 rvm:
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
-  - ree
-  - ruby-head
-  - jruby-18mode
+  - 2.0.0
   - jruby-19mode
-  - jruby-head
 
 gemfile:
   - gemfiles/3.0.gemfile
   - gemfiles/3.1.gemfile
   - gemfiles/3.2.gemfile
-  - gemfiles/edge.gemfile
+  - gemfiles/4.0.gemfile
 
 matrix:
-  exclude:
-    - rvm: 1.8.7
-      gemfile: gemfiles/edge.gemfile
   allow_failures:
-    - 1.8.7
-    - gemfile: gemfiles/edge.gemfile
+    - rvm: jruby-19mode
 
 script: RAILS_ENV=test bundle exec rspec spec
-
-notifications:
-  campfire: 80beans:d43f43244263cafb088182aa79e7d96419da0372@188927
-  email: false

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.6.2
+* Bugfix in backtrace cleaner usage for Rails 4
+
 # 0.6.1
 * Bugfix in Capistrano integration
 

data/README.md

@@ -1,12 +1,16 @@
-appsignal
+AppSignal agent
 =================
 
+This gem collects error and performance data from your Rails
+applications and sends it to [AppSignal](https://appsignal.com)
+
+[![Build Status](https://travis-ci.org/appsignal/appsignal.png?branch=develop)](https://travis-ci.org/appsignal/appsignal)
+[![Code Climate](https://codeclimate.com/github/appsignal/appsignal.png)](https://codeclimate.com/github/appsignal/appsignal)
 
 ## Pull requests / issues
 
 New features should be made in an issue or pullrequest. Title format is as follows:
 
-
     name [request_count]
 
 example
@@ -14,9 +18,10 @@ example
     tagging [2]
 
 ## Postprocessing middleware
-Appsignal logs Rails
+
+Appsignal sends Rails
 [ActiveSupport::Notification](http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html)-events
-to appsignal.com over SSL. These events contain basic metadata such as a name
+to AppSignal over SSL. These events contain basic metadata such as a name
 and timestamps, and additional 'payload' log data. Appsignal uses a postprocessing
 middleware stack to clean up events before they get sent to appsignal.com. You
 can add your own middleware to this stack in `config/environment/my_env.rb`.
@@ -24,6 +29,7 @@ can add your own middleware to this stack in `config/environment/my_env.rb`.
 ### Examples
 
 #### Minimal template
+
 ```ruby
 class MiddlewareTemplate
   def call(event)
@@ -37,6 +43,7 @@ Appsignal.postprocessing_middleware.add MiddlewareTemplate
 ```
 
 #### Remove boring payloads
+
 ```ruby
 class RemoveBoringPayload
   def call(event)

data/Rakefile

@@ -3,6 +3,7 @@ require 'appsignal/version'
 task :publish do
   NAME = 'appsignal'
   VERSION_FILE = 'lib/appsignal/version.rb'
+  CHANGELOG_FILE = 'CHANGELOG.md'
 
   raise '$EDITOR should be set' unless ENV['EDITOR']
 
@@ -49,6 +50,7 @@ task :publish do
   if changes.member?(VERSION_FILE)
     Appsignal.send(:remove_const, :VERSION)
     load File.expand_path(VERSION_FILE)
+    system("$EDITOR #{CHANGELOG_FILE}")
     build_and_push_gem
     create_and_push_tag
   else

data/gemfiles/3.0.gemfile

@@ -1,7 +1,7 @@
 # encoding: utf-8
 source :rubygems
 
-gem 'rails', '~> 3.0.17'
+gem 'rails', '~> 3.0'
 gem 'rspec'
 gem 'rake'
 gem 'json'

data/gemfiles/3.1.gemfile

@@ -1,7 +1,7 @@
 # encoding: utf-8
 source :rubygems
 
-gem 'rails', '~> 3.1.8'
+gem 'rails', '~> 3.1'
 gem 'rspec'
 gem 'rake'
 gem 'json'

data/gemfiles/3.2.gemfile

@@ -1,7 +1,7 @@
 # encoding: utf-8
 source :rubygems
 
-gem 'rails', '~> 3.2.8'
+gem 'rails', '~> 3.2'
 gem 'rspec'
 gem 'rake'
 gem 'json'

data/gemfiles/{edge.gemfile → 4.0.gemfile}

@@ -1,7 +1,7 @@
 # encoding: utf-8
 source :rubygems
 
-gem 'rails', :git => 'git://github.com/rails/rails.git'
+gem 'rails', '~> 4.0'
 gem 'rspec'
 gem 'rake'
 gem 'json'

data/lib/appsignal/exception_notification.rb

@@ -5,13 +5,16 @@ module Appsignal
   end
 
   class ExceptionNotification
-    attr_reader :env, :exception, :kontroller, :request, :backtrace
+    attr_reader :env, :exception, :backtrace
 
-    def initialize(env, exception, rails_cleaner=true)
+    def initialize(env, exception, run_rails_cleaner=true)
+      @env = env
       @exception = exception
-      @backtrace = rails_cleaner && Rails.respond_to?(:backtrace_cleaner) ?
-        Rails.backtrace_cleaner.send(:filter, exception.backtrace) :
-        exception.backtrace
+      if run_rails_cleaner && Rails.respond_to?(:backtrace_cleaner)
+        @backtrace = Rails.backtrace_cleaner.clean(@exception.backtrace, nil)
+      else
+        @backtrace = @exception.backtrace
+      end
     end
 
     def name

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.6.1'
+  VERSION = '0.6.2'
 end

data/spec/appsignal/auth_check_spec.rb

@@ -25,7 +25,7 @@ describe Appsignal::AuthCheck do
 
   context "transmitting" do
     before do
-      @transmitter = mock
+      @transmitter = double
       Appsignal::Transmitter.should_receive(:new).
         with('http://localhost:3000/1', 'auth', 'def').
         and_return(@transmitter)

data/spec/appsignal/capistrano_spec.rb

@@ -46,7 +46,7 @@ describe Appsignal::Capistrano do
 
       context "proper setup" do
         before do
-          @transmitter = mock()
+          @transmitter = double
           Appsignal::Transmitter.should_receive(:new).and_return(@transmitter)
         end
 

data/spec/appsignal/cli_spec.rb

@@ -67,7 +67,7 @@ describe Appsignal::CLI do
         options
       )
       Appsignal::Marker.should_receive(:new).
-        and_return(mock(:transmit => true))
+        and_return(double(:transmit => true))
       cli.notify_of_deploy(options)
     end
 

data/spec/appsignal/exception_notification_spec.rb

@@ -2,11 +2,37 @@ require 'spec_helper'
 
 describe Appsignal::ExceptionNotification do
   let(:error) { StandardError.new('moo') }
-  let(:notification) { Appsignal::ExceptionNotification.new({}, error) }
+  let(:notification) { Appsignal::ExceptionNotification.new({}, error, false) }
   subject { notification }
-  before { Rails.stub(:respond_to? => false) }
+  before do
+    Rails.stub(:root => '/home/app/current')
+  end
 
+  its(:env) { should == {} }
   its(:exception) { should == error }
   its(:name) { should == 'StandardError' }
   its(:message) { should == 'moo' }
+
+  context "backtrace" do
+    let(:backtrace) do
+      [
+        '/home/app/current/app/controllers/somethings_controller.rb:10',
+        '/user/local/ruby/path.rb:8'
+      ]
+    end
+    before { error.stub(:backtrace => backtrace) }
+
+    subject { notification.backtrace }
+
+    it { should == backtrace }
+
+    context "when running the backtrace cleaner" do
+      let(:notification) { Appsignal::ExceptionNotification.new({}, error) }
+
+      it { should == [
+        'app/controllers/somethings_controller.rb:10',
+        '/user/local/ruby/path.rb:8'
+      ] }
+    end
+  end
 end

data/spec/appsignal/listener_spec.rb

@@ -12,10 +12,10 @@ end
 
 describe Appsignal::Listener do
   describe '#call' do
-    let(:app) { stub(:call => true) }
+    let(:app) { double(:call => true) }
     let(:env) { {'action_dispatch.request_id' => '1'} }
     let(:middleware) { Appsignal::Listener.new(app, {})}
-    let(:current) { stub(:complete! => true, :add_exception => true) }
+    let(:current) { double(:complete! => true, :add_exception => true) }
     before { Appsignal::Transaction.stub(:current => current) }
 
     describe 'around call' do

data/spec/appsignal/marker_spec.rb

@@ -18,7 +18,7 @@ describe Appsignal::Marker do
 
   context "transmit" do
     before do
-      @transmitter = mock()
+      @transmitter = double
       Appsignal::Transmitter.should_receive(:new).
         with('http://localhost:3000/1', 'markers', 'abc').
         and_return(@transmitter)

data/spec/appsignal/middleware/chain_spec.rb

@@ -7,8 +7,8 @@ describe Appsignal::Middleware do
   let(:entry) { entry_klass.new(object, {:foo => :bar}) }
 
   describe Appsignal::Middleware::Chain do
-    let(:object) { mock(:object) }
-    let(:other_object) { mock(:other_object) }
+    let(:object) { double(:object) }
+    let(:other_object) { double(:other_object) }
 
     describe "#initialize" do
       it "yields itself when passing a block" do
@@ -156,7 +156,7 @@ describe Appsignal::Middleware do
   describe Appsignal::Middleware::Entry do
 
     describe "#make_new" do
-      let(:object) { mock }
+      let(:object) { double }
       subject { entry.make_new }
 
       it "initializes the passed object" do

data/spec/appsignal/railtie_spec.rb

@@ -36,7 +36,7 @@ describe Appsignal::Railtie do
 
     context "non action_controller event" do
       it "should call add_event for non action_controller event" do
-        current = mock(:current)
+        current = double(:current)
         current.should_receive(:add_event)
         Appsignal::Transaction.should_receive(:current).twice.
           and_return(current)
@@ -47,7 +47,7 @@ describe Appsignal::Railtie do
 
     context "action_controller event" do
       it "should call set_process_action_event for action_controller event" do
-        current = mock(:current)
+        current = double(:current)
         current.should_receive(:set_process_action_event)
         current.should_receive(:add_event)
         Appsignal::Transaction.should_receive(:current).exactly(3).times.

data/spec/appsignal/transaction_spec.rb

@@ -49,7 +49,7 @@ describe Appsignal::Transaction do
     end
 
     describe '#add_event' do
-      let(:event) { mock(:event, :name => 'test') }
+      let(:event) { double(:event, :name => 'test') }
 
       it 'should add an event' do
         expect {
@@ -59,7 +59,7 @@ describe Appsignal::Transaction do
     end
 
     context "using exceptions" do
-      let(:exception) { mock(:exception, :name => 'test') }
+      let(:exception) { double(:exception, :name => 'test') }
 
       describe '#add_exception' do
         it 'should add an exception' do
@@ -225,7 +225,7 @@ describe Appsignal::Transaction do
     end
 
     describe '#complete!' do
-      let(:event) { mock(:event) }
+      let(:event) { double(:event) }
       before { transaction.set_process_action_event(notification_event) }
 
       it 'should remove transaction from the list' do

data/spec/appsignal/transmitter_spec.rb

@@ -19,8 +19,8 @@ describe Appsignal::Transmitter do
   end
 
   describe "#transmit" do
-    let(:response) { mock(:response, :code => '200') }
-    let(:http_client) { mock(:request, :request => response) }
+    let(:response) { double(:response, :code => '200') }
+    let(:http_client) { double(:request, :request => response) }
     before { instance.stub(:http_client => http_client) }
 
     subject { instance.transmit(:shipit => :payload) }
@@ -30,7 +30,7 @@ describe Appsignal::Transmitter do
 
   describe "#http_post" do
     it "calls Net::HTTP.post_form with the correct params" do
-      post = mock(:post)
+      post = double(:post)
       post.should_receive(:[]=).
         with('Content-Type', 'application/json; charset=UTF-8')
       post.should_receive(:[]=).

data/spec/appsignal_spec.rb

@@ -105,7 +105,7 @@ describe Appsignal do
 
   describe ".send_exception" do
     it "should raise exception" do
-      agent = mock
+      agent = double
       Appsignal.should_receive(:agent).exactly(3).times.and_return(agent)
       agent.should_receive(:send_queue)
       agent.should_receive(:enqueue).with(kind_of(Appsignal::Transaction))

data/spec/generators/appsignal/appsignal_generator_spec.rb

@@ -19,7 +19,7 @@ describe AppsignalGenerator do
     context "known key" do
       before do
         prepare_destination
-        authcheck = mock()
+        authcheck = double
         Appsignal::AuthCheck.should_receive(:new).and_return(authcheck)
         authcheck.should_receive(:perform_with_result).
           and_return(['200', 'everything ok'])
@@ -34,7 +34,7 @@ describe AppsignalGenerator do
     context "invalid key" do
       before do
         prepare_destination
-        authcheck = mock()
+        authcheck = double
         Appsignal::AuthCheck.should_receive(:new).and_return(authcheck)
         authcheck.should_receive(:perform_with_result).
           and_return(['401', 'unauthorized'])
@@ -49,7 +49,7 @@ describe AppsignalGenerator do
     context "failed check" do
       before do
         prepare_destination
-        authcheck = mock()
+        authcheck = double
         Appsignal::AuthCheck.should_receive(:new).and_return(authcheck)
         authcheck.should_receive(:perform_with_result).
           and_return(['500', 'error!'])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-19 00:00:00.000000000 Z
+date: 2013-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -134,7 +134,7 @@ files:
 - gemfiles/3.0.gemfile
 - gemfiles/3.1.gemfile
 - gemfiles/3.2.gemfile
-- gemfiles/edge.gemfile
+- gemfiles/4.0.gemfile
 - lib/appsignal.rb
 - lib/appsignal/agent.rb
 - lib/appsignal/aggregator.rb