appsignal 0.11.16 → 0.11.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e8df99b6b521fdda3a9e54873ea46bad0e1667f
-  data.tar.gz: 32711b82d0e91a9cc08bde77ec0bc62bcc858129
+  metadata.gz: 9134a3a7b0864bbdbf6c23ee90d43537adc7faa9
+  data.tar.gz: 3c86992c153bcfceed5fae3db112d7e066b51c30
 SHA512:
-  metadata.gz: a7b0a13d1709bc11fd09857b56a2090a28dfdf872484bdc8f6c107ebb94935dc6b12bf1928359cee8816bebda5cc25ed41d277c43faace2876dc94bb25600d34
-  data.tar.gz: 052a53b0fe02ff563b6a54aa8e8066e169c5661568cb75d4c27e3ef894ae17f51c4bd35ab25c0dc08d5f20a4738fc522f4fb1ef94bc7f6d002ee8deabab72354
+  metadata.gz: 87aa26b8f6412505484af7adc3250f8339936cd71c09aeb3772c414f79813dcda1fbcafd9d02b7742fcc675d90abc81c5b39cd8b55d49735a6ec251b26185406
+  data.tar.gz: acf5e0a21d3a5a163bb40da40d5083f9a644050d21dbab767dd7b237df39b7adfdeca8e5af7b98f966bb4fb4827905bd602423de1cdb0a544181ba6d6482842a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.11.17
+* Fix for bug using rack request in `send_exception`
+
 # 0.11.16
 * Send tags passed to the frontend error catcher
 * Fix issue with ActiveAdmin sending incompatible instrumentation events

data/lib/appsignal.rb

@@ -106,7 +106,7 @@ module Appsignal
         logger.error('Can\'t send exception, given value is not an exception')
         return
       end
-      transaction = Appsignal::Transaction.create(SecureRandom.uuid, ENV)
+      transaction = Appsignal::Transaction.create(SecureRandom.uuid, nil)
       transaction.add_exception(exception)
       transaction.set_tags(tags) if tags
       transaction.complete!

data/lib/appsignal/transaction.rb

@@ -60,7 +60,7 @@ module Appsignal
     end
 
     def request
-      ::Rack::Request.new(@env)
+      ::Rack::Request.new(@env) if @env
     end
 
     def set_tags(given_tags={})
@@ -244,6 +244,7 @@ module Appsignal
     end
 
     def sanitize_session_data!
+      return unless request
       @sanitized_session_data = Appsignal::ParamsSanitizer.sanitize(
         request.session.to_hash
       ) if Appsignal.config[:skip_session_data] == false

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.11.16'
+  VERSION = '0.11.17'
 end

data/spec/lib/appsignal/transaction_spec.rb

@@ -77,6 +77,12 @@ describe Appsignal::Transaction do
       subject { transaction.request }
 
       it { should be_a ::Rack::Request }
+
+      context "without env" do
+        let(:env) { nil }
+
+        it { should be_nil }
+      end
     end
 
     describe '#set_process_action_event' do
@@ -738,6 +744,18 @@ describe Appsignal::Transaction do
           transaction.sanitized_session_data.should == {}
         end
       end
+
+      context "without a request" do
+        before do
+          transaction.stub(:request => nil)
+        end
+
+        it "does not pass the session data into the params sanitizer" do
+          Appsignal::ParamsSanitizer.should_not_receive(:sanitize)
+          subject
+          transaction.sanitized_session_data.should == {}
+        end
+      end
     end
 
     describe '#sanitize_params!' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.11.16
+  version: 0.11.17
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-19 00:00:00.000000000 Z
+date: 2015-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack