appsignal 0.11.10 → 0.11.11

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.11.11
+* Reliably get errors in production for Sinatra
+
 # 0.11.10
 * Fix for binding bug in exceptions in Resque
 * Handle invalidly encoded characters in payload

data/lib/appsignal/rack/sinatra_instrumentation.rb

@@ -19,6 +19,10 @@ module Appsignal
             payload[:action] = env['sinatra.route']
           end
         end
+      ensure
+        # In production newer versions of Sinatra don't raise errors, but store
+        # them in the sinatra.error env var.
+        Appsignal::Transaction.current.add_exception(env['sinatra.error']) if env['sinatra.error']
       end
 
       def raw_payload(env)

data/lib/appsignal/transaction.rb

@@ -94,6 +94,7 @@ module Appsignal
 
     def add_exception(ex=nil)
       return unless ex
+      Appsignal.logger.debug("Adding #{ex.class.name} to transaction: #{request_id}")
       @time = Time.now.utc.to_f
       @exception = {
         :exception  => ex.class.name,

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.11.10'
+  VERSION = '0.11.11'
 end

data/spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb

@@ -49,6 +49,19 @@ if defined?(::Sinatra)
         process_action_event.name.should == 'process_action.sinatra'
         process_action_event.payload[:action].should == 'GET /'
       end
+
+      it "should add exceptions stored in env under sinatra.error" do
+        exception = RuntimeError.new('Raise the roof')
+        env['sinatra.error'] = exception
+
+        transaction = double
+        transaction.stub(:set_process_action_event)
+        transaction.stub(:add_event)
+        transaction.should_receive(:add_exception).with(exception)
+        Appsignal::Transaction.stub(:current => transaction)
+
+        middleware.call(env)
+      end
     end
 
     describe "raw_payload" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.11.10
+  version: 0.11.11
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-18 00:00:00.000000000 Z
+date: 2015-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack