approvals 0.0.20 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23b24cfaf9706d8ead8d9c1a436025d983ac8c7b
-  data.tar.gz: b5ee817b9554e90d064ebc0572f3f8786fbb429a
+  metadata.gz: 83fdc1b67aa0b4262df63630332d038a42c04de8
+  data.tar.gz: ade116ca8534915b28e6d052a3f8d215c915cdb3
 SHA512:
-  metadata.gz: 1d64e7023845cfa1b25365bf09682849e0d1b9912b44c621994badab49ed46be3deda93db41468a28e7eb88e95fa5fa7d02d197647b1a33a7aa52b96fda725c6
-  data.tar.gz: c4f5a05a1cb1e317c69aae65f931a3521f1cfda9cfca0faf455052a1904a53c6c961fb6898dbca5908649c0defd7db5eb75708eadac11322e605bc5e98f76fd0
+  metadata.gz: c76a9cf43067226a8a74178c4b5b762d9c6132ac781b4680324023e9a35c39c2383c6fc7a8b9341fd144704b718ef1282c00ff2addf673699a3f1d31d299a5d9
+  data.tar.gz: 23b5b8ce78c15b97a4665eb6daaaca00eccba0ae5e9841743d5bf9483ce5bad5d017e8e76a95bf376414929a4dad60832990fe22baa6975c171df5d065ba718a

data/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ### Next Release
 
+* [#64](https://github.com/kytrinyx/approvals/pull/64) Silence deprecation warnings - [@tmock12](https://github.com/tmock12)
 * Your contribution here
 
 ### v0.0.20 (2015-04-21)

data/README.md

@@ -165,7 +165,7 @@ verify :format => :json do
 end
 ```
 
-### Exclude dynamicly changed values from json
+### Exclude dynamically changed values from json
 
 ```ruby
 Approvals.configure do |c|

data/lib/approvals/approval.rb

@@ -1,4 +1,4 @@
-require 'erb' # It is referenced on line 56
+require 'erb' # It is referenced on line 69
 module Approvals
   class Approval
     class << self
@@ -35,7 +35,7 @@ module Approvals
     end
 
     def verify
-      unless File.exists?(namer.output_dir)
+      unless File.exist?(namer.output_dir)
         FileUtils.mkdir_p(namer.output_dir)
       end
 
@@ -57,11 +57,11 @@ module Approvals
     end
 
     def approved?
-      File.exists? approved_path
+      File.exist? approved_path
     end
 
     BINARY_FORMATS = [:binary]
-    
+
     def received_matches?
       if BINARY_FORMATS.include?(@format) # Read without ERB
         IO.read(received_path).chomp == IO.read(approved_path).chomp

data/lib/approvals/dotfile.rb

@@ -4,7 +4,7 @@ module Approvals
     class << self
 
       def reset
-        File.truncate(path, 0) if File.exists?(path)
+        File.truncate(path, 0) if File.exist?(path)
       end
 
       def append(text)

data/lib/approvals/filter.rb

@@ -20,7 +20,7 @@ module Approvals
       when Array
         value.map { |item| censored(item) }
       when Hash
-        Hash[value.map { |key, value| [key, censored(value, key)] }]
+        Hash[value.map { |inner_key, inner_value| [inner_key, censored(inner_value, inner_key)] }]
       else
         if value.nil?
           nil

data/lib/approvals/namers/directory_namer.rb

@@ -1,17 +1,13 @@
 module Approvals
   module Namers
     class DirectoryNamer < RSpecNamer
+      private
 
-      def initialize(example)
-        @name = directorize example
+      def name_for_example(example)
+        directorize example
       end
 
-      private
-
       def directorize(example)
-        parts     = [ ]
-        metadata  = example.metadata
-
         approvals_path = lambda do |metadata|
           description = normalize metadata[:description]
           example_group = if metadata.key?(:example_group)

data/lib/approvals/namers/rspec_namer.rb

@@ -1,10 +1,15 @@
 module Approvals
   module Namers
     class RSpecNamer
-
       attr_reader :name
+
       def initialize(example)
-        @name = normalize example.full_description
+        @name = name_for_example(example)
+        @output_dir = nil
+      end
+
+      def name_for_example(example)
+        normalize example.full_description
       end
 
       def normalize(string)
@@ -15,7 +20,7 @@ module Approvals
         unless @output_dir
           begin
             @output_dir = ::RSpec.configuration.approvals_path
-          rescue NoMethodError => e
+          rescue NoMethodError
           end
           @output_dir ||= 'spec/fixtures/approvals/'
         end

data/lib/approvals/version.rb

@@ -1,3 +1,3 @@
 module Approvals
-  VERSION = '0.0.20'
+  VERSION = '0.0.21'
 end

data/lib/approvals/writers/binary_writer.rb

@@ -6,19 +6,13 @@ module Approvals
       end
 
       def initialize(opts = {})
-        self.autoregister = opts[:autoregister] || true
-        self.detect = opts[:detect]
-        self.extension = opts[:extension] || ''
-        self.write = opts[:write] || EXCEPTION_WRITER
+        @autoregister = opts[:autoregister] || true
+        @detect = opts[:detect]
+        @extension = opts[:extension] || ''
+        @write = opts[:write] || EXCEPTION_WRITER
         self.format = opts[:format] || :binary
       end
 
-      attr_accessor :autoregister
-      attr_accessor :extension
-      attr_accessor :write
-      attr_accessor :detect
-
-
       attr_reader :format
 
       def format=(sym)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: approvals
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Katrina Owen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-21 00:00:00.000000000 Z
+date: 2015-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec