appraiser 0.1.5 → 0.1.6

data/CHANGELOG

@@ -1,3 +1,8 @@
+== 0.1.6
+
+* add specs for Gem::Commands::AppraiserCommand
+* testing on travis-ci.org
+
 == 0.1.5
 
 * gem commandify [amatsuda]

data/README.md

@@ -1,6 +1,8 @@
 Appraiser = a simple rubygems subcommand for Gemfile
 ====================================================
 
+[![Build Status](http://travis-ci.org/juno/appraiser.png)](http://travis-ci.org/juno/appraiser)
+
 `appraiser` displays gem information from `./Gemfile`.
 
 Like this:

data/Rakefile

@@ -1,2 +1,10 @@
 require 'bundler'
 Bundler::GemHelper.install_tasks
+
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new do |t|
+  t.pattern = 'spec/**/*_spec.rb'
+end
+
+task :default => :spec

data/appraiser.gemspec

@@ -36,5 +36,7 @@ appraiser installed as a rubygems subcommand.
   s.add_dependency('colored', ['~> 1.2'])
   s.add_dependency('json')
 
+  s.add_development_dependency('rake', ['~> 0.9'])
   s.add_development_dependency('rspec', ['~> 2.3'])
+  s.add_development_dependency('webmock', ['~> 1.7'])
 end

data/lib/appraiser/version.rb

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 
 module Appraiser
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end
 
 

data/lib/rubygems/commands/appraiser_command.rb

@@ -6,13 +6,17 @@ require 'bundler'
 require 'colored'
 require 'json'
 require 'open-uri'
+require 'stringio'
 
 require 'appraiser/version'
 
 class Gem::Commands::AppraiserCommand < Gem::Command
+
   RUBY_GEMS_URL = 'http://rubygems.org/api/v1/gems/%s.json'
+
   LINE = '-' * 60
 
+
   def initialize
     super 'appraiser', 'Display gem information in ./Gemfile'
 
@@ -26,14 +30,22 @@ class Gem::Commands::AppraiserCommand < Gem::Command
   end
 
   def execute
+    process($stdout)
+  end
+
+
+  private
+
+  # @param [IO] output
+  def process(output)
     group = (options[:group] || :default).to_sym
 
     dependencies_for(group).each do |dependency|
       json = load_json(dependency.name)
 
       if json.empty?
-        puts dependency.name.green
-        puts "Source   : #{dependency.source.to_s.cyan.underline}"
+        output.puts dependency.name.green
+        output.puts "Source   : #{dependency.source.to_s.cyan.underline}"
       else
         name = json['name']
         authors = json['authors']
@@ -43,20 +55,18 @@ class Gem::Commands::AppraiserCommand < Gem::Command
         src_uri = json['source_code_uri']
         info = json['info'].split("\n").first.strip
 
-        puts "#{name.green} (by #{authors})"
-        puts "Downloads: #{downloads.blue}"
-        puts "Project  : #{project_uri.cyan.underline}" if project_uri
-        puts "Document : #{doc_uri.cyan.underline}" if doc_uri
-        puts "Source   : #{src_uri.cyan.underline}" if src_uri
-        puts info
+        output.puts "#{name.green} (by #{authors})"
+        output.puts "Downloads: #{downloads.blue}"
+        output.puts "Project  : #{project_uri.cyan.underline}" if project_uri
+        output.puts "Document : #{doc_uri.cyan.underline}" if doc_uri
+        output.puts "Source   : #{src_uri.cyan.underline}" if src_uri
+        output.puts info
       end
 
-      puts LINE
+      output.puts LINE
     end
   end
 
-  private
-
   # @param [String] gem_name
   # @return [Hash]
   def load_json(gem_name)
@@ -68,7 +78,7 @@ class Gem::Commands::AppraiserCommand < Gem::Command
   # @param [Symbol] group
   # @return [Array<Bundler::Dependency>]
   def dependencies_for(group)
-    Bundler.definition.dependencies.select{ |i| i.groups.include? group }
+    Bundler.definition.dependencies.select { |i| i.groups.include? group }
   end
 
   # @param [Integer] number
@@ -82,4 +92,5 @@ class Gem::Commands::AppraiserCommand < Gem::Command
   rescue
     number.to_s
   end
+
 end

data/spec/.travis.yml

@@ -0,0 +1,4 @@
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - jruby

data/spec/appraiser_spec.rb

@@ -2,6 +2,224 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe "Gem::Commands::AppraiserCommand" do
-  it "um..."
+describe Gem::Commands::AppraiserCommand do
+
+  before do
+    @rails_json = <<-EOD
+{"dependencies":{"runtime":[{"name":"actionmailer","requirements":"= 3.0.9"},{"name":"actionpack","requirements":"= 3.0.9"},{"name":"activerecord","requirements":"= 3.0.9"},{"name":"activeresource","requirements":"= 3.0.9"},{"name":"activesupport","requirements":"= 3.0.9"},{"name":"bundler","requirements":"~> 1.0"},{"name":"railties","requirements":"= 3.0.9"}],"development":[]},"name":"rails","downloads":4977205,"info":"Ruby on Rails is a full-stack web framework optimized for programmer happiness and sustainable productivity. It encourages beautiful code by favoring convention over configuration.","version_downloads":306973,"version":"3.0.9","homepage_uri":"http://www.rubyonrails.org","bug_tracker_uri":"http://rails.lighthouseapp.com/projects/8994-ruby-on-rails","source_code_uri":"http://github.com/rails/rails","gem_uri":"http://rubygems.org/gems/rails-3.0.9.gem","project_uri":"http://rubygems.org/gems/rails","authors":"David Heinemeier Hansson","mailing_list_uri":"http://groups.google.com/group/rubyonrails-talk","documentation_uri":"http://api.rubyonrails.org","wiki_uri":"http://wiki.rubyonrails.org"}
+    EOD
+
+    @empty_json = '{}'
+  end
+
+  describe "Constants" do
+    describe "RUBY_GEMS_URL" do
+      subject { Gem::Commands::AppraiserCommand::RUBY_GEMS_URL }
+      it { should eq('http://rubygems.org/api/v1/gems/%s.json') }
+    end
+
+    describe "LINE" do
+      subject { Gem::Commands::AppraiserCommand::LINE }
+      it { should eq('-' * 60) }
+    end
+  end
+
+
+  # Instance methods
+
+  describe "#usage" do
+    let(:command) { Gem::Commands::AppraiserCommand.new }
+    subject { command.usage }
+    it { should eq('gem appraiser [-g group]') }
+  end
+
+  describe "#execute" do
+    let(:command) { Gem::Commands::AppraiserCommand.new }
+
+    it "call #process with STDOUT as output" do
+      command.should_receive(:process).with($stdout)
+      command.execute
+    end
+  end
+
+
+  # private methods
+
+  describe "#process(output)" do
+    let(:command) { Gem::Commands::AppraiserCommand.new }
+    let(:output) { stub(IO).as_null_object }
+
+    context "response body is not empty json" do
+      before do
+        dependencies = []
+        dependencies << stub(Bundler::Dependency, :groups => [:default], :name => 'rails')
+        dependencies << stub(Bundler::Dependency, :groups => [:test], :name => 'rspec')
+        Bundler.stub_chain(:definition, :dependencies) { dependencies }
+      end
+
+      it "retrieves :default group dependency json from RubyGems API" do
+        stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+          to_return(:status => 200, :body => @rails_json)
+        command.send(:process, output)
+        a_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').should have_been_made.once
+      end
+
+      it "not retrieves :test group dependency json from RubyGems API" do
+        stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+          to_return(:status => 200, :body => @rails_json)
+        command.send(:process, output)
+        a_request(:get, 'http://rubygems.org/api/v1/gems/rspec.json').should_not have_been_made
+      end
+    end
+
+    context "response body is empty json" do
+      before do
+        @dependency = stub(Bundler::Dependency,
+                           :groups => [:default],
+                           :name => 'rails',
+                           :source => 'git://github.com/tenderlove/nokogiri.git')
+        Bundler.stub_chain(:definition, :dependencies) { [@dependency] }
+
+        stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+          to_return(:status => 200, :body => @empty_json)
+      end
+
+      it "not raises exception" do
+        expect {
+          command.send(:process, output)
+        }.should_not raise_error
+      end
+
+      it "puts dependency source" do
+        @dependency.should_receive(:source) { 'git://github.com/tenderlove/nokogiri.git' }
+        command.send(:process, output)
+      end
+    end
+  end
+
+  describe "#load_json(gem_name)" do
+    let(:command) { Gem::Commands::AppraiserCommand.new }
+    let(:gem_name) { 'rails' }
+
+    context "open() raises OpenURI::HTTPError exception" do
+      before do
+        stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+          to_raise(OpenURI::HTTPError.new('error', stub(StringIO)))
+      end
+
+      subject { command.send(:load_json, gem_name) }
+      it { should be_kind_of(Hash) }
+      it { should be_empty }
+    end
+
+    context "open() returns JSON response" do
+      before do
+        stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+          to_return(:status => 200, :body => @rails_json)
+
+        @result = command.send(:load_json, gem_name)
+      end
+
+      it "have key 'name'" do
+        @result.should have_key('name')
+        @result['name'].should eq('rails')
+      end
+
+      it "have key 'authors'" do
+        @result.should have_key('authors')
+        @result['authors'].should eq('David Heinemeier Hansson')
+      end
+
+      it "have key 'downloads'" do
+        @result.should have_key('downloads')
+        @result['downloads'].should eq(4977205)
+      end
+
+      it "have key 'project_uri'" do
+        @result.should have_key('project_uri')
+        @result['project_uri'].should eq('http://rubygems.org/gems/rails')
+      end
+
+      it "have key 'documentation_uri'" do
+        @result.should have_key('documentation_uri')
+        @result['documentation_uri'].should eq('http://api.rubyonrails.org')
+      end
+
+      it "have key 'source_code_uri'" do
+        @result.should have_key('source_code_uri')
+        @result['source_code_uri'].should eq('http://github.com/rails/rails')
+      end
+
+      it "have key 'info'" do
+        @result.should have_key('info')
+        @result['info'].should eq("Ruby on Rails is a full-stack web framework optimized for programmer happiness and sustainable productivity. It encourages beautiful code by favoring convention over configuration.")
+      end
+    end
+  end
+
+  describe "#dependencies_for(group)" do
+    let(:command) { Gem::Commands::AppraiserCommand.new }
+    let(:group) { :development }
+
+    it "should call Bundler.definition.dependencies.select" do
+      dependencies = []
+      dependencies << stub(Bundler::Dependency, :groups => [:default])
+      dependencies << stub(Bundler::Dependency, :groups => [:development])
+      dependencies << stub(Bundler::Dependency, :groups => [:development, :test])
+      Bundler.stub_chain(:definition, :dependencies) { dependencies }
+
+      result = command.send(:dependencies_for, group)
+      result.should have(2).dependencies
+    end
+  end
+
+  describe "#number_with_delimiter(number, delimiter = ',', separator = '.')" do
+    let(:command) { Gem::Commands::AppraiserCommand.new }
+
+    context "number is 0" do
+      let(:number) { 0 }
+      subject { command.send(:number_with_delimiter, number) }
+      it { should eq('0') }
+    end
+
+    context "number is 100" do
+      let(:number) { 100 }
+      subject { command.send(:number_with_delimiter, number) }
+      it { should eq('100') }
+    end
+
+    context "number is 1000" do
+      let(:number) { 1000 }
+      subject { command.send(:number_with_delimiter, number) }
+      it { should eq('1,000') }
+    end
+
+    context "number is 10000.99" do
+      let(:number) { 10000.99 }
+      subject { command.send(:number_with_delimiter, number) }
+      it { should eq('10,000.99') }
+    end
+
+    context "number is 1000000" do
+      let(:number) { 1000000 }
+      subject { command.send(:number_with_delimiter, number) }
+      it { should eq('1,000,000') }
+    end
+
+    context "number is 1000000, delimiter is '_'" do
+      let(:number) { 1000000 }
+      let(:delimiter) { '_' }
+      subject { command.send(:number_with_delimiter, number, delimiter) }
+      it { should eq('1_000_000') }
+    end
+
+    context "number is '1000000 00', delimiter is '_', separator is ' '" do
+      let(:number) { 1000000 }
+      let(:delimiter) { '_' }
+      let(:separator) { ' ' }
+      subject { command.send(:number_with_delimiter, number, delimiter, separator) }
+      it { should eq('1_000_000') }
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -4,6 +4,7 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 
 require 'rspec'
+require 'webmock/rspec'
 require 'rubygems/commands/appraiser_command'
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}

metadata

@@ -1,72 +1,90 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: appraiser
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 0.1.6
   prerelease: 
-  version: 0.1.5
 platform: ruby
-authors: 
+authors:
 - Junya Ogura
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-04-25 00:00:00 +09:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-08-16 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: bundler
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70340450938180 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        version: "1.0"
+      - !ruby/object:Gem::Version
+        version: '1.0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: colored
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70340450938180
+- !ruby/object:Gem::Dependency
+  name: colored
+  requirement: &70340450937280 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        version: "1.2"
+      - !ruby/object:Gem::Version
+        version: '1.2'
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: json
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *70340450937280
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: &70340450936480 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: *70340450936480
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &70340450935120 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: *70340450935120
+- !ruby/object:Gem::Dependency
   name: rspec
+  requirement: &70340450934240 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.3'
+  type: :development
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *70340450934240
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: &70340450933340 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        version: "2.3"
+      - !ruby/object:Gem::Version
+        version: '1.7'
   type: :development
-  version_requirements: *id004
-description: `appraiser` is a rubygems subcommand which displays gem information in `./Gemfile`.
-email: 
+  prerelease: false
+  version_requirements: *70340450933340
+description: ! '`appraiser` is a rubygems subcommand which displays gem information
+  in `./Gemfile`.'
+email:
 - junyaogura@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
 - CHANGELOG
@@ -78,37 +96,42 @@ files:
 - lib/appraiser/version.rb
 - lib/rubygems/commands/appraiser_command.rb
 - lib/rubygems_plugin.rb
+- spec/.travis.yml
 - spec/appraiser_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: https://github.com/juno/appraiser
-licenses: 
+licenses:
 - MIT
-post_install_message: "\n\
-  appraiser installed as a rubygems subcommand.\n\n  (basic)\n  $ gem appraiser\n\n  (shorthand)\n  $ gem a\n\n  (\"group\" option)\n  $ gem a -g test\n\n"
+post_install_message: ! "\nappraiser installed as a rubygems subcommand.\n\n  (basic)\n
+  \ $ gem appraiser\n\n  (shorthand)\n  $ gem a\n\n  (\"group\" option)\n  $ gem a
+  -g test\n\n"
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: 2701355711312284477
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: 2701355711312284477
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
-summary: `appraiser` is a simple rubygems subcommand for Gemfile.
-test_files: 
+summary: ! '`appraiser` is a simple rubygems subcommand for Gemfile.'
+test_files:
 - spec/appraiser_spec.rb
 - spec/spec_helper.rb