appnexusapi 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d0d8a696916d00cb33332f0c9f959536f321838b
-  data.tar.gz: b6bc7bc92daf371d2f9c6141ee9f174d3f9a35f2
+  metadata.gz: 8b63b8d101eca2cb66dc080d7c5ef7b3f9e1e9d4
+  data.tar.gz: 7ff8db291e71dc36607b0a44b69b9ab3feb90703
 SHA512:
-  metadata.gz: d3c91ef186f3236070d03cbec6780cae75a7b5a8d7631da21fc4187411e3039fe4364aca15e5b6f5f3e6548896b58e95975d3df69339b45dc8f64ab8d3bbf3b2
-  data.tar.gz: 310fc055c9f7f0e6ff8c4a2094070bcc03b19f3b4be789078b25877237cf3f24484f745e9b74787092aa4929a8936813f7ed83b8ac99297c2dcaebfae1805e4f
+  metadata.gz: d86ce4b73c88990700087390f737fc5e76c8112127221dd0fd904743ad6692c822ff343fb973267c165dbd2d35db1e79219fc79f4ca29284d39a52f443c5bfa2
+  data.tar.gz: 5889df3927d2e16cc88c1a21b023c59f11e63da0f19131cde60dc47c451f0c5f6c149c82eef13f2f6c5d416219ab3dc8a7082d5a15e2f283c88264a8130b1319

data/lib/appnexusapi/connection.rb

@@ -1,5 +1,6 @@
 require 'faraday_middleware'
 require 'appnexusapi/faraday/raise_http_error'
+require 'null_logger'
 
 class AppnexusApi::Connection
   RATE_EXCEEDED_DEFAULT_TIMEOUT = 15
@@ -8,7 +9,7 @@ class AppnexusApi::Connection
   def initialize(config)
     @config = config
     @config['uri'] ||= 'https://api.appnexus.com/'
-    @logger = @config['logger'] || NullLogger.new
+    @logger = @config['logger'] || NullLogger.instance
     @connection = Faraday.new(@config['uri']) do |conn|
       conn.response :logger, @logger, bodies: true
       conn.request :json

data/lib/appnexusapi/version.rb

@@ -1,3 +1,3 @@
 module AppnexusApi
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/spec/connection_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe AppnexusApi::Connection do
+
+  it 'allows no logger to be specified' do
+    expect do
+      AppnexusApi::CreativeService.new(connection_with_null_logger, ENV['APPNEXUS_MEMBER_ID'])
+    end.to_not raise_error
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 require 'dotenv'
 Dotenv.load
 
-Bundler.require
 require 'pry'
 require 'logger'
 require_relative '../lib/appnexusapi'
@@ -26,3 +25,12 @@ def connection
     'logger'   => test_logger
   )
 end
+
+def connection_with_null_logger
+  AppnexusApi::Connection.new(
+    'username' => ENV['APPNEXUS_USERNAME'],
+    'password' => ENV['APPNEXUS_PASSWORD'],
+    'uri'      => ENV['APPNEXUS_URI']
+  )
+end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appnexusapi
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Brandon Aaron
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-23 00:00:00.000000000 Z
+date: 2016-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -210,6 +210,7 @@ files:
 - lib/appnexusapi/user_resource.rb
 - lib/appnexusapi/user_service.rb
 - lib/appnexusapi/version.rb
+- spec/connection_spec.rb
 - spec/creative_service_spec.rb
 - spec/spec_helper.rb
 homepage: http://simpli.fi
@@ -231,10 +232,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Unofficial Ruby API Wrapper for Appnexus
 test_files:
+- spec/connection_spec.rb
 - spec/creative_service_spec.rb
 - spec/spec_helper.rb