appmap 0.25.0 → 0.25.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d42f8555b02b0478b8927c249f6dfa54c9326b7e3122cd5a0b91b5d1fb308fbb
-  data.tar.gz: 525faceacd156300098b897f7ef7789d94d42601f9ccec5d3bfad0f41b62ac54
+  metadata.gz: 6ee5199f1f1f4c05ba3837f3caf04adb9798bb223c3bf0deb71cdd80216181a0
+  data.tar.gz: 3aeb05be87430862426a25075a236d54d2d20bb0a1d893b71b1eaa63c8c44c01
 SHA512:
-  metadata.gz: 8290dde850c68b07c51baa70c074a283907c77c15093c8d6ed9b151da66f1dbad866f37beef6a12c2897195b8b18d147a839dd049336fd52fa1b48fb5e3d8ab1
-  data.tar.gz: '035025557325693fd0a158ce007dab265ec2646a3cf2e729f42348ac0986081f4356a1cec1e66c1bc7d9608025c6889b497e52ec6f510612a3fb5cedd220f22d'
+  metadata.gz: fc4042fe8d7f56a87b205145fcd9e520beb946d27f1e17f5134f4a5127f7ca9c2ee8645cf8377339c34cf814b4faf348894d91f20d31a68e743ede3d5d863419
+  data.tar.gz: 3c4dba46e95a77b51030065af14e9987f66294ba396a38ef396b79d86b37540d36229670b170e4f632972b563369184d0fa1a4e5b4c18d99d1deb5243b166014

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v0.25.2
+
+* Stop checking a whitelist to see if each SQL query should be recorded. Record
+all queries.
+
+# v0.25.1
+
+* Ensure that caught exceptions are re-raised.
+* Add safety around indexing potentially nil backtrace locations. 
+
 # v0.25.0
 
 * Reports `exceptions` in [function return attributes](https://github.com/applandinc/appmap#function-return-attributes).

data/lib/appmap/event.rb

@@ -139,7 +139,7 @@ module AppMap
               next_exception = exception
               exceptions = []
               while next_exception
-                exception_backtrace = next_exception.backtrace_locations[0]
+                exception_backtrace = next_exception.backtrace_locations.try(:[], 0)
                 exceptions << {
                   class: next_exception.class.name,
                   message: next_exception.message,

data/lib/appmap/hook.rb

@@ -133,6 +133,7 @@ module AppMap
                   return_value = base_method.call(*args, &block)
                 rescue
                   exception = $ERROR_INFO
+                  raise
                 ensure
                   with_disabled_hook.call do
                     after_hook.call(call_event, defined_class, method, start_time, return_value, exception)

data/lib/appmap/rails/sql_handler.rb

@@ -102,9 +102,6 @@ module AppMap
         Thread.current[reentry_key] = true
         begin
           sql = payload[:sql].strip
-          sql_upper = sql.upcase
-
-          return unless WHITELIST.find { |keyword| sql_upper.index(keyword) == 0 }
 
           # Detect whether a function call within a specified filename is present in the call stack.
           find_in_backtrace = lambda do |file_name, function_name = nil|
@@ -143,8 +140,6 @@ module AppMap
           Thread.current[reentry_key] = nil
         end
       end
-
-      WHITELIST = %w[SELECT INSERT UPDATE DELETE].freeze
     end
   end
 end

data/lib/appmap/version.rb

@@ -3,7 +3,7 @@
 module AppMap
   URL = 'https://github.com/applandinc/appmap-ruby'
 
-  VERSION = '0.25.0'
+  VERSION = '0.25.2'
 
   APPMAP_FORMAT_VERSION = '1.2'
 end

data/spec/hook_spec.rb

@@ -351,7 +351,19 @@ describe 'AppMap class Hooking' do
         :lineno: 9
     YAML
     test_hook_behavior 'spec/fixtures/hook/exception_method.rb', events_yaml do
-      ExceptionMethod.new.raise_exception
+      begin
+        ExceptionMethod.new.raise_exception
+      rescue
+        # don't let the exception fail the test
+      end
+    end
+  end
+
+  it 're-raises exceptions' do
+    RSpec::Expectations.configuration.on_potential_false_positives = :nothing
+
+    invoke_test_file 'spec/fixtures/hook/exception_method.rb' do
+      expect { ExceptionMethod.new.raise_exception }.to raise_exception
     end
   end
 end

data/spec/spec_helper.rb

@@ -5,3 +5,7 @@ require 'yaml'
 require 'English'
 require 'webdrivers/chromedriver'
 require 'appmap'
+
+RSpec.configure do |config|
+  config.example_status_persistence_file_path = "tmp/rspec_failed_examples.txt"
+end

data/test/cli_test.rb

@@ -119,7 +119,7 @@ class CLITest < Minitest::Test
       `#{File.expand_path '../exe/appmap', __dir__} record -o #{OUTPUT_FILENAME} ./lib/cli_record_test/main.rb`
     end
 
-    upload_output = `./exe/appmap upload --no-open #{OUTPUT_FILENAME}`
+    upload_output = `./exe/appmap upload --org default --user admin --no-open #{OUTPUT_FILENAME}`
     assert_equal 0, $CHILD_STATUS.exitstatus
     # Example: 93e1e07d-4b39-49ac-82bf-27d63e296cae
     assert_match(/Scenario Id/, upload_output)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appmap
 version: !ruby/object:Gem::Version
-  version: 0.25.0
+  version: 0.25.2
 platform: ruby
 authors:
 - Kevin Gilpin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-13 00:00:00.000000000 Z
+date: 2020-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport