application_service 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2ba3938b2707398961940cb759ff62513c3e979
-  data.tar.gz: 3701a47aba069f130b9ae0b263123bc8f7c7ed47
+  metadata.gz: 5098843852847896293de30d2f5c4fecad1b3102
+  data.tar.gz: e0155d8b8a81b6b603446550cdc6828cbddc8d2a
 SHA512:
-  metadata.gz: 484eb1e80e2af5cbbcefc1c8bc0a60047664d8abf4b1a36f077ea5f92cccaec698d297551d8a663c3cc3ffb1666e034078df829aad2fb206a2269e78fac0435c
-  data.tar.gz: 8b1295095f81155e29ffe0bb7d63b1819af83907af787b7f9df77b341311a03186edb2d91866588acf973fb6bbece74f17abad85279e11503449ce6e9ca6421b
+  metadata.gz: 2f7e81a4f71400cc1439cd684b2332cc847afec95e351fe8b35e050e3424b0d7206a3b3b5581fe5e6637b1f5b4cae287f9337376df79b9fe2564fe36fa393312
+  data.tar.gz: cef7d3d2b4cfc15fe1fe8d396b5921be18a4fc75f1d5330e496594d14ff14c41eb60ca4e8c82540615ed952f7f20ba47cba50df72046becdf9468e22d0522cc7

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.2.2

data/application_service.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: application_service 0.2.0 ruby lib
+# stub: application_service 0.2.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "application_service"
-  s.version = "0.2.0"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Nathan Woodhull"]
-  s.date = "2014-08-20"
+  s.date = "2014-11-18"
   s.description = "A service layer scaffold for rails apps extracted from Agra"
   s.email = "woodhull@gmail.com"
   s.extra_rdoc_files = [

data/lib/application_service.rb

@@ -15,6 +15,9 @@ class ApplicationService
 
     args.each do |arg|
       set_callback callback, :before, arg, options
+      if options.fetch(:skip_on_admin_save, false)
+        skip_callback callback, :before, arg, if: -> { @on_admin_save }
+      end
     end
   end
 
@@ -23,6 +26,9 @@ class ApplicationService
 
     args.each do |arg|
       set_callback callback, :after, arg, options
+      if options.fetch(:skip_on_admin_save, false)
+        skip_callback callback, :after, arg, if: -> { @on_admin_save }
+      end
     end
   end
 
@@ -78,29 +84,46 @@ class ApplicationService
     end
   end
 
+  def admin_save(obj)
+    @obj = obj
+
+    @on_admin_save = true
+    save_method = @obj.respond_to?(:admin_save) ? :admin_save : :save
+    run_callbacks :save do
+      if @obj.new_record?
+        result = create(save_method)
+      else
+        result = update(save_method)
+      end
+      result
+    end
+  ensure
+    @on_admin_save = false
+  end
+
   private
 
-  def create!
+  def create!(save_method=:save!)
     run_callbacks :create do
-      @obj.save!
+      @obj.send(save_method)
     end
   end
 
-  def create
+  def create(save_method=:save)
     run_callbacks :create do
-      @obj.save
+      @obj.send(save_method)
     end
   end
 
-  def update
+  def update(save_method=:save)
     run_callbacks :update do
-      @obj.save
+      @obj.send(save_method)
     end
   end
 
-  def update!
+  def update!(save_method=:save!)
     run_callbacks :update do
-      @obj.save!
+      @obj.send(save_method)
     end
   end
 

data/spec/application_service_spec.rb

@@ -89,6 +89,114 @@ describe ApplicationService do
     end
   end
 
+  describe '#admin_save' do
+    it "should trigger admin_save if defined on object" do
+      obj = double(new_record?: true)
+      expect(obj).to receive(:admin_save)
+
+      subject.admin_save(obj)
+    end
+
+    it "should trigger regular save if admin_save not defined on object" do
+      obj = double(new_record?: true)
+      expect(obj).to receive(:save)
+
+      subject.admin_save(obj)
+    end
+
+    describe 'callbacks' do
+      let(:object) { double(new_record?: false, save: true) }
+
+      context 'invoke' do
+        it "should invoke callbacks if skip_on_admin_save is false" do
+          service_klass = Class.new(ApplicationService) do
+            before :save, :before_save_callback, skip_on_admin_save: false
+            after :save, :after_save_callback, skip_on_admin_save: false
+          end
+
+          service = service_klass.new
+          expect(service).to receive(:before_save_callback)
+          expect(service).to receive(:after_save_callback)
+
+          service.admin_save(object)
+        end
+
+        it "should invoke callbacks if skip_on_admin_save option missing" do
+          service_klass = Class.new(ApplicationService) do
+            before :save, :before_save_callback
+            after :save, :after_save_callback
+          end
+
+          service = service_klass.new
+          expect(service).to receive(:before_save_callback)
+          expect(service).to receive(:after_save_callback)
+
+          service.admin_save(object)
+        end
+
+        it "should invoke callbacks on save even if skip_on_admin_save is true" do
+          service_klass = Class.new(ApplicationService) do
+            before :save, :before_save_callback, skip_on_admin_save: true
+            after :save, :after_save_callback, skip_on_admin_save: true
+          end
+
+          service = service_klass.new
+          expect(service).to receive(:before_save_callback)
+          expect(service).to receive(:after_save_callback)
+
+          service.save(object)
+        end
+
+        it "should invoke callbacks on save even if admin_save raises exception" do
+          service_klass = Class.new(ApplicationService) do
+            before :save, :before_save_callback, skip_on_admin_save: true
+            after :save, :after_save_callback, skip_on_admin_save: true
+          end
+
+          expect(object).to receive(:save).and_raise(StandardError)
+
+          service = service_klass.new
+          expect(service).to receive(:before_save_callback).once
+          expect(service).to receive(:after_save_callback).once
+
+          expect { service.admin_save(object) }.to raise_error
+
+          expect(object).to receive(:save).and_return(true)
+
+          service.save(object)
+        end
+      end
+
+      context 'skip' do
+        it "should skip callbacks if skip_on_admin_save for create" do
+          service_klass = Class.new(ApplicationService) do
+            before :create, :before_create_callback, skip_on_admin_save: true
+            after :create, :after_create_callback, skip_on_admin_save: true
+          end
+
+          service = service_klass.new
+          expect(service).not_to receive(:before_create_callback)
+          expect(service).not_to receive(:after_create_callback)
+
+          service.admin_save(object)
+        end
+
+        it "should skip callbacks if skip_on_admin_save for update" do
+          service_klass = Class.new(ApplicationService) do
+            before :save, :before_save_callback, skip_on_admin_save: true
+            after :save, :after_save_callback, skip_on_admin_save: true
+          end
+
+          service = service_klass.new
+          expect(service).not_to receive(:before_save_callback)
+          expect(service).not_to receive(:after_save_callback)
+
+          service.admin_save(object)
+        end
+      end
+    end
+  end
+
   describe 'callbacks' do
     let(:object) { double(new_record?: false, save: true) }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: application_service
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Nathan Woodhull
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-20 00:00:00.000000000 Z
+date: 2014-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport