apollo-federation 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 446efb9b173791b74a0bfc8b6dff598f2540517b30fdcf3425a0b332303bf1f6
-  data.tar.gz: e7ddcd984c0ce2d9573b98459006577478bbdb5cc5347f6198eba17b5aae5494
+  metadata.gz: 4cb2c9ccf550442d466468618bc9656f3fcdd11dc945583ad8fcf4ffd9ab2101
+  data.tar.gz: ee79a0157e41dd292ab53d39a8edae5f220aac31abf9d69bfb6711c9dd16b7d4
 SHA512:
-  metadata.gz: f1978c886ed68a721c277c6589c8890445480a85998120f7454b40f45144afebb63f55ba8425473e1d04a82c39e1005639b368c5cd90d0cf5d0138a1180fb0a2
-  data.tar.gz: 811f1c1eaf17c1c4a795b6bd1bce88a95cb2699d0e4d54e3dc152a04702f340e25b4af158de14f9d5e954d564a6693d048df7ff76ac93571abac8d00f894529e
+  metadata.gz: 5004bc11baa692fc1a900f30ada8210bdaef68ea55eb40b22c67db11257bd2890c186958e411f3fea7fc678ee3556301ab606de1a67b5a6f64e5ac165e180c3d
+  data.tar.gz: 1e2fa18db2eb2f92997724a7c60fafec104fad63d0e3ad84ba72202c70221d32f342e3df96164b6c5619cb02b42c231912407ce17591de72856385a77f000b79

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 0.2.0 (Aug 1, 2019)
+
+### Features
+
+* Add a description to the `_Service` type ([#10](https://github.com/Gusto/apollo-federation-ruby/pull/10))
+
+### Bug fixes
+
+* Fix an issue coercing the `_Any` scalar in a Rails app ([#13](https://github.com/Gusto/apollo-federation-ruby/pull/13))
+
 ## 0.1.0 (Jun 21, 2019)
 
 * First release

data/README.md

@@ -147,6 +147,10 @@ class User < BaseObject
 end
 ```
 
-## Known Limitations and Issues
+## Known Issues and Limitations
  - Currently only works with class-based schemas
- - Does add directives to the output of `Schema.to_definition`. Since `graphql-ruby` doesn't natively support schema directives, the directives will only be visible to the [Apollo Gateway](https://www.apollographql.com/docs/apollo-server/api/apollo-gateway/) through the `Query._service` field (see the [Apollo Federation specification](https://www.apollographql.com/docs/apollo-server/federation/federation-spec/))
+ - Does not add directives to the output of `Schema.to_definition`. Since `graphql-ruby` doesn't natively support schema directives, the directives will only be visible to the [Apollo Gateway](https://www.apollographql.com/docs/apollo-server/api/apollo-gateway/) through the `Query._service` field (see the [Apollo Federation specification](https://www.apollographql.com/docs/apollo-server/federation/federation-spec/))
+
+## Maintainers
+ * [Rylan Collins](https://github.com/rylanc)
+ * [Noa Elad](https://github.com/noaelad)

data/lib/apollo-federation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'apollo-federation/version'
 require 'apollo-federation/schema'
 require 'apollo-federation/object'

data/lib/apollo-federation/any.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'graphql'
 
 module ApolloFederation
@@ -6,9 +8,11 @@ module ApolloFederation
 
     def self.coerce_input(value, _ctx)
       # TODO: Should we convert it to a Mash-like object?
-      result = Hash.new
-      value.each_key do |key|
-        result[key.to_sym] = value[key]
+      result = {}
+
+      # `value` can be an ActionController::Parameters instance
+      value.each_pair do |key, val|
+        result[key.to_sym] = val
       end
 
       result

data/lib/apollo-federation/entities_field.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'graphql'
 require 'apollo-federation/any'
 
@@ -24,14 +26,17 @@ module ApolloFederation
         type = context.warden.get_type(typename)
         if type.nil? || type.kind != GraphQL::TypeKinds::OBJECT
           # TODO: Raise a specific error class?
-          raise "The _entities resolver tried to load an entity for type \"#{typename}\", but no object type of that name was found in the schema"
+          raise "The _entities resolver tried to load an entity for type \"#{typename}\"," \
+                ' but no object type of that name was found in the schema'
         end
 
         # TODO: Handle non-class types?
         type_class = type.metadata[:type_class]
-        result = type_class.respond_to?(:resolve_reference) ?
-          type_class.resolve_reference(reference, context) :
-          reference
+        if type_class.respond_to?(:resolve_reference)
+          result = type_class.resolve_reference(reference, context)
+        else
+          result = reference
+        end
 
         # TODO: This isn't 100% correct: if (for some reason) 2 different resolve_reference calls
         # return the same object, it might not have the right type

data/lib/apollo-federation/entity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'graphql'
 
 module ApolloFederation

data/lib/apollo-federation/federated_document_from_schema_definition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'graphql'
 require 'apollo-federation/service'
 
@@ -7,16 +9,18 @@ module ApolloFederation
       '_Any',
       '_Entity',
       '_Service',
-    ]
+    ].freeze
     FEDERATION_QUERY_FIELDS = [
       '_entities',
       '_service',
-    ]
+    ].freeze
 
     def build_object_type_node(object_type)
       object_node = super
       if query_type?(object_type)
-        federation_fields = object_node.fields.select { |field| FEDERATION_QUERY_FIELDS.include?(field.name) }
+        federation_fields = object_node.fields.select do |field|
+          FEDERATION_QUERY_FIELDS.include?(field.name)
+        end
         federation_fields.each { |field| object_node = object_node.delete_child(field) }
       end
       merge_directives(object_node, object_type.metadata[:federation_directives])
@@ -48,7 +52,7 @@ module ApolloFederation
       (directives || []).each do |directive|
         node = node.merge_directive(
           name: directive[:name],
-          arguments: build_arguments_node(directive[:arguments])
+          arguments: build_arguments_node(directive[:arguments]),
         )
       end
       node

data/lib/apollo-federation/field.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'apollo-federation/has_directives'
 
 module ApolloFederation

data/lib/apollo-federation/has_directives.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 module ApolloFederation
   module HasDirectives

data/lib/apollo-federation/object.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'apollo-federation/has_directives'
 
 module ApolloFederation

data/lib/apollo-federation/schema.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'apollo-federation/entities_field'
 require 'apollo-federation/service_field'
 require 'apollo-federation/entity'
@@ -28,10 +30,10 @@ module ApolloFederation
 
         possible_entities = orig_defn.types.values.select do |type|
           !type.introspection? && !type.default_scalar? &&
-            type.metadata[:federation_directives]&.any? {|directive| directive[:name] == 'key'}
+            type.metadata[:federation_directives]&.any? { |directive| directive[:name] == 'key' }
         end
 
-        if possible_entities.length > 0
+        if !possible_entities.empty?
           entity_type = Class.new(Entity) do
             possible_types(*possible_entities)
           end
@@ -46,7 +48,7 @@ module ApolloFederation
       end
 
       def federation_sdl
-        @sdl ||= begin
+        @federation_sdl ||= begin
           document_from_schema = FederatedDocumentFromSchemaDefinition.new(self)
           GraphQL::Language::Printer.new.print(document_from_schema.document)
         end
@@ -54,4 +56,3 @@ module ApolloFederation
     end
   end
 end
-

data/lib/apollo-federation/service.rb

@@ -1,8 +1,13 @@
+# frozen_string_literal: true
+
 require 'graphql'
 
 module ApolloFederation
   class Service < GraphQL::Schema::Object
     graphql_name '_Service'
+    description 'The sdl representing the federated service capabilities. Includes federation ' \
+      'directives, removes federation types, and includes rest of full schema after schema ' \
+      'directives have been applied'
 
     field(:sdl, String, null: true)
   end

data/lib/apollo-federation/service_field.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'graphql'
 require 'apollo-federation/service'
 

data/lib/apollo-federation/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApolloFederation
-  VERSION = "0.1.0"
+  VERSION = '0.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: apollo-federation
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Noa Elad
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-21 00:00:00.000000000 Z
+date: 2019-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -25,6 +25,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: actionpack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -53,6 +67,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -67,6 +95,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.72.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.72.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Ruby implementation of Apollo Federation
 email:
 - noa.elad@gusto.com