apill 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c68aa89f529dc07063d53a0f2e53e210b606c1bb
-  data.tar.gz: 6fc4b20a268b92b45d8e2e3f0b6ae195b118827d
+  metadata.gz: 29f4ac346214c2037d109175b797ef0af4c78ca7
+  data.tar.gz: 433f57a538f9d55bd4503115eb01ccb621157a3f
 SHA512:
-  metadata.gz: 02544a5f552ca8205ccd6aff687b60460f001c06b49db580ebfc9ad2cc841e5af9af65440af2494d1ba3f4baf6c56b002d68ce1afc720b90c5b0192d62d7c509
-  data.tar.gz: 9ac237ebc9b635993885a286f8b22353c98c655efc68fde7c50056dba9cbc332298465e328bcc80c8cf23cc6a0f44eab59c21aa381943c06a43c54993fe8a4a5
+  metadata.gz: 0d2b742bd8b2ce19ddb52b2efb4e740d42196f2243447b70b775741013e1d74287399a592b402de96020b7bf644e71f0c1f53983abf1c9e1757172d2432e37bf
+  data.tar.gz: e65b063cb1653c9be04b248bbc2de33d63931441d44db7f5418a147a3b0972ae15d78c2e2a005d8593343ad030247d217fadb31c14e06b857560211d4dd4903a

data/lib/apill/parameters/filter.rb

@@ -4,20 +4,30 @@ class   Filter
   attr_accessor :raw_parameters
 
   def initialize(raw_parameters)
-    self.raw_parameters = raw_parameters
+    self.raw_parameters = raw_parameters || {}
   end
 
-  def each_with_object(memoized)
-    raw_parameters.each do |raw_parameter|
-      next if raw_parameter[0] == 'query' ||
-              raw_parameter[1] == '' ||
-              raw_parameter[1].nil?
+  def present?
+    compacted_parameters.any?
+  end
 
-      memoized = yield raw_parameter[0], raw_parameter[1], memoized
+  def each_with_object(memoized)
+    compacted_parameters.each do |name, value|
+      memoized = yield name, value, memoized
     end
 
     memoized
   end
+
+  private
+
+  def compacted_parameters
+    @compacted_parameters ||= raw_parameters.reject do |name, value|
+                                name == 'query' ||
+                                value == '' ||
+                                value.nil?
+    end
+  end
 end
 end
 end

data/lib/apill/parameters/index.rb

@@ -6,7 +6,11 @@ class   Index
   attr_accessor :raw_parameters
 
   def initialize(raw_parameters)
-    self.raw_parameters = raw_parameters
+    self.raw_parameters = raw_parameters || {}
+  end
+
+  def present?
+    query
   end
 
   def query

data/lib/apill/parameters/page.rb

@@ -1,13 +1,18 @@
 module  Apill
 class   Parameters
 class   Page
+  PAGING_PARAMETERS     = %w{number size limit offset cursor}
   DEFAULT_STARTING_PAGE = 1
   DEFAULT_PAGE_SIZE     = 25
 
   attr_accessor :raw_parameters
 
   def initialize(raw_parameters)
-    self.raw_parameters = raw_parameters
+    self.raw_parameters = raw_parameters || {}
+  end
+
+  def present?
+    (raw_parameters.keys & PAGING_PARAMETERS).any?
   end
 
   def page_number

data/lib/apill/parameters/sort.rb

@@ -6,7 +6,11 @@ class   Sort
   attr_accessor :raw_parameters
 
   def initialize(raw_parameters)
-    self.raw_parameters = raw_parameters ? raw_parameters.split(',') : ['-created_at']
+    self.raw_parameters = raw_parameters ? raw_parameters.split(',') : []
+  end
+
+  def present?
+    raw_parameters.any?
   end
 
   def to_h

data/lib/apill/resource/processors/indexing.rb

@@ -7,7 +7,7 @@ class  Indexing
   attr_accessor :resource,
                 :parameters
 
-  def initialize(resource, parameters)
+  def initialize(resource, parameters = {})
     self.resource   = resource
     self.parameters = Parameters::Index.new(parameters['filter'] || {})
   end
@@ -21,8 +21,7 @@ class  Indexing
   end
 
   def processed
-    return resource unless resource.respond_to?(:for_query) &&
-                           parameters.query
+    return resource unless parameters.present?
 
     resource.for_query(parameters.query)
   end

data/lib/apill/resource/processors/paging.rb

@@ -21,6 +21,8 @@ class   Paging
   end
 
   def processed
+    return resource unless parameters.present?
+
     resource.page(parameters.page_number).
              per(parameters.per_page)
   end

data/lib/apill/resource/processors/sorting.rb

@@ -21,6 +21,8 @@ class   Sorting
   end
 
   def processed
+    return resource unless parameters.present?
+
     resource.order(parameters.to_h)
   end
 

data/lib/apill/version.rb

@@ -1,3 +1,3 @@
 module Apill
-  VERSION = '3.0.0'
+  VERSION = '3.0.1'
 end

data/spec/apill/resource/processors/indexing_spec.rb

@@ -5,6 +5,13 @@ module    Apill
 module    Resource
 module    Processors
 describe  Indexing do
+  let(:indexing_resource) { double }
+
+  it 'does not do anything if indexing params are not passed in' do
+    indexing = Indexing.new(indexing_resource)
+
+    expect(indexing.processed).to eql indexing_resource
+  end
 end
 end
 end

data/spec/apill/resource/processors/paging_spec.rb

@@ -9,7 +9,10 @@ describe  Paging do
   let(:processed_resource) { double }
 
   it 'can return a default page' do
-    paging = Paging.new(paging_resource)
+    paging = Paging.new(paging_resource,
+                        'page' => {
+                          'size' => 10,
+                        })
 
     allow(processed_resource).to receive(:total_pages).and_return  10
     allow(processed_resource).to receive(:current_page).and_return 1
@@ -20,7 +23,7 @@ describe  Paging do
                               with(1).
                               and_return paging_resource
     allow(paging_resource).to receive(:per).
-                              with(25).
+                              with(10).
                               and_return processed_resource
 
     expect(paging.processed).to eql processed_resource
@@ -48,6 +51,22 @@ describe  Paging do
 
     expect(paging.processed).to eql processed_resource
   end
+
+  it 'does not consider non-ideomatic page params as valid' do
+    paging = Paging.new(paging_resource,
+                        'page' => {
+                          'nombre' => 5,
+                          'tamano' => 10,
+                        })
+
+    expect(paging.processed).to eql paging_resource
+  end
+
+  it 'does not do anything if page params are not passed in' do
+    paging = Paging.new(paging_resource)
+
+    expect(paging.processed).to eql paging_resource
+  end
 end
 end
 end

data/spec/apill/resource/processors/sorting_spec.rb

@@ -7,21 +7,6 @@ module    Processors
 describe  Sorting do
   let(:sorting_resource) { double }
 
-  it 'can return a default sort' do
-    sorting = Sorting.new(sorting_resource)
-
-    allow(sorting_resource).to receive(:order).
-                               with('created_at' => 'desc').
-                               and_return('sorted')
-
-    expect(sorting.processed).to eql 'sorted'
-    expect(sorting.meta).to      eql(
-      'sort' => {
-        'created_at' => 'desc',
-      },
-    )
-  end
-
   it 'can return an ascending sort' do
     sorting = Sorting.new(sorting_resource, 'sort' => 'my_attribute')
 
@@ -68,6 +53,12 @@ describe  Sorting do
       },
     )
   end
+
+  it 'does not do anything if sorting params are not passed in' do
+    sorting = Sorting.new(sorting_resource)
+
+    expect(sorting.processed).to eql sorting_resource
+  end
 end
 end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: apill
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - jfelchner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2015-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: human_error