api_me 0.9.3 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13972ff9aba7a136befeba0bbc99baff56bd5b48882de8fb62c439a3eeafde7b
-  data.tar.gz: 4742b40b1123e162ff279abbeea1410f99550bc8d0468f5136c882b4a7ac2af7
+  metadata.gz: aed5d142524f6fbf74249ad247e7570f6043bf46fab0d142025333464c95b615
+  data.tar.gz: 5533d6ed2788081506b6ab79f448ae58e91bc4cdada605e9e086d2875ffe3ed6
 SHA512:
-  metadata.gz: b4214d4d9a69499ec77ffe564e328d68b99ec3dfba66e61916ce22c94108591999c5ece0b61aa6e1d27134cefd5b9bb35d380dacf600342942b5cf8367102014
-  data.tar.gz: 989b0117ab862e775848bf30010c800bec998c3e0c3497abfefc5e70eda83e19358f5dbfdeb1bccc252779c21a2f5143d0733ac086e2627b6a0e13b8a6313d45
+  metadata.gz: 18c8ffeed181d5346baddf0e705e4a5507222fc65248f90d12ff845bde6d3b223a54ec740c99a29e53f151d29c0a26acbacb498f0fafd896b718b6185a35633b
+  data.tar.gz: 2041df09681bb28d2c87b31993ad6917a5c6c778657fa28330ea629e1f3ef4ea9b87886212e0a049267127cde0b1aec4efb5a9dd3e5dfc7ba0e86a1e511ea655

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    api_me (0.9.3)
+    api_me (0.9.4)
       active_model_serializers (~> 0.10.0)
       activerecord (>= 4.1.16)
       activesupport (>= 4.1.16)

data/{LICENCE → LICENSE}

@@ -1,4 +1,4 @@
-Copyright (c) 2014 Sam Clopton
+Copyright (c) 2018 Wildland Labs Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/lib/api_me.rb

@@ -76,14 +76,21 @@ module ApiMe
 
   def show
     @object = find_resource
-    authorize @object
+    authorize_resource @object
 
     render json: @object, root: singular_root_key, serializer: serializer_klass
   end
 
+  def new
+    @object = model_klass.new
+    authorize_resource @object
+
+    render_errors(['new endpoint not supported'], 404)
+  end
+
   def create
-    @object = model_klass.new(object_params)
-    authorize @object
+    @object = build_resource
+    authorize_resource @object
     @object.save!(object_params)
 
     render status: 201, json: @object, root: singular_root_key, serializer: serializer_klass
@@ -91,9 +98,16 @@ module ApiMe
     handle_errors(e)
   end
 
+  def edit
+    @object = find_resource
+    authorize_resource @object
+
+    render_errors(['edit endpoint not supported'], 404)
+  end
+
   def update
     @object = find_resource
-    authorize @object
+    authorize_resource @object
     @object.update!(object_params)
 
     head 204
@@ -103,8 +117,9 @@ module ApiMe
 
   def destroy
     @object = find_resource
-    authorize @object
+    authorize_resource @object
     @object.destroy
+
     head 204
   rescue ActiveRecord::RecordInvalid => e
     handle_errors(e)
@@ -177,10 +192,10 @@ module ApiMe
     ).results
   end
 
-  def sort_scope(scope)
+  def sort_scope(scope, sortable_params=sort_params)
     sort_klass.new(
         scope: scope,
-        sort_params: sort_hash
+        sort_params: sortable_params
     ).results
   end
 
@@ -201,15 +216,15 @@ module ApiMe
     params[:filters]
   end
 
-  def sort_hash
-    sort_params
+  def find_resource
+    @find_resource ||= model_klass.find_by_id!(params[:id])
   end
 
-  def sort_params
-    params[:sort]
+  def build_resource
+    @build_resource ||= model_klass.new(object_params)
   end
 
-  def find_resource
-    model_klass.find_by_id!(params[:id])
+  def authorize_resource(resource)
+    authorize resource
   end
 end

data/lib/api_me/version.rb

@@ -1,3 +1,3 @@
 module ApiMe
-  VERSION = '0.9.3'.freeze
+  VERSION = '0.9.4'.freeze
 end

data/lib/generators/api_me/controller/controller_generator.rb

@@ -76,7 +76,7 @@ module ApiMe
         in_root do
           insert_into_file(
             'config/routes.rb',
-            "      resources :#{resource_name}\n",
+            "      resources :#{resource_name}, only: [:show, :index, :create, :update, :destroy]\n",
             after: "namespace :#{controllers_api_version} do\n"
           )
         end

data/spec/acceptance/api/v1/users_spec.rb

@@ -23,15 +23,21 @@ describe 'Users API' do
     expect(last_response.status).to eq(404)
   end
 
-  it 'sends an individual user' do
-    user = User.create(username: 'Test')
+  it 'returns a 404 for new' do
 
-    get '/api/v1/users/' + user.id.to_s + '/'
+    get '/api/v1/users/new'
 
-    expect(last_response.status).to eq(200)
-    json = JSON.parse(last_response.body)
+    expect(last_response.status).to eq(404)
+  end
+
+  it 'returns a 404 for edit' do
+    user = User.create(username: 'Foo')
+
+    expect(user.username).to eq('Foo')
 
-    expect(json['user']['id']).to eq(user.id)
+    get '/api/v1/users/' + user.id.to_s + '/edit'
+
+    expect(last_response.status).to eq(404)
   end
 
   it 'creates a new user' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api_me
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
 platform: ruby
 authors:
 - Sam Clopton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-16 00:00:00.000000000 Z
+date: 2018-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -180,7 +180,7 @@ files:
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
-- LICENCE
+- LICENSE
 - README.md
 - Rakefile
 - api_me.gemspec