api_hammer 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47d49032018338bda7b3582ad0ee4ced9872023f
-  data.tar.gz: f29e3cddca5d09853af22dabeec7f1aaaa3bc809
+  metadata.gz: 99e31dd1684a1ad4d1b0ae026d71e1bea97be2aa
+  data.tar.gz: 4de47e712b79178f0bc475471710b84edc0659f8
 SHA512:
-  metadata.gz: 25525ad6d1eda4cbb4d9b61cbcf270a91255fa10278bb89774cdabdafb85d4a5ef591f5d9725759d557a3763ac1fbbbc148e394242cc562b8ad97e938ebdf8bd
-  data.tar.gz: 6ac7d6ea07947ed9a6b5dbf0a6a407d3e275cf53b762fdf7a0ff031422cbf3c832e7b9a2c8e1b7258d58ebf90a631bc9e616418aea619d1e8488120320115cad
+  metadata.gz: 38b4eb2e9f73b1b3b924904400b485c19e086a5c499fb68abee994acd7ac113a5a8668ead73757f34948c74ae0a4c5387ddacf4ddad85f7bc80537af1fac2451
+  data.tar.gz: 4e1abf7ff0cecc5c1aead145d8c73e4eb792719da9a134b755596a153204f6564e6a6266acdafeee8854eff3f101ffa2f1e4f47545b24852b8ac058eb8503c42

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.3.2
+- ActiveRecord::Base.cache_find_by support finding on associations, fix bind detection with symbols 
+
 # 0.3.1
 - bugfix ActiveRecord::Base.cache_find_by
 

data/lib/api_hammer/active_record_cache_find_by.rb

@@ -23,7 +23,7 @@ module ActiveRecord
     def one_record_with_caching(can_cache = true)
       actual_right = proc do |where_value|
         if where_value.right.is_a?(Arel::Nodes::BindParam)
-          column, value = bind_values.detect { |(column, value)| column.name == where_value.left.name }
+          column, value = bind_values.detect { |(column, value)| column.name.to_s == where_value.left.name.to_s }
           value
         else
           where_value.right

data/lib/api_hammer/version.rb

@@ -1,3 +1,3 @@
 module ApiHammer
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/test/active_record_cache_find_by_test.rb

@@ -36,6 +36,7 @@ class Album < ActiveRecord::Base
   cache_find_by(:performer)
   cache_find_by(:title, :performer)
   cache_find_by(:tracks)
+  cache_find_by(:catalog_xid, :title)
 end
 
 class Catalog < ActiveRecord::Base
@@ -63,6 +64,7 @@ describe 'ActiveRecord::Base.cache_find_by' do
 
   after do
     Album.all.each(&:destroy)
+    Catalog.all.each(&:destroy)
   end
 
   it('caches #find by primary key') do
@@ -157,6 +159,13 @@ describe 'ActiveRecord::Base.cache_find_by' do
     assert_caches("cache_find_by/albums/performer/y/title/x") { assert Album.where(:title => 'x', :performer => 'y').first }
   end
 
+  it('caches with two attributes on an association with a where') do
+    c = Catalog.create!
+    Album.create!(:title => 'x', :performer => 'y', :catalog_xid => c.id)
+    c = Catalog.first
+    assert_caches("cache_find_by/albums/catalog_xid/#{c.id}/title/x") { assert c.albums.where(:title => 'x').first }
+  end
+
   it('flushes cache on save') do
     album = Album.create!(:title => 'x', :performer => 'y')
     assert_caches(key1 = "cache_find_by/albums/performer/y/title/x") { assert Album.find_by_title_and_performer('x', 'y') }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api_hammer
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Ethan