api_hammer 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9927a5896d97412a1668d60c7f341649cca1232c
-  data.tar.gz: 0d65a4cf1399613c3f1433f0a456f88ae1cf9008
+  metadata.gz: 47d49032018338bda7b3582ad0ee4ced9872023f
+  data.tar.gz: f29e3cddca5d09853af22dabeec7f1aaaa3bc809
 SHA512:
-  metadata.gz: 1f1fdf86e116a112eee8a09420b62d356ce66ac8522e41ef30470862ed7c29491e0cbe7fa02e5fe7b63bb834887d572a68feeeb5fc9ab5eede0db6ddebe3e95c
-  data.tar.gz: 51a41edd33b376e0d2cc9e49ff86fa0d60afa7cb8dbda2d4ebac12b10f64c300002813db33f79d7f914d52a9f9636f87c11bea584aa06fcf081705b81e96ecb6
+  metadata.gz: 25525ad6d1eda4cbb4d9b61cbcf270a91255fa10278bb89774cdabdafb85d4a5ef591f5d9725759d557a3763ac1fbbbc148e394242cc562b8ad97e938ebdf8bd
+  data.tar.gz: 6ac7d6ea07947ed9a6b5dbf0a6a407d3e275cf53b762fdf7a0ff031422cbf3c832e7b9a2c8e1b7258d58ebf90a631bc9e616418aea619d1e8488120320115cad

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.3.1
+- bugfix ActiveRecord::Base.cache_find_by
+
 # 0.3.0
 - ActiveRecord::Base.cache_find_by
 

data/lib/api_hammer/active_record_cache_find_by.rb

@@ -33,7 +33,7 @@ module ActiveRecord
       can_cache &&= cache_find_bys &&
         !loaded? && # if it's loaded no need to hit cache 
         where_values.all? { |wv| wv.is_a?(Arel::Nodes::Equality) } && # no inequality or that sort of thing 
-        cache_find_bys.include?(where_values.map { |wv| wv.left.name }.sort) && # any of the set of where-values to cache match this relation 
+        cache_find_bys.include?(where_values.map { |wv| wv.left.name.to_s }.sort) && # any of the set of where-values to cache match this relation 
         where_values.map(&actual_right).all? { |r| r.is_a?(String) || r.is_a?(Numeric) } && # check all right side values are simple types, number or string 
         offset_value.nil? &&
         joins_values.blank? &&

data/lib/api_hammer/version.rb

@@ -1,3 +1,3 @@
 module ApiHammer
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/test/active_record_cache_find_by_test.rb

@@ -24,16 +24,24 @@ ActiveRecord::Schema.define do
     table.column :title, :string
     table.column :performer, :string
     table.column :tracks, :integer
+    table.column :catalog_xid, :integer
+  end
+  create_table :catalogs do |table|
   end
 end
 
 class Album < ActiveRecord::Base
+  belongs_to :catalog, :foreign_key => :catalog_xid
   cache_find_by(:id)
   cache_find_by(:performer)
   cache_find_by(:title, :performer)
   cache_find_by(:tracks)
 end
 
+class Catalog < ActiveRecord::Base
+  has_many :albums, :foreign_key => :catalog_xid
+end
+
 class VinylAlbum < Album
   self.finder_cache = ActiveSupport::Cache::MemoryStore.new
 end
@@ -198,4 +206,12 @@ describe 'ActiveRecord::Base.cache_find_by' do
     Album.where(:performer => 'y', :title => 'x').first
     assert_equal 'z', Album.where(:performer => 'y/title/x').first.title
   end
+
+  it 'works with a symbol on the left' do
+    # this makes an association with :catalog_xid as the left side of a where_value. these are usually 
+    # strings. this just makes sure it doesn't error out. 
+    c = Catalog.create!
+    c = Catalog.first
+    c.albums.where(:title => 'y').first
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api_hammer
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Ethan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-17 00:00:00.000000000 Z
+date: 2014-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack