api_for_asana 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f8625a70dc2a0bbcf9db770477c38f95e32fa44e13bc71a60276be983d897a5
-  data.tar.gz: 7b9eb78aa907c57ffb7ed4da99136429dcfa1d9de6d645f2ec380fdfec2d773b
+  metadata.gz: 7b3f292508c7d9a1e1c68a73afb5402518b9e1e45b199543102d5209dec48dd5
+  data.tar.gz: 8d1b2d3080291a30d04af55879bee1f61b4c4dc6ae660c942197f30b80cea8fb
 SHA512:
-  metadata.gz: 90ec20d8ed487721653805567945dab5f2f33d09a1edc22a657027991e73cf37c01af43fc7f2da66d9a5dc377b133906156272d3d50f31a330cb647db4d98767
-  data.tar.gz: f3cd0e58a11cfa63f07c7e63c74128850700034d1079425283883971782990addf5c25d37d5158fd9a83ec9678a77a25c0044241d01577c05aaf54628d225375
+  metadata.gz: b48c58ea6466aec0674cfca314bdb2f3b44055e10ed593a99839e36c9fa60e18ce64bd7fc0c0fe200775d3dfd372718ba780f2f30109200d816e0d7f787d3f67
+  data.tar.gz: 16c0358509964889cf39b742b7352280e85b342b32138be376624d0b2b0f968c2403ce16bd3d3c51302c8dfdc84b1f4df55250f67c54975e3f5f7262437d2fde

data/api_for_asana.gemspec

@@ -12,6 +12,8 @@ Gem::Specification.new do |spec|
     spec.files = Dir['lib/**/*.rb', 'LICENSE', 'spec/**/*.rb', 'api_for_asana.gemspec', 'README.md', 'Gemfile']
     spec.add_development_dependency 'rspec'
     spec.add_development_dependency 'rspec-rails'
+    spec.add_development_dependency 'dotenv'
+    spec.add_development_dependency 'webmock'
 
 
     # spec.metadata = {

data/lib/api_for_asana/helper.rb

@@ -0,0 +1,8 @@
+module Helper
+  def send_http_request(req, uri)
+    req['Authorization'] = "Bearer #{ENV['API_KEY']}"
+     Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+      http.request(req)
+    end
+  end
+end

data/lib/api_for_asana/version.rb

@@ -1,3 +1,3 @@
 module Version
-    VERSION = "0.0.2"
+    VERSION = '0.0.3'
 end

data/lib/api_for_asana.rb

@@ -1,72 +1,52 @@
 require 'net/http'
+require 'dotenv'
+require_relative './api_for_asana/helper'
+
 module ApiForAsana
-    
-  def get_sections
-    req = Net::HTTP::Get.new(project_url)
-    req['Authorization'] = token
-    Net::HTTP.start(project_url.hostname, project_url.port, use_ssl: true) do |http|
-      http.request(req)
-    end
+  include Helper
+  Dotenv.load
+  def get_section(project_id)
+    uri = URI("#{base_url}/projects/#{project_id}/sections")
+    req = Net::HTTP::Get.new(uri)
+    send_http_request(req, uri)
   end
 
-  def get_tasks(id)
-    uri = URI("https://app.asana.com/api/1.0/sections/#{id}/tasks")
+  def get_tasks(task_id)
+    uri = URI("#{base_url}/sections/#{task_id}/tasks")
     req = Net::HTTP::Get.new(uri)
-    req['Authorization'] = token
-    Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
-      http.request(req)
-    end
+    send_http_request(req, uri)
   end
 
-  def update_section(id, name)
-    uri = section_url(id)
+  def update_section(section_id, name)
+    uri = URI("#{base_url}/sections/#{section_id}")
     req = Net::HTTP::Put.new(uri)
-    req['Authorization'] = token
     req.set_form_data(name: name)
-    Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
-      http.request(req)
-    end
+    send_http_request(req, uri)
   end
 
-  def create_section(name)
-    req = Net::HTTP::Post.new(project_url)
-    req['Authorization'] = token
+  def create_section(project_id, name)
+    uri = URI("#{base_url}/projects/#{project_id}/sections")
+    req = Net::HTTP::Post.new(uri)
     req.set_form_data(name: name)
-    Net::HTTP.start(project_url.hostname, project_url.port, use_ssl: true) do |http|
-      http.request(req)
-    end
+    send_http_request(req, uri)
   end
 
-  def delete_section(id)
-    uri = section_url(id)
+  def delete_section(section_id)
+    uri = URI("#{base_url}/sections/#{section_id}")
     req = Net::HTTP::Delete.new(uri)
-    req['Authorization'] = token
-    Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
-      http.request(req)
-    end
+    send_http_request(req, uri)
   end
 
-  def update_task(id, name)
-    uri = URI("https://app.asana.com/api/1.0/tasks/#{id}")
+  def update_task(task_id, name)
+    uri = URI("#{base_url}/tasks/#{task_id}")
     req = Net::HTTP::Put.new(uri)
-    req['Authorization'] = token
     req.set_form_data(name: name)
-    Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
-      http.request(req)
-    end
+    send_http_request(req, uri)
   end
 
   private
 
-  def project_url
-    URI('https://app.asana.com/api/1.0/projects/1204884610326667/sections')
-  end
-
-  def token
-    'Bearer 1/1204884589111623:bcd5f3b78ab8580dab44dda843374ad5'
-  end
-
-  def section_url(id)
-    URI("https://app.asana.com/api/1.0/sections/#{id}")
+  def base_url
+    'https://app.asana.com/api/1.0'
   end
 end

data/spec/api_for_asana_spec.rb

@@ -1,122 +1,73 @@
 # frozen_string_literal: true
 
-
-
 require 'spec_helper'
-
+require 'webmock/rspec'
 require 'api_for_asana'
 
-describe 'ApiForAsana' do
-
-  let(:dummy) { Dummy.new }
-
-
+describe ApiForAsana do
+  let(:base_url) { 'https://app.asana.com/api/1.0' }
+  let(:api) { Class.new { extend ApiForAsana } }
 
   context 'When we try to access all section' do
-
     it 'should return status code 200' do
-
-      res = dummy.get_sections
-
+      stub_request(:get, "#{base_url}/projects/1204884610326667/sections")
+        .with(headers: { 'Authorization' => "Bearer #{ENV['API_KEY']}" })
+      res = api.get_section('1204884610326667')
       expect(res.code).to eq('200')
-
-    end
-
-  end
-
-
-
-  context 'When we try to access a task list with wrong section id' do
-
-    it 'should return status code 404' do
-
-      res = dummy.get_tasks('45689')
-
-      expect(res.code).to eq('404')
-
     end
-
   end
 
-  context 'When we try to access a task list with correct section id' do
-
+  context 'When we try to access a task list' do
     it 'should return status code 200' do
-
-      res = dummy.get_tasks('1204884610326670')
-
+      stub_request(:get, "#{base_url}/sections/45689/tasks")
+        .with(headers: { 'Authorization' => "Bearer #{ENV['API_KEY']}" })
+      res = api.get_tasks('45689')
       expect(res.code).to eq('200')
-
     end
-
   end
 
-  context 'When we try to update the section' do
 
-    it 'should return status code 200' do
-
-      res = dummy.update_section('1204884610326671', 'Completed')
 
+  context 'When we try to update the section' do
+    it 'should return status code 200' do
+      stub_request(:put, "#{base_url}/sections/1204884610326671")
+        .with(body: {name: 'Approved'}, headers: { 'Authorization' => "Bearer #{ENV['API_KEY']}" })
+        res = api.update_section('1204884610326671', 'Approved')
       expect(res.code).to eq('200')
-
     end
-
   end
 
-  context 'When we try to update the section with wrong id' do
-
-    it 'should return status code 404' do
-
-      res = dummy.update_section('12048846103271', 'Completed')
-
-      expect(res.code).to eq('404')
-
-    end
 
-  end
-  context 'When we try to update the task with wrong id' do
-    it 'should return status code 404' do
-      res = dummy.update_task('12048846103271', 'Draft Logo')
-      expect(res.code).to eq('404')
-    end
-  end
-  context 'When we try to update the task with valid task id' do
+  
+  context 'When we try to update the task' do
     it 'should return status code 200' do
-      res = dummy.update_task('1204884611102860', 'Draft Logo')
+       stub_request(:put, "#{base_url}/tasks/12048846103271")
+        .with(body: {name: 'Draft Logo'}, headers: { 'Authorization' => "Bearer #{ENV['API_KEY']}" })
+      res = api.update_task('12048846103271', 'Draft Logo')
       expect(res.code).to eq('200')
     end
   end
 
-  context 'When we try to create new section' do
 
-    it 'should return status code 201' do
-
-      res = dummy.create_section('Approved')
 
+  context 'When we try to create new section' do
+    it 'should return status code 201' do
+      stub_request(:post, "#{base_url}/projects/1204884610326667/sections")
+        .with(body: {name: 'Approved'}, headers: { 'Authorization' => "Bearer #{ENV['API_KEY']}" }).to_return( body: "", status: 201, headers: {})
+      res = api.create_section('1204884610326667', 'Approved')
       expect(res.code).to eq('201')
-
     end
-
   end
 
-  context 'When we try to delete non empty section' do
-
-    it 'should return status code 404' do
-
-      res = dummy.delete_section('12048846103271')
-
-      expect(res.code).to eq('404')
+  context 'When we try to delete section' do
+    it 'should return status code 200' do
+       stub_request(:delete, "#{base_url}/sections/12048846103271")
+        .with(headers: { 'Authorization' => "Bearer #{ENV['API_KEY']}" })
+      res = api.delete_section('12048846103271')
+      expect(res.code).to eq('200')
 
     end
 
   end
-
-end
-
-
-
-class Dummy
-
-  include ApiForAsana
-
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api_for_asana
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Melashu Amare
@@ -38,6 +38,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: dotenv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email: meshu.amare@gmail.com
 executables: []
@@ -48,6 +76,7 @@ files:
 - README.md
 - api_for_asana.gemspec
 - lib/api_for_asana.rb
+- lib/api_for_asana/helper.rb
 - lib/api_for_asana/version.rb
 - spec/api_for_asana_spec.rb
 - spec/spec_helper.rb