api_banking 0.1.21 → 0.1.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 63f1a044cffb07a5ff168c7705f9f33de188d289
-  data.tar.gz: 3aa1bdaf05ec4d8f7eb432578238568a1a922d0c
+  metadata.gz: 8bcc39fb4a83a34cdc2097a12f6362941fa7d87a
+  data.tar.gz: 26443a306676f60084181ba17c4b9e084a360b41
 SHA512:
-  metadata.gz: 47a37a3e15cb82d98352a649de5e659b5cc271c3be52254bdf0c79634ed997f64c7f0c68d8c797b602a1d8a89ed2331869154415920acee3415c706e203fee9e
-  data.tar.gz: b8798af20bd47a2e050f86a16da48acdb001c572fed1929e52f4186d59cb4e03d514136c89feed9e682014cd22a8c385fb02f369ea282c7abd1c145df6e85dfd
+  metadata.gz: 49025961a3b947e5a781b39cbc760f90ee9d536702cb1668a67ced1ecd70a6316d591a3bd6abe33fe73c1570cb3b07cc763be4614ac5e4b4b74956c828decf67
+  data.tar.gz: c6a721412769773323b7ab75e1ff4fc0bf654964ac3857f228d30a13899ec5022619f1c2bc33c53bc3efed4dc69fb6e48472a7971d5146bf49b84319516da8ae

data/lib/api_banking/json/accountStatement.rb

@@ -2,6 +2,7 @@ module ApiBanking
   class AccountStatement < JsonClient
 
     SERVICE_VERSION = 1
+    CODE_NO_TXN_FOUND = '8504'
 
     attr_accessor :request, :result
 
@@ -61,12 +62,12 @@ module ApiBanking
 
     def self.parse_reply(operationName, reply)
       if reply.kind_of?Fault
-        return reply
+        reply.code == CODE_NO_TXN_FOUND ? AccountStatement::Result.new([]) : reply
       else
         case operationName
           when :getStatement
           sortedTxnArray = Array.new
-          txnArray = reply['Acc_Stmt_DtRng_Res']['Body']['transactionDetails'].sort_by { |e| DateTime.parse(e['pstdDate'])}
+          txnArray = reply['Acc_Stmt_DtRng_Res']['Body']['transactionDetails'].sort_by { |e| parsed_datetime(e['pstdDate'])}
           txnArray.each do |txn|
             txnAmt = parsed_money(
                         txn['transactionSummary']['txnAmt']['amountValue'],

data/lib/api_banking/json/json_client.rb

@@ -60,7 +60,7 @@ module ApiBanking
         if response.headers['Content-Type'] =~ /json/
           j = JSON::parse(response.response_body)
           if j.first[1]['Header']['Status'] == 'FAILED'
-            return Fault.new(j.first[1]['Header']['Status'], j.first[1]['Header']['Error_Cde'], j.first[1]['Header']['Error_Desc'])
+            return Fault.new(j.first[1]['Header']['Error_Cde'], nil, j.first[1]['Header']['Error_Desc'])
           end
           return j
         end

data/lib/api_banking/version.rb

@@ -1,3 +1,3 @@
 module ApiBanking
-  VERSION = "0.1.21"
+  VERSION = "0.1.22"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api_banking
 version: !ruby/object:Gem::Version
-  version: 0.1.21
+  version: 0.1.22
 platform: ruby
 authors:
 - akil