api-resource 0.3.9 → 0.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91739dff4e4b5a22caa8b28e4f293e8a61997f2c
-  data.tar.gz: 70682abac9db8189786bf7597d5629b2fa679b90
+  metadata.gz: 5679beb28b336b6e3de3c3e1dee1531c7e26c0a5
+  data.tar.gz: 989d1b51c9476722951f7b67cb89b60dd5da01d7
 SHA512:
-  metadata.gz: 0135b77b12c1caff85771812cd7d3c2804d37c6ad275babcb3c9ca096df62127bdc3035eefbe2b3c65ccb3c43a90717d8922ba48c5e0b903cbd03470c2614f28
-  data.tar.gz: f084b237826eef6efee741718bfbffbd80602cfeb86c03affd5f79d599aa2343e58bc4de6bc452b2ec4d23b9ed12a09c9b912d4f503ecbcc7bd4119ffe2a775d
+  metadata.gz: 41a52921b7a012c11fd9643fc261152435ee8b12317997381bd52472896b2177f1d3c78c182055cfbc7d319303e174ed322313279865a503d7ae0421498b647b
+  data.tar.gz: 5ef30da9b85cdb575b7f3feada6177149acd481aee0c49a37c038581dcb23798e00fe153eb290e9ee1f316d8c51978de52b868b150542c86919e4374c14a5857

data/lib/api-resource/resource.rb

@@ -59,7 +59,7 @@ module ApiResource
     end
 
     def self.where(options, verb=:get)
-      result = client(verb, *(verb==:get ? [{}, "#{resource_name}?#{options.to_param}"] : [options, resource_name]))
+      result = client(verb, options, resource_name)
       create_resource_collection(result)
     end
 
@@ -129,7 +129,11 @@ module ApiResource
       headers    = { accept: :json }
       req_params = { url: url, method: verb, headers: headers }
       if verb == :get
-        headers[:params] = params
+        # using #to_query instead of URI::encode_www_form to comply with rails convention for query string array values
+        uri = URI.parse(url)
+        sep = (uri.query.blank? || params.to_query.blank?) ? '' : '&'
+        uri.query = [uri.query, params.to_query].join(sep)
+        req_params[:url] = uri.to_s
       else
         req_params[:payload] = params
       end

data/lib/api-resource/version.rb

@@ -1,3 +1,3 @@
 module ApiResource
-  VERSION = '0.3.9'
+  VERSION = '0.3.10'
 end

data/spec/resource_spec.rb

@@ -100,6 +100,12 @@ RSpec.describe ApiResource::Resource do
       result = Blog.where({ title: 'hello world', tags: ['hello', 'first', 'greeting'] }, :post)
       check_returned_array(Blog, @expected_resources, result)
     end
+
+    it 'not add query string for empty array parameter values on GET' do
+      req(:get, '/blogs', @expected_resources)
+      result = Blog.where({ tags: [] })
+      check_returned_array(Blog, @expected_resources, result)
+    end
   end
 
   context '#by_parent_resource' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api-resource
 version: !ruby/object:Gem::Version
-  version: 0.3.9
+  version: 0.3.10
 platform: ruby
 authors:
 - Chaker Nakhli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-16 00:00:00.000000000 Z
+date: 2015-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple-hmac