api-auth 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b4f04ff0b0fdfdc276177e1a225239af93aff34
-  data.tar.gz: 490677e918c7928517f8cb1bb476c5c81a9ac176
+  metadata.gz: a70b97184e4a7a11031e6c7bf62f26227da7e1cd
+  data.tar.gz: d6471c1d3d487b5b24106765d7eedde455e7c534
 SHA512:
-  metadata.gz: cd94a12c5eaaf7b76390fead34de8b6a60644656343b3a3aedbfff4fc1b5eea64777c258b20136a6d1ff3aa2bf0c071c007914c4ad958d2db5684f48cce23e08
-  data.tar.gz: 4ac0b39723cb446470b716d4cd8b06bc111bc88fd85fabf0c9e72a1300b6765c460463f038d9ed59f1d0c838bdcb5d103421e80cc833fba5e673bf43ffdea127
+  metadata.gz: c4d9d1eb76a1c1de3c65640dc9f44e877bdc62a7faad7773009527cf48034d58dadc304712bd54d70d3c3b934d240f0ce1d0951064183987e1f340066349a8a7
+  data.tar.gz: 13356a10470f99e4d2ab9104ca073cc92cb7f60f9f3696194013a13824b15e060a05ce1a102ca236bd4101a8e6e4523b9043849977a65a6d63f98eaf3a1f10d9

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.4.1 (2016-01-04)
+- Fixed an issue where getters wouldn't immdiately have the correct value after
+  setting a date or content md5 in some of the request drivers (#91)
+
 # 1.4 (2015-12-16)
 
 ## IMPORTANT SECURITY FIX (with backwards compatible fallback)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/VERSION

@@ -1 +1 @@
-1.4.0
+1.4.1

data/gemfiles/rails_23.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_30.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_31.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_32.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_41.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_42.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.4.0)
+    api-auth (1.4.1)
 
 GEM
   remote: https://rubygems.org/

data/lib/api_auth/request_drivers/action_controller.rb

@@ -8,13 +8,13 @@ module ApiAuth
 
       def initialize(request)
         @request = request
-        @headers = fetch_headers
+        fetch_headers
         true
       end
 
       def set_auth_header(header)
         @request.env["Authorization"] = header
-        @headers = fetch_headers
+        fetch_headers
         @request
       end
 
@@ -26,6 +26,7 @@ module ApiAuth
       def populate_content_md5
         if @request.put? || @request.post?
           @request.env["Content-MD5"] = calculated_md5
+          fetch_headers
         end
       end
 
@@ -38,7 +39,7 @@ module ApiAuth
       end
 
       def fetch_headers
-        capitalize_keys @request.env
+        @headers = capitalize_keys @request.env
       end
 
       def http_method
@@ -61,6 +62,7 @@ module ApiAuth
 
       def set_date
         @request.env['HTTP_DATE'] = Time.now.utc.httpdate
+        fetch_headers
       end
 
       def timestamp

data/lib/api_auth/request_drivers/curb.rb

@@ -8,13 +8,13 @@ module ApiAuth
 
       def initialize(request)
         @request = request
-        @headers = fetch_headers
+        fetch_headers
         true
       end
 
       def set_auth_header(header)
         @request.headers.merge!({ "Authorization" => header })
-        @headers = fetch_headers
+        fetch_headers
         @request
       end
 
@@ -27,7 +27,7 @@ module ApiAuth
       end
 
       def fetch_headers
-        capitalize_keys @request.headers
+        @headers = capitalize_keys @request.headers
       end
 
       def http_method
@@ -50,6 +50,7 @@ module ApiAuth
 
       def set_date
         @request.headers.merge!({ "DATE" => Time.now.utc.httpdate })
+        fetch_headers
       end
 
       def timestamp

data/lib/api_auth/request_drivers/faraday.rb

@@ -8,13 +8,13 @@ module ApiAuth
 
       def initialize(request)
         @request = request
-        @headers = fetch_headers
+        fetch_headers
         true
       end
 
       def set_auth_header(header)
         @request.headers.merge!({ "Authorization" => header })
-        @headers = fetch_headers
+        fetch_headers
         @request
       end
 
@@ -30,6 +30,7 @@ module ApiAuth
       def populate_content_md5
         if ['POST', 'PUT'].include?(@request.method.to_s.upcase)
           @request.headers["Content-MD5"] = calculated_md5
+          fetch_headers
         end
       end
 
@@ -42,7 +43,7 @@ module ApiAuth
       end
 
       def fetch_headers
-        capitalize_keys @request.headers
+        @headers = capitalize_keys @request.headers
       end
 
       def http_method
@@ -68,6 +69,7 @@ module ApiAuth
 
       def set_date
         @request.headers.merge!({ "DATE" => Time.now.utc.httpdate })
+        fetch_headers
       end
 
       def timestamp

data/lib/api_auth/request_drivers/httpi.rb

@@ -8,13 +8,13 @@ module ApiAuth
 
       def initialize(request)
         @request = request
-        @headers = fetch_headers
+        fetch_headers
         true
       end
 
       def set_auth_header(header)
         @request.headers["Authorization"] = header
-        @headers = fetch_headers
+        fetch_headers
         @request
       end
 
@@ -25,6 +25,7 @@ module ApiAuth
       def populate_content_md5
         if @request.body
           @request.headers["Content-MD5"] = calculated_md5
+          fetch_headers
         end
       end
 
@@ -37,7 +38,7 @@ module ApiAuth
       end
 
       def fetch_headers
-        capitalize_keys @request.headers
+        @headers = capitalize_keys @request.headers
       end
 
       def http_method
@@ -60,6 +61,7 @@ module ApiAuth
 
       def set_date
         @request.headers["DATE"] = Time.now.utc.httpdate
+        fetch_headers
       end
 
       def timestamp

data/lib/api_auth/request_drivers/rack.rb

@@ -8,13 +8,13 @@ module ApiAuth
 
       def initialize(request)
         @request = request
-        @headers = fetch_headers
+        fetch_headers
         true
       end
 
       def set_auth_header(header)
         @request.env.merge!({ "Authorization" => header })
-        @headers = fetch_headers
+        fetch_headers
         @request
       end
 
@@ -31,6 +31,7 @@ module ApiAuth
       def populate_content_md5
         if ['POST', 'PUT'].include?(@request.request_method)
           @request.env["Content-MD5"] = calculated_md5
+          fetch_headers
         end
       end
 
@@ -43,7 +44,7 @@ module ApiAuth
       end
 
       def fetch_headers
-        capitalize_keys @request.env
+        @headers = capitalize_keys @request.env
       end
 
       def http_method
@@ -66,6 +67,7 @@ module ApiAuth
 
       def set_date
         @request.env.merge!({ "DATE" => Time.now.utc.httpdate })
+        fetch_headers
       end
 
       def timestamp

data/spec/request_drivers/action_controller_spec.rb

@@ -105,6 +105,11 @@ if defined?(ActionController::Request)
             driven_request.populate_content_md5
             expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
           end
+
+          it "refreshes the cached headers" do
+            driven_request.populate_content_md5
+            expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          end
         end
 
         context "when putting" do
@@ -113,6 +118,11 @@ if defined?(ActionController::Request)
             driven_request.populate_content_md5
             expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
           end
+
+          it "refreshes the cached headers" do
+            driven_request.populate_content_md5
+            expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          end
         end
 
         context "when deleting" do
@@ -126,11 +136,19 @@ if defined?(ActionController::Request)
       end
 
       describe "#set_date" do
-        it "sets the date" do
+        before do
           allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+        end
+
+        it "sets the date header of the request" do
           driven_request.set_date
           expect(request.env['HTTP_DATE']).to eq(timestamp)
         end
+
+        it "refreshes the cached headers" do
+          driven_request.set_date
+          expect(driven_request.timestamp).to eq(timestamp)
+        end
       end
 
       describe "#set_auth_header" do

data/spec/request_drivers/action_dispatch_spec.rb

@@ -106,6 +106,11 @@ if defined?(ActionDispatch::Request)
             driven_request.populate_content_md5
             expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
           end
+
+          it "refreshes the cached headers" do
+            driven_request.populate_content_md5
+            expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          end
         end
 
         context "when putting" do
@@ -114,6 +119,11 @@ if defined?(ActionDispatch::Request)
             driven_request.populate_content_md5
             expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
           end
+
+          it "refreshes the cached headers" do
+            driven_request.populate_content_md5
+            expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          end
         end
 
         context "when deleting" do
@@ -127,11 +137,19 @@ if defined?(ActionDispatch::Request)
       end
 
       describe "#set_date" do
-        it "sets the date" do
+        before do
           allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+        end
+
+        it "sets the date header of the request" do
           driven_request.set_date
           expect(request.env['HTTP_DATE']).to eq(timestamp)
         end
+
+        it "refreshes the cached headers" do
+          driven_request.set_date
+          expect(driven_request.timestamp).to eq(timestamp)
+        end
       end
 
       describe "#set_auth_header" do

data/spec/request_drivers/curb_spec.rb

@@ -66,11 +66,19 @@ describe ApiAuth::RequestDrivers::CurbRequest do
     end
 
     describe "#set_date" do
-      it "sets the date" do
+      before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+      end
+
+      it "sets the date header of the request" do
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
+
+      it "refreshes the cached headers" do
+        driven_request.set_date
+        expect(driven_request.timestamp).to eq(timestamp)
+      end
     end
 
     describe "#set_auth_header" do

data/spec/request_drivers/faraday_spec.rb

@@ -131,6 +131,11 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
           driven_request.populate_content_md5
           expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
 
       context "when putting" do
@@ -139,6 +144,11 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
           driven_request.populate_content_md5
           expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
 
       context "when deleting" do
@@ -152,11 +162,19 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
     end
 
     describe "#set_date" do
-      it "sets the date" do
+      before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+      end
+
+      it "sets the date header of the request" do
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
+
+      it "refreshes the cached headers" do
+        driven_request.set_date
+        expect(driven_request.timestamp).to eq(timestamp)
+      end
     end
 
     describe "#set_auth_header" do

data/spec/request_drivers/httpi_spec.rb

@@ -87,15 +87,28 @@ describe ApiAuth::RequestDrivers::HttpiRequest do
           driven_request.populate_content_md5
           expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
     end
 
     describe "#set_date" do
-      it "sets the date" do
+      before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+      end
+
+      it "sets the date header of the request" do
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
+
+      it "refreshes the cached headers" do
+        driven_request.set_date
+        expect(driven_request.timestamp).to eq(timestamp)
+      end
     end
 
     describe "#set_auth_header" do

data/spec/request_drivers/net_http_spec.rb

@@ -123,15 +123,28 @@ describe ApiAuth::RequestDrivers::NetHttpRequest do
           driven_request.populate_content_md5
           expect(request["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
     end
 
     describe "#set_date" do
-      it "sets the date" do
+      before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+      end
+
+      it "sets the date header of the request" do
         driven_request.set_date
         expect(request['DATE']).to eq(timestamp)
       end
+
+      it "refreshes the cached headers" do
+        driven_request.set_date
+        expect(driven_request.timestamp).to eq(timestamp)
+      end
     end
 
     describe "#set_auth_header" do

data/spec/request_drivers/rack_spec.rb

@@ -137,6 +137,11 @@ describe ApiAuth::RequestDrivers::RackRequest do
           driven_request.populate_content_md5
           expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
 
       context "when putting" do
@@ -154,6 +159,11 @@ describe ApiAuth::RequestDrivers::RackRequest do
           driven_request.populate_content_md5
           expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
 
       context "when deleting" do
@@ -175,11 +185,19 @@ describe ApiAuth::RequestDrivers::RackRequest do
     end
 
     describe "#set_date" do
-      it "sets the date" do
+      before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+      end
+
+      it "sets the date header of the request" do
         driven_request.set_date
         expect(request.env['DATE']).to eq(timestamp)
       end
+
+      it "refreshes the cached headers" do
+        driven_request.set_date
+        expect(driven_request.timestamp).to eq(timestamp)
+      end
     end
 
     describe "#set_auth_header" do

data/spec/request_drivers/rest_client_spec.rb

@@ -131,6 +131,11 @@ describe ApiAuth::RequestDrivers::RestClientRequest do
           driven_request.populate_content_md5
           expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
 
       context "when putting" do
@@ -147,6 +152,11 @@ describe ApiAuth::RequestDrivers::RestClientRequest do
           driven_request.populate_content_md5
           expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
+
+        it "refreshes the cached headers" do
+          driven_request.populate_content_md5
+          expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
+        end
       end
 
       context "when deleting" do
@@ -167,11 +177,20 @@ describe ApiAuth::RequestDrivers::RestClientRequest do
     end
 
     describe "#set_date" do
-      it "sets the date" do
+      before do
+        allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
+      end
+
+      it "sets the date header of the request" do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
+
+      it "refreshes the cached headers" do
+        driven_request.set_date
+        expect(driven_request.timestamp).to eq(timestamp)
+      end
     end
 
     describe "#set_auth_header" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api-auth
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Mauricio Gomes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-16 00:00:00.000000000 Z
+date: 2016-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal