apache_secure_download 0.1.0 → 0.1.1

data/COPYING

@@ -1,7 +1,7 @@
 = License for apache_secure_download
-  
-                      GNU GENERAL PUBLIC LICENSE
-                         Version 3, 29 June 2007
+
+                      GNU AFFERO GENERAL PUBLIC LICENSE
+                         Version 3, 19 November 2007
   
    Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
    Everyone is permitted to copy and distribute verbatim copies
@@ -9,17 +9,15 @@
   
                               Preamble
   
-    The GNU General Public License is a free, copyleft license for
-  software and other kinds of works.
+    The GNU Affero General Public License is a free, copyleft license for
+  software and other kinds of works, specifically designed to ensure
+  cooperation with the community in the case of network server software.
   
     The licenses for most software and other practical works are designed
   to take away your freedom to share and change the works.  By contrast,
-  the GNU General Public License is intended to guarantee your freedom to
+  our General Public Licenses are intended to guarantee your freedom to
   share and change all versions of a program--to make sure it remains free
-  software for all its users.  We, the Free Software Foundation, use the
-  GNU General Public License for most of our software; it applies also to
-  any other work released this way by its authors.  You can apply it to
-  your programs, too.
+  software for all its users.
   
     When we speak of free software, we are referring to freedom, not
   price.  Our General Public Licenses are designed to make sure that you
@@ -28,44 +26,34 @@
   want it, that you can change the software or use pieces of it in new
   free programs, and that you know you can do these things.
   
-    To protect your rights, we need to prevent others from denying you
-  these rights or asking you to surrender the rights.  Therefore, you have
-  certain responsibilities if you distribute copies of the software, or if
-  you modify it: responsibilities to respect the freedom of others.
-  
-    For example, if you distribute copies of such a program, whether
-  gratis or for a fee, you must pass on to the recipients the same
-  freedoms that you received.  You must make sure that they, too, receive
-  or can get the source code.  And you must show them these terms so they
-  know their rights.
-  
-    Developers that use the GNU GPL protect your rights with two steps:
-  (1) assert copyright on the software, and (2) offer you this License
-  giving you legal permission to copy, distribute and/or modify it.
-  
-    For the developers' and authors' protection, the GPL clearly explains
-  that there is no warranty for this free software.  For both users' and
-  authors' sake, the GPL requires that modified versions be marked as
-  changed, so that their problems will not be attributed erroneously to
-  authors of previous versions.
-  
-    Some devices are designed to deny users access to install or run
-  modified versions of the software inside them, although the manufacturer
-  can do so.  This is fundamentally incompatible with the aim of
-  protecting users' freedom to change the software.  The systematic
-  pattern of such abuse occurs in the area of products for individuals to
-  use, which is precisely where it is most unacceptable.  Therefore, we
-  have designed this version of the GPL to prohibit the practice for those
-  products.  If such problems arise substantially in other domains, we
-  stand ready to extend this provision to those domains in future versions
-  of the GPL, as needed to protect the freedom of users.
-  
-    Finally, every program is threatened constantly by software patents.
-  States should not allow patents to restrict development and use of
-  software on general-purpose computers, but in those that do, we wish to
-  avoid the special danger that patents applied to a free program could
-  make it effectively proprietary.  To prevent this, the GPL assures that
-  patents cannot be used to render the program non-free.
+    Developers that use our General Public Licenses protect your rights
+  with two steps: (1) assert copyright on the software, and (2) offer
+  you this License which gives you legal permission to copy, distribute
+  and/or modify the software.
+  
+    A secondary benefit of defending all users' freedom is that
+  improvements made in alternate versions of the program, if they
+  receive widespread use, become available for other developers to
+  incorporate.  Many developers of free software are heartened and
+  encouraged by the resulting cooperation.  However, in the case of
+  software used on network servers, this result may fail to come about.
+  The GNU General Public License permits making a modified version and
+  letting the public access it on a server without ever releasing its
+  source code to the public.
+  
+    The GNU Affero General Public License is designed specifically to
+  ensure that, in such cases, the modified source code becomes available
+  to the community.  It requires the operator of a network server to
+  provide the source code of the modified version running there to the
+  users of that server.  Therefore, public use of a modified version, on
+  a publicly accessible server, gives the public access to the source
+  code of the modified version.
+  
+    An older license, called the Affero General Public License and
+  published by Affero, was designed to accomplish similar goals.  This is
+  a different license, not a version of the Affero GPL, but Affero has
+  released a new version of the Affero GPL which permits relicensing under
+  this license.
   
     The precise terms and conditions for copying, distribution and
   modification follow.
@@ -74,7 +62,7 @@
   
     0. Definitions.
   
-    "This License" refers to version 3 of the GNU General Public License.
+    "This License" refers to version 3 of the GNU Affero General Public License.
   
     "Copyright" also means copyright-like laws that apply to other kinds of
   works, such as semiconductor masks.
@@ -551,35 +539,45 @@
   the Program, the only way you could satisfy both those terms and this
   License would be to refrain entirely from conveying the Program.
   
-    13. Use with the GNU Affero General Public License.
+    13. Remote Network Interaction; Use with the GNU General Public License.
+  
+    Notwithstanding any other provision of this License, if you modify the
+  Program, your modified version must prominently offer all users
+  interacting with it remotely through a computer network (if your version
+  supports such interaction) an opportunity to receive the Corresponding
+  Source of your version by providing access to the Corresponding Source
+  from a network server at no charge, through some standard or customary
+  means of facilitating copying of software.  This Corresponding Source
+  shall include the Corresponding Source for any work covered by version 3
+  of the GNU General Public License that is incorporated pursuant to the
+  following paragraph.
   
     Notwithstanding any other provision of this License, you have
   permission to link or combine any covered work with a work licensed
-  under version 3 of the GNU Affero General Public License into a single
+  under version 3 of the GNU General Public License into a single
   combined work, and to convey the resulting work.  The terms of this
   License will continue to apply to the part which is the covered work,
-  but the special requirements of the GNU Affero General Public License,
-  section 13, concerning interaction through a network will apply to the
-  combination as such.
+  but the work with which it is combined will remain governed by version
+  3 of the GNU General Public License.
   
     14. Revised Versions of this License.
   
     The Free Software Foundation may publish revised and/or new versions of
-  the GNU General Public License from time to time.  Such new versions will
-  be similar in spirit to the present version, but may differ in detail to
+  the GNU Affero General Public License from time to time.  Such new versions
+  will be similar in spirit to the present version, but may differ in detail to
   address new problems or concerns.
   
     Each version is given a distinguishing version number.  If the
-  Program specifies that a certain numbered version of the GNU General
+  Program specifies that a certain numbered version of the GNU Affero General
   Public License "or any later version" applies to it, you have the
   option of following the terms and conditions either of that numbered
   version or of any later version published by the Free Software
   Foundation.  If the Program does not specify a version number of the
-  GNU General Public License, you may choose any version ever published
+  GNU Affero General Public License, you may choose any version ever published
   by the Free Software Foundation.
   
     If the Program specifies that a proxy can decide which future
-  versions of the GNU General Public License can be used, that proxy's
+  versions of the GNU Affero General Public License can be used, that proxy's
   public statement of acceptance of a version permanently authorizes you
   to choose that version for the Program.
   
@@ -637,40 +635,29 @@
       Copyright (C) <year>  <name of author>
   
       This program is free software: you can redistribute it and/or modify
-      it under the terms of the GNU General Public License as published by
+      it under the terms of the GNU Affero General Public License as published by
       the Free Software Foundation, either version 3 of the License, or
       (at your option) any later version.
   
       This program is distributed in the hope that it will be useful,
       but WITHOUT ANY WARRANTY; without even the implied warranty of
       MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-      GNU General Public License for more details.
+      GNU Affero General Public License for more details.
   
-      You should have received a copy of the GNU General Public License
+      You should have received a copy of the GNU Affero General Public License
       along with this program.  If not, see <http://www.gnu.org/licenses/>.
   
   Also add information on how to contact you by electronic and paper mail.
   
-    If the program does terminal interaction, make it output a short
-  notice like this when it starts in an interactive mode:
-  
-      <program>  Copyright (C) <year>  <name of author>
-      This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-      This is free software, and you are welcome to redistribute it
-      under certain conditions; type `show c' for details.
-  
-  The hypothetical commands `show w' and `show c' should show the appropriate
-  parts of the General Public License.  Of course, your program's commands
-  might be different; for a GUI interface, you would use an "about box".
+    If your software can interact with users remotely through a computer
+  network, you should also make sure that it provides a way for users to
+  get its source.  For example, if your program is a web application, its
+  interface could display a "Source" link that leads users to an archive
+  of the code.  There are many ways you could offer source, and different
+  solutions will be better for different programs; see section 13 for the
+  specific requirements.
   
     You should also get your employer (if you work as a programmer) or school,
   if any, to sign a "copyright disclaimer" for the program, if necessary.
-  For more information on this, and how to apply and follow the GNU GPL, see
+  For more information on this, and how to apply and follow the GNU AGPL, see
   <http://www.gnu.org/licenses/>.
-  
-    The GNU General Public License does not permit incorporating your program
-  into proprietary programs.  If your program is a subroutine library, you
-  may consider it more useful to permit linking proprietary applications with
-  the library.  If this is what you want to do, use the GNU Lesser General
-  Public License instead of this License.  But first, please read
-  <http://www.gnu.org/philosophy/why-not-lgpl.html>.

data/README

@@ -2,7 +2,7 @@
 
 == VERSION
 
-This documentation refers to apache_secure_download version 0.1.0
+This documentation refers to apache_secure_download version 0.1.1
 
 
 == DESCRIPTION
@@ -48,10 +48,9 @@ See Apache::SecureDownload::Util.secure_url for more examples.
 == LINKS
 
 <b></b>
-Documentation::     <http://prometheus.rubyforge.org/apache_secure_download>
-Source code (old):: <http://prometheus.rubyforge.org/svn/scratch/apache_secure_download>
-Source code::       <http://github.com/blackwinter/apache_secure_download>
-Rubyforge project:: <http://rubyforge.org/projects/prometheus>
+Documentation::     http://prometheus.rubyforge.org/apache_secure_download
+Source code::       http://github.com/blackwinter/apache_secure_download
+RubyForge project:: http://rubyforge.org/projects/prometheus
 
 
 == AUTHORS
@@ -61,18 +60,18 @@ Rubyforge project:: <http://rubyforge.org/projects/prometheus>
 
 == LICENSE AND COPYRIGHT
 
-Copyright (C) 2008-2010 University of Cologne,
+Copyright (C) 2008-2011 University of Cologne,
 Albertus-Magnus-Platz, 50923 Cologne, Germany
 
 apache_secure_download is free software: you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by the Free
-Software Foundation, either version 3 of the License, or (at your option) any
-later version.
+it under the terms of the GNU Affero General Public License as published by
+the Free Software Foundation, either version 3 of the License, or (at your
+option) any later version.
 
 apache_secure_download is distributed in the hope that it will be useful, but
 WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
-FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
-details.
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License
+for more details.
 
-You should have received a copy of the GNU General Public License along
+You should have received a copy of the GNU Affero General Public License along
 with apache_secure_download. If not, see <http://www.gnu.org/licenses/>.

data/Rakefile

@@ -1,4 +1,4 @@
-require %q{lib/apache/secure_download/version}
+require File.expand_path(%q{../lib/apache/secure_download/version}, __FILE__)
 
 begin
   require 'hen'
@@ -10,15 +10,19 @@ begin
     },
 
     :gem => {
-      :version      => Apache::SecureDownload::VERSION,
-      :summary      => %q{Apache module providing secure downloading functionality, just like Mongrel Secure Download does for mongrel.},
-      :files        => FileList['lib/**/*.rb'].to_a,
-      :extra_files  => FileList['[A-Z]*'].to_a,
-      :dependencies => %w[]
+      :version => Apache::SecureDownload::VERSION,
+      :summary => %q{Apache module providing secure downloading functionality, just like Mongrel Secure Download does for mongrel.},
+      :author  => %q{Jens Wille},
+      :email   => %q{jens.wille@uni-koeln.de}
     }
   }}
-rescue LoadError
-  abort "Please install the 'hen' gem first."
+rescue LoadError => err
+  warn "Please install the `hen' gem. (#{err})"
 end
 
-### Place your custom Rake tasks here.
+desc "Run benchmarks"
+task :bench do
+  Dir["#{File.dirname(__FILE__)}/bench/**/*_bench.rb"].each { |bench|
+    load bench, true
+  }
+end

data/lib/apache/secure_download/util.rb

@@ -3,7 +3,7 @@
 #                                                                             #
 # A component of apache_secure_download.                                      #
 #                                                                             #
-# Copyright (C) 2008-2010 University of Cologne,                              #
+# Copyright (C) 2008-2011 University of Cologne,                              #
 #                         Albertus-Magnus-Platz,                              #
 #                         50923 Cologne, Germany                              #
 #                                                                             #
@@ -11,17 +11,18 @@
 #     Jens Wille <jens.wille@uni-koeln.de>                                    #
 #                                                                             #
 # apache_secure_download is free software: you can redistribute it and/or     #
-# modify it under the terms of the GNU General Public License as published by #
-# the Free Software Foundation, either version 3 of the License, or (at your  #
-# option) any later version.                                                  #
+# modify it under the terms of the GNU Affero General Public License as       #
+# published by the Free Software Foundation, either version 3 of the          #
+# License, or (at your option) any later version.                             #
 #                                                                             #
-# apache_secure_download is distributed in the hope that it will be useful,   #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General    #
-# Public License for more details.                                            #
+# apache_secure_download is distributed in the hope that it will be           #
+# useful, but WITHOUT ANY WARRANTY; without even the implied warranty         #
+# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU         #
+# Affero General Public License for more details.                             #
 #                                                                             #
-# You should have received a copy of the GNU General Public License along     #
-# with apache_secure_download. If not, see <http://www.gnu.org/licenses/>.    #
+# You should have received a copy of the GNU Affero General Public            #
+# License along with apache_secure_download. If not, see                      #
+# <http://www.gnu.org/licenses/>.                                             #
 #                                                                             #
 ###############################################################################
 #++

data/lib/apache/secure_download/version.rb

@@ -6,7 +6,7 @@ module Apache
 
       MAJOR = 0
       MINOR = 1
-      TINY  = 0
+      TINY  = 1
 
       class << self
 

data/lib/apache/secure_download.rb

@@ -12,17 +12,18 @@
 #     Jens Wille <jens.wille@uni-koeln.de>                                    #
 #                                                                             #
 # apache_secure_download is free software: you can redistribute it and/or     #
-# modify it under the terms of the GNU General Public License as published by #
-# the Free Software Foundation, either version 3 of the License, or (at your  #
-# option) any later version.                                                  #
+# modify it under the terms of the GNU Affero General Public License as       #
+# published by the Free Software Foundation, either version 3 of the          #
+# License, or (at your option) any later version.                             #
 #                                                                             #
-# apache_secure_download is distributed in the hope that it will be useful,   #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General    #
-# Public License for more details.                                            #
+# apache_secure_download is distributed in the hope that it will be           #
+# useful, but WITHOUT ANY WARRANTY; without even the implied warranty         #
+# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU         #
+# Affero General Public License for more details.                             #
 #                                                                             #
-# You should have received a copy of the GNU General Public License along     #
-# with apache_secure_download. If not, see <http://www.gnu.org/licenses/>.    #
+# You should have received a copy of the GNU Affero General Public            #
+# License along with apache_secure_download. If not, see                      #
+# <http://www.gnu.org/licenses/>.                                             #
 #                                                                             #
 ###############################################################################
 #++

data/spec/apache/secure_download/util_spec.rb

@@ -0,0 +1,392 @@
+describe Apache::SecureDownload::Util do
+
+  before :each do
+    @module = Apache::SecureDownload::Util
+    @secret = 'secret'
+  end
+
+  describe "#secure_url" do
+
+    before :each do
+      @url = '/secure/url'
+      @now = Time.at(1204024618)
+    end
+
+    describe "generating secure URLs" do
+
+      before :each do
+        @timestamp = @now.to_i + 60
+        @token     = '5671a9b3966e8bbed91fc0bb5594d576c504cdf0'
+
+        @result = "?timestamp=#{@timestamp}&token=#{@token}"
+      end
+
+      it "should generate secure URL" do
+        url = @url
+        @module.secure_url(@secret, url).should == url + @result
+      end
+
+      it "should take path component into account" do
+        url = @url + '2'
+        @module.secure_url(@secret, url).should =~ /\A#{Regexp.escape(url)}\?/
+        @module.secure_url(@secret, url).should_not == url + @result
+      end
+
+      it "should ignore host component" do
+        url = 'http://example.com' + @url
+        @module.secure_url(@secret, url).should == url + @result
+      end
+
+      it "should preserve query component" do
+        url = @url + '?a=b&x=y'
+        @module.secure_url(@secret, url).should =~ /\A#{Regexp.escape(url)}&/
+      end
+
+      it "should preserve URL fragment" do
+        url = @url + '#foo'
+        result = @module.secure_url(@secret, url)
+
+        result.should =~ /\A#{Regexp.escape(@url)}\?/
+        result.should =~ /#foo\z/
+      end
+
+      it "should preserve query component and URL fragment" do
+        url = @url + '?x=y#foo'
+        result = @module.secure_url(@secret, url)
+
+        result.should =~ /\A#{Regexp.escape(@url)}\?x=y&/
+        result.should =~ /#foo\z/
+      end
+
+      it "should respect secret" do
+        @module.secure_url(@secret.swapcase, @url).should_not == @url + @result
+      end
+
+    end
+
+    describe "with custom expiration" do
+
+      before :each do
+        @result1 = "#{@url}?timestamp=1204025218&token=7e51f91cf4406f308a8df24f4e2cbf188de3c1bf"
+        @result2 = "#{@url}?timestamp=1204026000&token=58eb12f9fc3fcd984fe4e918d3fd0590392c172d"
+      end
+
+      it "should accept time" do
+        @module.secure_url(@secret, @url, Time.now + 600).should == @result1
+      end
+
+      it "should accept offset" do
+        @module.secure_url(@secret, @url, :offset => 600).should == @result2
+        @result2.should_not == @result1
+      end
+
+      it "should disable caching with offset" do
+        @module.secure_url(@secret, @url, :offset => 600, :cache => false).should == @result1
+        @result1.should_not == @result2
+      end
+
+    end
+
+    describe "caching" do
+
+      before :each do
+        @result1 = "#{@url}?timestamp=1204024680&token=ccf279daf1787d34ad063cbf5851ee88aae967fb"
+        @result2 = "#{@url}?timestamp=1204024740&token=c7dcea5679ad539a7bad1dc4b7f44eb3dd36d6e8"
+        @result3 = "#{@url}?timestamp=1204024800&token=aa11618f1cc0883a29e9239b777ca53dfc4d9604"
+      end
+
+      describe "explicitly (with expires)" do
+
+        it "should produce identical URLs for a window of 1 minute (on average)" do
+          t = Time.now
+
+          @module.secure_url(@secret, @url, :expires => t,      :cache => 60).should == @result1
+          @module.secure_url(@secret, @url, :expires => t + 30, :cache => 60).should == @result1
+          @module.secure_url(@secret, @url, :expires => t + 60, :cache => 60).should == @result2
+          @module.secure_url(@secret, @url, :expires => t + 90, :cache => 60).should == @result2
+        end
+
+      end
+
+      describe "implicitly (with offset)" do
+
+        it "should produce identical URLs for a window of 1 minute (on average)" do
+          @module.secure_url(@secret, @url, :offset => 60).should == @result2
+          @now += 30  # 30 seconds later...
+          @module.secure_url(@secret, @url, :offset => 60).should == @result2
+          @now += 30  # 30 seconds later...
+          @module.secure_url(@secret, @url, :offset => 60).should == @result3
+          @now += 30  # 30 seconds later...
+          @module.secure_url(@secret, @url, :offset => 60).should == @result3
+        end
+
+      end
+
+    end
+
+  end
+
+  describe "#token" do
+
+    before :each do
+      @path = '/some/path'
+      @timestamp = Time.now.to_i
+
+      @result = @module.token(@secret, @path, @timestamp)
+    end
+
+    it "should take secret into account" do
+      @module.token(@secret.swapcase, @path, @timestamp).should_not == @result
+    end
+
+    it "should take path into account" do
+      @module.token(@secret, @path + '/foo', @timestamp).should_not == @result
+    end
+
+    it "should take query parameters in path into account" do
+      @module.token(@secret, @path + '?foo=bar', @timestamp).should_not == @result
+    end
+
+    it "should take timestamp into account" do
+      @module.token(@secret, @path, @timestamp + 42).should_not == @result
+    end
+
+    it "should ignore timestamp parameter in path" do
+      @module.token(@secret, @path + '?timestamp=foo', @timestamp).should == @result
+    end
+
+    it "should ignore token parameter in path" do
+      @module.token(@secret, @path + '?token=bar', @timestamp).should == @result
+    end
+
+    it "should ignore timestamp and token parameters in path" do
+      @module.token(@secret, @path + '?timestamp=foo&token=bar', @timestamp).should == @result
+    end
+
+    it "should ignore timestamp and token parameters in path, regardless of order" do
+      @module.token(@secret, @path + '?token=bar&timestamp=foo', @timestamp).should == @result
+    end
+
+    describe "when other parameters are present in path" do
+
+      describe "at the front" do
+
+        before :each do
+          @path2 = @path + '?foo=bar'
+          @result2 = @module.token(@secret, @path2, @timestamp)
+        end
+
+        it "should not ignore them" do
+          @module.token(@secret, @path2 + '&timestamp=foo&token=bar', @timestamp).should_not == @result
+        end
+
+        it "should ignore timestamp parameter in path" do
+          @module.token(@secret, @path2 + '&timestamp=foo', @timestamp).should == @result2
+        end
+
+        it "should ignore token parameter in path" do
+          @module.token(@secret, @path2 + '&token=bar', @timestamp).should == @result2
+        end
+
+        it "should ignore timestamp and token parameters in path" do
+          @module.token(@secret, @path2 + '&timestamp=foo&token=bar', @timestamp).should == @result2
+        end
+
+        it "should ignore timestamp and token parameters in path, regardless of order" do
+          @module.token(@secret, @path2 + '&token=bar&timestamp=foo', @timestamp).should == @result2
+        end
+
+      end
+
+      describe "at the end" do
+
+        before :each do
+          @query = '&foo=bar'
+          @result2 = @module.token(@secret, @path + @query.sub(/&/, '?'), @timestamp)
+        end
+
+        it "should not ignore them" do
+          @module.token(@secret, @path + '?timestamp=foo&token=bar' + @query, @timestamp).should_not == @result
+        end
+
+        it "should ignore timestamp parameter in path" do
+          @module.token(@secret, @path + '?timestamp=foo' + @query, @timestamp).should == @result2
+        end
+
+        it "should ignore token parameter in path" do
+          @module.token(@secret, @path + '?token=bar' + @query, @timestamp).should == @result2
+        end
+
+        it "should ignore timestamp and token parameters in path" do
+          @module.token(@secret, @path + '?timestamp=foo&token=bar' + @query, @timestamp).should == @result2
+        end
+
+        it "should ignore timestamp and token parameters in path, regardless of order" do
+          @module.token(@secret, @path + '?token=bar&timestamp=foo' + @query, @timestamp).should == @result2
+        end
+
+      end
+
+    end
+
+  end
+
+  describe "#real_path" do
+
+    before :each do
+      @path = '/some/path'
+    end
+
+    describe "without recognized query parameters" do
+
+      it "should leave the path intact" do
+        @module.real_path(@path).should == @path
+      end
+
+      it "should leave other query parameters intact" do
+        @module.real_path(@path + '?foo=bar').should == @path + '?foo=bar'
+      end
+
+    end
+
+    describe "with recognized query parameters" do
+
+      it "should remove timestamp parameter" do
+        @module.real_path(@path + '?timestamp=foo').should == @path
+      end
+
+      it "should remove token parameter" do
+        @module.real_path(@path + '?token=bar').should == @path
+      end
+
+      it "should remove timestamp and token parameters" do
+        @module.real_path(@path + '?timestamp=foo&token=bar').should == @path
+      end
+
+      it "should remove timestamp and token parameters, regardless of order" do
+        @module.real_path(@path + '?token=bar&timestamp=foo').should == @path
+      end
+
+      describe "when other parameters are present" do
+
+        describe "at the front" do
+
+          before :each do
+            @path2 = @path + '?foo=bar'
+          end
+
+          it "should remove timestamp parameter" do
+            @module.real_path(@path2 + '&timestamp=foo').should == @path2
+          end
+
+          it "should remove token parameter" do
+            @module.real_path(@path2 + '&token=bar').should == @path2
+          end
+
+          it "should remove timestamp and token parameters" do
+            @module.real_path(@path2 + '&timestamp=foo&token=bar').should == @path2
+          end
+
+          it "should remove timestamp and token parameters, regardless of order" do
+            @module.real_path(@path2 + '&token=bar&timestamp=foo').should == @path2
+          end
+
+        end
+
+        describe "at the end" do
+
+          before :each do
+            @query = '&foo=bar'
+            @path2 = @path + @query.sub(/&/, '?')
+          end
+
+          it "should remove timestamp parameter" do
+            @module.real_path(@path + '?timestamp=foo' + @query).should == @path2
+          end
+
+          it "should remove token parameter" do
+            @module.real_path(@path + '?token=bar' + @query).should == @path2
+          end
+
+          it "should remove timestamp and token parameters" do
+            @module.real_path(@path + '?timestamp=foo&token=bar' + @query).should == @path2
+          end
+
+          it "should remove timestamp and token parameters, regardless of order" do
+            @module.real_path(@path + '?token=bar&timestamp=foo' + @query).should == @path2
+          end
+
+        end
+
+      end
+
+    end
+
+  end
+
+  describe "#real_query" do
+
+    before :each do
+      @query = 'some=query'
+    end
+
+    describe "without recognized query parameters" do
+
+      it "should leave the query intact" do
+        @module.real_query(@query).should == @query
+      end
+
+      it "should leave other query parameters intact" do
+        @module.real_query(@query + '&foo=bar').should == @query + '&foo=bar'
+      end
+
+    end
+
+    describe "with recognized query parameters" do
+
+      it "should remove timestamp parameter" do
+        @module.real_query(@query + '&timestamp=foo').should == @query
+      end
+
+      it "should remove token parameter" do
+        @module.real_query(@query + '&token=bar').should == @query
+      end
+
+      it "should remove timestamp and token parameters" do
+        @module.real_query(@query + '&timestamp=foo&token=bar').should == @query
+      end
+
+      it "should remove timestamp and token parameters, regardless of order" do
+        @module.real_query(@query + '&token=bar&timestamp=foo').should == @query
+      end
+
+      describe "when other parameters are present" do
+
+        before :each do
+          @params = '&foo=bar'
+          @query2 = @query + @params
+        end
+
+        it "should remove timestamp parameter" do
+          @module.real_query(@query + '&timestamp=foo' + @params).should == @query2
+        end
+
+        it "should remove token parameter" do
+          @module.real_query(@query + '&token=bar' + @params).should == @query2
+        end
+
+        it "should remove timestamp and token parameters" do
+          @module.real_query(@query + '&timestamp=foo&token=bar' + @params).should == @query2
+        end
+
+        it "should remove timestamp and token parameters, regardless of order" do
+          @module.real_query(@query + '&token=bar&timestamp=foo' + @params).should == @query2
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/spec/apache/secure_download_spec.rb

@@ -0,0 +1,257 @@
+describe Apache::SecureDownload do
+
+  before :each do
+    @class = Apache::SecureDownload
+  end
+
+  describe "#initialize" do
+
+    it "should require a secret" do
+      lambda { @class.new(nil) }.should raise_error(ArgumentError, 'secret is missing')
+    end
+
+    it "should accept a string for secret" do
+      @class.new('secret').should be_an_instance_of(@class)
+    end
+
+    it "should require secret to be a string" do
+      lambda { @class.new(42) }.should raise_error(ArgumentError, 'secret is missing')
+    end
+
+    it "should not require :deny" do
+      @class.new('secret', :deny => nil).should be_an_instance_of(@class)
+    end
+
+    it "should accept a regexp for :deny" do
+      @class.new('secret', :deny => /regexp/).should be_an_instance_of(@class)
+    end
+
+    it "should require :deny to be a regexp" do
+      lambda { @class.new('secret', :deny => 'regexp') }.should raise_error(ArgumentError, ':deny is not a regexp')
+    end
+
+    it "should not require :allow" do
+      @class.new('secret', :allow => nil).should be_an_instance_of(@class)
+    end
+
+    it "should accept a regexp for :allow" do
+      @class.new('secret', :allow => /regexp/).should be_an_instance_of(@class)
+    end
+
+    it "should require :allow to be a regexp" do
+      lambda { @class.new('secret', :allow => 'regexp') }.should raise_error(ArgumentError, ':allow is not a regexp')
+    end
+
+    it "should accept :deny and :allow at the same time" do
+      @class.new('secret', :deny => /regexp/, :allow => /regexp/).should be_an_instance_of(@class)
+    end
+
+  end
+
+  describe "#check_access" do
+
+    def self.it_should_be_allowed(msg, &block)
+      it "should be allowed #{msg}" do
+        instance_eval(&block) if block
+
+        mock_request
+        @handler.check_access(@request).should == Apache::OK
+      end
+    end
+
+    def self.it_should_be_forbidden(msg, &block)
+      it "should be forbidden #{msg}" do
+        instance_eval(&block) if block
+
+        mock_request
+        @handler.check_access(@request).should == Apache::FORBIDDEN
+      end
+    end
+
+    before :each do
+      @secret = 'secret'
+      @uri = '/some/uri'
+
+      @timestamp = Time.now.to_i + 23
+      @token = @class::Util.token(@secret, @uri, @timestamp)
+
+      @handler = @class.new(@secret)
+    end
+
+    describe "normally", :shared => true do
+
+      it_should_be_allowed "with correct secret"
+
+      it_should_be_forbidden "with incorrect secret" do
+        @token = @class::Util.token(@secret.swapcase, @uri, @timestamp)
+      end
+
+      it_should_be_forbidden "for different URL" do
+        @token = @class::Util.token(@secret, @uri + '2', @timestamp)
+      end
+
+      it_should_be_forbidden "with different timestamp" do
+        @token = @class::Util.token(@secret, @uri, @timestamp + 42)
+      end
+
+      it_should_be_forbidden "when expired" do
+        @now += 60
+      end
+
+    end
+
+    describe "always allowed", :shared => true do
+
+      it_should_be_allowed "with correct secret"
+
+      it_should_be_allowed "with incorrect secret" do
+        @token = @class::Util.token(@secret.swapcase, @uri, @timestamp)
+      end
+
+      it_should_be_allowed "for different URL" do
+        @token = @class::Util.token(@secret, @uri + '2', @timestamp)
+      end
+
+      it_should_be_allowed "with different timestamp" do
+        @token = @class::Util.token(@secret, @uri, @timestamp + 42)
+      end
+
+      it_should_be_allowed "when expired" do
+        @now += 60
+      end
+
+    end
+
+    describe "always forbidden", :shared => true do
+
+      it_should_be_forbidden "with correct secret"
+
+      it_should_be_forbidden "with incorrect secret" do
+        @token = @class::Util.token(@secret.swapcase, @uri, @timestamp)
+      end
+
+      it_should_be_forbidden "for different URL" do
+        @token = @class::Util.token(@secret, @uri + '2', @timestamp)
+      end
+
+      it_should_be_forbidden "with different timestamp" do
+        @token = @class::Util.token(@secret, @uri, @timestamp + 42)
+      end
+
+      it_should_be_forbidden "when expired" do
+        @now += 60
+      end
+
+    end
+
+    it_should_behave_like "normally"
+
+    describe "with query args" do
+
+      before :each do
+        @args = 'foo=bar'
+        @token = @class::Util.token(@secret, "#{@uri}?#{@args}", @timestamp)
+      end
+
+      it_should_behave_like "normally"
+
+    end
+
+    describe "with matching :allow" do
+
+      before :each do
+        @handler = @class.new(@secret, :allow => /\A\/some\//)
+      end
+
+      it_should_behave_like "always allowed"
+
+      describe "and matching :deny" do
+
+        before :each do
+          @handler.instance_variable_set(:@deny, /\A\/some\//)
+        end
+
+        it_should_behave_like "always forbidden"
+
+      end
+
+      describe "and non-matching :deny" do
+
+        before :each do
+          @handler.instance_variable_set(:@deny, /\A\/other\//)
+        end
+
+        it_should_behave_like "always allowed"
+
+      end
+
+    end
+
+    describe "with non-matching :allow" do
+
+      before :each do
+        @handler = @class.new(@secret, :allow => /\A\/other\//)
+      end
+
+      it_should_behave_like "normally"
+
+    end
+
+    describe "with matching :deny" do
+
+      before :each do
+        @handler = @class.new(@secret, :deny => /\A\/some\//)
+      end
+
+      it_should_behave_like "always forbidden"
+
+      describe "and matching :allow" do
+
+        before :each do
+          @handler.instance_variable_set(:@allow, /\A\/some\//)
+        end
+
+        it_should_behave_like "always forbidden"
+
+      end
+
+      describe "and non-matching :allow" do
+
+        before :each do
+          @handler.instance_variable_set(:@allow, /\A\/other\//)
+        end
+
+        it_should_behave_like "always forbidden"
+
+      end
+
+    end
+
+    describe "with non-matching :deny" do
+
+      before :each do
+        @handler = @class.new(@secret, :deny => /\A\/other\//)
+      end
+
+      it_should_behave_like "normally"
+
+    end
+
+    def mock_request
+      args = "timestamp=#{@timestamp}&token=#{@token}"
+      args = "#{@args}&#{args}" if @args
+
+      clean_args = @class::Util.real_query(args)
+
+      @request = mock('Request', :uri => @uri, :unparsed_uri => "#{@uri}?#{args}")
+
+      @request.should_receive(:param).with('timestamp').once.and_return(@timestamp)
+      @request.should_receive(:param).with('token').once.and_return(@token)
+
+      @request.should_receive(:args).with(no_args).once.and_return(args)
+      @request.should_receive(:args=).with(clean_args).once.and_return(clean_args)
+    end
+
+  end
+
+end

data/spec/spec.opts

@@ -0,0 +1,2 @@
+--colour
+--require spec/spec_helper.rb

data/spec/spec_helper.rb

@@ -0,0 +1,13 @@
+require 'spec'
+
+$:.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+
+require 'apache/secure_download'
+require 'apache/mock_constants'
+
+Spec::Runner.configure do |config|
+  config.before :each do
+    @now = Time.now
+    Time.stub!(:now).and_return { @now }
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: apache_secure_download
 version: !ruby/object:Gem::Version 
-  hash: 27
-  prerelease: false
+  hash: 25
+  prerelease: 
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Jens Wille
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-06-24 00:00:00 +02:00
-default_executable: 
+date: 2011-04-29 00:00:00 Z
 dependencies: []
 
 description: Apache module providing secure downloading functionality, just like Mongrel Secure Download does for mongrel.
@@ -26,9 +25,9 @@ executables: []
 extensions: []
 
 extra_rdoc_files: 
+- README
 - COPYING
 - ChangeLog
-- README
 files: 
 - lib/apache/secure_download/util.rb
 - lib/apache/secure_download/version.rb
@@ -38,20 +37,22 @@ files:
 - ChangeLog
 - Rakefile
 - COPYING
-has_rdoc: true
+- spec/spec.opts
+- spec/apache/secure_download/util_spec.rb
+- spec/apache/secure_download_spec.rb
+- spec/spec_helper.rb
 homepage: http://prometheus.rubyforge.org/apache_secure_download
 licenses: []
 
 post_install_message: 
 rdoc_options: 
+- --charset
+- UTF-8
 - --title
-- apache_secure_download Application documentation
+- apache_secure_download Application documentation (v0.1.1)
 - --main
 - README
 - --line-numbers
-- --inline-source
-- --charset
-- UTF-8
 - --all
 require_paths: 
 - lib
@@ -76,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: prometheus
-rubygems_version: 1.3.7
+rubygems_version: 1.7.2
 signing_key: 
 specification_version: 3
 summary: Apache module providing secure downloading functionality, just like Mongrel Secure Download does for mongrel.