aop 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 71f2faab1dfdd248cc8a9c2aea4c166106dbd1e3
-  data.tar.gz: fe1c1dc3713fa1789c7ace4c12c5f55c8b51c428
+  metadata.gz: af9f44c8cac54ec4197e54a135d3c6829b8badd6
+  data.tar.gz: f9ffd78f10555e9ef4f09c2d14231d7248f4c82f
 SHA512:
-  metadata.gz: f9fc488c1c3c6ca225f89f24f934c051141ddbfbcb5dd3eaac203a679f55a73967c019830a53651c77fa692fbe5e0b8527d597bcf6fceb4f51c766ce2968e534
-  data.tar.gz: bcbb2ab9c96b2fde4cdf45727ba7f426c5a26963cef3fc6bd6804f593519688ce327a16bec838d6aa3b1a53c24c8c22d86c780c31866581097fc7f682df78cfc
+  metadata.gz: f24dd40907b9bd09ac43e491651cfb64cedaa4044363d99fba028e3b23c85afe2a5d1a12baa6d2c440a6e7dec0aec8f65413048753584183cb63efb8a8451b2a
+  data.tar.gz: af8f883d3f73072302b052afd3e69cca24d4d5d0517bb404cb30c68bc9f9be906e987aa3e1a596c9d3e625a96e028a28c5f7166708f405e66aa184b23282ca71

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+rvm:
+  - 1.8.7
+  - 1.9.3
+  - 2.0.0
+  - 2.1
+  - 2.2
+  - jruby-18mode
+  - jruby-19mode
+  - rbx
+
+script: bundle exec rspec
+bundler_args: --without development

data/Gemfile

@@ -2,3 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in aop.gemspec
 gemspec
+
+group :test do
+  gem 'rspec'
+end

data/README.md

@@ -1,5 +1,7 @@
 # Aop
 
+[![Build Status](https://travis-ci.org/waterlink/aop.svg?branch=master)](https://travis-ci.org/waterlink/aop)
+
 Very thin AOP gem for Ruby.
 
 Thin and fast framework for Aspect Oriented Programming in Ruby.
@@ -24,11 +26,9 @@ Or install it yourself as:
 
 ### Before advice
 
-*Not implemented*
-
 ```ruby
 module Authentication
-  Aop["BankAccount#transfer:before"] do |account, *args, &blk|
+  Aop["BankAccount#transfer:before"].advice do |account, *args, &blk|
     can!(:transfer, account)
   end
 
@@ -40,11 +40,9 @@ end
 
 ### After advice
 
-*Not implemented*
-
 ```ruby
 module Analytics
-  Aop["User#sign_in:after"] do |target, *args, &blk|
+  Aop["User#sign_in:after"].advice do |target, *args, &blk|
     report("sign_in", user.id)
   end
 end
@@ -56,7 +54,7 @@ end
 
 ```ruby
 module Transactional
-  Aop["BankAccount#transfer:around"] do |joint_point, account, *args, &blk|
+  Aop["BankAccount#transfer:around"].advice do |joint_point, account, *args, &blk|
     start_transaction
     joint_point.call
     finish_transaction
@@ -66,7 +64,7 @@ end
 
 ## TODO (to specify)
 
-- multiple classes, methods and types of advices
+- multiple classes, methods and types of advices at once
 
 ## Contributing
 

data/lib/aop.rb

@@ -1,5 +1,5 @@
 require "aop/version"
+require "aop/pointcut"
 
 module Aop
-  # Your code goes here...
 end

data/lib/aop/pointcut.rb

@@ -0,0 +1,106 @@
+require "securerandom"
+
+module Aop
+  def self.[](pointcut_spec)
+    Pointcut.new(pointcut_spec)
+  end
+
+  class Pointcut
+    def initialize(spec)
+      @spec = spec
+
+      @class_spec = spec.scan(/^[^#\.]+/).first || ""
+      @class_names = @class_spec.split(",")
+      @classes = @class_names.map { |name| Object.const_get(name) }
+
+      @method_spec = spec.scan(/[#\.][^#\.:]+/)
+      @methods = @method_spec.map { |m| MethodReference.from(m) }
+
+      @advices = spec.scan(/[^:]:([^:]+)/).flatten
+    end
+
+    def advice(&advised)
+      advices = @advices
+      advices.each do |advice|
+        _advice(advice, advised)
+      end
+    end
+
+    private
+
+    def _advice(advice, advised)
+      return before_advice(advised) if advice == "before"
+      after_advice(advised)
+    end
+
+    def generic_advice(advised, &body)
+      methods = @methods
+      @classes.each do |klass|
+        klass.class_eval do
+          methods.each do |method_ref|
+            method_ref.decorate(klass, &body[method_ref])
+          end
+        end
+      end
+    end
+
+    def before_advice(advised)
+      generic_advice(advised) do |method_ref|
+        lambda do |*args, &blk|
+          advised.call(self, *args, &blk)
+          method_ref.call(self, *args, &blk)
+        end
+      end
+    end
+
+    def after_advice(advised)
+      generic_advice(advised) do |method_ref|
+        lambda do |*args, &blk|
+          result = method_ref.call(self, *args, &blk)
+          advised.call(self, *args, &blk)
+          result
+        end
+      end
+    end
+
+    class MethodReference
+      def self.from(m)
+        return new(m) if m[0...1] == "#"
+        Singleton.new(m)
+      end
+
+      def initialize(m)
+        @name = m[1..-1]
+      end
+
+      def decorate(target, &with)
+        name = @name
+        new_name = alias_name
+        alias_target(target).class_eval do
+          alias_method(new_name, name)
+          define_method(name, &with)
+        end
+      end
+
+      def call(target, *args, &blk)
+        alias_target(target).send(alias_name, *args, &blk)
+      end
+
+      private
+
+      def alias_target(target)
+        target
+      end
+
+      def alias_name
+        @_alias_name ||= "__aop_#{SecureRandom.hex(10)}"
+      end
+
+      class Singleton < self
+        def alias_target(target)
+          class << target; self; end
+        end
+      end
+    end
+  end
+end

data/lib/aop/version.rb

@@ -1,3 +1,3 @@
 module Aop
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/aop/after_spec.rb

@@ -0,0 +1,24 @@
+RSpec.describe "After advice" do
+  include FixtureLoader
+
+  let(:spy) { double("Spy") }
+
+  before do
+    load_fixture("BankAccount", "bank_account")
+
+    Aop["BankAccount#transfer:after"].advice do |account, *args, &blk|
+      spy.after(account, *args, &blk)
+    end
+  end
+
+  it "fires after #transfer" do
+    account = BankAccount.new(spy)
+    other = BankAccount.new(spy)
+    amount = 55
+
+    expect(spy).to receive(:inside).with(other, amount).ordered.once
+    expect(spy).to receive(:after).with(account, other, amount).ordered.once
+
+    expect(account.transfer(other, amount)).to eq(:a_result)
+  end
+end

data/spec/aop/before_spec.rb

@@ -0,0 +1,24 @@
+RSpec.describe "Before advice" do
+  include FixtureLoader
+
+  let(:spy) { double("Spy") }
+
+  before do
+    load_fixture("BankAccount", "bank_account")
+
+    Aop["BankAccount#transfer:before"].advice do |account, *args, &blk|
+      spy.before(account, *args, &blk)
+    end
+  end
+
+  it "fires before #transfer" do
+    account = BankAccount.new(spy)
+    other = BankAccount.new(spy)
+    amount = 55
+
+    expect(spy).to receive(:before).with(account, other, amount).ordered.once
+    expect(spy).to receive(:inside).with(other, amount).ordered.once
+
+    expect(account.transfer(other, amount)).to eq(:a_result)
+  end
+end

data/spec/fixtures/bank_account.rb

@@ -0,0 +1,6 @@
+class BankAccount < Struct.new(:spy)
+  def transfer(to, amount)
+    spy.inside(to, amount)
+    :a_result
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,29 @@
+require "aop"
+require "./spec/support/loader"
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  config.disable_monkey_patching!
+
+  config.warnings = true
+
+  if config.files_to_run.one?
+    config.default_formatter = 'doc'
+  end
+
+  config.profile_examples = 10
+
+  config.order = :random
+
+  Kernel.srand config.seed
+end

data/spec/support/loader.rb

@@ -0,0 +1,23 @@
+module FixtureLoader
+  def self.included(base)
+    base.after { reset_fixtures }
+  end
+
+  def load_fixture(name, filename)
+    return if loaded[name]
+    load "./spec/fixtures/#{filename}.rb"
+    loaded[name] = 1
+  end
+
+  def reset_fixtures
+    loaded.each do |name, _|
+      Object.send(:remove_const, name)
+    end
+  end
+
+  private
+
+  def loaded
+    @_loaded ||= {}
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aop
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Alex Fedorov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-22 00:00:00.000000000 Z
+date: 2015-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -46,13 +46,21 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - aop.gemspec
 - lib/aop.rb
+- lib/aop/pointcut.rb
 - lib/aop/version.rb
+- spec/aop/after_spec.rb
+- spec/aop/before_spec.rb
+- spec/fixtures/bank_account.rb
+- spec/spec_helper.rb
+- spec/support/loader.rb
 homepage: https://github.com/waterlink/aop
 licenses:
 - MIT
@@ -77,4 +85,9 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Very thin AOP gem for Ruby
-test_files: []
+test_files:
+- spec/aop/after_spec.rb
+- spec/aop/before_spec.rb
+- spec/fixtures/bank_account.rb
+- spec/spec_helper.rb
+- spec/support/loader.rb