anycable 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d4c8d5a17b2fdbb6c0bbd0d6e83654c4bd42f8a8
-  data.tar.gz: 9c8dcf6244537cdb0f8596fa1bbe036fbc949c4f
+  metadata.gz: e07569569f2ca894f95d64651ff38f73ffeed061
+  data.tar.gz: 68a013beec17cb6793ad976afafa5997529f7ce1
 SHA512:
-  metadata.gz: 3138dae66b1b8eef2462384c4c0d5d8bfa189762dc785e7188dc3e8427839bad632af183924d402dad8b29fcfe745723cd93756dfe8ac60d6053c79fcc44662a
-  data.tar.gz: 65ec89f8cb16c4d0a1c669c62c0e1d83efe19d57d332b666fec9e65f181322f4185b55f1476b5b9dc5ef57e32db69c44daf2e24c7ea05030ddb3a121ee18726c
+  metadata.gz: aecf9c7806fcb493a98cbd4312902d45482a1a3c8fbf3c414bbf7ec54ff994fabb5f3df413ffe1f7b3137338e3eb97f21f52fd041bec42af1136247d501842d9
+  data.tar.gz: f2b07fd79ef4a1f1e5b8b960415580baca0a4dd88d1ecaaf1363d9ee8df423f33f2da7e9f91ef88785a4a806b527dd1eb09f42fcea21beca22425f5ac274ab8a

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 0.4.4 (2017-03-06)
+
+- Handle `StandardError` gracefully in RPC calls. ([@palkan][])
+
 ## 0.4.3 (2017-02-18)
 
 - Update `grpc` version dependency to support Ruby 2.4. ([@palkan][])

data/lib/anycable/handler/exceptions_handling.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module Anycable
+  module Handler
+    # Handle app-level errors
+    module ExceptionsHandling
+      def connect(*)
+        super
+      rescue StandardError => e
+        logger.error(e.message)
+        Anycable::ConnectionResponse.new(status: Anycable::Status::ERROR)
+      end
+
+      def disconnect(*)
+        super
+      rescue StandardError => e
+        logger.error(e.message)
+        Anycable::DisconnectResponse.new(status: Anycable::Status::ERROR)
+      end
+
+      def command(*)
+        super
+      rescue StandardError => e
+        logger.error(e.message)
+        Anycable::CommandResponse.new(status: Anycable::Status::ERROR)
+      end
+    end
+  end
+end

data/lib/anycable/rpc_handler.rb

@@ -3,11 +3,15 @@ require 'anycable/socket'
 require 'anycable/rpc/rpc'
 require 'anycable/rpc/rpc_services'
 
+require 'anycable/handler/exceptions_handling'
+
 # rubocop:disable Metrics/AbcSize
 # rubocop:disable Metrics/MethodLength
 module Anycable
   # RPC service handler
   class RPCHandler < Anycable::RPC::Service
+    prepend Handler::ExceptionsHandling
+
     # Handle connection request from WebSocket server
     def connect(request, _unused_call)
       logger.debug("RPC Connect: #{request}")
@@ -43,7 +47,7 @@ module Anycable
       if connection.handle_close
         Anycable::DisconnectResponse.new(status: Anycable::Status::SUCCESS)
       else
-        Anycable::ConnectionResponse.new(status: Anycable::Status::ERROR)
+        Anycable::DisconnectResponse.new(status: Anycable::Status::ERROR)
       end
     end
 

data/lib/anycable/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Anycable
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - palkan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-18 00:00:00.000000000 Z
+date: 2017-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anyway_config
@@ -171,6 +171,7 @@ files:
 - circle.yml
 - lib/anycable.rb
 - lib/anycable/config.rb
+- lib/anycable/handler/exceptions_handling.rb
 - lib/anycable/pubsub.rb
 - lib/anycable/rpc/rpc.rb
 - lib/anycable/rpc/rpc_services.rb