anycable-rails 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 543429b3563ec46a43bd569c1618b02bc8ffe60b
-  data.tar.gz: ca280799cf84a65246991702b21292e74a07ea15
+SHA256:
+  metadata.gz: bcdcb3ba12a6f1b8366c5b3258135198fe6e30d30daa90401f9e826aded2464d
+  data.tar.gz: 47cf4a2661e21dff58c8a824968e9054eb45669d2a22c5f20eaaefc2ebf564af
 SHA512:
-  metadata.gz: 0d1cbc8dff4fb113187d959d4fed909fc370c204412c1f230dfa52b95f068dc45879a1f653b37b3ff67d95f06dc1ea8fe66426e2d29c02bdac1f94d047cea2e2
-  data.tar.gz: aba10277d8e2680065275ce977dec610194a21cae397e4b0c25717852442e9f3fa12e898f443faf2fd0ae6ee027a7304edcdc8691e24190caf5c7dd59569a920
+  metadata.gz: 9956b15de7712c4d71fff95c05fa0582f500955fa4cc7d6bbb4a586715118af8532516a4a6b853552e71e82b08017278a571fc42f87bcd2e7a171c52d7b30b1a
+  data.tar.gz: f43d521934283f60770acd972f0500ee582ab3424f98cc172735a7d8d5d5fde0d1061023fdc77d4ca08617440de0ca5b58be34aa258cb1efbc20e50393f38765

data/.rubocop.yml

@@ -32,6 +32,9 @@ Style/Documentation:
 Style/FormatString:
   Enabled: false
 
+Style/FormatStringToken:
+  Enabled: false
+
 Style/StringLiterals: 
   Enabled: false
 

data/.travis.yml

@@ -4,10 +4,12 @@ cache: bundler
 notifications:
   email: false
 
-rvm: 2.3.3
-
 matrix:
   include:
+    - rvm: 2.4.3
+      gemfile: Gemfile
+    - rvm: 2.5.0
+      gemfile: Gemfile
     - gemfile: gemfiles/rails5.gemfile
     - gemfile: gemfiles/railsmaster.gemfile
   allow_failures:

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change log
 
+## master
+
+## 0.5.3
+
+- Fix return value of `Connection#handle_close`. ([@palkan][])
+
+  Should always be `true`, we do not expect a failure here.
+
 ## 0.5.2
 
 - Add config/anycable.yml to Rails generator. ([@alekseyl][])

data/Gemfile

@@ -6,6 +6,4 @@ local_gemfile = "#{File.dirname(__FILE__)}/Gemfile.local"
 
 if File.exist?(local_gemfile)
   eval(File.read(local_gemfile)) # rubocop:disable Lint/Eval
-else
-  # ??
 end

data/README.md

@@ -84,7 +84,7 @@ Anycable uses [anyway_config](https://github.com/palkan/anyway_config), thus it
 Run Anycable RPC server:
 
 ```ruby
-./bin/anycable
+RAILS_ENV=production ./bin/anycable
 ```
 
 and also run AnyCable-compatible WebSocket server, e.g. [anycable-go](https://github.com/anycable/anycable-go):
@@ -93,10 +93,18 @@ and also run AnyCable-compatible WebSocket server, e.g. [anycable-go](https://gi
 anycable-go -addr='localhost:3334'
 ```
 
-Don't forget to set cable url in your `config/environments/production.rb`:
+Don't forget to set cable url in your environment:
 
 ```ruby
+# For development it's likely the localhost
+
+# config/environments/development.rb
 config.action_cable.url = "ws://localhost:3334/cable"
+
+# For production it's likely to have a sub-domain and secure connection
+
+# config/environments/production.rb
+config.action_cable.url = "wss://ws.example.com/cable"
 ```
 
 ### Logging

data/lib/anycable/rails/actioncable/channel.rb

@@ -21,14 +21,6 @@ module ActionCable
       def stop_all_streams
         connection.socket.unsubscribe_from_all identifier
       end
-
-      def delegate_connection_identifiers
-        connection.identifiers.each do |identifier|
-          define_singleton_method(identifier) do
-            connection.fetch_identifier(identifier)
-          end
-        end
-      end
     end
   end
 end

data/lib/anycable/rails/actioncable/connection.rb

@@ -54,6 +54,7 @@ module ActionCable
 
         subscriptions.unsubscribe_from_all
         disconnect if respond_to?(:disconnect)
+        true
       end
 
       # rubocop:disable Metrics/MethodLength

data/lib/anycable/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Anycable
   module Rails
-    VERSION = "0.5.2"
+    VERSION = "0.5.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - palkan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-15 00:00:00.000000000 Z
+date: 2018-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Rails adapter for AnyCable