anycable-rails 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: befe1ee696c2e92b1b9b6a862a9b9c5e024dbbfb
-  data.tar.gz: c0a573fbc413d53840f7bfd11d3cd5ea860f8e6f
+  metadata.gz: 6f487f9b1437eeeb4fab3bec3ec73c3f06e32bc3
+  data.tar.gz: 5d1105fbde9dfcce31da1cb02ac1699bbe80fd5e
 SHA512:
-  metadata.gz: e4e56fb8e4f7baad3a1e2a73a798f84883b195796ceb9b112b927343434f97b66875f5df13e7b3fa099d73d7f73a08659a66ba6896f41c7f83fc690f68a6a174
-  data.tar.gz: 8448424ff837cbb57a6ac4ba1aa6c165dcf544e9ca4e0dd53e278cb591b72fdcb440b692f6465f0edfd4174d5742e4bd4151da408504b493a9a83f52d03d7de4
+  metadata.gz: f6b87a26ed485cb1391fc388fa96734f37487b11c0862b149dcc64fb9ecb9d31c47fe1c50be1d297b0dbb1dad91a35d6aa9c6b88d96559c17feed058058e4704
+  data.tar.gz: 9634bf30406506e577496c92afe462377c1d8da5b3e7d005b36c2a6c849a596b11c782bad4a40c3bcadc071eaeeac0b632ab25479223d8e39d2139462dc58d38

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 # Change log
 
-## master
+## 0.5.1
+
+- Improve Rails integration. ([@palkan][])
+
+Log to STDOUT in development.
+Make order of initializers more deterministic.
+Show warning if AnyCable is loaded after application initialization.
+
+## 0.5.0
 
 - [#17](https://github.com/anycable/anycable-rails/issues/17) Refactor logging. ([@palkan][])
 

data/README.md

@@ -51,6 +51,9 @@ gem 'anycable-rails'
 gem 'anycable-rails', group: :production
 ```
 
+**NOTE**: if you want to require `anycable-rails` _manually_ (i.e. with `require: false` in your `Gemfile`)
+make sure that it's loaded prior to `Rails.application.initialize!` call (see `config/environment.rb`).
+
 And then run:
 
 ```shell
@@ -116,7 +119,6 @@ production:
   access_logs_disabled: false
 ```
 
-
 ## ActionCable Compatibility
 
 This is the compatibility list for the AnyCable gem, not for AnyCable servers (which may not support some of the features yet).

data/lib/anycable/rails.rb

@@ -12,3 +12,15 @@ module Anycable
     require "anycable/rails/actioncable/connection"
   end
 end
+
+# Warn if application has been already initialized.
+# Anycable should be loaded before initialization in order to work correctly.
+if defined?(::Rails) && ::Rails.application && ::Rails.application.initialized?
+  puts("\n**************************************************")
+  puts(
+    "⛔️  WARNING: AnyCable loaded after application initialization. Might not work correctly.\n"\
+    "Please, make sure to remove `require: false` in your Gemfile or "\
+    "require manually in `environment.rb` before `Rails.application.initialize!`"
+  )
+  puts("**************************************************\n\n")
+end

data/lib/anycable/rails/railtie.rb

@@ -20,20 +20,35 @@ module Anycable
     end
 
     class Railtie < ::Rails::Railtie # :nodoc:
-      initializer "disable built-in Action Cable mount" do |app|
+      initializer "anycable.disable_action_cable_mount", before: "action_cable.routes" do |app|
         app.config.action_cable.mount_path = nil
       end
 
-      initializer "set up logger" do |_app|
+      initializer "anycable.logger", after: :initialize_logger do |_app|
         Anycable.logger = LoggerProxy.new(::Rails.logger)
+
+        # Broadcast logs to STDOUT in development
+        if ::Rails.env.development? &&
+           !ActiveSupport::Logger.logger_outputs_to?(::Rails.logger, STDOUT)
+          console = ActiveSupport::Logger.new(STDOUT)
+          console.formatter = ::Rails.logger.formatter
+          console.level = ::Rails.logger.level
+          ::Rails.logger.extend(ActiveSupport::Logger.broadcast(console))
+        end
       end
 
-      initializer "release AR connections in RPC handler" do |_app|
+      initializer "anycable.release_connections" do |_app|
         ActiveSupport.on_load(:active_record) do
           require "anycable/rails/activerecord/release_connection"
           Anycable::RPCHandler.prepend Anycable::Rails::ActiveRecord::ReleaseConnection
         end
       end
+
+      initializer "anycable.connection_factory", after: "action_cable.set_configs" do |_app|
+        ActiveSupport.on_load(:action_cable) do
+          Anycable.connection_factory = connection_class.call
+        end
+      end
     end
   end
 end

data/lib/anycable/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Anycable
   module Rails
-    VERSION = "0.5.0"
+    VERSION = "0.5.1"
   end
 end

data/lib/generators/anycable/templates/script

@@ -2,10 +2,5 @@
 # frozen_string_literal: true
 
 require ::File.expand_path('../../config/environment', __FILE__)
-require "anycable-rails"
-
-Anycable.connection_factory = ActionCable.server.config.connection_class.call
-
-Rails.application.eager_load!
 
 Anycable::Server.start

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - palkan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-21 00:00:00.000000000 Z
+date: 2017-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails