any_logger 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 334a3aebbaebdfacb7515933cd3bacb1a75e8e06ef8c97610a45bba6456eb84e
-  data.tar.gz: 163ecc53aeca64261a1fb85fc5c43d6056866c66d187b9dadd3f1e928e75304b
+  metadata.gz: de56cdda136e683ae52ee87f6a0cb802792f1e3aa1c6e946ade58b6dde832664
+  data.tar.gz: 9760f9c169b6d1f721e353d2a995b3da7ed07218cfd3f9d7ff1d7f7bd58417cf
 SHA512:
-  metadata.gz: 809c03c57003c27026ad6b948f51928bfead45fbfe1d61a7207a587cd0276a7feefd940c4852440703d0bb6ea02eb45af9ce00e0cf89f7c1c5c90fff87918596
-  data.tar.gz: 250cf71e5950b04ac2421d24830d58a4e6ef5df12d7138c0d5eb29295db40b2f83396aa1ca50c50d28861f4439670972aba00665712fcbb0f7c1fecc0bc67218
+  metadata.gz: c3f6346e9da6a573bddc918a41195a7827c9d34086c3ab1a5b47290017615ef1c5d182968ee06a94d8eab2b31d672533cf7166fb7109849d327a7e39e5455dfb
+  data.tar.gz: de5672b026af7fbf51619d947e72ca52495781fc39397c559b10ca467227fb3811e61555eac684310b219e1628007dea3220f19ae0f5571e44cfeb46266723b6

data/.rubocop.yml

@@ -27,3 +27,9 @@ Style/RegexpLiteral:
 
 Bundler/OrderedGems:
   Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false

data/CHANGELOG.md

@@ -11,3 +11,7 @@
 ## [0.1.3] - 2025-01-15
 
 - AnyLogger.startをデフォルトで不要に変更
+
+## [0.1.4] - 2025-01-15
+
+- Example::ControllerSubscriberのログの改行位置がおかしかったのを修正

data/README.md

@@ -5,7 +5,7 @@ A DSL for simplifying modification of Rails LogSubscribers
 ### Example
 
 ```ruby
-# initializer/any_logger.rb
+# initializers/any_logger.rb
 require "any_logger"
 require "any_logger/example/controller_subscriber"
 

data/lib/any_logger/example/controller_subscriber.rb

@@ -28,65 +28,44 @@ module AnyLogger
       #     params: {"foo" => "bar"}
       #     redirect: "/fuga"
       private def formatted_message
-        <<~MESSAGE
-
-          #{l_method} #{l_action} #{l_for} #{l_at}
-            #{l_path}
-            #{l_status} #{l_duration} (#{l_view_runtime} | #{l_db_runtime})
-            #{"#{l_params}\n" if @payload[:params].present?}#{l_redirect if @headers[:location].present?}
-        MESSAGE
+        e = formatted_log_details
+        # ヒアドキュメントだとparamsとredirectの有無で改行の入り方が変わってしまうので、配列を結合する方法を採用
+        lines = []
+        lines << ""
+        lines << "[#{e[:method]}] #{e[:controller]}##{e[:action]} for: #{e[:ip]} at: #{e[:datetime]}"
+        lines << "  🔍 path: \"#{e[:path]}\""
+        lines << "  🧱 status: #{e[:status]} in #{e[:duration]}ms " \
+                 "(view: #{e[:view_runtime]}ms | db: #{e[:db_runtime]}ms)"
+        lines << "  📝 params: #{e[:params]}" if @payload[:params].present?
+        lines << "  🚀 redirect: \"#{e[:redirect_to]}\"" if @headers[:location].present?
+        lines.join("\n")
       end
 
       private def match_unnecessary_path?
         UNNECESSARY_PATHS.include?(@payload[:path])
       end
 
-      private def l_method
-        "[#{@payload[:method].upcase}]"
-      end
-
-      private def l_action
-        "#{@payload[:controller]}##{@payload[:action]}"
-      end
-
-      private def l_for
-        "for: #{@payload[:request].remote_ip}"
-      end
-
-      private def l_at
-        "at: #{conversion_event_time_to_datetime}"
-      end
-
-      private def l_path
-        "🔍 path: \"#{@payload[:path]}\""
-      end
-
-      private def l_status
-        "🧱 status: #{@payload[:status]}"
-      end
-
-      private def l_duration
-        "in #{@event.duration&.round(2) || 0}ms"
-      end
-
-      private def l_view_runtime
-        "view: #{@payload[:view_runtime]&.round(2) || 0}ms"
-      end
-
-      private def l_db_runtime
-        "db: #{@payload[:db_runtime]&.round(2) || 0}ms"
-      end
-
-      private def l_params
-        @payload[:params] = except_unnecessary_params
-        "📝 params: #{@payload[:params]&.inspect || {}}"
-      end
-
-      private def l_redirect
+      private def formatted_log_details
+        {
+          method: @payload[:method].upcase,
+          controller: @payload[:controller],
+          action: @payload[:action],
+          ip: @payload[:request].remote_ip,
+          datetime: conversion_event_time_to_datetime,
+          path: @payload[:path],
+          status: @payload[:status],
+          duration: round_value(@event.duration),
+          view_runtime: round_value(@payload[:view_runtime]),
+          db_runtime: round_value(@payload[:db_runtime]),
+          params: expect_unnecessary_params || {},
+          redirect_to: formatted_redirect_location
+        }
+      end
+
+      private def formatted_redirect_location
         return unless REDIRECT_CODES.any? { @payload[:status] == Rack::Utils.status_code(it) }
 
-        ellipsised_url = ellipsis_scheme_and_authority(@headers[:location])
-        "🚀 redirect: \"#{ellipsised_url}\""
+        ellipsis_scheme_and_authority(@headers[:location])
       end
 
       private def conversion_event_time_to_datetime
@@ -97,6 +76,10 @@ module AnyLogger
         Time.at((now - elapsed).to_i)
       end
 
+      private def round_value(value)
+        value&.round(2) || 0
+      end
+
       private def except_unnecessary_params
         @payload[:params].except("controller", "action")
       end

data/lib/any_logger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AnyLogger
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: any_logger
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - milkeclair